patches for DPDK stable branches
 help / color / mirror / Atom feed
From: christian.ehrhardt@canonical.com
To: Brian Dooley <brian.dooley@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	Tyler Retzlaff <roretzla@linux.microsoft.com>,
	dpdk stable <stable@dpdk.org>
Subject: patch 'eventdev: add missing C++ guards' has been queued to stable release 19.11.12
Date: Wed,  9 Mar 2022 12:00:36 +0100	[thread overview]
Message-ID: <20220309110116.1295395-5-christian.ehrhardt@canonical.com> (raw)
In-Reply-To: <20220309110116.1295395-1-christian.ehrhardt@canonical.com>

Hi,

FYI, your patch has been queued to stable release 19.11.12

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/11/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/5d5711a19a1a975ec86948db1aa8896ea2f27bc8

Thanks.

Christian Ehrhardt <christian.ehrhardt@canonical.com>

---
From 5d5711a19a1a975ec86948db1aa8896ea2f27bc8 Mon Sep 17 00:00:00 2001
From: Brian Dooley <brian.dooley@intel.com>
Date: Wed, 16 Feb 2022 15:14:52 +0000
Subject: [PATCH] eventdev: add missing C++ guards

[ upstream commit 2c552933ba453984c26262136150d75235f6aabe ]

Some public header files were missing 'extern "C"' C++ guards,
and couldn't be used by C++ applications. Add the missing guards.

Fixes: dc39e2f359b5 ("eventdev: add ring structure for events")
Fixes: 7a3357205755 ("lib: remove C++ include guard from private headers")

Signed-off-by: Brian Dooley <brian.dooley@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 lib/librte_eventdev/rte_event_ring.h        | 9 +++++++++
 lib/librte_eventdev/rte_eventdev_pmd.h      | 8 ++++++++
 lib/librte_eventdev/rte_eventdev_pmd_pci.h  | 4 ++++
 lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 4 ++++
 4 files changed, 25 insertions(+)

diff --git a/lib/librte_eventdev/rte_event_ring.h b/lib/librte_eventdev/rte_event_ring.h
index 827a3209ea..f76e508c54 100644
--- a/lib/librte_eventdev/rte_event_ring.h
+++ b/lib/librte_eventdev/rte_event_ring.h
@@ -13,6 +13,10 @@
 #ifndef _RTE_EVENT_RING_
 #define _RTE_EVENT_RING_
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 #include <stdint.h>
 
 #include <rte_common.h>
@@ -275,4 +279,9 @@ rte_event_ring_get_capacity(const struct rte_event_ring *r)
 {
 	return rte_ring_get_capacity(&r->r);
 }
+
+#ifdef __cplusplus
+}
+#endif
+
 #endif
diff --git a/lib/librte_eventdev/rte_eventdev_pmd.h b/lib/librte_eventdev/rte_eventdev_pmd.h
index ec77e65f29..2ecdd56308 100644
--- a/lib/librte_eventdev/rte_eventdev_pmd.h
+++ b/lib/librte_eventdev/rte_eventdev_pmd.h
@@ -5,6 +5,10 @@
 #ifndef _RTE_EVENTDEV_PMD_H_
 #define _RTE_EVENTDEV_PMD_H_
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 /** @file
  * RTE Event PMD APIs
  *
@@ -1112,4 +1116,8 @@ rte_event_pmd_release(struct rte_eventdev *eventdev);
 }
 #endif
 
+#ifdef __cplusplus
+}
+#endif
+
 #endif /* _RTE_EVENTDEV_PMD_H_ */
diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
index 443cd38c23..92eeed6411 100644
--- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
+++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
@@ -5,6 +5,10 @@
 #ifndef _RTE_EVENTDEV_PMD_PCI_H_
 #define _RTE_EVENTDEV_PMD_PCI_H_
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 /** @file
  * RTE Eventdev PCI PMD APIs
  *
diff --git a/lib/librte_eventdev/rte_eventdev_pmd_vdev.h b/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
index 8c64a06743..ff79d82530 100644
--- a/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
+++ b/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
@@ -5,6 +5,10 @@
 #ifndef _RTE_EVENTDEV_PMD_VDEV_H_
 #define _RTE_EVENTDEV_PMD_VDEV_H_
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 /** @file
  * RTE Eventdev VDEV PMD APIs
  *
-- 
2.35.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-03-09 11:57:43.667139495 +0100
+++ 0005-eventdev-add-missing-C-guards.patch	2022-03-09 11:57:43.316937904 +0100
@@ -1 +1 @@
-From 2c552933ba453984c26262136150d75235f6aabe Mon Sep 17 00:00:00 2001
+From 5d5711a19a1a975ec86948db1aa8896ea2f27bc8 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 2c552933ba453984c26262136150d75235f6aabe ]
+
@@ -11 +12,0 @@
-Cc: stable@dpdk.org
@@ -17,5 +18,5 @@
- lib/eventdev/eventdev_pmd.h      | 8 ++++++++
- lib/eventdev/eventdev_pmd_pci.h  | 8 ++++++++
- lib/eventdev/eventdev_pmd_vdev.h | 8 ++++++++
- lib/eventdev/rte_event_ring.h    | 9 +++++++++
- 4 files changed, 33 insertions(+)
+ lib/librte_eventdev/rte_event_ring.h        | 9 +++++++++
+ lib/librte_eventdev/rte_eventdev_pmd.h      | 8 ++++++++
+ lib/librte_eventdev/rte_eventdev_pmd_pci.h  | 4 ++++
+ lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 4 ++++
+ 4 files changed, 25 insertions(+)
@@ -23,4 +24,29 @@
-diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h
-index b05ffce549..ce469d47a6 100644
---- a/lib/eventdev/eventdev_pmd.h
-+++ b/lib/eventdev/eventdev_pmd.h
+diff --git a/lib/librte_eventdev/rte_event_ring.h b/lib/librte_eventdev/rte_event_ring.h
+index 827a3209ea..f76e508c54 100644
+--- a/lib/librte_eventdev/rte_event_ring.h
++++ b/lib/librte_eventdev/rte_event_ring.h
+@@ -13,6 +13,10 @@
+ #ifndef _RTE_EVENT_RING_
+ #define _RTE_EVENT_RING_
+ 
++#ifdef __cplusplus
++extern "C" {
++#endif
++
+ #include <stdint.h>
+ 
+ #include <rte_common.h>
+@@ -275,4 +279,9 @@ rte_event_ring_get_capacity(const struct rte_event_ring *r)
+ {
+ 	return rte_ring_get_capacity(&r->r);
+ }
++
++#ifdef __cplusplus
++}
++#endif
++
+ #endif
+diff --git a/lib/librte_eventdev/rte_eventdev_pmd.h b/lib/librte_eventdev/rte_eventdev_pmd.h
+index ec77e65f29..2ecdd56308 100644
+--- a/lib/librte_eventdev/rte_eventdev_pmd.h
++++ b/lib/librte_eventdev/rte_eventdev_pmd.h
@@ -38,3 +64,3 @@
-@@ -1366,4 +1370,8 @@ void
- event_dev_fp_ops_set(struct rte_event_fp_ops *fp_ops,
- 		     const struct rte_eventdev *dev);
+@@ -1112,4 +1116,8 @@ rte_event_pmd_release(struct rte_eventdev *eventdev);
+ }
+ #endif
@@ -47,4 +73,4 @@
-diff --git a/lib/eventdev/eventdev_pmd_pci.h b/lib/eventdev/eventdev_pmd_pci.h
-index 499852db16..24b56faaa9 100644
---- a/lib/eventdev/eventdev_pmd_pci.h
-+++ b/lib/eventdev/eventdev_pmd_pci.h
+diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
+index 443cd38c23..92eeed6411 100644
+--- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
++++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
@@ -62,13 +88,4 @@
-@@ -150,4 +154,8 @@ rte_event_pmd_pci_remove(struct rte_pci_device *pci_dev,
- 	return 0;
- }
- 
-+#ifdef __cplusplus
-+}
-+#endif
-+
- #endif /* _RTE_EVENTDEV_PMD_PCI_H_ */
-diff --git a/lib/eventdev/eventdev_pmd_vdev.h b/lib/eventdev/eventdev_pmd_vdev.h
-index d9ee7277dd..77904910a2 100644
---- a/lib/eventdev/eventdev_pmd_vdev.h
-+++ b/lib/eventdev/eventdev_pmd_vdev.h
+diff --git a/lib/librte_eventdev/rte_eventdev_pmd_vdev.h b/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
+index 8c64a06743..ff79d82530 100644
+--- a/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
++++ b/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
@@ -86,34 +102,0 @@
-@@ -99,4 +103,8 @@ rte_event_pmd_vdev_uninit(const char *name)
- 	return 0;
- }
- 
-+#ifdef __cplusplus
-+}
-+#endif
-+
- #endif /* _RTE_EVENTDEV_PMD_VDEV_H_ */
-diff --git a/lib/eventdev/rte_event_ring.h b/lib/eventdev/rte_event_ring.h
-index 0a54f7fde2..0101cc0aa2 100644
---- a/lib/eventdev/rte_event_ring.h
-+++ b/lib/eventdev/rte_event_ring.h
-@@ -14,6 +14,10 @@
- #ifndef _RTE_EVENT_RING_
- #define _RTE_EVENT_RING_
- 
-+#ifdef __cplusplus
-+extern "C" {
-+#endif
-+
- #include <stdint.h>
- 
- #include <rte_common.h>
-@@ -264,4 +268,9 @@ rte_event_ring_get_capacity(const struct rte_event_ring *r)
- {
- 	return rte_ring_get_capacity(&r->r);
- }
-+
-+#ifdef __cplusplus
-+}
-+#endif
-+
- #endif

  parent reply	other threads:[~2022-03-09 11:01 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09 11:00 patch 'eventdev/eth_tx: fix queue add error code' " christian.ehrhardt
2022-03-09 11:00 ` patch 'telemetry: add missing C++ guards' " christian.ehrhardt
2022-03-09 11:00 ` patch 'acl: " christian.ehrhardt
2022-03-09 11:00 ` patch 'compressdev: " christian.ehrhardt
2022-03-09 11:00 ` christian.ehrhardt [this message]
2022-03-09 11:00 ` patch 'kni: " christian.ehrhardt
2022-03-09 11:00 ` patch 'ethdev: fix cast for C++ compatibility' " christian.ehrhardt
2022-03-09 11:00 ` patch 'cryptodev: fix RSA key type name' " christian.ehrhardt
2022-03-09 11:00 ` patch 'doc: fix FIPS guide' " christian.ehrhardt
2022-03-09 11:00 ` patch 'examples/l2fwd-crypto: fix port mask overflow' " christian.ehrhardt
2022-03-09 11:00 ` patch 'crypto/virtio: fix out-of-bounds access' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/nfb: fix array indexes in deinit functions' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/nfb: fix multicast/promiscuous mode switching' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ixgbe: reset security context pointer on close' " christian.ehrhardt
2022-03-09 11:00 ` patch 'app/testpmd: check starting port is not in bonding' " christian.ehrhardt
2022-03-09 11:00 ` patch 'vhost: fix unsafe vring addresses modifications' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/af_xdp: add missing trailing newline in logs' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: remove unused enumeration' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: remove unused offload variables' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: skip timer if reset is triggered' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: fix meta descriptor DF flag setup' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: fix checksum flag for L4' " christian.ehrhardt
2022-03-09 11:00 ` patch 'doc: remove obsolete vector Tx explanations from mlx5 guide' " christian.ehrhardt
2022-03-09 11:00 ` patch 'doc: replace broken links in mlx guides' " christian.ehrhardt
2022-03-09 11:00 ` patch 'app/testpmd: fix build without drivers' " christian.ehrhardt
2022-03-09 11:00 ` patch 'test/efd: fix sockets mask size' " christian.ehrhardt
2022-03-09 11:00 ` patch 'distributor: fix potential overflow' " christian.ehrhardt
2022-03-09 11:00 ` patch 'eal/linux: fix illegal memory access in uevent handler' " christian.ehrhardt
2022-03-09 11:01 ` patch 'kni: fix freeing order in device release' " christian.ehrhardt
2022-03-09 11:01 ` patch 'app/compress-perf: fix socket ID type during init' " christian.ehrhardt
2022-03-09 11:01 ` patch 'app/compress-perf: fix number of queue pairs to setup' " christian.ehrhardt
2022-03-09 11:01 ` patch 'compressdev: fix socket ID type' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/hns3: remove duplicate macro definition' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/hns3: fix RSS TC mode entry' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/hns3: fix VF " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/hns3: increase time waiting for PF reset completion' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/ixgbe: fix FSP check for X550EM devices' " christian.ehrhardt
2022-03-09 11:01 ` patch 'doc: fix typos and punctuation in flow API guide' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/mlx5: fix matcher priority with ICMP or ICMPv6' " christian.ehrhardt
2022-03-09 11:01 ` patch 'raw/ifpga: fix variable initialization in probing' " christian.ehrhardt
2022-03-09 11:01 ` patch 'app/pdump: abort on multi-core capture limit' " christian.ehrhardt
2022-03-09 11:01 ` patch 'examples/distributor: reduce Tx queue number to 1' " christian.ehrhardt
2022-03-09 11:01 ` patch 'examples/flow_classify: fix failure message' " christian.ehrhardt
2022-03-09 11:01 ` patch 'ethdev: fix doxygen comments for device info struct' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/mlx5: fix modify port action validation' " christian.ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220309110116.1295395-5-christian.ehrhardt@canonical.com \
    --to=christian.ehrhardt@canonical.com \
    --cc=brian.dooley@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).