patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: David Christensen <drc@linux.vnet.ibm.com>
Cc: Thinh Tran <thinhtr@linux.vnet.ibm.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'acl: fix crash on PPC64 with GCC 11' has been queued to stable release 21.11.4
Date: Thu, 30 Mar 2023 09:35:59 +0100	[thread overview]
Message-ID: <20230330083600.473876-7-ktraynor@redhat.com> (raw)
In-Reply-To: <20230330083600.473876-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/02/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/27af78b522f13ed10453373a87c0db6389c9a6cd

Thanks.

Kevin

---
From 27af78b522f13ed10453373a87c0db6389c9a6cd Mon Sep 17 00:00:00 2001
From: David Christensen <drc@linux.vnet.ibm.com>
Date: Wed, 22 Mar 2023 13:29:33 -0400
Subject: [PATCH] acl: fix crash on PPC64 with GCC 11

[ upstream commit 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 ]

Original ACL implementation of Altivec optimized code included an
explicit -O2 optimization level for a particular inlined function.
When DPDK is built with the default -O3 optimization level on gcc
11.x or later, the resulting code may generate a segmentation
fault as observed in acl_autotest.

Since there is no explicit reason given for the local function
optimization level in the original commit, and testing with gcc
versions 8.x through 12.x results in working code at all -O
optimization settings, the local optimization is removed.

Bugzilla ID: 1197

Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Tested-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
 lib/acl/acl_run_altivec.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/acl/acl_run_altivec.h b/lib/acl/acl_run_altivec.h
index 4dfe7a14b4..4556e1503b 100644
--- a/lib/acl/acl_run_altivec.h
+++ b/lib/acl/acl_run_altivec.h
@@ -103,5 +103,5 @@ acl_match_check_x4(int slot, const struct rte_acl_ctx *ctx, struct parms *parms,
  * Process 4 transitions (in 2 XMM registers) in parallel
  */
-static inline __attribute__((optimize("O2"))) xmm_t
+static __rte_always_inline xmm_t
 transition4(xmm_t next_input, const uint64_t *trans,
 	xmm_t *indices1, xmm_t *indices2)
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-30 09:30:45.465810753 +0100
+++ 0008-acl-fix-crash-on-PPC64-with-GCC-11.patch	2023-03-30 09:30:45.275229273 +0100
@@ -1 +1 @@
-From 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 Mon Sep 17 00:00:00 2001
+From 27af78b522f13ed10453373a87c0db6389c9a6cd Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 ]
+
@@ -18 +19,0 @@
-Cc: stable@dpdk.org


  parent reply	other threads:[~2023-03-30  8:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30  8:35 patch 'examples/qos_sched: fix config entries in wrong sections' " Kevin Traynor
2023-03-30  8:35 ` patch 'net/mlx5: fix build with GCC 12 and ASan' " Kevin Traynor
2023-03-30  8:35 ` patch 'net/mlx5: fix CQE dump for Tx' " Kevin Traynor
2023-03-30  8:35 ` patch 'net/mlx5: fix sysfs port name translation' " Kevin Traynor
2023-03-30  8:35 ` patch 'test/crypto: fix statistics error messages' " Kevin Traynor
2023-03-30  8:35 ` patch 'pdump: fix build with GCC 12' " Kevin Traynor
2023-03-30  8:35 ` Kevin Traynor [this message]
2023-03-30  8:36 ` patch 'doc: fix pipeline example path in user guide' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230330083600.473876-7-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=drc@linux.vnet.ibm.com \
    --cc=stable@dpdk.org \
    --cc=thinhtr@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).