* [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf
@ 2023-09-18 8:25 Rahul Bhansali
2023-09-19 16:29 ` Jerin Jacob
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Rahul Bhansali @ 2023-09-18 8:25 UTC (permalink / raw)
To: dev, Naga Harish K S V, Jerin Jacob, Ganapati Kundapura
Cc: Rahul Bhansali, stable
For eventdev internal port, timestamp dynamic field registration
in mbuf is not required as that will be done from net device.
For SW eventdev, Rx timestamp field registration will be
done during Rx queue add operation as per device capabilities and
offload configuration.
Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf field")
Cc: stable@dpdk.org
Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
---
lib/eventdev/rte_event_eth_rx_adapter.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index 3ebfa5366d..5a5fade466 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -2472,13 +2472,6 @@ rxa_create(uint8_t id, uint8_t dev_id,
if (conf_cb == rxa_default_conf_cb)
rx_adapter->default_cb_arg = 1;
- if (rte_mbuf_dyn_rx_timestamp_register(
- &event_eth_rx_timestamp_dynfield_offset,
- &event_eth_rx_timestamp_dynflag) != 0) {
- RTE_EDEV_LOG_ERR("Error registering timestamp field in mbuf\n");
- return -rte_errno;
- }
-
rte_eventdev_trace_eth_rx_adapter_create(id, dev_id, conf_cb,
conf_arg);
return 0;
@@ -2738,6 +2731,7 @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
1);
}
} else {
+ uint64_t dev_offloads;
rte_spinlock_lock(&rx_adapter->rx_lock);
dev_info->internal_event_port = 0;
ret = rxa_init_service(rx_adapter, id);
@@ -2749,6 +2743,17 @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
rxa_sw_adapter_queue_count(rx_adapter));
}
rte_spinlock_unlock(&rx_adapter->rx_lock);
+
+ dev_offloads = dev_info->dev->data->dev_conf.rxmode.offloads;
+ if (dev_offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) {
+ if (rte_mbuf_dyn_rx_timestamp_register(
+ &event_eth_rx_timestamp_dynfield_offset,
+ &event_eth_rx_timestamp_dynflag) != 0) {
+ RTE_EDEV_LOG_ERR("Error registering timestamp field in mbuf\n");
+ return -rte_errno;
+ }
+ }
+
}
rte_eventdev_trace_eth_rx_adapter_queue_add(id, eth_dev_id,
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf
2023-09-18 8:25 [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf Rahul Bhansali
@ 2023-09-19 16:29 ` Jerin Jacob
2023-09-25 10:18 ` Naga Harish K, S V
2023-09-20 12:32 ` Naga Harish K, S V
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Jerin Jacob @ 2023-09-19 16:29 UTC (permalink / raw)
To: Rahul Bhansali
Cc: dev, Naga Harish K S V, Jerin Jacob, Ganapati Kundapura, stable
On Mon, Sep 18, 2023 at 6:46 PM Rahul Bhansali <rbhansali@marvell.com> wrote:
>
> For eventdev internal port, timestamp dynamic field registration
> in mbuf is not required as that will be done from net device.
> For SW eventdev, Rx timestamp field registration will be
> done during Rx queue add operation as per device capabilities and
> offload configuration.
>
> Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf field")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
Ping for review from maintainer.
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf
2023-09-18 8:25 [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf Rahul Bhansali
2023-09-19 16:29 ` Jerin Jacob
@ 2023-09-20 12:32 ` Naga Harish K, S V
2023-09-20 16:17 ` Rahul Bhansali
2023-09-20 16:32 ` [PATCH v2] " Rahul Bhansali
2023-09-20 16:48 ` [PATCH v3] " Rahul Bhansali
3 siblings, 1 reply; 10+ messages in thread
From: Naga Harish K, S V @ 2023-09-20 12:32 UTC (permalink / raw)
To: Rahul Bhansali, dev, Jerin Jacob, Kundapura, Ganapati; +Cc: stable
> -----Original Message-----
> From: Rahul Bhansali <rbhansali@marvell.com>
> Sent: Monday, September 18, 2023 1:56 PM
> To: dev@dpdk.org; Naga Harish K, S V <s.v.naga.harish.k@intel.com>; Jerin
> Jacob <jerinj@marvell.com>; Kundapura, Ganapati
> <ganapati.kundapura@intel.com>
> Cc: Rahul Bhansali <rbhansali@marvell.com>; stable@dpdk.org
> Subject: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf
>
> For eventdev internal port, timestamp dynamic field registration in mbuf is not
> required as that will be done from net device.
> For SW eventdev, Rx timestamp field registration will be done during Rx queue
> add operation as per device capabilities and offload configuration.
>
> Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf
> field")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
> ---
> lib/eventdev/rte_event_eth_rx_adapter.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
> b/lib/eventdev/rte_event_eth_rx_adapter.c
> index 3ebfa5366d..5a5fade466 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -2472,13 +2472,6 @@ rxa_create(uint8_t id, uint8_t dev_id,
> if (conf_cb == rxa_default_conf_cb)
> rx_adapter->default_cb_arg = 1;
>
> - if (rte_mbuf_dyn_rx_timestamp_register(
> - &event_eth_rx_timestamp_dynfield_offset,
> - &event_eth_rx_timestamp_dynflag) != 0) {
> - RTE_EDEV_LOG_ERR("Error registering timestamp field in
> mbuf\n");
> - return -rte_errno;
> - }
> -
> rte_eventdev_trace_eth_rx_adapter_create(id, dev_id, conf_cb,
> conf_arg);
> return 0;
> @@ -2738,6 +2731,7 @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
> 1);
> }
> } else {
> + uint64_t dev_offloads;
> rte_spinlock_lock(&rx_adapter->rx_lock);
> dev_info->internal_event_port = 0;
> ret = rxa_init_service(rx_adapter, id); @@ -2749,6 +2743,17
> @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
> rxa_sw_adapter_queue_count(rx_adapter));
> }
> rte_spinlock_unlock(&rx_adapter->rx_lock);
> +
> + dev_offloads = dev_info->dev->data-
> >dev_conf.rxmode.offloads;
This is a one-time operation and need not happen for every queue_add.
Move this registration to "rxa_init_service()" function which executes only once for creating rte_service.
Also, no need to check for offload capabilities and directly do the registration inside
Rxa_init_service as done before in rxa_create.
Mbuf field is global to the entire application and need not be done based on ethdev offload capabilities.
> + if (dev_offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) {
> + if (rte_mbuf_dyn_rx_timestamp_register(
> +
> &event_eth_rx_timestamp_dynfield_offset,
> +
> &event_eth_rx_timestamp_dynflag) != 0) {
> + RTE_EDEV_LOG_ERR("Error registering
> timestamp field in mbuf\n");
> + return -rte_errno;
> + }
> + }
> +
> }
>
> rte_eventdev_trace_eth_rx_adapter_queue_add(id, eth_dev_id,
> --
> 2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf
2023-09-20 12:32 ` Naga Harish K, S V
@ 2023-09-20 16:17 ` Rahul Bhansali
0 siblings, 0 replies; 10+ messages in thread
From: Rahul Bhansali @ 2023-09-20 16:17 UTC (permalink / raw)
To: Naga Harish K, S V, dev, Jerin Jacob Kollanukkaran, Kundapura, Ganapati
Cc: stable
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Wednesday, September 20, 2023 6:03 PM
> To: Rahul Bhansali <rbhansali@marvell.com>; dev@dpdk.org; Jerin Jacob
> Kollanukkaran <jerinj@marvell.com>; Kundapura, Ganapati
> <ganapati.kundapura@intel.com>
> Cc: stable@dpdk.org
> Subject: [EXT] RE: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf
>
> External Email
>
> ----------------------------------------------------------------------
>
>
> > -----Original Message-----
> > From: Rahul Bhansali <rbhansali@marvell.com>
> > Sent: Monday, September 18, 2023 1:56 PM
> > To: dev@dpdk.org; Naga Harish K, S V <s.v.naga.harish.k@intel.com>;
> > Jerin Jacob <jerinj@marvell.com>; Kundapura, Ganapati
> > <ganapati.kundapura@intel.com>
> > Cc: Rahul Bhansali <rbhansali@marvell.com>; stable@dpdk.org
> > Subject: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf
> >
> > For eventdev internal port, timestamp dynamic field registration in
> > mbuf is not required as that will be done from net device.
> > For SW eventdev, Rx timestamp field registration will be done during
> > Rx queue add operation as per device capabilities and offload configuration.
> >
> > Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf
> > field")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
> > ---
> > lib/eventdev/rte_event_eth_rx_adapter.c | 19 ++++++++++++-------
> > 1 file changed, 12 insertions(+), 7 deletions(-)
> >
> > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
> > b/lib/eventdev/rte_event_eth_rx_adapter.c
> > index 3ebfa5366d..5a5fade466 100644
> > --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> > @@ -2472,13 +2472,6 @@ rxa_create(uint8_t id, uint8_t dev_id,
> > if (conf_cb == rxa_default_conf_cb)
> > rx_adapter->default_cb_arg = 1;
> >
> > - if (rte_mbuf_dyn_rx_timestamp_register(
> > - &event_eth_rx_timestamp_dynfield_offset,
> > - &event_eth_rx_timestamp_dynflag) != 0) {
> > - RTE_EDEV_LOG_ERR("Error registering timestamp field in
> > mbuf\n");
> > - return -rte_errno;
> > - }
> > -
> > rte_eventdev_trace_eth_rx_adapter_create(id, dev_id, conf_cb,
> > conf_arg);
> > return 0;
> > @@ -2738,6 +2731,7 @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
> > 1);
> > }
> > } else {
> > + uint64_t dev_offloads;
> > rte_spinlock_lock(&rx_adapter->rx_lock);
> > dev_info->internal_event_port = 0;
> > ret = rxa_init_service(rx_adapter, id); @@ -2749,6 +2743,17
> @@
> > rte_event_eth_rx_adapter_queue_add(uint8_t id,
> > rxa_sw_adapter_queue_count(rx_adapter));
> > }
> > rte_spinlock_unlock(&rx_adapter->rx_lock);
> > +
> > + dev_offloads = dev_info->dev->data-
> > >dev_conf.rxmode.offloads;
>
> This is a one-time operation and need not happen for every queue_add.
> Move this registration to "rxa_init_service()" function which executes only once
> for creating rte_service.
>
> Also, no need to check for offload capabilities and directly do the registration
> inside Rxa_init_service as done before in rxa_create.
> Mbuf field is global to the entire application and need not be done based on
> ethdev offload capabilities.
>
>
Ack, will address and send v2.
> > + if (dev_offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) {
> > + if (rte_mbuf_dyn_rx_timestamp_register(
> > +
> > &event_eth_rx_timestamp_dynfield_offset,
> > +
> > &event_eth_rx_timestamp_dynflag) != 0) {
> > + RTE_EDEV_LOG_ERR("Error registering
> > timestamp field in mbuf\n");
> > + return -rte_errno;
> > + }
> > + }
> > +
> > }
> >
> > rte_eventdev_trace_eth_rx_adapter_queue_add(id, eth_dev_id,
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] eventdev/eth_rx: fix timestamp field register in mbuf
2023-09-18 8:25 [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf Rahul Bhansali
2023-09-19 16:29 ` Jerin Jacob
2023-09-20 12:32 ` Naga Harish K, S V
@ 2023-09-20 16:32 ` Rahul Bhansali
2023-09-20 16:48 ` [PATCH v3] " Rahul Bhansali
3 siblings, 0 replies; 10+ messages in thread
From: Rahul Bhansali @ 2023-09-20 16:32 UTC (permalink / raw)
To: dev, Naga Harish K S V, Jerin Jacob, Ganapati Kundapura
Cc: Rahul Bhansali, stable
For eventdev internal port, timestamp dynamic field registration
in mbuf is not required as that will be done from net device.
For SW eventdev, Rx timestamp field registration will be
done during Rxa service initialization.
Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf field")
Cc: stable@dpdk.org
Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
---
v2 changes:
- addresses the review comment to have registration in rxa_init_service()
lib/eventdev/rte_event_eth_rx_adapter.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index 3ebfa5366d..ddab5a71d7 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -1932,6 +1932,14 @@ rxa_init_service(struct event_eth_rx_adapter *rx_adapter, uint8_t id)
ret);
goto err_done;
}
+
+ if (rte_mbuf_dyn_rx_timestamp_register(
+ &event_eth_rx_timestamp_dynfield_offset,
+ &event_eth_rx_timestamp_dynflag) != 0) {
+ RTE_EDEV_LOG_ERR("Error registering timestamp field in mbuf\n");
+ return -rte_errno;
+ }
+
rx_adapter->event_port_id = rx_adapter_conf.event_port_id;
rx_adapter->max_nb_rx = rx_adapter_conf.max_nb_rx;
rx_adapter->service_inited = 1;
@@ -2472,13 +2480,6 @@ rxa_create(uint8_t id, uint8_t dev_id,
if (conf_cb == rxa_default_conf_cb)
rx_adapter->default_cb_arg = 1;
- if (rte_mbuf_dyn_rx_timestamp_register(
- &event_eth_rx_timestamp_dynfield_offset,
- &event_eth_rx_timestamp_dynflag) != 0) {
- RTE_EDEV_LOG_ERR("Error registering timestamp field in mbuf\n");
- return -rte_errno;
- }
-
rte_eventdev_trace_eth_rx_adapter_create(id, dev_id, conf_cb,
conf_arg);
return 0;
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf
2023-09-18 8:25 [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf Rahul Bhansali
` (2 preceding siblings ...)
2023-09-20 16:32 ` [PATCH v2] " Rahul Bhansali
@ 2023-09-20 16:48 ` Rahul Bhansali
2023-09-26 7:04 ` Naga Harish K, S V
3 siblings, 1 reply; 10+ messages in thread
From: Rahul Bhansali @ 2023-09-20 16:48 UTC (permalink / raw)
To: dev, Naga Harish K S V, Jerin Jacob, Ganapati Kundapura
Cc: Rahul Bhansali, stable
For eventdev internal port, timestamp dynamic field registration
in mbuf is not required as that will be done from net device.
For SW eventdev, Rx timestamp field registration will be
done during Rxa service initialization.
Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf field")
Cc: stable@dpdk.org
Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
---
v3 changes:
- timestamp register move before other Rxa init config.
v2 changes:
- addresses the review comment to have registration in rxa_init_service()
lib/eventdev/rte_event_eth_rx_adapter.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index 3ebfa5366d..8df92247fa 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -1910,6 +1910,13 @@ rxa_init_service(struct event_eth_rx_adapter *rx_adapter, uint8_t id)
if (rx_adapter->service_inited)
return 0;
+ if (rte_mbuf_dyn_rx_timestamp_register(
+ &event_eth_rx_timestamp_dynfield_offset,
+ &event_eth_rx_timestamp_dynflag) != 0) {
+ RTE_EDEV_LOG_ERR("Error registering timestamp field in mbuf\n");
+ return -rte_errno;
+ }
+
memset(&service, 0, sizeof(service));
snprintf(service.name, ETH_RX_ADAPTER_SERVICE_NAME_LEN,
"rte_event_eth_rx_adapter_%d", id);
@@ -2472,13 +2479,6 @@ rxa_create(uint8_t id, uint8_t dev_id,
if (conf_cb == rxa_default_conf_cb)
rx_adapter->default_cb_arg = 1;
- if (rte_mbuf_dyn_rx_timestamp_register(
- &event_eth_rx_timestamp_dynfield_offset,
- &event_eth_rx_timestamp_dynflag) != 0) {
- RTE_EDEV_LOG_ERR("Error registering timestamp field in mbuf\n");
- return -rte_errno;
- }
-
rte_eventdev_trace_eth_rx_adapter_create(id, dev_id, conf_cb,
conf_arg);
return 0;
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf
2023-09-19 16:29 ` Jerin Jacob
@ 2023-09-25 10:18 ` Naga Harish K, S V
2023-09-26 7:37 ` Jerin Jacob
0 siblings, 1 reply; 10+ messages in thread
From: Naga Harish K, S V @ 2023-09-25 10:18 UTC (permalink / raw)
To: Jerin Jacob, Rahul Bhansali; +Cc: dev, Jerin Jacob, Kundapura, Ganapati, stable
[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]
As per the DPDK contribution guidelines,
Ideally, the review should be done within 1 week of patch submission to the mailing list.
https://doc.dpdk.org/guides/contributing/patches.html
Surprised to see this review request ping message the very next day of the patch.
Better to follow the contribution guidelines.
-Harish
________________________________
From: Jerin Jacob <jerinjacobk@gmail.com>
Sent: Tuesday, September 19, 2023 9:59 PM
To: Rahul Bhansali <rbhansali@marvell.com>
Cc: dev@dpdk.org <dev@dpdk.org>; Naga Harish K, S V <s.v.naga.harish.k@intel.com>; Jerin Jacob <jerinj@marvell.com>; Kundapura, Ganapati <Ganapati.Kundapura@intel.com>; stable@dpdk.org <stable@dpdk.org>
Subject: Re: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf
On Mon, Sep 18, 2023 at 6:46 PM Rahul Bhansali <rbhansali@marvell.com> wrote:
>
> For eventdev internal port, timestamp dynamic field registration
> in mbuf is not required as that will be done from net device.
> For SW eventdev, Rx timestamp field registration will be
> done during Rx queue add operation as per device capabilities and
> offload configuration.
>
> Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf field")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
Ping for review from maintainer.
[-- Attachment #2: Type: text/html, Size: 4735 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf
2023-09-20 16:48 ` [PATCH v3] " Rahul Bhansali
@ 2023-09-26 7:04 ` Naga Harish K, S V
2023-09-27 4:58 ` Jerin Jacob
0 siblings, 1 reply; 10+ messages in thread
From: Naga Harish K, S V @ 2023-09-26 7:04 UTC (permalink / raw)
To: Rahul Bhansali, dev, Jerin Jacob, Kundapura, Ganapati; +Cc: stable
> -----Original Message-----
> From: Rahul Bhansali <rbhansali@marvell.com>
> Sent: Wednesday, September 20, 2023 10:18 PM
> To: dev@dpdk.org; Naga Harish K, S V <s.v.naga.harish.k@intel.com>; Jerin
> Jacob <jerinj@marvell.com>; Kundapura, Ganapati
> <ganapati.kundapura@intel.com>
> Cc: Rahul Bhansali <rbhansali@marvell.com>; stable@dpdk.org
> Subject: [PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf
>
> For eventdev internal port, timestamp dynamic field registration in mbuf is not
> required as that will be done from net device.
> For SW eventdev, Rx timestamp field registration will be done during Rxa
> service initialization.
>
> Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf
> field")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
Acked-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> ---
> v3 changes:
> - timestamp register move before other Rxa init config.
>
> v2 changes:
> - addresses the review comment to have registration in rxa_init_service()
>
> lib/eventdev/rte_event_eth_rx_adapter.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
> b/lib/eventdev/rte_event_eth_rx_adapter.c
> index 3ebfa5366d..8df92247fa 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -1910,6 +1910,13 @@ rxa_init_service(struct event_eth_rx_adapter
> *rx_adapter, uint8_t id)
> if (rx_adapter->service_inited)
> return 0;
>
> + if (rte_mbuf_dyn_rx_timestamp_register(
> + &event_eth_rx_timestamp_dynfield_offset,
> + &event_eth_rx_timestamp_dynflag) != 0) {
> + RTE_EDEV_LOG_ERR("Error registering timestamp field in
> mbuf\n");
> + return -rte_errno;
> + }
> +
> memset(&service, 0, sizeof(service));
> snprintf(service.name, ETH_RX_ADAPTER_SERVICE_NAME_LEN,
> "rte_event_eth_rx_adapter_%d", id);
> @@ -2472,13 +2479,6 @@ rxa_create(uint8_t id, uint8_t dev_id,
> if (conf_cb == rxa_default_conf_cb)
> rx_adapter->default_cb_arg = 1;
>
> - if (rte_mbuf_dyn_rx_timestamp_register(
> - &event_eth_rx_timestamp_dynfield_offset,
> - &event_eth_rx_timestamp_dynflag) != 0) {
> - RTE_EDEV_LOG_ERR("Error registering timestamp field in
> mbuf\n");
> - return -rte_errno;
> - }
> -
> rte_eventdev_trace_eth_rx_adapter_create(id, dev_id, conf_cb,
> conf_arg);
> return 0;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf
2023-09-25 10:18 ` Naga Harish K, S V
@ 2023-09-26 7:37 ` Jerin Jacob
0 siblings, 0 replies; 10+ messages in thread
From: Jerin Jacob @ 2023-09-26 7:37 UTC (permalink / raw)
To: Naga Harish K, S V, Qi Zhang, Thomas Monjalon, Ali Alnubani,
Ferruh Yigit, David Marchand, Andrew Rybchenko, Ajit Khaparde,
Raslan Darawsheh, Maxime Coquelin, cheng1.jiang, Akhil Goyal,
Richardson, Bruce
Cc: Rahul Bhansali, dev, Jerin Jacob, Kundapura, Ganapati, stable
On Mon, Sep 25, 2023 at 3:48 PM Naga Harish K, S V
<s.v.naga.harish.k@intel.com> wrote:
>
> As per the DPDK contribution guidelines,
> Ideally, the review should be done within 1 week of patch submission to the mailing list.
> https://doc.dpdk.org/guides/contributing/patches.html
>
> Surprised to see this review request ping message the very next day of the patch.
> Better to follow the contribution guidelines.
+ @Thomas Monjalon @Ali Alnubani @Ferruh Yigit @David Marchand
@Andrew Rybchenko @Ajit Khaparde @Qi Zhang @Raslan Darawsheh @Maxime
Coquelin @cheng1.jiang@intel.com @Akhil Goyal @Richardson, Bruce
Yes, and I agree, and thanks for reporting this. I usually merge a set
of patches together and call for review action if something pending in
my list. I was not looking to the timestamp as it was manual.
Seems like good feature additions in patchwork if it not ready
available or if available then we can configure for DPDK.
i.e., if patchwork can track email time for the patch and flag for no
reviewed happened in N days(N as configurable) to help maintainers.
Also, Get list of pending patches on component maintainers(I think,
currently we can get only based on tree delegation) not per component
maintainer.
>
> -Harish
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf
2023-09-26 7:04 ` Naga Harish K, S V
@ 2023-09-27 4:58 ` Jerin Jacob
0 siblings, 0 replies; 10+ messages in thread
From: Jerin Jacob @ 2023-09-27 4:58 UTC (permalink / raw)
To: Naga Harish K, S V
Cc: Rahul Bhansali, dev, Jerin Jacob, Kundapura, Ganapati, stable
On Wed, Sep 27, 2023 at 2:41 AM Naga Harish K, S V
<s.v.naga.harish.k@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Rahul Bhansali <rbhansali@marvell.com>
> > Sent: Wednesday, September 20, 2023 10:18 PM
> > To: dev@dpdk.org; Naga Harish K, S V <s.v.naga.harish.k@intel.com>; Jerin
> > Jacob <jerinj@marvell.com>; Kundapura, Ganapati
> > <ganapati.kundapura@intel.com>
> > Cc: Rahul Bhansali <rbhansali@marvell.com>; stable@dpdk.org
> > Subject: [PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf
> >
> > For eventdev internal port, timestamp dynamic field registration in mbuf is not
> > required as that will be done from net device.
> > For SW eventdev, Rx timestamp field registration will be done during Rxa
> > service initialization.
> >
> > Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf
> > field")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
>
> Acked-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-09-27 4:59 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-18 8:25 [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf Rahul Bhansali
2023-09-19 16:29 ` Jerin Jacob
2023-09-25 10:18 ` Naga Harish K, S V
2023-09-26 7:37 ` Jerin Jacob
2023-09-20 12:32 ` Naga Harish K, S V
2023-09-20 16:17 ` Rahul Bhansali
2023-09-20 16:32 ` [PATCH v2] " Rahul Bhansali
2023-09-20 16:48 ` [PATCH v3] " Rahul Bhansali
2023-09-26 7:04 ` Naga Harish K, S V
2023-09-27 4:58 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).