patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] eal: fix epoll fd list rebuild
@ 2020-05-11 13:43 Harman Kalra
  2020-05-24 15:30 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  0 siblings, 1 reply; 9+ messages in thread
From: Harman Kalra @ 2020-05-11 13:43 UTC (permalink / raw)
  To: stephen, jgrajcia, david.marchand; +Cc: dev, Harman Kalra, stable

An issue has been observed where epoll file descriptor
list rebuilds every time an interrupt/alarm event is
received.

eal_intr_process_interrupts() should notify pipe fd only
if any source is removed from the source list i.e (rv > 0)

Fixes: 0c7ce182a760 ("eal: add pending interrupt callback unregister"
Cc: stable@dpdk.org

Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
 lib/librte_eal/linux/eal_interrupts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/linux/eal_interrupts.c b/lib/librte_eal/linux/eal_interrupts.c
index 16e7a7d51..84eeaa1bc 100644
--- a/lib/librte_eal/linux/eal_interrupts.c
+++ b/lib/librte_eal/linux/eal_interrupts.c
@@ -1010,7 +1010,7 @@ eal_intr_process_interrupts(struct epoll_event *events, int nfds)
 		}
 
 		/* notify the pipe fd waited by epoll_wait to rebuild the wait list */
-		if (rv >= 0 && write(intr_pipe.writefd, "1", 1) < 0) {
+		if (rv > 0 && write(intr_pipe.writefd, "1", 1) < 0) {
 			rte_spinlock_unlock(&intr_lock);
 			return -EPIPE;
 		}
-- 
2.18.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix epoll fd list rebuild
  2020-05-11 13:43 [dpdk-stable] [PATCH] eal: fix epoll fd list rebuild Harman Kalra
@ 2020-05-24 15:30 ` " Thomas Monjalon
  2020-05-25  9:49   ` [dpdk-stable] [EXT] " Harman Kalra
  2020-06-19 13:59   ` [dpdk-stable] [PATCH v2] " Harman Kalra
  0 siblings, 2 replies; 9+ messages in thread
From: Thomas Monjalon @ 2020-05-24 15:30 UTC (permalink / raw)
  To: Harman Kalra; +Cc: stephen, jgrajcia, david.marchand, dev, stable

11/05/2020 15:43, Harman Kalra:
> An issue has been observed where epoll file descriptor
> list rebuilds every time an interrupt/alarm event is
> received.
> 
> eal_intr_process_interrupts() should notify pipe fd only
> if any source is removed from the source list i.e (rv > 0)
> 
> Fixes: 0c7ce182a760 ("eal: add pending interrupt callback unregister"
> Cc: stable@dpdk.org
> 
> Signed-off-by: Harman Kalra <hkalra@marvell.com>

This patch is missing 20.05 because no review was done.
In general, we are missing a maintainer on "interrupts" area.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [EXT] Re: [dpdk-dev] [PATCH] eal: fix epoll fd list rebuild
  2020-05-24 15:30 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
@ 2020-05-25  9:49   ` " Harman Kalra
  2020-05-27 12:32     ` [dpdk-stable] [dpdk-dev] [EXT] " Harman Kalra
  2020-06-19 13:59   ` [dpdk-stable] [PATCH v2] " Harman Kalra
  1 sibling, 1 reply; 9+ messages in thread
From: Harman Kalra @ 2020-05-25  9:49 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: stephen, jgrajcia, david.marchand, dev, stable

On Sun, May 24, 2020 at 05:30:26PM +0200, Thomas Monjalon wrote:
> External Email
> 
> ----------------------------------------------------------------------
> 11/05/2020 15:43, Harman Kalra:
> > An issue has been observed where epoll file descriptor
> > list rebuilds every time an interrupt/alarm event is
> > received.
> > 
> > eal_intr_process_interrupts() should notify pipe fd only
> > if any source is removed from the source list i.e (rv > 0)
> > 
> > Fixes: 0c7ce182a760 ("eal: add pending interrupt callback unregister"
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Harman Kalra <hkalra@marvell.com>
> 
> This patch is missing 20.05 because no review was done.
> In general, we are missing a maintainer on "interrupts" area.

Hi Thomas,

If everybody is fine we can take up the responsibility of maintaining
interrupt subsystem. I can send a patch to update maintainer list for
the same.

Thanks
Harman

> 
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [EXT] Re: [PATCH] eal: fix epoll fd list rebuild
  2020-05-25  9:49   ` [dpdk-stable] [EXT] " Harman Kalra
@ 2020-05-27 12:32     ` " Harman Kalra
  2020-05-27 12:44       ` Harman Kalra
  0 siblings, 1 reply; 9+ messages in thread
From: Harman Kalra @ 2020-05-27 12:32 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: stephen, jgrajcia, david.marchand, dev, stable

On Mon, May 25, 2020 at 03:19:08PM +0530, Harman Kalra wrote:
> On Sun, May 24, 2020 at 05:30:26PM +0200, Thomas Monjalon wrote:
> > External Email
> > 
> > ----------------------------------------------------------------------
> > 11/05/2020 15:43, Harman Kalra:
> > > An issue has been observed where epoll file descriptor
> > > list rebuilds every time an interrupt/alarm event is
> > > received.
> > > 
> > > eal_intr_process_interrupts() should notify pipe fd only
> > > if any source is removed from the source list i.e (rv > 0)
> > > 
> > > Fixes: 0c7ce182a760 ("eal: add pending interrupt callback unregister"
> > > Cc: stable@dpdk.org
> > > 
> > > Signed-off-by: Harman Kalra <hkalra@marvell.com>
> > 
> > This patch is missing 20.05 because no review was done.
> > In general, we are missing a maintainer on "interrupts" area.
> 

Ping.

> Hi Thomas,
> 
> If everybody is fine we can take up the responsibility of maintaining
> interrupt subsystem. I can send a patch to update maintainer list for
> the same.
> 
> Thanks
> Harman
> 
> > 
> > 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [EXT] Re: [PATCH] eal: fix epoll fd list rebuild
  2020-05-27 12:32     ` [dpdk-stable] [dpdk-dev] [EXT] " Harman Kalra
@ 2020-05-27 12:44       ` Harman Kalra
  2020-05-27 13:04         ` Thomas Monjalon
  0 siblings, 1 reply; 9+ messages in thread
From: Harman Kalra @ 2020-05-27 12:44 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: stephen, jgrajcia, david.marchand, dev, stable

On Wed, May 27, 2020 at 06:02:53PM +0530, Harman Kalra wrote:
> On Mon, May 25, 2020 at 03:19:08PM +0530, Harman Kalra wrote:
> > On Sun, May 24, 2020 at 05:30:26PM +0200, Thomas Monjalon wrote:
> > > External Email
> > > 
> > > ----------------------------------------------------------------------
> > > 11/05/2020 15:43, Harman Kalra:
> > > > An issue has been observed where epoll file descriptor
> > > > list rebuilds every time an interrupt/alarm event is
> > > > received.
> > > > 
> > > > eal_intr_process_interrupts() should notify pipe fd only
> > > > if any source is removed from the source list i.e (rv > 0)
> > > > 
> > > > Fixes: 0c7ce182a760 ("eal: add pending interrupt callback unregister"
> > > > Cc: stable@dpdk.org
> > > > 
> > > > Signed-off-by: Harman Kalra <hkalra@marvell.com>
> > > 
> > > This patch is missing 20.05 because no review was done.
> > > In general, we are missing a maintainer on "interrupts" area.
> > 
> 
> Ping.
> 
> > Hi Thomas,
> > 
> > If everybody is fine we can take up the responsibility of maintaining
> > interrupt subsystem. I can send a patch to update maintainer list for
> > the same.

Sorry for wrong placement of ping in my last mail, as it is bit
confusing if it was for the patch.

Rather intention of this ping is to get input if we can take up the
maintainership of interrupt subsystem to help the community with the
reviews.

> > 
> > Thanks
> > Harman
> > 
> > > 
> > > 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [EXT] Re: [PATCH] eal: fix epoll fd list rebuild
  2020-05-27 12:44       ` Harman Kalra
@ 2020-05-27 13:04         ` Thomas Monjalon
  2020-05-27 17:19           ` Harman Kalra
  0 siblings, 1 reply; 9+ messages in thread
From: Thomas Monjalon @ 2020-05-27 13:04 UTC (permalink / raw)
  To: Harman Kalra; +Cc: stephen, jgrajcia, david.marchand, dev, stable

27/05/2020 14:44, Harman Kalra:
> On Wed, May 27, 2020 at 06:02:53PM +0530, Harman Kalra wrote:
> > On Mon, May 25, 2020 at 03:19:08PM +0530, Harman Kalra wrote:
> > > On Sun, May 24, 2020 at 05:30:26PM +0200, Thomas Monjalon wrote:
> > > > This patch is missing 20.05 because no review was done.
> > > > In general, we are missing a maintainer on "interrupts" area.
> > 
> > Ping.
> > 
> > > Hi Thomas,
> > > 
> > > If everybody is fine we can take up the responsibility of maintaining
> > > interrupt subsystem. I can send a patch to update maintainer list for
> > > the same.
> 
> Sorry for wrong placement of ping in my last mail, as it is bit
> confusing if it was for the patch.
> 
> Rather intention of this ping is to get input if we can take up the
> maintainership of interrupt subsystem to help the community with the
> reviews.

Please Cc everybody who contributed to this code.
Thanks




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [EXT] Re: [PATCH] eal: fix epoll fd list rebuild
  2020-05-27 13:04         ` Thomas Monjalon
@ 2020-05-27 17:19           ` Harman Kalra
  0 siblings, 0 replies; 9+ messages in thread
From: Harman Kalra @ 2020-05-27 17:19 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: stephen, jgrajcia, david.marchand, dev, anatoly.burakov,
	cunming.liang, jianfeng.tan, ndabilpuram, jia.guo, danny.zhou,
	jblunck, nelio.laranjeiro, bluca, shahafs, stable

On Wed, May 27, 2020 at 03:04:04PM +0200, Thomas Monjalon wrote:
> 27/05/2020 14:44, Harman Kalra:
> > On Wed, May 27, 2020 at 06:02:53PM +0530, Harman Kalra wrote:
> > > On Mon, May 25, 2020 at 03:19:08PM +0530, Harman Kalra wrote:
> > > > On Sun, May 24, 2020 at 05:30:26PM +0200, Thomas Monjalon wrote:
> > > > > This patch is missing 20.05 because no review was done.
> > > > > In general, we are missing a maintainer on "interrupts" area.
> > > 
> > > Ping.
> > > 
> > > > Hi Thomas,
> > > > 
> > > > If everybody is fine we can take up the responsibility of maintaining
> > > > interrupt subsystem. I can send a patch to update maintainer list for
> > > > the same.
> > 
> > Sorry for wrong placement of ping in my last mail, as it is bit
> > confusing if it was for the patch.
> > 
> > Rather intention of this ping is to get input if we can take up the
> > maintainership of interrupt subsystem to help the community with the
> > reviews.
> 
> Please Cc everybody who contributed to this code.
> Thanks

Adding all the code contributors for interrupt subsystem in CC.

Currently eal interrupt layer doesnt have a maintainer, if anybody
is willing to take up the responsibility for maintaining it, please feel
free to take it up or else I would like to volunteer for the same if
everybody is fine with the decision.

Thanks
Harman

> 
> 
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [dpdk-stable] [PATCH v2] eal: fix epoll fd list rebuild
  2020-05-24 15:30 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  2020-05-25  9:49   ` [dpdk-stable] [EXT] " Harman Kalra
@ 2020-06-19 13:59   ` " Harman Kalra
  2020-06-24  8:01     ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  1 sibling, 1 reply; 9+ messages in thread
From: Harman Kalra @ 2020-06-19 13:59 UTC (permalink / raw)
  To: stephen, jgrajcia, david.marchand; +Cc: dev, Harman Kalra, stable

An issue has been observed where epoll file descriptor
list rebuilds every time an interrupt/alarm event is
received.

eal_intr_process_interrupts() should notify pipe fd only
if any source is removed from the source list i.e (rv > 0)

Fixes: 0c7ce182a760 ("eal: add pending interrupt callback unregister")
Cc: stable@dpdk.org

Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
*V2: missing closing bracket in Fixes tag in V1

 lib/librte_eal/linux/eal_interrupts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/linux/eal_interrupts.c b/lib/librte_eal/linux/eal_interrupts.c
index 16e7a7d51..84eeaa1bc 100644
--- a/lib/librte_eal/linux/eal_interrupts.c
+++ b/lib/librte_eal/linux/eal_interrupts.c
@@ -1010,7 +1010,7 @@ eal_intr_process_interrupts(struct epoll_event *events, int nfds)
 		}
 
 		/* notify the pipe fd waited by epoll_wait to rebuild the wait list */
-		if (rv >= 0 && write(intr_pipe.writefd, "1", 1) < 0) {
+		if (rv > 0 && write(intr_pipe.writefd, "1", 1) < 0) {
 			rte_spinlock_unlock(&intr_lock);
 			return -EPIPE;
 		}
-- 
2.18.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] eal: fix epoll fd list rebuild
  2020-06-19 13:59   ` [dpdk-stable] [PATCH v2] " Harman Kalra
@ 2020-06-24  8:01     ` " Thomas Monjalon
  0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2020-06-24  8:01 UTC (permalink / raw)
  To: Harman Kalra; +Cc: stephen, jgrajcia, david.marchand, dev, stable

19/06/2020 15:59, Harman Kalra:
> An issue has been observed where epoll file descriptor
> list rebuilds every time an interrupt/alarm event is
> received.
> 
> eal_intr_process_interrupts() should notify pipe fd only
> if any source is removed from the source list i.e (rv > 0)
> 
> Fixes: 0c7ce182a760 ("eal: add pending interrupt callback unregister")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Harman Kalra <hkalra@marvell.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11 13:43 [dpdk-stable] [PATCH] eal: fix epoll fd list rebuild Harman Kalra
2020-05-24 15:30 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2020-05-25  9:49   ` [dpdk-stable] [EXT] " Harman Kalra
2020-05-27 12:32     ` [dpdk-stable] [dpdk-dev] [EXT] " Harman Kalra
2020-05-27 12:44       ` Harman Kalra
2020-05-27 13:04         ` Thomas Monjalon
2020-05-27 17:19           ` Harman Kalra
2020-06-19 13:59   ` [dpdk-stable] [PATCH v2] " Harman Kalra
2020-06-24  8:01     ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox