patches for DPDK stable branches
 help / color / mirror / Atom feed
* 21.11.4 patches review and test
@ 2023-04-06 11:37 Kevin Traynor
  2023-04-13  6:12 ` Xu, HailinX
  2023-04-19 13:24 ` Ali Alnubani
  0 siblings, 2 replies; 15+ messages in thread
From: Kevin Traynor @ 2023-04-06 11:37 UTC (permalink / raw)
  To: stable
  Cc: dev, Abhishek Marathe, Ali Alnubani, benjamin.walker,
	David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
	John McNamara, Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi,
	Pei Zhang, qian.q.xu, Raslan Darawsheh, Thomas Monjalon,
	yanghliu, yuan.peng, zhaoyan.chen

Hi all,

Here is a list of patches targeted for stable release 21.11.4.

The planned date for the final release is 25th April.

Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1

These patches are located at branch 21.11 of dpdk-stable repo:
    https://dpdk.org/browse/dpdk-stable/

Thanks.

Kevin

---
Akhil Goyal (1):
      examples/ipsec-secgw: fix auth IV length

Alexander Kozyrev (4):
      net/mlx5: fix error CQE dumping for vectorized Rx
      net/mlx5: ignore non-critical syndromes for Rx queue
      net/mlx5: check compressed CQE opcode in vectorized Rx
      net/mlx5: fix CQE dump for Tx

Andy Pei (2):
      vdpa/ifc: fix argument compatibility check
      vdpa/ifc: fix reconnection in SW-assisted live migration

Anoob Joseph (3):
      app/crypto-perf: fix number of segments
      app/crypto-perf: fix SPI zero
      app/crypto-perf: fix IPsec direction

Arkadiusz Kusztal (1):
      app/compress-perf: fix remaining data for ops

Ashish Sadanandan (1):
      eal/linux: fix hugetlbfs sub-directories discovery

Ben Magistro (1):
      app/dumpcap: fix storing port identifier

Bing Zhao (2):
      net/mlx5: fix hairpin Tx queue reference count
      net/mlx5: fix sysfs port name translation

Boleslav Stankevich (1):
      net/virtio: deduce IP length for TSO checksum

Bruce Richardson (8):
      dma/ioat: fix device stop if no copies done
      dma/ioat: fix indexes after restart
      dma/ioat: fix error reporting on restart
      build: fix toolchain definition
      examples/cmdline: fix build with GCC 12
      examples/qos_sched: fix Tx port config when link down
      mailmap: add list of contributors
      examples/qos_sched: fix config entries in wrong sections

Chengwen Feng (13):
      mem: fix hugepage info mapping
      raw/ifpga/base: fix init with multi-process
      telemetry: fix repeat display when callback don't init dict
      net/hns3: declare flow rule keeping capability
      eal/freebsd: fix lock in alarm callback
      kvargs: add API documentation for process callback
      compressdev: fix empty devargs parsing
      cryptodev: fix empty devargs parsing
      net/hns3: fix empty devargs parsing
      net/virtio: fix empty devargs parsing
      dma/skeleton: fix empty devargs parsing
      raw/skeleton: fix empty devargs parsing
      net/hns3: remove unused structures

Ciara Power (4):
      crypto/qat: fix stream cipher direction
      app/crypto-perf: fix test file memory leak
      test/crypto: fix ZUC digest length in comparison
      test/crypto: fix capability check for ZUC cipher-auth

David Christensen (1):
      acl: fix crash on PPC64 with GCC 11

David Marchand (21):
      hash: fix GFNI implementation build with GCC 12
      fbarray: fix metadata dump
      gpudev: fix deadlocks when registering callback
      graph: fix node shrink
      crypto/ccp: remove some printf
      crypto/ccp: remove some dead code for UIO
      crypto/ccp: fix IOVA handling
      net/iavf: protect insertion in flow list
      app/testpmd: fix crash on cleanup
      doc: fix reference to event timer header
      vhost: fix OOB access for invalid vhost ID
      app/testpmd: fix Tx preparation in checksum engine
      app/testpmd: fix packet count in IEEE 1588 engine
      app/testpmd: fix packet transmission in noisy VNF engine
      raw/skeleton: fix selftest
      net/vhost: add missing newline in logs
      net/vhost: fix leak in interrupt handle setup
      net/vhost: fix Rx interrupt
      net/virtio: remove address width limit for modern devices
      net/mlx5: fix build with GCC 12 and ASan
      ci: switch to Ubuntu 20.04

Edwin Brossette (1):
      net/bnxt: fix link state change interrupt config

Erik Gabriel Carrillo (1):
      eventdev/timer: fix overflow

Fengnan Chang (1):
      eal: cleanup alarm and hotplug before memory detach

Ferruh Yigit (4):
      kni: fix build on RHEL 9.1
      app/testpmd: fix forwarding stats for Tx dropped
      app/testpmd: fix link check condition on port start
      ethdev: remove telemetry Rx mbuf alloc failed field

Gerry Gribbon (2):
      regex/mlx5: utilize all available queue pairs
      regex/mlx5: fix doorbell record

Gowrishankar Muthukrishnan (1):
      common/cnxk: fix auth key length

Gregory Etelson (1):
      app/testpmd: fix interactive mode with no ports

Harshad Narayane (1):
      doc: fix pipeline example path in user guide

Hernan Vargas (6):
      baseband/acc: fix memory leak on acc100 close
      baseband/acc: fix acc100 iteration counter in TB
      test/bbdev: fix crash for non supported HARQ length
      test/bbdev: extend HARQ tolerance
      test/bbdev: remove check for invalid opaque data
      app/bbdev: check statistics failure

Honnappa Nagarahalli (1):
      eal: use same atomic intrinsics for GCC and clang

Huisong Li (39):
      net/hns3: fix inaccurate RTC time to read
      telemetry: move include after guard
      ethdev: fix telemetry data truncation
      mempool: fix telemetry data truncation
      cryptodev: fix telemetry data truncation
      mem: fix telemetry data truncation
      net/hns3: fix log about indirection table size
      net/hns3: extract common function to query device
      net/hns3: refactor set RSS hash algorithm and key interface
      net/hns3: fix clearing RSS configuration
      net/hns3: use RSS filter list to check duplicated rule
      net/hns3: remove useless code when destroy valid RSS rule
      net/hns3: fix warning on flush or destroy rule
      net/hns3: fix config struct used for conversion
      net/hns3: fix duplicate RSS rule check
      net/hns3: add debug info for Rx/Tx dummy function
      net/hns3: remove debug condition for Tx prepare
      mem: fix heap ID in telemetry
      net/hns3: fix possible truncation of hash key when config
      net/hns3: fix possible truncation of redirection table
      net/hns3: use hardware config to report redirection table
      net/hns3: separate setting redirection table
      net/hns3: separate setting and clearing RSS rule
      net/hns3: separate Tx prepare from getting Tx function
      net/hns3: make getting Tx function static
      net/hns3: fix RSS key size compatibility
      net/hns3: fix burst mode query with dummy function
      net/hns3: extract common functions to set Rx/Tx
      net/hns3: use hardware config to report hash key
      net/hns3: use hardware config to report hash types
      net/hns3: separate setting hash algorithm
      net/hns3: separate setting hash key
      net/hns3: separate setting RSS types
      net/hns3: use new RSS rule to configure hardware
      net/hns3: save hash algo to RSS filter list node
      net/hns3: allow adding queue buffer size hash rule
      net/hns3: separate flow RSS config from RSS conf
      net/hns3: reimplement hash flow function
      net/hns3: add verification of RSS types

Ivan Malov (6):
      net/sfc: export pick transfer proxy callback to representors
      net/sfc: fix MAC address entry leak in transfer flow parsing
      net/sfc: enforce fate action in transfer flow rules
      common/sfc_efx/base: add MAE mark reset action
      net/sfc: fix resetting mark in tunnel offload switch rules
      net/sfc: invalidate switch port entry on representor unplug

Jiawei Wang (1):
      net/mlx5: fix flow sample with ConnectX-5

Jiawen Wu (5):
      net/txgbe: fix default signal quality value for KX/KX4
      net/txgbe: fix packet type to parse from offload flags
      net/ngbe: fix packet type to parse from offload flags
      net/txgbe: fix interrupt loss
      net/txgbe: fix Rx buffer size in config register

Jie Hai (1):
      test/mbuf: fix mbuf reset test

Joyce Kong (1):
      pdump: fix build with GCC 12

Kaiwen Deng (2):
      net/ixgbe: enable IPv6 mask in flow rules
      net/ixgbe: fix IPv6 mask in flow director

Kalesh AP (1):
      net/bnxt: fix Tx queue stats after queue stop and start

Kamalakshitha Aligeri (2):
      net/i40e: fix AVX512 fast-free path
      doc: fix LPM support in l3forward guide

Kevin Traynor (1):
      net/af_xdp: squash deprecated-declaration warnings

Krzysztof Karas (1):
      ethdev: fix build with LTO

Long Wu (1):
      net/nfp: fix getting RSS configuration

Maxime Coquelin (4):
      vhost: decrease log level for unimplemented requests
      vhost: fix possible FD leaks on truncation
      net/virtio-user: fix device starting failure handling
      vhost: fix possible FD leaks

Megha Ajmera (2):
      examples/qos_sched: fix debug mode
      sched: fix alignment of structs in subport

Michael Baum (6):
      compressdev: fix end of driver list
      app/compress-perf: fix some typos
      app/compress-perf: fix testing single operation
      compress/mlx5: fix decompress xform validation
      compress/mlx5: fix output Adler-32 checksum offset
      compress/mlx5: fix queue setup for partial transformations

Michal Schmidt (1):
      net/iavf: fix VLAN offload with AVX2

Mike Baucom (1):
      net/bnxt: fix Rx queue stats after queue stop and start

Mike Pattrick (1):
      net/iavf: add lock for VF commands

Mohammad Iqbal Ahmad (1):
      app/flow-perf: fix division or module by zero

Naga Harish K S V (1):
      eventdev/eth_tx: fix devices loop

Nithin Dabilpuram (1):
      common/cnxk: add memory clobber to steor and ldeor

Pavan Nikhilesh (2):
      event/cnxk: fix burst timer arm
      event/cnxk: fix timer operations in secondary process

Pavel Ivashchenko (1):
      test/mbuf: fix test with mbuf debug enabled

Peng Zhang (2):
      net/nfp: fix firmware name derived from PCI name
      net/nfp: fix MTU configuration order

Qiming Yang (1):
      net/i40e: reduce interrupt interval in multi-driver mode

Rahul Bhansali (1):
      event/cnxk: wait for CPT flow control on WQE path

Rakesh Kudurumalla (1):
      net/cnxk: fix LBK BPID usage

Saoirse O'Donovan (1):
      test/crypto: fix statistics error messages

Satheesh Paul (1):
      common/cnxk: fix dual VLAN parsing

Shiyang He (2):
      net/ixgbe: fix firmware version consistency
      app/testpmd: fix secondary process packet forwarding

Stephen Hemminger (2):
      cmdline: make rdline status not private
      cmdline: handle EOF as quit

Steve Yang (2):
      net/i40e: fix validation of flow transfer attribute
      net/ice: fix validation of flow transfer attribute

Thomas Monjalon (7):
      doc: fix dependency setup in l2fwd-cat example guide
      devtools: fix escaped space in grep pattern
      doc: fix description of L2TPV2 flow item
      build: fix dependencies lookup
      eal/windows: fix pedantic build
      doc: add gpudev to the Doxygen index
      net/mlx5: fix Windows build with MinGW GCC 12

Venkat Duvvuru (1):
      net/bnxt: fix RSS hash in mbuf

Vikash Poddar (1):
      test/crypto: fix typo in AES test

Visa Hankala (1):
      net/e1000: fix saving of stripped VLAN TCI

Volodymyr Fialko (5):
      test/crypto: add missing MAC-I to PDCP vectors
      reorder: invalidate buffer from ready queue in drain
      test/reorder: fix double free of drained buffers
      event/cnxk: fix SSO cleanup
      reorder: fix sequence number mbuf field register

Wei Huang (3):
      bus/ifpga: fix devargs handling
      net/ipn3ke: fix thread exit
      net/ipn3ke: fix representor name

Wenjing Qiao (1):
      net/i40e: fix MAC loopback on X722

Wenwu Ma (1):
      vhost: fix net header settings in datapath

Yangchao Zhou (1):
      kni: fix possible starvation when mbufs are exhausted

Yogesh Jangra (1):
      table: fix action selector group size log2 setting

Zhichao Zeng (2):
      net/iavf: fix building data desc
      net/iavf: fix device stop during reset

Zhuobin Huang (1):
      test: fix segment length in packet generator


^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: 21.11.4 patches review and test
  2023-04-06 11:37 21.11.4 patches review and test Kevin Traynor
@ 2023-04-13  6:12 ` Xu, HailinX
  2023-04-19 11:00   ` YangHang Liu
  2023-04-20  2:40   ` Xu, HailinX
  2023-04-19 13:24 ` Ali Alnubani
  1 sibling, 2 replies; 15+ messages in thread
From: Xu, HailinX @ 2023-04-13  6:12 UTC (permalink / raw)
  To: Kevin Traynor, stable
  Cc: dev, Abhishek Marathe, Ali Alnubani, Walker,  Benjamin,
	David Christensen, Hemant Agrawal, Stokes, Ian, Jerin Jacob,
	Mcnamara, John, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Xu,
	Qian Q, Raslan Darawsheh, Thomas Monjalon, yanghliu, Peng, Yuan,
	Chen, Zhaoyan

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Thursday, April 6, 2023 7:38 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
> <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian
> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin
> Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei
> Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan
> Darawsheh <rasland@nvidia.com>; Thomas Monjalon
> <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: 21.11.4 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 21.11.4.
> 
> The planned date for the final release is 25th April.
> 
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes and
> reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
> 
> These patches are located at branch 21.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Kevin

HI All,

Update the test status for Intel part. Till now dpdk21.11.4-rc1 validation test rate is 85%. No critical issue is found.
2 new bugs are found, 1 new issue is under confirming by Intel Dev.
New bugs:   --20.11.8-rc1 also has these two issues
  1. pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac: performance drop about 23.5% when send small packets 
	https://bugs.dpdk.org/show_bug.cgi?id=1212    -- no fix yet
  2. some of the virtio tests are failing:    -- Intel dev is under investigating
# Basic Intel(R) NIC testing
* Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as
  Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4, FreeBSD13.1, SUSE15, CentOS7.9, etc.
- All test done. No new dpdk issue is found.
* PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. 
- All test done. No new dpdk issue is found.
* VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.		
- All test done. No new dpdk issue is found.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
- All test done. No new dpdk issue is found.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
- All test done. No new dpdk issue is found.
* IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
- On going.
		
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
- All test done. found bug1.
* Cryptodev: 
  *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
    - Execution rate is 90%. found bug2.
  *Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc.
    - All test done. No new dpdk issue is found.

Regards,
Xu, Hailin


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: 21.11.4 patches review and test
  2023-04-13  6:12 ` Xu, HailinX
@ 2023-04-19 11:00   ` YangHang Liu
  2023-04-19 14:21     ` Kevin Traynor
  2023-04-20  2:40   ` Xu, HailinX
  1 sibling, 1 reply; 15+ messages in thread
From: YangHang Liu @ 2023-04-19 11:00 UTC (permalink / raw)
  To: Xu, HailinX
  Cc: Kevin Traynor, stable, dev, Abhishek Marathe, Ali Alnubani,
	Walker, Benjamin, David Christensen, Hemant Agrawal, Stokes, Ian,
	Jerin Jacob, Mcnamara, John, Ju-Hyoung Lee, Luca Boccassi,
	Pei Zhang, Xu, Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng,
	Yuan, Chen, Zhaoyan, Chao Yang

[-- Attachment #1: Type: text/plain, Size: 5673 bytes --]

Hi, Kevin

RedHat QE does not find new issues about the v21.11.4-rc1 dpdk during the
tests.

We tested below 18 scenarios and all got PASS on RHEL9:

   - Guest with device assignment(PF) throughput testing(1G hugepage size):
   PASS
   - Guest with device assignment(PF) throughput testing(2M hugepage size)
   : PASS
   - Guest with device assignment(VF) throughput testing: PASS
   - PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
   - PVP vhost-user 2Q throughput testing: PASS
   - PVP vhost-user 1Q - cross numa node throughput testing: PASS
   - Guest with vhost-user 2 queues throughput testing: PASS
   - vhost-user reconnect with dpdk-client, qemu-server qemu reconnect: PASS
   - vhost-user reconnect with dpdk-client, qemu-server ovs reconnect: PASS
   - PVP  reconnect with dpdk-client, qemu-server: PASS
   - PVP 1Q live migration testing: PASS
   - PVP 1Q cross numa node live migration testing: PASS
   - Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
   - Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
   - Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
   - Guest with ovs+dpdk+vhost-user 4Q live migration testing: PASS
   - Host PF + DPDK testing: PASS
   - Host VF + DPDK testing: PASS

Test Versions:

   - qemu-kvm-6.2.0
   - kernel 5.14
   - dpdk 21.11.4-rc1

git log -1

commit f7dce59377b34750fdda7d1780d527233c84663f

Author: Kevin Traynor <ktraynor@redhat.com>

Date: Thu Apr 6 09:11:25 2023 +0100

version: 21.11.4-rc1

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>


   - Test device : X540-AT2 NIC(ixgbe, 10G)

Best Regards,
YangHang Liu

On Thu, Apr 13, 2023 at 2:13 PM Xu, HailinX <hailinx.xu@intel.com> wrote:

> > -----Original Message-----
> > From: Kevin Traynor <ktraynor@redhat.com>
> > Sent: Thursday, April 6, 2023 7:38 PM
> > To: stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> > Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
> > <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>;
> > Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian
> > <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
> > <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin
> > Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei
> > Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan
> > Darawsheh <rasland@nvidia.com>; Thomas Monjalon
> > <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
> > <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > Subject: 21.11.4 patches review and test
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 21.11.4.
> >
> > The planned date for the final release is 25th April.
> >
> > Please help with testing and validation of your use cases and report any
> > issues/results with reply-all to this mail. For the final release the
> fixes and
> > reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> >     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
> >
> > These patches are located at branch 21.11 of dpdk-stable repo:
> >     https://dpdk.org/browse/dpdk-stable/
> >
> > Thanks.
> >
> > Kevin
>
> HI All,
>
> Update the test status for Intel part. Till now dpdk21.11.4-rc1 validation
> test rate is 85%. No critical issue is found.
> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
> New bugs:   --20.11.8-rc1 also has these two issues
>   1. pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
> performance drop about 23.5% when send small packets
>         https://bugs.dpdk.org/show_bug.cgi?id=1212    -- no fix yet
>   2. some of the virtio tests are failing:    -- Intel dev is under
> investigating
> # Basic Intel(R) NIC testing
> * Build & CFLAG compile: cover the build test combination with latest
> GCC/Clang version and the popular OS revision such as
>   Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4,
> FreeBSD13.1, SUSE15, CentOS7.9, etc.
> - All test done. No new dpdk issue is found.
> * PF(i40e, ixgbe): test scenarios including
> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> - All test done. No new dpdk issue is found.
> * VF(i40e, ixgbe): test scenarios including
> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> - All test done. No new dpdk issue is found.
> * PF/VF(ice): test scenarios including Switch features/Package
> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
> Descriptor, etc.
> - All test done. No new dpdk issue is found.
> * Intel NIC single core/NIC performance: test scenarios including PF/VF
> single core performance test, etc.
> - All test done. No new dpdk issue is found.
> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test
> - QAT&SW/FIB library, etc.
> - On going.
>
> # Basic cryptodev and virtio testing
> * Virtio: both function and performance test are covered. Such as
> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
> testing/VMAWARE ESXI 8.0, etc.
> - All test done. found bug1.
> * Cryptodev:
>   *Function test: test scenarios including Cryptodev API
> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>     - Execution rate is 90%. found bug2.
>   *Performance test: test scenarios including Thoughput
> Performance/Cryptodev Latency, etc.
>     - All test done. No new dpdk issue is found.
>
> Regards,
> Xu, Hailin
>
>

[-- Attachment #2: Type: text/html, Size: 11192 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: 21.11.4 patches review and test
  2023-04-06 11:37 21.11.4 patches review and test Kevin Traynor
  2023-04-13  6:12 ` Xu, HailinX
@ 2023-04-19 13:24 ` Ali Alnubani
  2023-04-19 14:21   ` Kevin Traynor
  1 sibling, 1 reply; 15+ messages in thread
From: Ali Alnubani @ 2023-04-19 13:24 UTC (permalink / raw)
  To: Kevin Traynor, stable
  Cc: dev, Abhishek Marathe, benjamin.walker, David Christensen,
	Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
	Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, qian.q.xu,
	Raslan Darawsheh, NBU-Contact-Thomas Monjalon (EXTERNAL),
	yanghliu, yuan.peng, zhaoyan.chen

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Thursday, April 6, 2023 2:38 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Ali Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; David
> Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin
> Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>;
> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
> <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; yanghliu@redhat.com; yuan.peng@intel.com;
> zhaoyan.chen@intel.com
> Subject: 21.11.4 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 21.11.4.
> 
> The planned date for the final release is 25th April.
> 
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
> 
> These patches are located at branch 21.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Kevin
> 
> ---

We ran the following functional tests with Nvidia hardware on 21.11.4-rc1:
- Basic functionality:
  Send and receive multiple types of traffic.
- testpmd xstats counter test.
- testpmd timestamp test.
- Changing/checking link status through testpmd.
- rte_flow tests.
- Some RSS tests.
- VLAN filtering, stripping and insertion tests.
- Checksum and TSO tests.
- ptype tests.
- link_status_interrupt example application tests.
- l3fwd-power example application tests.
- Multi-process example applications tests.
- Hardware LRO tests.
- Regex application tests.
- Buffer Split tests.
- Tx scheduling tests.

Functional tests ran on:
- NIC: ConnectX-6 Dx / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-5.9-0.5.6.0 / Firmware: 22.36.1010
- NIC: ConnectX-7 / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-5.9-0.5.6.0 / Firmware: 22.36.1010
- DPU: BlueField-2 / DOCA SW version: 1.5.1 / Firmware: 24.35.2000

Additionally, we ran compilation tests with multiple configurations in the following OS/driver combinations:
- Ubuntu 20.04.5 with MLNX_OFED_LINUX-5.9-0.5.6.0.
- Ubuntu 20.04.5 with rdma-core master (f0a079f).
- Ubuntu 20.04.5 with rdma-core v28.0.
- Ubuntu 18.04.6 with rdma-core v17.1.
- Ubuntu 18.04.6 with rdma-core master (f0a079f) (i386).
- Fedora 37 with rdma-core v41.0.
- Fedora 39 (Rawhide) with rdma-core v44.0.
- CentOS 7 7.9.2009 with rdma-core master (f0a079f).
- CentOS 7 7.9.2009 with MLNX_OFED_LINUX-5.9-0.5.6.0.
- CentOS 8 8.4.2105 with rdma-core master (f0a079f).
- OpenSUSE Leap 15.4 with rdma-core v38.1.
- Windows Server 2019 with Clang 11.0.0.

We don't see new issues caused by the changes in this release.

Please note that not all the functional tests mentioned above fall under "Basic functionality with testpmd" like reported in the release notes for previous releases:
https://git.dpdk.org/dpdk-stable/commit/?h=v21.11.3&id=31608e4db56893c896375288671b5ee38723a211
Some of them test other applications.

Thanks,
Ali

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: 21.11.4 patches review and test
  2023-04-19 11:00   ` YangHang Liu
@ 2023-04-19 14:21     ` Kevin Traynor
  0 siblings, 0 replies; 15+ messages in thread
From: Kevin Traynor @ 2023-04-19 14:21 UTC (permalink / raw)
  To: YangHang Liu, Xu, HailinX; +Cc: stable

On 19/04/2023 12:00, YangHang Liu wrote:
> Hi, Kevin
> 
> RedHat QE does not find new issues about the v21.11.4-rc1 dpdk during the
> tests.
> 

Hi YangHang, thanks for testing and the report.
Kevin.


> We tested below 18 scenarios and all got PASS on RHEL9:
> 
>     - Guest with device assignment(PF) throughput testing(1G hugepage size):
>     PASS
>     - Guest with device assignment(PF) throughput testing(2M hugepage size)
>     : PASS
>     - Guest with device assignment(VF) throughput testing: PASS
>     - PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
>     - PVP vhost-user 2Q throughput testing: PASS
>     - PVP vhost-user 1Q - cross numa node throughput testing: PASS
>     - Guest with vhost-user 2 queues throughput testing: PASS
>     - vhost-user reconnect with dpdk-client, qemu-server qemu reconnect: PASS
>     - vhost-user reconnect with dpdk-client, qemu-server ovs reconnect: PASS
>     - PVP  reconnect with dpdk-client, qemu-server: PASS
>     - PVP 1Q live migration testing: PASS
>     - PVP 1Q cross numa node live migration testing: PASS
>     - Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
>     - Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
>     - Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
>     - Guest with ovs+dpdk+vhost-user 4Q live migration testing: PASS
>     - Host PF + DPDK testing: PASS
>     - Host VF + DPDK testing: PASS
> 
> Test Versions:
> 
>     - qemu-kvm-6.2.0
>     - kernel 5.14
>     - dpdk 21.11.4-rc1
> 
> git log -1
> 
> commit f7dce59377b34750fdda7d1780d527233c84663f
> 
> Author: Kevin Traynor <ktraynor@redhat.com>
> 
> Date: Thu Apr 6 09:11:25 2023 +0100
> 
> version: 21.11.4-rc1
> 
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> 
> 
>     - Test device : X540-AT2 NIC(ixgbe, 10G)
> 
> Best Regards,
> YangHang Liu
> 
> On Thu, Apr 13, 2023 at 2:13 PM Xu, HailinX <hailinx.xu@intel.com> wrote:
> 
>>> -----Original Message-----
>>> From: Kevin Traynor <ktraynor@redhat.com>
>>> Sent: Thursday, April 6, 2023 7:38 PM
>>> To: stable@dpdk.org
>>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>>> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
>>> <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>;
>>> Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian
>>> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
>>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin
>>> Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei
>>> Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan
>>> Darawsheh <rasland@nvidia.com>; Thomas Monjalon
>>> <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>>> Subject: 21.11.4 patches review and test
>>>
>>> Hi all,
>>>
>>> Here is a list of patches targeted for stable release 21.11.4.
>>>
>>> The planned date for the final release is 25th April.
>>>
>>> Please help with testing and validation of your use cases and report any
>>> issues/results with reply-all to this mail. For the final release the
>> fixes and
>>> reported validations will be added to the release notes.
>>>
>>> A release candidate tarball can be found at:
>>>
>>>      https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
>>>
>>> These patches are located at branch 21.11 of dpdk-stable repo:
>>>      https://dpdk.org/browse/dpdk-stable/
>>>
>>> Thanks.
>>>
>>> Kevin
>>
>> HI All,
>>
>> Update the test status for Intel part. Till now dpdk21.11.4-rc1 validation
>> test rate is 85%. No critical issue is found.
>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
>> New bugs:   --20.11.8-rc1 also has these two issues
>>    1. pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
>> performance drop about 23.5% when send small packets
>>          https://bugs.dpdk.org/show_bug.cgi?id=1212    -- no fix yet
>>    2. some of the virtio tests are failing:    -- Intel dev is under
>> investigating
>> # Basic Intel(R) NIC testing
>> * Build & CFLAG compile: cover the build test combination with latest
>> GCC/Clang version and the popular OS revision such as
>>    Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4,
>> FreeBSD13.1, SUSE15, CentOS7.9, etc.
>> - All test done. No new dpdk issue is found.
>> * PF(i40e, ixgbe): test scenarios including
>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>> - All test done. No new dpdk issue is found.
>> * VF(i40e, ixgbe): test scenarios including
>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>> - All test done. No new dpdk issue is found.
>> * PF/VF(ice): test scenarios including Switch features/Package
>> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
>> Descriptor, etc.
>> - All test done. No new dpdk issue is found.
>> * Intel NIC single core/NIC performance: test scenarios including PF/VF
>> single core performance test, etc.
>> - All test done. No new dpdk issue is found.
>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test
>> - QAT&SW/FIB library, etc.
>> - On going.
>>
>> # Basic cryptodev and virtio testing
>> * Virtio: both function and performance test are covered. Such as
>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
>> testing/VMAWARE ESXI 8.0, etc.
>> - All test done. found bug1.
>> * Cryptodev:
>>    *Function test: test scenarios including Cryptodev API
>> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>>      - Execution rate is 90%. found bug2.
>>    *Performance test: test scenarios including Thoughput
>> Performance/Cryptodev Latency, etc.
>>      - All test done. No new dpdk issue is found.
>>
>> Regards,
>> Xu, Hailin
>>
>>
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: 21.11.4 patches review and test
  2023-04-19 13:24 ` Ali Alnubani
@ 2023-04-19 14:21   ` Kevin Traynor
  0 siblings, 0 replies; 15+ messages in thread
From: Kevin Traynor @ 2023-04-19 14:21 UTC (permalink / raw)
  To: Ali Alnubani, stable; +Cc: dev

On 19/04/2023 14:24, Ali Alnubani wrote:
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Thursday, April 6, 2023 2:38 PM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Ali Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; David
>> Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
>> <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin
>> Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>;
>> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
>> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
>> <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
>> <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
>> <thomas@monjalon.net>; yanghliu@redhat.com; yuan.peng@intel.com;
>> zhaoyan.chen@intel.com
>> Subject: 21.11.4 patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for stable release 21.11.4.
>>
>> The planned date for the final release is 25th April.
>>
>> Please help with testing and validation of your use cases and report
>> any issues/results with reply-all to this mail. For the final release
>> the fixes and reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>      https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
>>
>> These patches are located at branch 21.11 of dpdk-stable repo:
>>      https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks.
>>
>> Kevin
>>
>> ---
> 
> We ran the following functional tests with Nvidia hardware on 21.11.4-rc1:
> - Basic functionality:
>    Send and receive multiple types of traffic.
> - testpmd xstats counter test.
> - testpmd timestamp test.
> - Changing/checking link status through testpmd.
> - rte_flow tests.
> - Some RSS tests.
> - VLAN filtering, stripping and insertion tests.
> - Checksum and TSO tests.
> - ptype tests.
> - link_status_interrupt example application tests.
> - l3fwd-power example application tests.
> - Multi-process example applications tests.
> - Hardware LRO tests.
> - Regex application tests.
> - Buffer Split tests.
> - Tx scheduling tests.
> 
> Functional tests ran on:
> - NIC: ConnectX-6 Dx / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-5.9-0.5.6.0 / Firmware: 22.36.1010
> - NIC: ConnectX-7 / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-5.9-0.5.6.0 / Firmware: 22.36.1010
> - DPU: BlueField-2 / DOCA SW version: 1.5.1 / Firmware: 24.35.2000
> 
> Additionally, we ran compilation tests with multiple configurations in the following OS/driver combinations:
> - Ubuntu 20.04.5 with MLNX_OFED_LINUX-5.9-0.5.6.0.
> - Ubuntu 20.04.5 with rdma-core master (f0a079f).
> - Ubuntu 20.04.5 with rdma-core v28.0.
> - Ubuntu 18.04.6 with rdma-core v17.1.
> - Ubuntu 18.04.6 with rdma-core master (f0a079f) (i386).
> - Fedora 37 with rdma-core v41.0.
> - Fedora 39 (Rawhide) with rdma-core v44.0.
> - CentOS 7 7.9.2009 with rdma-core master (f0a079f).
> - CentOS 7 7.9.2009 with MLNX_OFED_LINUX-5.9-0.5.6.0.
> - CentOS 8 8.4.2105 with rdma-core master (f0a079f).
> - OpenSUSE Leap 15.4 with rdma-core v38.1.
> - Windows Server 2019 with Clang 11.0.0.
> 
> We don't see new issues caused by the changes in this release.
> 

Great, thanks for testing and reporting Ali.
Kevin.

> Please note that not all the functional tests mentioned above fall under "Basic functionality with testpmd" like reported in the release notes for previous releases:
> https://git.dpdk.org/dpdk-stable/commit/?h=v21.11.3&id=31608e4db56893c896375288671b5ee38723a211
> Some of them test other applications.
> 
> Thanks,
> Ali


^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: 21.11.4 patches review and test
  2023-04-13  6:12 ` Xu, HailinX
  2023-04-19 11:00   ` YangHang Liu
@ 2023-04-20  2:40   ` Xu, HailinX
  2023-04-20 10:32     ` Kevin Traynor
  1 sibling, 1 reply; 15+ messages in thread
From: Xu, HailinX @ 2023-04-20  2:40 UTC (permalink / raw)
  To: Kevin Traynor, stable
  Cc: dev, Abhishek Marathe, Ali Alnubani, Walker,  Benjamin,
	David Christensen, Hemant Agrawal, Stokes, Ian, Jerin Jacob,
	Mcnamara, John, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Xu,
	Qian Q, Raslan Darawsheh, Thomas Monjalon, yanghliu, Peng, Yuan,
	Chen, Zhaoyan

> -----Original Message-----
> From: Xu, HailinX <hailinx.xu@intel.com>
> Sent: Thursday, April 13, 2023 2:13 PM
> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
> <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian
> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca
> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q
> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: RE: 21.11.4 patches review and test
> 
> > -----Original Message-----
> > From: Kevin Traynor <ktraynor@redhat.com>
> > Sent: Thursday, April 6, 2023 7:38 PM
> > To: stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> > Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
> > <benjamin.walker@intel.com>; David Christensen
> > <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> > Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> > Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> > <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
> > Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian
> > Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
> Thomas
> > Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
> > <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > Subject: 21.11.4 patches review and test
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 21.11.4.
> >
> > The planned date for the final release is 25th April.
> >
> > Please help with testing and validation of your use cases and report
> > any issues/results with reply-all to this mail. For the final release
> > the fixes and reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> >     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
> >
> > These patches are located at branch 21.11 of dpdk-stable repo:
> >     https://dpdk.org/browse/dpdk-stable/
> >
> > Thanks.
> >
> > Kevin
> 
> HI All,
> 
> Update the test status for Intel part. Till now dpdk21.11.4-rc1 validation test
> rate is 85%. No critical issue is found.
> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
> New bugs:   --20.11.8-rc1 also has these two issues
>   1. pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
> performance drop about 23.5% when send small packets
> 	https://bugs.dpdk.org/show_bug.cgi?id=1212    -- no fix yet
>   2. some of the virtio tests are failing:    -- Intel dev is under investigating
> # Basic Intel(R) NIC testing
> * Build & CFLAG compile: cover the build test combination with latest
> GCC/Clang version and the popular OS revision such as
>   Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4,
> FreeBSD13.1, SUSE15, CentOS7.9, etc.
> - All test done. No new dpdk issue is found.
> * PF(i40e, ixgbe): test scenarios including
> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> - All test done. No new dpdk issue is found.
> * VF(i40e, ixgbe): test scenarios including
> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> - All test done. No new dpdk issue is found.
> * PF/VF(ice): test scenarios including Switch features/Package
> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
> Descriptor, etc.
> - All test done. No new dpdk issue is found.
> * Intel NIC single core/NIC performance: test scenarios including PF/VF single
> core performance test, etc.
> - All test done. No new dpdk issue is found.
> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
> QAT&SW/FIB library, etc.
> - On going.
> 
> # Basic cryptodev and virtio testing
> * Virtio: both function and performance test are covered. Such as
> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
> testing/VMAWARE ESXI 8.0, etc.
> - All test done. found bug1.
> * Cryptodev:
>   *Function test: test scenarios including Cryptodev API testing/CompressDev
> ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>     - Execution rate is 90%. found bug2.
>   *Performance test: test scenarios including Thoughput
> Performance/Cryptodev Latency, etc.
>     - All test done. No new dpdk issue is found.
> 
> Regards,
> Xu, Hailin
Update the test status for Intel part. completed dpdk21.11.4-rc1 all validation. No critical issue is found.
2 new bugs are found, 1 new issue is under confirming by Intel Dev.
New bugs: --20.11.8-rc1 also has these two issues
  1. pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac: performance drop about 23.5% when send small packets 
	https://bugs.dpdk.org/show_bug.cgi?id=1212  --not fix yet, Only the specified platform exists
  2. some of the virtio tests are failing: -- Intel dev is under investigating
# Basic Intel(R) NIC testing
* Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as
  Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4, FreeBSD13.1, SUSE15, CentOS7.9, etc.
- All test done. No new dpdk issue is found.
* PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. 
- All test done. No new dpdk issue is found.
* VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.		
- All test done. No new dpdk issue is found.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
- All test done. No new dpdk issue is found.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
- All test done. No new dpdk issue is found.
* IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
- All test done. No new dpdk issue is found.
		
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
- All test done. found bug1.
* Cryptodev: 
  *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
    - All test done. found bug2.
  *Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc.
    - All test done. No new dpdk issue is found.

Regards,
Xu, Hailin

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: 21.11.4 patches review and test
  2023-04-20  2:40   ` Xu, HailinX
@ 2023-04-20 10:32     ` Kevin Traynor
  2023-05-02  9:35       ` Kevin Traynor
  0 siblings, 1 reply; 15+ messages in thread
From: Kevin Traynor @ 2023-04-20 10:32 UTC (permalink / raw)
  To: Xu, HailinX, stable
  Cc: dev, Abhishek Marathe, Ali Alnubani, Walker, Benjamin,
	David Christensen, Hemant Agrawal, Stokes, Ian, Jerin Jacob,
	Mcnamara, John, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Xu,
	Qian Q, Raslan Darawsheh, Thomas Monjalon, yanghliu, Peng, Yuan,
	Chen, Zhaoyan

On 20/04/2023 03:40, Xu, HailinX wrote:
>> -----Original Message-----
>> From: Xu, HailinX <hailinx.xu@intel.com>
>> Sent: Thursday, April 13, 2023 2:13 PM
>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
>> <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>;
>> Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian
>> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca
>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q
>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>> Subject: RE: 21.11.4 patches review and test
>>
>>> -----Original Message-----
>>> From: Kevin Traynor <ktraynor@redhat.com>
>>> Sent: Thursday, April 6, 2023 7:38 PM
>>> To: stable@dpdk.org
>>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>>> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
>>> <benjamin.walker@intel.com>; David Christensen
>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
>>> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
>>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
>>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian
>>> Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
>> Thomas
>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>>> Subject: 21.11.4 patches review and test
>>>
>>> Hi all,
>>>
>>> Here is a list of patches targeted for stable release 21.11.4.
>>>
>>> The planned date for the final release is 25th April.
>>>
>>> Please help with testing and validation of your use cases and report
>>> any issues/results with reply-all to this mail. For the final release
>>> the fixes and reported validations will be added to the release notes.
>>>
>>> A release candidate tarball can be found at:
>>>
>>>      https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
>>>
>>> These patches are located at branch 21.11 of dpdk-stable repo:
>>>      https://dpdk.org/browse/dpdk-stable/
>>>
>>> Thanks.
>>>
>>> Kevin
>>
>> HI All,
>>
>> Update the test status for Intel part. Till now dpdk21.11.4-rc1 validation test
>> rate is 85%. No critical issue is found.
>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
>> New bugs:   --20.11.8-rc1 also has these two issues
>>    1. pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
>> performance drop about 23.5% when send small packets
>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212    -- no fix yet
>>    2. some of the virtio tests are failing:    -- Intel dev is under investigating
>> # Basic Intel(R) NIC testing
>> * Build & CFLAG compile: cover the build test combination with latest
>> GCC/Clang version and the popular OS revision such as
>>    Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4,
>> FreeBSD13.1, SUSE15, CentOS7.9, etc.
>> - All test done. No new dpdk issue is found.
>> * PF(i40e, ixgbe): test scenarios including
>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>> - All test done. No new dpdk issue is found.
>> * VF(i40e, ixgbe): test scenarios including
>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>> - All test done. No new dpdk issue is found.
>> * PF/VF(ice): test scenarios including Switch features/Package
>> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
>> Descriptor, etc.
>> - All test done. No new dpdk issue is found.
>> * Intel NIC single core/NIC performance: test scenarios including PF/VF single
>> core performance test, etc.
>> - All test done. No new dpdk issue is found.
>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
>> QAT&SW/FIB library, etc.
>> - On going.
>>
>> # Basic cryptodev and virtio testing
>> * Virtio: both function and performance test are covered. Such as
>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
>> testing/VMAWARE ESXI 8.0, etc.
>> - All test done. found bug1.
>> * Cryptodev:
>>    *Function test: test scenarios including Cryptodev API testing/CompressDev
>> ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>>      - Execution rate is 90%. found bug2.
>>    *Performance test: test scenarios including Thoughput
>> Performance/Cryptodev Latency, etc.
>>      - All test done. No new dpdk issue is found.
>>
>> Regards,
>> Xu, Hailin
> Update the test status for Intel part. completed dpdk21.11.4-rc1 all validation. No critical issue is found.

Hi. Thanks for testing.

> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
> New bugs: --20.11.8-rc1 also has these two issues
>    1. pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac: performance drop about 23.5% when send small packets
> 	https://bugs.dpdk.org/show_bug.cgi?id=1212  --not fix yet, Only the specified platform exists

Do you know which patch caaused the regression? I'm not fully clear from 
the Bz for 20.11. The backported patch ID'd as root cause [0] in 20.11 
is in the previous releases of 20.11 (and 21.11).

Trying to understand because then it would have shown in testing for 
previous releases. Or is this a new test introduced for latest LTS 
releases? and if so, what is the baseline performance based on?

[0]
commit 1c9a7fba5c90e0422b517404499ed106f647bcff
Author: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Date:   Mon Jul 11 14:11:32 2022 +0200

     net: accept unaligned data in checksum routines

>    2. some of the virtio tests are failing: -- Intel dev is under investigating

ok, thank you.

Kevin.

> # Basic Intel(R) NIC testing
> * Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as
>    Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4, FreeBSD13.1, SUSE15, CentOS7.9, etc.
> - All test done. No new dpdk issue is found.
> * PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> - All test done. No new dpdk issue is found.
> * VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.		
> - All test done. No new dpdk issue is found.
> * PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
> - All test done. No new dpdk issue is found.
> * Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
> - All test done. No new dpdk issue is found.
> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
> - All test done. No new dpdk issue is found.
> 		
> # Basic cryptodev and virtio testing
> * Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
> - All test done. found bug1.
> * Cryptodev:
>    *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>      - All test done. found bug2.
>    *Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc.
>      - All test done. No new dpdk issue is found.
> 
> Regards,
> Xu, Hailin
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: 21.11.4 patches review and test
  2023-04-20 10:32     ` Kevin Traynor
@ 2023-05-02  9:35       ` Kevin Traynor
  2023-05-04  2:13         ` Xu, HailinX
  0 siblings, 1 reply; 15+ messages in thread
From: Kevin Traynor @ 2023-05-02  9:35 UTC (permalink / raw)
  To: Xu, HailinX, stable
  Cc: Stokes, Ian, Mcnamara, John, Luca Boccassi, Xu, Qian Q,
	Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan, dev

On 20/04/2023 11:32, Kevin Traynor wrote:
> On 20/04/2023 03:40, Xu, HailinX wrote:
>>> -----Original Message-----
>>> From: Xu, HailinX <hailinx.xu@intel.com>
>>> Sent: Thursday, April 13, 2023 2:13 PM
>>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
>>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>>> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
>>> <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>;
>>> Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian
>>> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
>>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca
>>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q
>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>>> Subject: RE: 21.11.4 patches review and test
>>>
>>>> -----Original Message-----
>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>> Sent: Thursday, April 6, 2023 7:38 PM
>>>> To: stable@dpdk.org
>>>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>>>> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
>>>> <benjamin.walker@intel.com>; David Christensen
>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>>>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
>>>> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
>>>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
>>>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian
>>>> Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
>>> Thomas
>>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
>>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>>>> Subject: 21.11.4 patches review and test
>>>>
>>>> Hi all,
>>>>
>>>> Here is a list of patches targeted for stable release 21.11.4.
>>>>
>>>> The planned date for the final release is 25th April.
>>>>
>>>> Please help with testing and validation of your use cases and report
>>>> any issues/results with reply-all to this mail. For the final release
>>>> the fixes and reported validations will be added to the release notes.
>>>>
>>>> A release candidate tarball can be found at:
>>>>
>>>>       https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
>>>>
>>>> These patches are located at branch 21.11 of dpdk-stable repo:
>>>>       https://dpdk.org/browse/dpdk-stable/
>>>>
>>>> Thanks.
>>>>
>>>> Kevin
>>>
>>> HI All,
>>>
>>> Update the test status for Intel part. Till now dpdk21.11.4-rc1 validation test
>>> rate is 85%. No critical issue is found.
>>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
>>> New bugs:   --20.11.8-rc1 also has these two issues
>>>     1. pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
>>> performance drop about 23.5% when send small packets
>>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212    -- no fix yet
>>>     2. some of the virtio tests are failing:    -- Intel dev is under investigating
>>> # Basic Intel(R) NIC testing
>>> * Build & CFLAG compile: cover the build test combination with latest
>>> GCC/Clang version and the popular OS revision such as
>>>     Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4,
>>> FreeBSD13.1, SUSE15, CentOS7.9, etc.
>>> - All test done. No new dpdk issue is found.
>>> * PF(i40e, ixgbe): test scenarios including
>>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>> - All test done. No new dpdk issue is found.
>>> * VF(i40e, ixgbe): test scenarios including
>>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>> - All test done. No new dpdk issue is found.
>>> * PF/VF(ice): test scenarios including Switch features/Package
>>> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
>>> Descriptor, etc.
>>> - All test done. No new dpdk issue is found.
>>> * Intel NIC single core/NIC performance: test scenarios including PF/VF single
>>> core performance test, etc.
>>> - All test done. No new dpdk issue is found.
>>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
>>> QAT&SW/FIB library, etc.
>>> - On going.
>>>
>>> # Basic cryptodev and virtio testing
>>> * Virtio: both function and performance test are covered. Such as
>>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
>>> testing/VMAWARE ESXI 8.0, etc.
>>> - All test done. found bug1.
>>> * Cryptodev:
>>>     *Function test: test scenarios including Cryptodev API testing/CompressDev
>>> ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>>>       - Execution rate is 90%. found bug2.
>>>     *Performance test: test scenarios including Thoughput
>>> Performance/Cryptodev Latency, etc.
>>>       - All test done. No new dpdk issue is found.
>>>
>>> Regards,
>>> Xu, Hailin
>> Update the test status for Intel part. completed dpdk21.11.4-rc1 all validation. No critical issue is found.
> 
> Hi. Thanks for testing.
> 
>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
>> New bugs: --20.11.8-rc1 also has these two issues
>>     1. pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac: performance drop about 23.5% when send small packets
>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212  --not fix yet, Only the specified platform exists
> 
> Do you know which patch caaused the regression? I'm not fully clear from
> the Bz for 20.11. The backported patch ID'd as root cause [0] in 20.11
> is in the previous releases of 20.11 (and 21.11).
> 
> Trying to understand because then it would have shown in testing for
> previous releases. Or is this a new test introduced for latest LTS
> releases? and if so, what is the baseline performance based on?
> 
> [0]
> commit 1c9a7fba5c90e0422b517404499ed106f647bcff
> Author: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Date:   Mon Jul 11 14:11:32 2022 +0200
> 
>       net: accept unaligned data in checksum routines
> 
>>     2. some of the virtio tests are failing: -- Intel dev is under investigating
> 
> ok, thank you.
> 

Hi, it was mentioned in a separate mail that the performance drop issue 
was not the same as 20.11.

Is there any update on that and the failing virtio tests ? Is there a 
regression introduced since in 21.11.4 ?

thanks,
Kevin,

> Kevin.
> 
>> # Basic Intel(R) NIC testing
>> * Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as
>>     Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4, FreeBSD13.1, SUSE15, CentOS7.9, etc.
>> - All test done. No new dpdk issue is found.
>> * PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>> - All test done. No new dpdk issue is found.
>> * VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.		
>> - All test done. No new dpdk issue is found.
>> * PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
>> - All test done. No new dpdk issue is found.
>> * Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
>> - All test done. No new dpdk issue is found.
>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
>> - All test done. No new dpdk issue is found.
>> 		
>> # Basic cryptodev and virtio testing
>> * Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
>> - All test done. found bug1.
>> * Cryptodev:
>>     *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>>       - All test done. found bug2.
>>     *Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc.
>>       - All test done. No new dpdk issue is found.
>>
>> Regards,
>> Xu, Hailin
>>
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: 21.11.4 patches review and test
  2023-05-02  9:35       ` Kevin Traynor
@ 2023-05-04  2:13         ` Xu, HailinX
  2023-05-04 10:10           ` Kevin Traynor
  0 siblings, 1 reply; 15+ messages in thread
From: Xu, HailinX @ 2023-05-04  2:13 UTC (permalink / raw)
  To: Kevin Traynor, stable
  Cc: Stokes, Ian, Mcnamara, John, Luca Boccassi, Xu, Qian Q,
	Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan, dev

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Tuesday, May 2, 2023 5:35 PM
> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
> Cc: Stokes, Ian <ian.stokes@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Xu, Qian Q
> <qian.q.xu@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Peng,
> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>;
> dev@dpdk.org
> Subject: Re: 21.11.4 patches review and test
> 
> On 20/04/2023 11:32, Kevin Traynor wrote:
> > On 20/04/2023 03:40, Xu, HailinX wrote:
> >>> -----Original Message-----
> >>> From: Xu, HailinX <hailinx.xu@intel.com>
> >>> Sent: Thursday, April 13, 2023 2:13 PM
> >>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
> >>> Cc: dev@dpdk.org; Abhishek Marathe
> <Abhishek.Marathe@microsoft.com>;
> >>> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
> >>> <benjamin.walker@intel.com>; David Christensen
> >>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>;
> >>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
> >>> <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> >>> Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi
> >>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q
> >>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
> Thomas
> >>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
> >>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> >>> Subject: RE: 21.11.4 patches review and test
> >>>
> >>>> -----Original Message-----
> >>>> From: Kevin Traynor <ktraynor@redhat.com>
> >>>> Sent: Thursday, April 6, 2023 7:38 PM
> >>>> To: stable@dpdk.org
> >>>> Cc: dev@dpdk.org; Abhishek Marathe
> >>>> <Abhishek.Marathe@microsoft.com>; Ali Alnubani
> >>>> <alialnu@nvidia.com>; Walker, Benjamin <benjamin.walker@intel.com>;
> >>>> David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
> >>>> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> >>>> Jacob <jerinj@marvell.com>; Mcnamara, John
> >>>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>;
> >>>> Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi
> >>>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q
> >>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
> >>> Thomas
> >>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
> >>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> >>>> Subject: 21.11.4 patches review and test
> >>>>
> >>>> Hi all,
> >>>>
> >>>> Here is a list of patches targeted for stable release 21.11.4.
> >>>>
> >>>> The planned date for the final release is 25th April.
> >>>>
> >>>> Please help with testing and validation of your use cases and
> >>>> report any issues/results with reply-all to this mail. For the
> >>>> final release the fixes and reported validations will be added to the
> release notes.
> >>>>
> >>>> A release candidate tarball can be found at:
> >>>>
> >>>>       https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
> >>>>
> >>>> These patches are located at branch 21.11 of dpdk-stable repo:
> >>>>       https://dpdk.org/browse/dpdk-stable/
> >>>>
> >>>> Thanks.
> >>>>
> >>>> Kevin
> >>>
> >>> HI All,
> >>>
> >>> Update the test status for Intel part. Till now dpdk21.11.4-rc1
> >>> validation test rate is 85%. No critical issue is found.
> >>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
> >>> New bugs:   --20.11.8-rc1 also has these two issues
> >>>     1.
> pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
> >>> performance drop about 23.5% when send small packets
> >>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212    -- no fix yet
> >>>     2. some of the virtio tests are failing:    -- Intel dev is under
> investigating
> >>> # Basic Intel(R) NIC testing
> >>> * Build & CFLAG compile: cover the build test combination with
> >>> latest GCC/Clang version and the popular OS revision such as
> >>>     Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4,
> >>> FreeBSD13.1, SUSE15, CentOS7.9, etc.
> >>> - All test done. No new dpdk issue is found.
> >>> * PF(i40e, ixgbe): test scenarios including
> >>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >>> - All test done. No new dpdk issue is found.
> >>> * VF(i40e, ixgbe): test scenarios including
> >>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >>> - All test done. No new dpdk issue is found.
> >>> * PF/VF(ice): test scenarios including Switch features/Package
> >>> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
> >>> Descriptor, etc.
> >>> - All test done. No new dpdk issue is found.
> >>> * Intel NIC single core/NIC performance: test scenarios including
> >>> PF/VF single core performance test, etc.
> >>> - All test done. No new dpdk issue is found.
> >>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic
> >>> test - QAT&SW/FIB library, etc.
> >>> - On going.
> >>>
> >>> # Basic cryptodev and virtio testing
> >>> * Virtio: both function and performance test are covered. Such as
> >>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
> >>> testing/VMAWARE ESXI 8.0, etc.
> >>> - All test done. found bug1.
> >>> * Cryptodev:
> >>>     *Function test: test scenarios including Cryptodev API
> >>> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
> >>>       - Execution rate is 90%. found bug2.
> >>>     *Performance test: test scenarios including Thoughput
> >>> Performance/Cryptodev Latency, etc.
> >>>       - All test done. No new dpdk issue is found.
> >>>
> >>> Regards,
> >>> Xu, Hailin
> >> Update the test status for Intel part. completed dpdk21.11.4-rc1 all
> validation. No critical issue is found.
> >
> > Hi. Thanks for testing.
> >
> >> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
> >> New bugs: --20.11.8-rc1 also has these two issues
> >>     1.
> pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
> performance drop about 23.5% when send small packets
> >> 	https://bugs.dpdk.org/show_bug.cgi?id=1212  --not fix yet, Only the
> >> specified platform exists
> >
> > Do you know which patch caaused the regression? I'm not fully clear
> > from the Bz for 20.11. The backported patch ID'd as root cause [0] in
> > 20.11 is in the previous releases of 20.11 (and 21.11).
> >
> > Trying to understand because then it would have shown in testing for
> > previous releases. Or is this a new test introduced for latest LTS
> > releases? and if so, what is the baseline performance based on?
> >
> > [0]
> > commit 1c9a7fba5c90e0422b517404499ed106f647bcff
> > Author: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> > Date:   Mon Jul 11 14:11:32 2022 +0200
> >
> >       net: accept unaligned data in checksum routines
> >
> >>     2. some of the virtio tests are failing: -- Intel dev is under
> >> investigating
> >
> > ok, thank you.
> >
> 
> Hi, it was mentioned in a separate mail that the performance drop issue was
> not the same as 20.11.
> 
> Is there any update on that and the failing virtio tests ? Is there a regression
> introduced since in 21.11.4 ?

Found bad commit id: 
commit c41493361c87e730459ead9311c68528eb0874aa
Author: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
Date:   Fri Mar 3 14:19:29 2023 +0300
    net/virtio: deduce IP length for TSO checksum

We try this issue on 3 different platforms
Performance drop only found on Intel(R) Xeon(R) Platinum 8280M CPU @ 2.70GHz CPU.

Regards,
Xu, Hailin

> 
> thanks,
> Kevin,
> 
> > Kevin.
> >
> >> # Basic Intel(R) NIC testing
> >> * Build & CFLAG compile: cover the build test combination with latest
> GCC/Clang version and the popular OS revision such as
> >>     Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4,
> FreeBSD13.1, SUSE15, CentOS7.9, etc.
> >> - All test done. No new dpdk issue is found.
> >> * PF(i40e, ixgbe): test scenarios including
> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >> - All test done. No new dpdk issue is found.
> >> * VF(i40e, ixgbe): test scenarios including
> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >> - All test done. No new dpdk issue is found.
> >> * PF/VF(ice): test scenarios including Switch features/Package
> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
> Descriptor, etc.
> >> - All test done. No new dpdk issue is found.
> >> * Intel NIC single core/NIC performance: test scenarios including PF/VF
> single core performance test, etc.
> >> - All test done. No new dpdk issue is found.
> >> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
> QAT&SW/FIB library, etc.
> >> - All test done. No new dpdk issue is found.
> >>
> >> # Basic cryptodev and virtio testing
> >> * Virtio: both function and performance test are covered. Such as
> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
> testing/VMAWARE ESXI 8.0, etc.
> >> - All test done. found bug1.
> >> * Cryptodev:
> >>     *Function test: test scenarios including Cryptodev API
> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
> >>       - All test done. found bug2.
> >>     *Performance test: test scenarios including Thoughput
> Performance/Cryptodev Latency, etc.
> >>       - All test done. No new dpdk issue is found.
> >>
> >> Regards,
> >> Xu, Hailin
> >>
> >


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: 21.11.4 patches review and test
  2023-05-04  2:13         ` Xu, HailinX
@ 2023-05-04 10:10           ` Kevin Traynor
  2023-05-05  1:42             ` Xu, HailinX
  0 siblings, 1 reply; 15+ messages in thread
From: Kevin Traynor @ 2023-05-04 10:10 UTC (permalink / raw)
  To: Xu, HailinX, stable
  Cc: Stokes, Ian, Mcnamara, John, Luca Boccassi, Xu, Qian Q,
	Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan, dev

On 04/05/2023 03:13, Xu, HailinX wrote:
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Tuesday, May 2, 2023 5:35 PM
>> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
>> Cc: Stokes, Ian <ian.stokes@intel.com>; Mcnamara, John
>> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Xu, Qian Q
>> <qian.q.xu@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Peng,
>> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>;
>> dev@dpdk.org
>> Subject: Re: 21.11.4 patches review and test
>>
>> On 20/04/2023 11:32, Kevin Traynor wrote:
>>> On 20/04/2023 03:40, Xu, HailinX wrote:
>>>>> -----Original Message-----
>>>>> From: Xu, HailinX <hailinx.xu@intel.com>
>>>>> Sent: Thursday, April 13, 2023 2:13 PM
>>>>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
>>>>> Cc: dev@dpdk.org; Abhishek Marathe
>> <Abhishek.Marathe@microsoft.com>;
>>>>> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
>>>>> <benjamin.walker@intel.com>; David Christensen
>>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
>> <hemant.agrawal@nxp.com>;
>>>>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
>>>>> <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
>>>>> Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi
>>>>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q
>>>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
>> Thomas
>>>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
>>>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>>>>> Subject: RE: 21.11.4 patches review and test
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>>>> Sent: Thursday, April 6, 2023 7:38 PM
>>>>>> To: stable@dpdk.org
>>>>>> Cc: dev@dpdk.org; Abhishek Marathe
>>>>>> <Abhishek.Marathe@microsoft.com>; Ali Alnubani
>>>>>> <alialnu@nvidia.com>; Walker, Benjamin <benjamin.walker@intel.com>;
>>>>>> David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
>>>>>> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
>>>>>> Jacob <jerinj@marvell.com>; Mcnamara, John
>>>>>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>;
>>>>>> Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi
>>>>>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q
>>>>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
>>>>> Thomas
>>>>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
>>>>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>>>>>> Subject: 21.11.4 patches review and test
>>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> Here is a list of patches targeted for stable release 21.11.4.
>>>>>>
>>>>>> The planned date for the final release is 25th April.
>>>>>>
>>>>>> Please help with testing and validation of your use cases and
>>>>>> report any issues/results with reply-all to this mail. For the
>>>>>> final release the fixes and reported validations will be added to the
>> release notes.
>>>>>>
>>>>>> A release candidate tarball can be found at:
>>>>>>
>>>>>>        https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
>>>>>>
>>>>>> These patches are located at branch 21.11 of dpdk-stable repo:
>>>>>>        https://dpdk.org/browse/dpdk-stable/
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>> Kevin
>>>>>
>>>>> HI All,
>>>>>
>>>>> Update the test status for Intel part. Till now dpdk21.11.4-rc1
>>>>> validation test rate is 85%. No critical issue is found.
>>>>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
>>>>> New bugs:   --20.11.8-rc1 also has these two issues
>>>>>      1.
>> pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
>>>>> performance drop about 23.5% when send small packets
>>>>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212    -- no fix yet
>>>>>      2. some of the virtio tests are failing:    -- Intel dev is under
>> investigating
>>>>> # Basic Intel(R) NIC testing
>>>>> * Build & CFLAG compile: cover the build test combination with
>>>>> latest GCC/Clang version and the popular OS revision such as
>>>>>      Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4,
>>>>> FreeBSD13.1, SUSE15, CentOS7.9, etc.
>>>>> - All test done. No new dpdk issue is found.
>>>>> * PF(i40e, ixgbe): test scenarios including
>>>>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>>> - All test done. No new dpdk issue is found.
>>>>> * VF(i40e, ixgbe): test scenarios including
>>>>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>>> - All test done. No new dpdk issue is found.
>>>>> * PF/VF(ice): test scenarios including Switch features/Package
>>>>> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
>>>>> Descriptor, etc.
>>>>> - All test done. No new dpdk issue is found.
>>>>> * Intel NIC single core/NIC performance: test scenarios including
>>>>> PF/VF single core performance test, etc.
>>>>> - All test done. No new dpdk issue is found.
>>>>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic
>>>>> test - QAT&SW/FIB library, etc.
>>>>> - On going.
>>>>>
>>>>> # Basic cryptodev and virtio testing
>>>>> * Virtio: both function and performance test are covered. Such as
>>>>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
>>>>> testing/VMAWARE ESXI 8.0, etc.
>>>>> - All test done. found bug1.
>>>>> * Cryptodev:
>>>>>      *Function test: test scenarios including Cryptodev API
>>>>> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>>>>>        - Execution rate is 90%. found bug2.
>>>>>      *Performance test: test scenarios including Thoughput
>>>>> Performance/Cryptodev Latency, etc.
>>>>>        - All test done. No new dpdk issue is found.
>>>>>
>>>>> Regards,
>>>>> Xu, Hailin
>>>> Update the test status for Intel part. completed dpdk21.11.4-rc1 all
>> validation. No critical issue is found.
>>>
>>> Hi. Thanks for testing.
>>>
>>>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
>>>> New bugs: --20.11.8-rc1 also has these two issues
>>>>      1.
>> pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
>> performance drop about 23.5% when send small packets
>>>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212  --not fix yet, Only the
>>>> specified platform exists
>>>
>>> Do you know which patch caaused the regression? I'm not fully clear
>>> from the Bz for 20.11. The backported patch ID'd as root cause [0] in
>>> 20.11 is in the previous releases of 20.11 (and 21.11).
>>>
>>> Trying to understand because then it would have shown in testing for
>>> previous releases. Or is this a new test introduced for latest LTS
>>> releases? and if so, what is the baseline performance based on?
>>>
>>> [0]
>>> commit 1c9a7fba5c90e0422b517404499ed106f647bcff
>>> Author: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>>> Date:   Mon Jul 11 14:11:32 2022 +0200
>>>
>>>        net: accept unaligned data in checksum routines
>>>
>>>>      2. some of the virtio tests are failing: -- Intel dev is under
>>>> investigating
>>>
>>> ok, thank you.
>>>
>>
>> Hi, it was mentioned in a separate mail that the performance drop issue was
>> not the same as 20.11.
>>
>> Is there any update on that and the failing virtio tests ? Is there a regression
>> introduced since in 21.11.4 ?
> 
> Found bad commit id:
> commit c41493361c87e730459ead9311c68528eb0874aa
> Author: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
> Date:   Fri Mar 3 14:19:29 2023 +0300
>      net/virtio: deduce IP length for TSO checksum
> 
> We try this issue on 3 different platforms
> Performance drop only found on Intel(R) Xeon(R) Platinum 8280M CPU @ 2.70GHz CPU.
> 

Ok, thanks for reporting. This commit was also in 23.03 and 20.11.8 so 
not sure if they were tested on this platform?

This commit fixes a functional issue, so I don't think it should be 
removed unless it is critical issue.

There's no update on other performance report. Release is already 1 week 
overdue, is there critical issues that we should hold release for?

thanks,
Kevin.

> Regards,
> Xu, Hailin
> 
>>
>> thanks,
>> Kevin,
>>
>>> Kevin.
>>>
>>>> # Basic Intel(R) NIC testing
>>>> * Build & CFLAG compile: cover the build test combination with latest
>> GCC/Clang version and the popular OS revision such as
>>>>      Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6, RHEL8.4,
>> FreeBSD13.1, SUSE15, CentOS7.9, etc.
>>>> - All test done. No new dpdk issue is found.
>>>> * PF(i40e, ixgbe): test scenarios including
>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>> - All test done. No new dpdk issue is found.
>>>> * VF(i40e, ixgbe): test scenarios including
>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>> - All test done. No new dpdk issue is found.
>>>> * PF/VF(ice): test scenarios including Switch features/Package
>> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
>> Descriptor, etc.
>>>> - All test done. No new dpdk issue is found.
>>>> * Intel NIC single core/NIC performance: test scenarios including PF/VF
>> single core performance test, etc.
>>>> - All test done. No new dpdk issue is found.
>>>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
>> QAT&SW/FIB library, etc.
>>>> - All test done. No new dpdk issue is found.
>>>>
>>>> # Basic cryptodev and virtio testing
>>>> * Virtio: both function and performance test are covered. Such as
>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
>> testing/VMAWARE ESXI 8.0, etc.
>>>> - All test done. found bug1.
>>>> * Cryptodev:
>>>>      *Function test: test scenarios including Cryptodev API
>> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>>>>        - All test done. found bug2.
>>>>      *Performance test: test scenarios including Thoughput
>> Performance/Cryptodev Latency, etc.
>>>>        - All test done. No new dpdk issue is found.
>>>>
>>>> Regards,
>>>> Xu, Hailin
>>>>
>>>
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: 21.11.4 patches review and test
  2023-05-04 10:10           ` Kevin Traynor
@ 2023-05-05  1:42             ` Xu, HailinX
  2023-05-08 15:23               ` Kevin Traynor
  0 siblings, 1 reply; 15+ messages in thread
From: Xu, HailinX @ 2023-05-05  1:42 UTC (permalink / raw)
  To: Kevin Traynor, stable
  Cc: Stokes, Ian, Mcnamara, John, Luca Boccassi, Xu, Qian Q,
	Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan, dev

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Thursday, May 4, 2023 6:11 PM
> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
> Cc: Stokes, Ian <ian.stokes@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Xu, Qian Q
> <qian.q.xu@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Peng,
> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>;
> dev@dpdk.org
> Subject: Re: 21.11.4 patches review and test
> 
> On 04/05/2023 03:13, Xu, HailinX wrote:
> >> -----Original Message-----
> >> From: Kevin Traynor <ktraynor@redhat.com>
> >> Sent: Tuesday, May 2, 2023 5:35 PM
> >> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
> >> Cc: Stokes, Ian <ian.stokes@intel.com>; Mcnamara, John
> >> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Xu, Qian
> >> Q <qian.q.xu@intel.com>; Thomas Monjalon <thomas@monjalon.net>;
> Peng,
> >> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>;
> >> dev@dpdk.org
> >> Subject: Re: 21.11.4 patches review and test
> >>
> >> On 20/04/2023 11:32, Kevin Traynor wrote:
> >>> On 20/04/2023 03:40, Xu, HailinX wrote:
> >>>>> -----Original Message-----
> >>>>> From: Xu, HailinX <hailinx.xu@intel.com>
> >>>>> Sent: Thursday, April 13, 2023 2:13 PM
> >>>>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
> >>>>> Cc: dev@dpdk.org; Abhishek Marathe
> >> <Abhishek.Marathe@microsoft.com>;
> >>>>> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
> >>>>> <benjamin.walker@intel.com>; David Christensen
> >>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
> >> <hemant.agrawal@nxp.com>;
> >>>>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
> >>>>> <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> >>>>> Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi
> >>>>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q
> >>>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
> >> Thomas
> >>>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
> >>>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> >>>>> Subject: RE: 21.11.4 patches review and test
> >>>>>
> >>>>>> -----Original Message-----
> >>>>>> From: Kevin Traynor <ktraynor@redhat.com>
> >>>>>> Sent: Thursday, April 6, 2023 7:38 PM
> >>>>>> To: stable@dpdk.org
> >>>>>> Cc: dev@dpdk.org; Abhishek Marathe
> >>>>>> <Abhishek.Marathe@microsoft.com>; Ali Alnubani
> >>>>>> <alialnu@nvidia.com>; Walker, Benjamin
> >>>>>> <benjamin.walker@intel.com>; David Christensen
> >>>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
> >>>>>> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>;
> >>>>>> Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
> >>>>>> <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>;
> >>>>>> Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi
> >>>>>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q
> >>>>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
> >>>>> Thomas
> >>>>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
> >>>>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> >>>>>> Subject: 21.11.4 patches review and test
> >>>>>>
> >>>>>> Hi all,
> >>>>>>
> >>>>>> Here is a list of patches targeted for stable release 21.11.4.
> >>>>>>
> >>>>>> The planned date for the final release is 25th April.
> >>>>>>
> >>>>>> Please help with testing and validation of your use cases and
> >>>>>> report any issues/results with reply-all to this mail. For the
> >>>>>> final release the fixes and reported validations will be added to
> >>>>>> the
> >> release notes.
> >>>>>>
> >>>>>> A release candidate tarball can be found at:
> >>>>>>
> >>>>>>        https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
> >>>>>>
> >>>>>> These patches are located at branch 21.11 of dpdk-stable repo:
> >>>>>>        https://dpdk.org/browse/dpdk-stable/
> >>>>>>
> >>>>>> Thanks.
> >>>>>>
> >>>>>> Kevin
> >>>>>
> >>>>> HI All,
> >>>>>
> >>>>> Update the test status for Intel part. Till now dpdk21.11.4-rc1
> >>>>> validation test rate is 85%. No critical issue is found.
> >>>>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
> >>>>> New bugs:   --20.11.8-rc1 also has these two issues
> >>>>>      1.
> >> pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
> >>>>> performance drop about 23.5% when send small packets
> >>>>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212    -- no fix yet
> >>>>>      2. some of the virtio tests are failing:    -- Intel dev is under
> >> investigating
> >>>>> # Basic Intel(R) NIC testing
> >>>>> * Build & CFLAG compile: cover the build test combination with
> >>>>> latest GCC/Clang version and the popular OS revision such as
> >>>>>      Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6,
> >>>>> RHEL8.4, FreeBSD13.1, SUSE15, CentOS7.9, etc.
> >>>>> - All test done. No new dpdk issue is found.
> >>>>> * PF(i40e, ixgbe): test scenarios including
> >>>>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >>>>> - All test done. No new dpdk issue is found.
> >>>>> * VF(i40e, ixgbe): test scenarios including
> >>>>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >>>>> - All test done. No new dpdk issue is found.
> >>>>> * PF/VF(ice): test scenarios including Switch features/Package
> >>>>> Management/Flow Director/Advanced Tx/Advanced
> RSS/ACL/DCF/Flexible
> >>>>> Descriptor, etc.
> >>>>> - All test done. No new dpdk issue is found.
> >>>>> * Intel NIC single core/NIC performance: test scenarios including
> >>>>> PF/VF single core performance test, etc.
> >>>>> - All test done. No new dpdk issue is found.
> >>>>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library
> >>>>> basic test - QAT&SW/FIB library, etc.
> >>>>> - On going.
> >>>>>
> >>>>> # Basic cryptodev and virtio testing
> >>>>> * Virtio: both function and performance test are covered. Such as
> >>>>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
> >>>>> testing/VMAWARE ESXI 8.0, etc.
> >>>>> - All test done. found bug1.
> >>>>> * Cryptodev:
> >>>>>      *Function test: test scenarios including Cryptodev API
> >>>>> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
> >>>>>        - Execution rate is 90%. found bug2.
> >>>>>      *Performance test: test scenarios including Thoughput
> >>>>> Performance/Cryptodev Latency, etc.
> >>>>>        - All test done. No new dpdk issue is found.
> >>>>>
> >>>>> Regards,
> >>>>> Xu, Hailin
> >>>> Update the test status for Intel part. completed dpdk21.11.4-rc1
> >>>> all
> >> validation. No critical issue is found.
> >>>
> >>> Hi. Thanks for testing.
> >>>
> >>>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
> >>>> New bugs: --20.11.8-rc1 also has these two issues
> >>>>      1.
> >> pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
> >> performance drop about 23.5% when send small packets
> >>>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212  --not fix yet, Only
> >>>> the specified platform exists
> >>>
> >>> Do you know which patch caaused the regression? I'm not fully clear
> >>> from the Bz for 20.11. The backported patch ID'd as root cause [0]
> >>> in
> >>> 20.11 is in the previous releases of 20.11 (and 21.11).
> >>>
> >>> Trying to understand because then it would have shown in testing for
> >>> previous releases. Or is this a new test introduced for latest LTS
> >>> releases? and if so, what is the baseline performance based on?
> >>>
> >>> [0]
> >>> commit 1c9a7fba5c90e0422b517404499ed106f647bcff
> >>> Author: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> >>> Date:   Mon Jul 11 14:11:32 2022 +0200
> >>>
> >>>        net: accept unaligned data in checksum routines
> >>>
> >>>>      2. some of the virtio tests are failing: -- Intel dev is under
> >>>> investigating
> >>>
> >>> ok, thank you.
> >>>
> >>
> >> Hi, it was mentioned in a separate mail that the performance drop
> >> issue was not the same as 20.11.
> >>
> >> Is there any update on that and the failing virtio tests ? Is there a
> >> regression introduced since in 21.11.4 ?
> >
> > Found bad commit id:
> > commit c41493361c87e730459ead9311c68528eb0874aa
> > Author: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
> > Date:   Fri Mar 3 14:19:29 2023 +0300
> >      net/virtio: deduce IP length for TSO checksum
> >
> > We try this issue on 3 different platforms Performance drop only found
> > on Intel(R) Xeon(R) Platinum 8280M CPU @ 2.70GHz CPU.
> >
> 
> Ok, thanks for reporting. This commit was also in 23.03 and 20.11.8 so not sure
> if they were tested on this platform?
> 
Yes, But 23.03 doesn't have such issue on the same platform

> This commit fixes a functional issue, so I don't think it should be removed unless
> it is critical issue.
> 
> There's no update on other performance report. Release is already 1 week
> overdue, is there critical issues that we should hold release for?
> 
No other issues found

Regards,
Xu, Hailin

> thanks,
> Kevin.
> 
> > Regards,
> > Xu, Hailin
> >
> >>
> >> thanks,
> >> Kevin,
> >>
> >>> Kevin.
> >>>
> >>>> # Basic Intel(R) NIC testing
> >>>> * Build & CFLAG compile: cover the build test combination with
> >>>> latest
> >> GCC/Clang version and the popular OS revision such as
> >>>>      Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6,
> >>>> RHEL8.4,
> >> FreeBSD13.1, SUSE15, CentOS7.9, etc.
> >>>> - All test done. No new dpdk issue is found.
> >>>> * PF(i40e, ixgbe): test scenarios including
> >> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >>>> - All test done. No new dpdk issue is found.
> >>>> * VF(i40e, ixgbe): test scenarios including
> >> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >>>> - All test done. No new dpdk issue is found.
> >>>> * PF/VF(ice): test scenarios including Switch features/Package
> >> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
> >> Descriptor, etc.
> >>>> - All test done. No new dpdk issue is found.
> >>>> * Intel NIC single core/NIC performance: test scenarios including
> >>>> PF/VF
> >> single core performance test, etc.
> >>>> - All test done. No new dpdk issue is found.
> >>>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library
> >>>> basic test -
> >> QAT&SW/FIB library, etc.
> >>>> - All test done. No new dpdk issue is found.
> >>>>
> >>>> # Basic cryptodev and virtio testing
> >>>> * Virtio: both function and performance test are covered. Such as
> >> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
> >> testing/VMAWARE ESXI 8.0, etc.
> >>>> - All test done. found bug1.
> >>>> * Cryptodev:
> >>>>      *Function test: test scenarios including Cryptodev API
> >> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
> >>>>        - All test done. found bug2.
> >>>>      *Performance test: test scenarios including Thoughput
> >> Performance/Cryptodev Latency, etc.
> >>>>        - All test done. No new dpdk issue is found.
> >>>>
> >>>> Regards,
> >>>> Xu, Hailin
> >>>>
> >>>
> >


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: 21.11.4 patches review and test
  2023-05-05  1:42             ` Xu, HailinX
@ 2023-05-08 15:23               ` Kevin Traynor
  2023-05-11  7:33                 ` Jiang, YuX
  0 siblings, 1 reply; 15+ messages in thread
From: Kevin Traynor @ 2023-05-08 15:23 UTC (permalink / raw)
  To: Xu, HailinX, stable
  Cc: Stokes, Ian, Mcnamara, John, Luca Boccassi, Xu, Qian Q,
	Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan, dev

On 05/05/2023 02:42, Xu, HailinX wrote:
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Thursday, May 4, 2023 6:11 PM
>> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
>> Cc: Stokes, Ian <ian.stokes@intel.com>; Mcnamara, John
>> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Xu, Qian Q
>> <qian.q.xu@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Peng,
>> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>;
>> dev@dpdk.org
>> Subject: Re: 21.11.4 patches review and test
>>
>> On 04/05/2023 03:13, Xu, HailinX wrote:
>>>> -----Original Message-----
>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>> Sent: Tuesday, May 2, 2023 5:35 PM
>>>> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
>>>> Cc: Stokes, Ian <ian.stokes@intel.com>; Mcnamara, John
>>>> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Xu, Qian
>>>> Q <qian.q.xu@intel.com>; Thomas Monjalon <thomas@monjalon.net>;
>> Peng,
>>>> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>;
>>>> dev@dpdk.org
>>>> Subject: Re: 21.11.4 patches review and test
>>>>
>>>> On 20/04/2023 11:32, Kevin Traynor wrote:
>>>>> On 20/04/2023 03:40, Xu, HailinX wrote:
>>>>>>> -----Original Message-----
>>>>>>> From: Xu, HailinX <hailinx.xu@intel.com>
>>>>>>> Sent: Thursday, April 13, 2023 2:13 PM
>>>>>>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
>>>>>>> Cc: dev@dpdk.org; Abhishek Marathe
>>>> <Abhishek.Marathe@microsoft.com>;
>>>>>>> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
>>>>>>> <benjamin.walker@intel.com>; David Christensen
>>>>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
>>>> <hemant.agrawal@nxp.com>;
>>>>>>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
>>>>>>> <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
>>>>>>> Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi
>>>>>>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q
>>>>>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
>>>> Thomas
>>>>>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
>>>>>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>>>>>>> Subject: RE: 21.11.4 patches review and test
>>>>>>>
>>>>>>>> -----Original Message-----
>>>>>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>>>>>> Sent: Thursday, April 6, 2023 7:38 PM
>>>>>>>> To: stable@dpdk.org
>>>>>>>> Cc: dev@dpdk.org; Abhishek Marathe
>>>>>>>> <Abhishek.Marathe@microsoft.com>; Ali Alnubani
>>>>>>>> <alialnu@nvidia.com>; Walker, Benjamin
>>>>>>>> <benjamin.walker@intel.com>; David Christensen
>>>>>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
>>>>>>>> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>;
>>>>>>>> Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
>>>>>>>> <john.mcnamara@intel.com>; Ju-Hyoung Lee
>> <juhlee@microsoft.com>;
>>>>>>>> Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi
>>>>>>>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian Q
>>>>>>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
>>>>>>> Thomas
>>>>>>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
>>>>>>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>>>>>>>> Subject: 21.11.4 patches review and test
>>>>>>>>
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> Here is a list of patches targeted for stable release 21.11.4.
>>>>>>>>
>>>>>>>> The planned date for the final release is 25th April.
>>>>>>>>
>>>>>>>> Please help with testing and validation of your use cases and
>>>>>>>> report any issues/results with reply-all to this mail. For the
>>>>>>>> final release the fixes and reported validations will be added to
>>>>>>>> the
>>>> release notes.
>>>>>>>>
>>>>>>>> A release candidate tarball can be found at:
>>>>>>>>
>>>>>>>>         https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
>>>>>>>>
>>>>>>>> These patches are located at branch 21.11 of dpdk-stable repo:
>>>>>>>>         https://dpdk.org/browse/dpdk-stable/
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>>
>>>>>>>> Kevin
>>>>>>>
>>>>>>> HI All,
>>>>>>>
>>>>>>> Update the test status for Intel part. Till now dpdk21.11.4-rc1
>>>>>>> validation test rate is 85%. No critical issue is found.
>>>>>>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
>>>>>>> New bugs:   --20.11.8-rc1 also has these two issues
>>>>>>>       1.
>>>> pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
>>>>>>> performance drop about 23.5% when send small packets
>>>>>>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212    -- no fix yet
>>>>>>>       2. some of the virtio tests are failing:    -- Intel dev is under
>>>> investigating
>>>>>>> # Basic Intel(R) NIC testing
>>>>>>> * Build & CFLAG compile: cover the build test combination with
>>>>>>> latest GCC/Clang version and the popular OS revision such as
>>>>>>>       Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6,
>>>>>>> RHEL8.4, FreeBSD13.1, SUSE15, CentOS7.9, etc.
>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>> * PF(i40e, ixgbe): test scenarios including
>>>>>>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>> * VF(i40e, ixgbe): test scenarios including
>>>>>>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>> * PF/VF(ice): test scenarios including Switch features/Package
>>>>>>> Management/Flow Director/Advanced Tx/Advanced
>> RSS/ACL/DCF/Flexible
>>>>>>> Descriptor, etc.
>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>> * Intel NIC single core/NIC performance: test scenarios including
>>>>>>> PF/VF single core performance test, etc.
>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library
>>>>>>> basic test - QAT&SW/FIB library, etc.
>>>>>>> - On going.
>>>>>>>
>>>>>>> # Basic cryptodev and virtio testing
>>>>>>> * Virtio: both function and performance test are covered. Such as
>>>>>>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
>>>>>>> testing/VMAWARE ESXI 8.0, etc.
>>>>>>> - All test done. found bug1.
>>>>>>> * Cryptodev:
>>>>>>>       *Function test: test scenarios including Cryptodev API
>>>>>>> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>>>>>>>         - Execution rate is 90%. found bug2.
>>>>>>>       *Performance test: test scenarios including Thoughput
>>>>>>> Performance/Cryptodev Latency, etc.
>>>>>>>         - All test done. No new dpdk issue is found.
>>>>>>>
>>>>>>> Regards,
>>>>>>> Xu, Hailin
>>>>>> Update the test status for Intel part. completed dpdk21.11.4-rc1
>>>>>> all
>>>> validation. No critical issue is found.
>>>>>
>>>>> Hi. Thanks for testing.
>>>>>
>>>>>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
>>>>>> New bugs: --20.11.8-rc1 also has these two issues
>>>>>>       1.
>>>> pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
>>>> performance drop about 23.5% when send small packets
>>>>>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212  --not fix yet, Only
>>>>>> the specified platform exists
>>>>>
>>>>> Do you know which patch caaused the regression? I'm not fully clear
>>>>> from the Bz for 20.11. The backported patch ID'd as root cause [0]
>>>>> in
>>>>> 20.11 is in the previous releases of 20.11 (and 21.11).
>>>>>
>>>>> Trying to understand because then it would have shown in testing for
>>>>> previous releases. Or is this a new test introduced for latest LTS
>>>>> releases? and if so, what is the baseline performance based on?
>>>>>
>>>>> [0]
>>>>> commit 1c9a7fba5c90e0422b517404499ed106f647bcff
>>>>> Author: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>>>>> Date:   Mon Jul 11 14:11:32 2022 +0200
>>>>>
>>>>>         net: accept unaligned data in checksum routines
>>>>>
>>>>>>       2. some of the virtio tests are failing: -- Intel dev is under
>>>>>> investigating
>>>>>
>>>>> ok, thank you.
>>>>>
>>>>
>>>> Hi, it was mentioned in a separate mail that the performance drop
>>>> issue was not the same as 20.11.
>>>>
>>>> Is there any update on that and the failing virtio tests ? Is there a
>>>> regression introduced since in 21.11.4 ?
>>>
>>> Found bad commit id:
>>> commit c41493361c87e730459ead9311c68528eb0874aa
>>> Author: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
>>> Date:   Fri Mar 3 14:19:29 2023 +0300
>>>       net/virtio: deduce IP length for TSO checksum
>>>
>>> We try this issue on 3 different platforms Performance drop only found
>>> on Intel(R) Xeon(R) Platinum 8280M CPU @ 2.70GHz CPU.
>>>
>>
>> Ok, thanks for reporting. This commit was also in 23.03 and 20.11.8 so not sure
>> if they were tested on this platform?
>>
> Yes, But 23.03 doesn't have such issue on the same platform
> 

ok, thanks.

>> This commit fixes a functional issue, so I don't think it should be removed unless
>> it is critical issue.
>>
>> There's no update on other performance report. Release is already 1 week
>> overdue, is there critical issues that we should hold release for?
>>
> No other issues found
> 

I'm not fully clear on the status, so let's separate. There were two 
reported issues.

1. Performance drop on specific Intel platform.
- Is this being investigated by Intel dev?
- Is it is a release blocking issue ?

2. Virtio issue caused by

commit c41493361c87e730459ead9311c68528eb0874aa
Author: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
Date:   Fri Mar 3 14:19:29 2023 +0300
        net/virtio: deduce IP length for TSO checksum

- Is this being investigated by Intel dev?
- Is it is a release blocking issue ?

thanks,
Kevin.

> Regards,
> Xu, Hailin
> 
>> thanks,
>> Kevin.
>>
>>> Regards,
>>> Xu, Hailin
>>>
>>>>
>>>> thanks,
>>>> Kevin,
>>>>
>>>>> Kevin.
>>>>>
>>>>>> # Basic Intel(R) NIC testing
>>>>>> * Build & CFLAG compile: cover the build test combination with
>>>>>> latest
>>>> GCC/Clang version and the popular OS revision such as
>>>>>>       Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6,
>>>>>> RHEL8.4,
>>>> FreeBSD13.1, SUSE15, CentOS7.9, etc.
>>>>>> - All test done. No new dpdk issue is found.
>>>>>> * PF(i40e, ixgbe): test scenarios including
>>>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>>>> - All test done. No new dpdk issue is found.
>>>>>> * VF(i40e, ixgbe): test scenarios including
>>>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>>>> - All test done. No new dpdk issue is found.
>>>>>> * PF/VF(ice): test scenarios including Switch features/Package
>>>> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
>>>> Descriptor, etc.
>>>>>> - All test done. No new dpdk issue is found.
>>>>>> * Intel NIC single core/NIC performance: test scenarios including
>>>>>> PF/VF
>>>> single core performance test, etc.
>>>>>> - All test done. No new dpdk issue is found.
>>>>>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library
>>>>>> basic test -
>>>> QAT&SW/FIB library, etc.
>>>>>> - All test done. No new dpdk issue is found.
>>>>>>
>>>>>> # Basic cryptodev and virtio testing
>>>>>> * Virtio: both function and performance test are covered. Such as
>>>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
>>>> testing/VMAWARE ESXI 8.0, etc.
>>>>>> - All test done. found bug1.
>>>>>> * Cryptodev:
>>>>>>       *Function test: test scenarios including Cryptodev API
>>>> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>>>>>>         - All test done. found bug2.
>>>>>>       *Performance test: test scenarios including Thoughput
>>>> Performance/Cryptodev Latency, etc.
>>>>>>         - All test done. No new dpdk issue is found.
>>>>>>
>>>>>> Regards,
>>>>>> Xu, Hailin
>>>>>>
>>>>>
>>>
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: 21.11.4 patches review and test
  2023-05-08 15:23               ` Kevin Traynor
@ 2023-05-11  7:33                 ` Jiang, YuX
  2023-05-16  8:41                   ` Kevin Traynor
  0 siblings, 1 reply; 15+ messages in thread
From: Jiang, YuX @ 2023-05-11  7:33 UTC (permalink / raw)
  To: Kevin Traynor, Xu, HailinX, stable, boleslav.stankevich,
	maxime.coquelin, Xia, Chenbo, Ji, Kai
  Cc: Stokes, Ian, Mcnamara, John, Luca Boccassi, Xu, Qian Q,
	Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan, dev

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Monday, May 8, 2023 11:24 PM
> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
> Cc: Stokes, Ian <ian.stokes@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Xu, Qian Q
> <qian.q.xu@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Peng,
> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>;
> dev@dpdk.org
> Subject: Re: 21.11.4 patches review and test
> 
> On 05/05/2023 02:42, Xu, HailinX wrote:
> >> -----Original Message-----
> >> From: Kevin Traynor <ktraynor@redhat.com>
> >> Sent: Thursday, May 4, 2023 6:11 PM
> >> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
> >> Cc: Stokes, Ian <ian.stokes@intel.com>; Mcnamara, John
> >> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Xu,
> Qian
> >> Q <qian.q.xu@intel.com>; Thomas Monjalon <thomas@monjalon.net>;
> Peng,
> >> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan
> <zhaoyan.chen@intel.com>;
> >> dev@dpdk.org
> >> Subject: Re: 21.11.4 patches review and test
> >>
> >> On 04/05/2023 03:13, Xu, HailinX wrote:
> >>>> -----Original Message-----
> >>>> From: Kevin Traynor <ktraynor@redhat.com>
> >>>> Sent: Tuesday, May 2, 2023 5:35 PM
> >>>> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
> >>>> Cc: Stokes, Ian <ian.stokes@intel.com>; Mcnamara, John
> >>>> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Xu,
> >>>> Qian Q <qian.q.xu@intel.com>; Thomas Monjalon
> >>>> <thomas@monjalon.net>;
> >> Peng,
> >>>> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan
> <zhaoyan.chen@intel.com>;
> >>>> dev@dpdk.org
> >>>> Subject: Re: 21.11.4 patches review and test
> >>>>
> >>>> On 20/04/2023 11:32, Kevin Traynor wrote:
> >>>>> On 20/04/2023 03:40, Xu, HailinX wrote:
> >>>>>>> -----Original Message-----
> >>>>>>> From: Xu, HailinX <hailinx.xu@intel.com>
> >>>>>>> Sent: Thursday, April 13, 2023 2:13 PM
> >>>>>>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
> >>>>>>> Cc: dev@dpdk.org; Abhishek Marathe
> >>>> <Abhishek.Marathe@microsoft.com>;
> >>>>>>> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
> >>>>>>> <benjamin.walker@intel.com>; David Christensen
> >>>>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
> >>>> <hemant.agrawal@nxp.com>;
> >>>>>>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
> >>>>>>> <jerinj@marvell.com>; Mcnamara, John
> <john.mcnamara@intel.com>;
> >>>>>>> Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi
> >>>>>>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian
> Q
> >>>>>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
> >>>> Thomas
> >>>>>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng,
> Yuan
> >>>>>>> <yuan.peng@intel.com>; Chen, Zhaoyan
> <zhaoyan.chen@intel.com>
> >>>>>>> Subject: RE: 21.11.4 patches review and test
> >>>>>>>
> >>>>>>>> -----Original Message-----
> >>>>>>>> From: Kevin Traynor <ktraynor@redhat.com>
> >>>>>>>> Sent: Thursday, April 6, 2023 7:38 PM
> >>>>>>>> To: stable@dpdk.org
> >>>>>>>> Cc: dev@dpdk.org; Abhishek Marathe
> >>>>>>>> <Abhishek.Marathe@microsoft.com>; Ali Alnubani
> >>>>>>>> <alialnu@nvidia.com>; Walker, Benjamin
> >>>>>>>> <benjamin.walker@intel.com>; David Christensen
> >>>>>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
> >>>>>>>> <hemant.agrawal@nxp.com>; Stokes, Ian
> <ian.stokes@intel.com>;
> >>>>>>>> Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
> >>>>>>>> <john.mcnamara@intel.com>; Ju-Hyoung Lee
> >> <juhlee@microsoft.com>;
> >>>>>>>> Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi
> >>>>>>>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu,
> Qian Q
> >>>>>>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
> >>>>>>> Thomas
> >>>>>>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng,
> Yuan
> >>>>>>>> <yuan.peng@intel.com>; Chen, Zhaoyan
> <zhaoyan.chen@intel.com>
> >>>>>>>> Subject: 21.11.4 patches review and test
> >>>>>>>>
> >>>>>>>> Hi all,
> >>>>>>>>
> >>>>>>>> Here is a list of patches targeted for stable release 21.11.4.
> >>>>>>>>
> >>>>>>>> The planned date for the final release is 25th April.
> >>>>>>>>
> >>>>>>>> Please help with testing and validation of your use cases and
> >>>>>>>> report any issues/results with reply-all to this mail. For the
> >>>>>>>> final release the fixes and reported validations will be added
> >>>>>>>> to the
> >>>> release notes.
> >>>>>>>>
> >>>>>>>> A release candidate tarball can be found at:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
> >>>>>>>>
> >>>>>>>> These patches are located at branch 21.11 of dpdk-stable repo:
> >>>>>>>>         https://dpdk.org/browse/dpdk-stable/
> >>>>>>>>
> >>>>>>>> Thanks.
> >>>>>>>>
> >>>>>>>> Kevin
> >>>>>>>
> >>>>>>> HI All,
> >>>>>>>
> >>>>>>> Update the test status for Intel part. Till now dpdk21.11.4-rc1
> >>>>>>> validation test rate is 85%. No critical issue is found.
> >>>>>>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
> >>>>>>> New bugs:   --20.11.8-rc1 also has these two issues
> >>>>>>>       1.
> >>>>
> pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
> >>>>>>> performance drop about 23.5% when send small packets
> >>>>>>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212    -- no fix yet
> >>>>>>>       2. some of the virtio tests are failing:    -- Intel dev is under
> >>>> investigating
> >>>>>>> # Basic Intel(R) NIC testing
> >>>>>>> * Build & CFLAG compile: cover the build test combination with
> >>>>>>> latest GCC/Clang version and the popular OS revision such as
> >>>>>>>       Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6,
> >>>>>>> RHEL8.4, FreeBSD13.1, SUSE15, CentOS7.9, etc.
> >>>>>>> - All test done. No new dpdk issue is found.
> >>>>>>> * PF(i40e, ixgbe): test scenarios including
> >>>>>>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >>>>>>> - All test done. No new dpdk issue is found.
> >>>>>>> * VF(i40e, ixgbe): test scenarios including
> >>>>>>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN,
> etc.
> >>>>>>> - All test done. No new dpdk issue is found.
> >>>>>>> * PF/VF(ice): test scenarios including Switch features/Package
> >>>>>>> Management/Flow Director/Advanced Tx/Advanced
> >> RSS/ACL/DCF/Flexible
> >>>>>>> Descriptor, etc.
> >>>>>>> - All test done. No new dpdk issue is found.
> >>>>>>> * Intel NIC single core/NIC performance: test scenarios
> >>>>>>> including PF/VF single core performance test, etc.
> >>>>>>> - All test done. No new dpdk issue is found.
> >>>>>>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library
> >>>>>>> basic test - QAT&SW/FIB library, etc.
> >>>>>>> - On going.
> >>>>>>>
> >>>>>>> # Basic cryptodev and virtio testing
> >>>>>>> * Virtio: both function and performance test are covered. Such
> >>>>>>> as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM
> >>>>>>> perf testing/VMAWARE ESXI 8.0, etc.
> >>>>>>> - All test done. found bug1.
> >>>>>>> * Cryptodev:
> >>>>>>>       *Function test: test scenarios including Cryptodev API
> >>>>>>> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
> >>>>>>>         - Execution rate is 90%. found bug2.
> >>>>>>>       *Performance test: test scenarios including Thoughput
> >>>>>>> Performance/Cryptodev Latency, etc.
> >>>>>>>         - All test done. No new dpdk issue is found.
> >>>>>>>
> >>>>>>> Regards,
> >>>>>>> Xu, Hailin
> >>>>>> Update the test status for Intel part. completed dpdk21.11.4-rc1
> >>>>>> all
> >>>> validation. No critical issue is found.
> >>>>>
> >>>>> Hi. Thanks for testing.
> >>>>>
> >>>>>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
> >>>>>> New bugs: --20.11.8-rc1 also has these two issues
> >>>>>>       1.
> >>>>
> pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
> >>>> performance drop about 23.5% when send small packets
> >>>>>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212  --not fix yet,
> Only
> >>>>>> the specified platform exists
> >>>>>
> >>>>> Do you know which patch caaused the regression? I'm not fully
> >>>>> clear from the Bz for 20.11. The backported patch ID'd as root
> >>>>> cause [0] in
> >>>>> 20.11 is in the previous releases of 20.11 (and 21.11).
> >>>>>
> >>>>> Trying to understand because then it would have shown in testing
> >>>>> for previous releases. Or is this a new test introduced for latest
> >>>>> LTS releases? and if so, what is the baseline performance based on?
> >>>>>
> >>>>> [0]
> >>>>> commit 1c9a7fba5c90e0422b517404499ed106f647bcff
> >>>>> Author: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> >>>>> Date:   Mon Jul 11 14:11:32 2022 +0200
> >>>>>
> >>>>>         net: accept unaligned data in checksum routines
> >>>>>
> >>>>>>       2. some of the virtio tests are failing: -- Intel dev is
> >>>>>> under investigating
> >>>>>
> >>>>> ok, thank you.
> >>>>>
> >>>>
> >>>> Hi, it was mentioned in a separate mail that the performance drop
> >>>> issue was not the same as 20.11.
> >>>>
> >>>> Is there any update on that and the failing virtio tests ? Is there
> >>>> a regression introduced since in 21.11.4 ?
> >>>
> >>> Found bad commit id:
> >>> commit c41493361c87e730459ead9311c68528eb0874aa
> >>> Author: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
> >>> Date:   Fri Mar 3 14:19:29 2023 +0300
> >>>       net/virtio: deduce IP length for TSO checksum
> >>>
> >>> We try this issue on 3 different platforms Performance drop only
> >>> found on Intel(R) Xeon(R) Platinum 8280M CPU @ 2.70GHz CPU.
> >>>
> >>
> >> Ok, thanks for reporting. This commit was also in 23.03 and 20.11.8
> >> so not sure if they were tested on this platform?
> >>
> > Yes, But 23.03 doesn't have such issue on the same platform
> >
> 
> ok, thanks.
> 
> >> This commit fixes a functional issue, so I don't think it should be
> >> removed unless it is critical issue.
> >>
> >> There's no update on other performance report. Release is already 1
> >> week overdue, is there critical issues that we should hold release for?
> >>
> > No other issues found
> >
> 
> I'm not fully clear on the status, so let's separate. There were two reported
> issues.
> 
> 1. Performance drop on specific Intel platform.
> - Is this being investigated by Intel dev?
> - Is it is a release blocking issue ?
> 
> 2. Virtio issue caused by
> 
> commit c41493361c87e730459ead9311c68528eb0874aa
> Author: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
> Date:   Fri Mar 3 14:19:29 2023 +0300
>         net/virtio: deduce IP length for TSO checksum
> 
> - Is this being investigated by Intel dev?
> - Is it is a release blocking issue ?
> 
> thanks,
> Kevin.
> 
Hi Kevin,

I need correct/clarify the description of the two issues:
1, Performance drop on specific Intel platform -> should be pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac: Benchmark pvp performance drop about 23.5% when send small packets" 
Its bad commit id: 
commit c41493361c87e730459ead9311c68528eb0874aa
Author: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
Date:   Fri Mar 3 14:19:29 2023 +0300

    net/virtio: deduce IP length for TSO checksum

    [ upstream commit d069c80a5d8c0a05033932421851cdb7159de0df ]

    The length of TSO payload could not fit into 16 bits provided by the
    IPv4 total length and IPv6 payload length fields. Thus, deduce it
    from the length of the packet.

    Fixes: 696573046e9e ("net/virtio: support TSO")

    Signed-off-by: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
    Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
    Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> 

Intel validation owner has done lots of verification and compared these performance data on 8280&8380 platforms.
This performance big drop is only found on special platform (Intel(R) Xeon(R) Platinum 8280M CPU @ 2.70GHz CPU) when vhost-user(back-end) 
and virtio-pmd(front-end) are not on the same socket (front-end is on the socket1, back-end and nic are on the socket0).
But our test case doesn't call this bad commit id's related code, suspect whether it may be related to compiler optimization on special platform. 
We hope the bad commit id owner or other experts can support to analysis the root cause.  

2, Virtio issue -> should be virtio crypto test failure.
It is not a regression issue, old lts and main branch also reproduce by validation owner, and there's no clear bad commit id found. 
Intel dev and validation owner are investigating it, but we don't find out the root cause yet. 

Best regards,
Yu Jiang

> > Regards,
> > Xu, Hailin
> >
> >> thanks,
> >> Kevin.
> >>
> >>> Regards,
> >>> Xu, Hailin
> >>>
> >>>>
> >>>> thanks,
> >>>> Kevin,
> >>>>
> >>>>> Kevin.
> >>>>>
> >>>>>> # Basic Intel(R) NIC testing
> >>>>>> * Build & CFLAG compile: cover the build test combination with
> >>>>>> latest
> >>>> GCC/Clang version and the popular OS revision such as
> >>>>>>       Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6,
> >>>>>> RHEL8.4,
> >>>> FreeBSD13.1, SUSE15, CentOS7.9, etc.
> >>>>>> - All test done. No new dpdk issue is found.
> >>>>>> * PF(i40e, ixgbe): test scenarios including
> >>>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >>>>>> - All test done. No new dpdk issue is found.
> >>>>>> * VF(i40e, ixgbe): test scenarios including
> >>>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >>>>>> - All test done. No new dpdk issue is found.
> >>>>>> * PF/VF(ice): test scenarios including Switch features/Package
> >>>> Management/Flow Director/Advanced Tx/Advanced
> RSS/ACL/DCF/Flexible
> >>>> Descriptor, etc.
> >>>>>> - All test done. No new dpdk issue is found.
> >>>>>> * Intel NIC single core/NIC performance: test scenarios including
> >>>>>> PF/VF
> >>>> single core performance test, etc.
> >>>>>> - All test done. No new dpdk issue is found.
> >>>>>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library
> >>>>>> basic test -
> >>>> QAT&SW/FIB library, etc.
> >>>>>> - All test done. No new dpdk issue is found.
> >>>>>>
> >>>>>> # Basic cryptodev and virtio testing
> >>>>>> * Virtio: both function and performance test are covered. Such as
> >>>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
> >>>> testing/VMAWARE ESXI 8.0, etc.
> >>>>>> - All test done. found bug1.
> >>>>>> * Cryptodev:
> >>>>>>       *Function test: test scenarios including Cryptodev API
> >>>> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
> >>>>>>         - All test done. found bug2.
> >>>>>>       *Performance test: test scenarios including Thoughput
> >>>> Performance/Cryptodev Latency, etc.
> >>>>>>         - All test done. No new dpdk issue is found.
> >>>>>>
> >>>>>> Regards,
> >>>>>> Xu, Hailin
> >>>>>>
> >>>>>
> >>>
> >


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: 21.11.4 patches review and test
  2023-05-11  7:33                 ` Jiang, YuX
@ 2023-05-16  8:41                   ` Kevin Traynor
  0 siblings, 0 replies; 15+ messages in thread
From: Kevin Traynor @ 2023-05-16  8:41 UTC (permalink / raw)
  To: Jiang, YuX, Xu, HailinX, stable, boleslav.stankevich,
	maxime.coquelin, Xia, Chenbo, Ji, Kai
  Cc: Stokes, Ian, Mcnamara, John, Luca Boccassi, Xu, Qian Q,
	Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan, dev

On 11/05/2023 08:33, Jiang, YuX wrote:
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Monday, May 8, 2023 11:24 PM
>> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
>> Cc: Stokes, Ian <ian.stokes@intel.com>; Mcnamara, John
>> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Xu, Qian Q
>> <qian.q.xu@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Peng,
>> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>;
>> dev@dpdk.org
>> Subject: Re: 21.11.4 patches review and test
>>
>> On 05/05/2023 02:42, Xu, HailinX wrote:
>>>> -----Original Message-----
>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>> Sent: Thursday, May 4, 2023 6:11 PM
>>>> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
>>>> Cc: Stokes, Ian <ian.stokes@intel.com>; Mcnamara, John
>>>> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Xu,
>> Qian
>>>> Q <qian.q.xu@intel.com>; Thomas Monjalon <thomas@monjalon.net>;
>> Peng,
>>>> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan
>> <zhaoyan.chen@intel.com>;
>>>> dev@dpdk.org
>>>> Subject: Re: 21.11.4 patches review and test
>>>>
>>>> On 04/05/2023 03:13, Xu, HailinX wrote:
>>>>>> -----Original Message-----
>>>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>>>> Sent: Tuesday, May 2, 2023 5:35 PM
>>>>>> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
>>>>>> Cc: Stokes, Ian <ian.stokes@intel.com>; Mcnamara, John
>>>>>> <john.mcnamara@intel.com>; Luca Boccassi <bluca@debian.org>; Xu,
>>>>>> Qian Q <qian.q.xu@intel.com>; Thomas Monjalon
>>>>>> <thomas@monjalon.net>;
>>>> Peng,
>>>>>> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan
>> <zhaoyan.chen@intel.com>;
>>>>>> dev@dpdk.org
>>>>>> Subject: Re: 21.11.4 patches review and test
>>>>>>
>>>>>> On 20/04/2023 11:32, Kevin Traynor wrote:
>>>>>>> On 20/04/2023 03:40, Xu, HailinX wrote:
>>>>>>>>> -----Original Message-----
>>>>>>>>> From: Xu, HailinX <hailinx.xu@intel.com>
>>>>>>>>> Sent: Thursday, April 13, 2023 2:13 PM
>>>>>>>>> To: Kevin Traynor <ktraynor@redhat.com>; stable@dpdk.org
>>>>>>>>> Cc: dev@dpdk.org; Abhishek Marathe
>>>>>> <Abhishek.Marathe@microsoft.com>;
>>>>>>>>> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
>>>>>>>>> <benjamin.walker@intel.com>; David Christensen
>>>>>>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
>>>>>> <hemant.agrawal@nxp.com>;
>>>>>>>>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
>>>>>>>>> <jerinj@marvell.com>; Mcnamara, John
>> <john.mcnamara@intel.com>;
>>>>>>>>> Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi
>>>>>>>>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu, Qian
>> Q
>>>>>>>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
>>>>>> Thomas
>>>>>>>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng,
>> Yuan
>>>>>>>>> <yuan.peng@intel.com>; Chen, Zhaoyan
>> <zhaoyan.chen@intel.com>
>>>>>>>>> Subject: RE: 21.11.4 patches review and test
>>>>>>>>>
>>>>>>>>>> -----Original Message-----
>>>>>>>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>>>>>>>> Sent: Thursday, April 6, 2023 7:38 PM
>>>>>>>>>> To: stable@dpdk.org
>>>>>>>>>> Cc: dev@dpdk.org; Abhishek Marathe
>>>>>>>>>> <Abhishek.Marathe@microsoft.com>; Ali Alnubani
>>>>>>>>>> <alialnu@nvidia.com>; Walker, Benjamin
>>>>>>>>>> <benjamin.walker@intel.com>; David Christensen
>>>>>>>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
>>>>>>>>>> <hemant.agrawal@nxp.com>; Stokes, Ian
>> <ian.stokes@intel.com>;
>>>>>>>>>> Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
>>>>>>>>>> <john.mcnamara@intel.com>; Ju-Hyoung Lee
>>>> <juhlee@microsoft.com>;
>>>>>>>>>> Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi
>>>>>>>>>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Xu,
>> Qian Q
>>>>>>>>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@nvidia.com>;
>>>>>>>>> Thomas
>>>>>>>>>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Peng,
>> Yuan
>>>>>>>>>> <yuan.peng@intel.com>; Chen, Zhaoyan
>> <zhaoyan.chen@intel.com>
>>>>>>>>>> Subject: 21.11.4 patches review and test
>>>>>>>>>>
>>>>>>>>>> Hi all,
>>>>>>>>>>
>>>>>>>>>> Here is a list of patches targeted for stable release 21.11.4.
>>>>>>>>>>
>>>>>>>>>> The planned date for the final release is 25th April.
>>>>>>>>>>
>>>>>>>>>> Please help with testing and validation of your use cases and
>>>>>>>>>> report any issues/results with reply-all to this mail. For the
>>>>>>>>>> final release the fixes and reported validations will be added
>>>>>>>>>> to the
>>>>>> release notes.
>>>>>>>>>>
>>>>>>>>>> A release candidate tarball can be found at:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.4-rc1
>>>>>>>>>>
>>>>>>>>>> These patches are located at branch 21.11 of dpdk-stable repo:
>>>>>>>>>>          https://dpdk.org/browse/dpdk-stable/
>>>>>>>>>>
>>>>>>>>>> Thanks.
>>>>>>>>>>
>>>>>>>>>> Kevin
>>>>>>>>>
>>>>>>>>> HI All,
>>>>>>>>>
>>>>>>>>> Update the test status for Intel part. Till now dpdk21.11.4-rc1
>>>>>>>>> validation test rate is 85%. No critical issue is found.
>>>>>>>>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
>>>>>>>>> New bugs:   --20.11.8-rc1 also has these two issues
>>>>>>>>>        1.
>>>>>>
>> pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
>>>>>>>>> performance drop about 23.5% when send small packets
>>>>>>>>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212    -- no fix yet
>>>>>>>>>        2. some of the virtio tests are failing:    -- Intel dev is under
>>>>>> investigating
>>>>>>>>> # Basic Intel(R) NIC testing
>>>>>>>>> * Build & CFLAG compile: cover the build test combination with
>>>>>>>>> latest GCC/Clang version and the popular OS revision such as
>>>>>>>>>        Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6,
>>>>>>>>> RHEL8.4, FreeBSD13.1, SUSE15, CentOS7.9, etc.
>>>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>>>> * PF(i40e, ixgbe): test scenarios including
>>>>>>>>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>>>> * VF(i40e, ixgbe): test scenarios including
>>>>>>>>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN,
>> etc.
>>>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>>>> * PF/VF(ice): test scenarios including Switch features/Package
>>>>>>>>> Management/Flow Director/Advanced Tx/Advanced
>>>> RSS/ACL/DCF/Flexible
>>>>>>>>> Descriptor, etc.
>>>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>>>> * Intel NIC single core/NIC performance: test scenarios
>>>>>>>>> including PF/VF single core performance test, etc.
>>>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>>>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library
>>>>>>>>> basic test - QAT&SW/FIB library, etc.
>>>>>>>>> - On going.
>>>>>>>>>
>>>>>>>>> # Basic cryptodev and virtio testing
>>>>>>>>> * Virtio: both function and performance test are covered. Such
>>>>>>>>> as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM
>>>>>>>>> perf testing/VMAWARE ESXI 8.0, etc.
>>>>>>>>> - All test done. found bug1.
>>>>>>>>> * Cryptodev:
>>>>>>>>>        *Function test: test scenarios including Cryptodev API
>>>>>>>>> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>>>>>>>>>          - Execution rate is 90%. found bug2.
>>>>>>>>>        *Performance test: test scenarios including Thoughput
>>>>>>>>> Performance/Cryptodev Latency, etc.
>>>>>>>>>          - All test done. No new dpdk issue is found.
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Xu, Hailin
>>>>>>>> Update the test status for Intel part. completed dpdk21.11.4-rc1
>>>>>>>> all
>>>>>> validation. No critical issue is found.
>>>>>>>
>>>>>>> Hi. Thanks for testing.
>>>>>>>
>>>>>>>> 2 new bugs are found, 1 new issue is under confirming by Intel Dev.
>>>>>>>> New bugs: --20.11.8-rc1 also has these two issues
>>>>>>>>        1.
>>>>>>
>> pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac:
>>>>>> performance drop about 23.5% when send small packets
>>>>>>>> 	https://bugs.dpdk.org/show_bug.cgi?id=1212  --not fix yet,
>> Only
>>>>>>>> the specified platform exists
>>>>>>>
>>>>>>> Do you know which patch caaused the regression? I'm not fully
>>>>>>> clear from the Bz for 20.11. The backported patch ID'd as root
>>>>>>> cause [0] in
>>>>>>> 20.11 is in the previous releases of 20.11 (and 21.11).
>>>>>>>
>>>>>>> Trying to understand because then it would have shown in testing
>>>>>>> for previous releases. Or is this a new test introduced for latest
>>>>>>> LTS releases? and if so, what is the baseline performance based on?
>>>>>>>
>>>>>>> [0]
>>>>>>> commit 1c9a7fba5c90e0422b517404499ed106f647bcff
>>>>>>> Author: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>>>>>>> Date:   Mon Jul 11 14:11:32 2022 +0200
>>>>>>>
>>>>>>>          net: accept unaligned data in checksum routines
>>>>>>>
>>>>>>>>        2. some of the virtio tests are failing: -- Intel dev is
>>>>>>>> under investigating
>>>>>>>
>>>>>>> ok, thank you.
>>>>>>>
>>>>>>
>>>>>> Hi, it was mentioned in a separate mail that the performance drop
>>>>>> issue was not the same as 20.11.
>>>>>>
>>>>>> Is there any update on that and the failing virtio tests ? Is there
>>>>>> a regression introduced since in 21.11.4 ?
>>>>>
>>>>> Found bad commit id:
>>>>> commit c41493361c87e730459ead9311c68528eb0874aa
>>>>> Author: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
>>>>> Date:   Fri Mar 3 14:19:29 2023 +0300
>>>>>        net/virtio: deduce IP length for TSO checksum
>>>>>
>>>>> We try this issue on 3 different platforms Performance drop only
>>>>> found on Intel(R) Xeon(R) Platinum 8280M CPU @ 2.70GHz CPU.
>>>>>
>>>>
>>>> Ok, thanks for reporting. This commit was also in 23.03 and 20.11.8
>>>> so not sure if they were tested on this platform?
>>>>
>>> Yes, But 23.03 doesn't have such issue on the same platform
>>>
>>
>> ok, thanks.
>>
>>>> This commit fixes a functional issue, so I don't think it should be
>>>> removed unless it is critical issue.
>>>>
>>>> There's no update on other performance report. Release is already 1
>>>> week overdue, is there critical issues that we should hold release for?
>>>>
>>> No other issues found
>>>
>>
>> I'm not fully clear on the status, so let's separate. There were two reported
>> issues.
>>
>> 1. Performance drop on specific Intel platform.
>> - Is this being investigated by Intel dev?
>> - Is it is a release blocking issue ?
>>
>> 2. Virtio issue caused by
>>
>> commit c41493361c87e730459ead9311c68528eb0874aa
>> Author: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
>> Date:   Fri Mar 3 14:19:29 2023 +0300
>>          net/virtio: deduce IP length for TSO checksum
>>
>> - Is this being investigated by Intel dev?
>> - Is it is a release blocking issue ?
>>
>> thanks,
>> Kevin.
>>
> Hi Kevin,
> 

Hi Yu Jang,

Thanks for the information.

> I need correct/clarify the description of the two issues:
> 1, Performance drop on specific Intel platform -> should be pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac: Benchmark pvp performance drop about 23.5% when send small packets"
> Its bad commit id:
> commit c41493361c87e730459ead9311c68528eb0874aa
> Author: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
> Date:   Fri Mar 3 14:19:29 2023 +0300
> 
>      net/virtio: deduce IP length for TSO checksum
> 
>      [ upstream commit d069c80a5d8c0a05033932421851cdb7159de0df ]
> 
>      The length of TSO payload could not fit into 16 bits provided by the
>      IPv4 total length and IPv6 payload length fields. Thus, deduce it
>      from the length of the packet.
> 
>      Fixes: 696573046e9e ("net/virtio: support TSO")
> 
>      Signed-off-by: Boleslav Stankevich <boleslav.stankevich@oktetlabs.ru>
>      Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>      Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Intel validation owner has done lots of verification and compared these performance data on 8280&8380 platforms.
> This performance big drop is only found on special platform (Intel(R) Xeon(R) Platinum 8280M CPU @ 2.70GHz CPU) when vhost-user(back-end)
> and virtio-pmd(front-end) are not on the same socket (front-end is on the socket1, back-end and nic are on the socket0).
> But our test case doesn't call this bad commit id's related code, suspect whether it may be related to compiler optimization on special platform.
> We hope the bad commit id owner or other experts can support to analysis the root cause.
> 

ok, for this one, it is a performance drop on a single test on a 
specific Intel platform and inter-socket related. It does not appear to 
be related to the commit being ID'd. To revert the commit would 
re-introduce a functional issue.

> 2, Virtio issue -> should be virtio crypto test failure.
> It is not a regression issue, old lts and main branch also reproduce by validation owner, and there's no clear bad commit id found.
> Intel dev and validation owner are investigating it, but we don't find out the root cause yet.
> 

ok, this is not a regression in 21.11.4.

On that basis, I will go ahead with the 21.11.4 release tomorrow. If 
there's any objection please let me know by end of day today.

thanks,
Kevin.

> Best regards,
> Yu Jiang
> 
>>> Regards,
>>> Xu, Hailin
>>>
>>>> thanks,
>>>> Kevin.
>>>>
>>>>> Regards,
>>>>> Xu, Hailin
>>>>>
>>>>>>
>>>>>> thanks,
>>>>>> Kevin,
>>>>>>
>>>>>>> Kevin.
>>>>>>>
>>>>>>>> # Basic Intel(R) NIC testing
>>>>>>>> * Build & CFLAG compile: cover the build test combination with
>>>>>>>> latest
>>>>>> GCC/Clang version and the popular OS revision such as
>>>>>>>>        Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora37, RHEL8.6,
>>>>>>>> RHEL8.4,
>>>>>> FreeBSD13.1, SUSE15, CentOS7.9, etc.
>>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>>> * PF(i40e, ixgbe): test scenarios including
>>>>>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>>> * VF(i40e, ixgbe): test scenarios including
>>>>>> VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>>> * PF/VF(ice): test scenarios including Switch features/Package
>>>>>> Management/Flow Director/Advanced Tx/Advanced
>> RSS/ACL/DCF/Flexible
>>>>>> Descriptor, etc.
>>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>>> * Intel NIC single core/NIC performance: test scenarios including
>>>>>>>> PF/VF
>>>>>> single core performance test, etc.
>>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library
>>>>>>>> basic test -
>>>>>> QAT&SW/FIB library, etc.
>>>>>>>> - All test done. No new dpdk issue is found.
>>>>>>>>
>>>>>>>> # Basic cryptodev and virtio testing
>>>>>>>> * Virtio: both function and performance test are covered. Such as
>>>>>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
>>>>>> testing/VMAWARE ESXI 8.0, etc.
>>>>>>>> - All test done. found bug1.
>>>>>>>> * Cryptodev:
>>>>>>>>        *Function test: test scenarios including Cryptodev API
>>>>>> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>>>>>>>>          - All test done. found bug2.
>>>>>>>>        *Performance test: test scenarios including Thoughput
>>>>>> Performance/Cryptodev Latency, etc.
>>>>>>>>          - All test done. No new dpdk issue is found.
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Xu, Hailin
>>>>>>>>
>>>>>>>
>>>>>
>>>
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2023-05-16  8:42 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-06 11:37 21.11.4 patches review and test Kevin Traynor
2023-04-13  6:12 ` Xu, HailinX
2023-04-19 11:00   ` YangHang Liu
2023-04-19 14:21     ` Kevin Traynor
2023-04-20  2:40   ` Xu, HailinX
2023-04-20 10:32     ` Kevin Traynor
2023-05-02  9:35       ` Kevin Traynor
2023-05-04  2:13         ` Xu, HailinX
2023-05-04 10:10           ` Kevin Traynor
2023-05-05  1:42             ` Xu, HailinX
2023-05-08 15:23               ` Kevin Traynor
2023-05-11  7:33                 ` Jiang, YuX
2023-05-16  8:41                   ` Kevin Traynor
2023-04-19 13:24 ` Ali Alnubani
2023-04-19 14:21   ` Kevin Traynor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).