From: Luca Boccassi <bluca@debian.org>
To: Ori Kam <orika@mellanox.com>,
David Christensen <drc@linux.vnet.ibm.com>,
Beilei Xing <beilei.xing@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>, Matan Azrad <matan@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 19.11] eal/ppc: fix bool type after altivec include
Date: Mon, 01 Jun 2020 11:07:15 +0100 [thread overview]
Message-ID: <652e8efbfbefc802ae148ef869a2ef11ff4f0939.camel@debian.org> (raw)
In-Reply-To: <1590939369-60764-1-git-send-email-orika@mellanox.com>
On Sun, 2020-05-31 at 15:36 +0000, Ori Kam wrote:
> [ upstream commit f5bf02df3145f95b1ee8ed9dee67f4222ac42c8c ]
>
> The AltiVec header file breaks boolean type. [1] [2]
>
> Currently the workaround was located only in mlx5 device.
> Adding the trace module caused this issue to appear again, due to
> order of includes, it keeps overriding the local fix.
>
> This patch solves this issue by resetting the bool type, immediately
> after it is being changed.
>
> [1] https://mails.dpdk.org/archives/dev/2018-August/110281.html
This patch breaks all ppc64 builds:
[ 136s] In file included from /home/abuild/rpmbuild/BUILD/dpdk-1591003733.2dff15dd5/lib/librte_eal/common/eal_common_options.c:27:
[ 136s] /home/abuild/rpmbuild/BUILD/dpdk-1591003733.2dff15dd5/ppc_64-power8-linux-gcc/include/rte_memcpy.h:12:10: fatal error: rte_altivec.h: No such file or directory
[ 136s] #include "rte_altivec.h"
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2020-06-01 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 15:36 Ori Kam
2020-06-01 10:07 ` Luca Boccassi [this message]
2020-06-02 11:27 ` Ori Kam
2020-06-02 13:29 ` Luca Boccassi
2020-06-02 14:13 ` Ori Kam
2020-06-02 14:25 ` David Marchand
2020-06-03 8:46 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=652e8efbfbefc802ae148ef869a2ef11ff4f0939.camel@debian.org \
--to=bluca@debian.org \
--cc=beilei.xing@intel.com \
--cc=drc@linux.vnet.ibm.com \
--cc=matan@mellanox.com \
--cc=maxime.coquelin@redhat.com \
--cc=orika@mellanox.com \
--cc=qi.z.zhang@intel.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=viacheslavo@mellanox.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).