From: "lihuisong (C)" <lihuisong@huawei.com> To: "Xueming(Steven) Li" <xuemingl@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org> Cc: "fengchengwen@huawei.com" <fengchengwen@huawei.com> Subject: Re: [PATCH 20.11 V2 1/2] net/hns3: fix residual MAC after setting default MAC Date: Mon, 6 Dec 2021 14:11:16 +0800 Message-ID: <9ad416cc-dd37-772c-9959-99a9bf2cb067@huawei.com> (raw) In-Reply-To: <51e73446d5611e014fe87104a90853e489a6680a.camel@nvidia.com> 在 2021/11/27 21:55, Xueming(Steven) Li 写道: > On Sat, 2021-11-13 at 17:17 +0800, Huisong Li wrote: >> [ upstream commit 19e67d8ebced5cb12829f75c70e6c497b5925e82 ] >> >> This problem occurs in the following scenarios: >> 1) reset is encountered when the adapter is running. >> 2) set a new default MAC address >> >> After the above two steps, the old default MAC address should be not >> take effect. But the current behavior is contrary to that. This is due >> to the change of the "default_addr_setted" in hw->mac from 'true' to >> 'false' after the reset. As a result, the old MAC address is not removed >> when the new default MAC address is set. This variable controls whether >> to delete the old default MAC address when setting the default MAC >> address. It is only used when the mac_addr_set API is called for the >> first time. In fact, when a unicast MAC address is deleted, if the >> address isn't in the MAC address table, the driver doesn't return >> failure. So this patch remove the redundant and troublesome variables to >> resolve this problem. >> >> Fixes: 7d7f9f80bbfb ("net/hns3: support MAC address related operations") >> >> Signed-off-by: Huisong Li <lihuisong@huawei.com> >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> >> --- > Applied to 20.11.4 list. > > One trailing tab removed, please run checkpatch next time :) ok,thanks😅 > > Best Regards, > Xueming Li
next prev parent reply other threads:[~2021-12-06 6:11 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-13 8:34 [PATCH V1 0/2] net/hns3: backport two patches to 20.11.4 Huisong Li 2021-11-13 8:34 ` [PATCH V1 1/2] net/hns3: fix residual MAC after setting default MAC Huisong Li 2021-11-13 8:34 ` [PATCH V1 2/2] net/hns3: fix interrupt vector freeing Huisong Li 2021-11-13 9:02 ` [PATCH V1 0/2][20.11] net/hns3: backport two patches to 20.11.4 Xueming(Steven) Li 2021-11-13 9:17 ` [PATCH 20.11 V2 0/2] " Huisong Li 2021-11-13 9:17 ` [PATCH 20.11 V2 1/2] net/hns3: fix residual MAC after setting default MAC Huisong Li 2021-11-27 13:55 ` Xueming(Steven) Li 2021-12-06 6:11 ` lihuisong (C) [this message] 2021-11-13 9:17 ` [PATCH 20.11 V2 2/2] net/hns3: fix interrupt vector freeing Huisong Li 2021-11-27 13:56 ` Xueming(Steven) Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9ad416cc-dd37-772c-9959-99a9bf2cb067@huawei.com \ --to=lihuisong@huawei.com \ --cc=fengchengwen@huawei.com \ --cc=stable@dpdk.org \ --cc=xuemingl@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git