From: "Zhou, JunX W" <junx.w.zhou@intel.com>
To: "Xu, Ting" <ting.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] lib/table: fix cache alignment issue
Date: Thu, 2 Jul 2020 08:06:35 +0000
Message-ID: <EDA4914C4BAB5848BD29F696B5FE612D0445E7A8@CDSMSX102.ccr.corp.intel.com> (raw)
In-Reply-To: <20200617054355.7895-1-ting.xu@intel.com>
Tested-by: junx.w.zhou@intel.com
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ting Xu
Sent: Wednesday, June 17, 2020 1:44 PM
To: dev@dpdk.org
Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] lib/table: fix cache alignment issue
When create softnic hash table with 16 keys, it failed on 32bit environment because of the structure rte_bucket_4_16 alignment issue. Add __rte_cache_aligned to ensure correct cache align.
Fixes: 8aa327214c ("table: hash")
Cc: stable@dpdk.org
Signed-off-by: Ting Xu <ting.xu@intel.com>
---
v1->v2: Correct patch time
---
lib/librte_table/rte_table_hash_key16.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_table/rte_table_hash_key16.c b/lib/librte_table/rte_table_hash_key16.c
index 2cca1c924..5e1665c15 100644
--- a/lib/librte_table/rte_table_hash_key16.c
+++ b/lib/librte_table/rte_table_hash_key16.c
@@ -44,7 +44,7 @@ struct rte_bucket_4_16 {
uint64_t key[4][2];
/* Cache line 2 */
- uint8_t data[0];
+ uint8_t data[0] __rte_cache_aligned;
};
struct rte_table_hash {
--
2.17.1
next prev parent reply index
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 16:27 [dpdk-stable] [PATCH v1] " Ting Xu
2020-06-17 5:43 ` [dpdk-stable] [PATCH v2] " Ting Xu
2020-07-02 8:06 ` Zhou, JunX W [this message]
2020-07-09 1:48 ` [dpdk-stable] [PATCH v3] " Ting Xu
2020-07-20 14:37 ` Dumitrescu, Cristian
2020-07-21 5:15 ` Xu, Ting
2020-07-21 21:16 ` Dumitrescu, Cristian
2020-07-22 2:16 ` Xu, Ting
2020-07-22 2:16 ` [dpdk-stable] [PATCH v4] " Ting Xu
2020-07-22 8:26 ` Dumitrescu, Cristian
2020-07-22 8:30 ` Xu, Ting
2020-07-22 8:49 ` Dumitrescu, Cristian
2020-07-22 8:48 ` Dumitrescu, Cristian
2020-07-29 12:01 ` [dpdk-stable] [dpdk-dev] " David Marchand
2020-07-29 13:13 ` Dumitrescu, Cristian
2020-07-29 13:28 ` David Marchand
2020-07-29 13:54 ` Dumitrescu, Cristian
2020-07-29 13:59 ` David Marchand
2020-07-29 14:53 ` Dumitrescu, Cristian
2020-07-30 6:57 ` Xu, Ting
2020-07-30 10:35 ` Kevin Traynor
2020-09-09 6:18 ` Xu, Ting
2020-09-15 8:03 ` David Marchand
2020-10-14 8:26 ` Xu, Ting
2020-10-14 13:53 ` David Marchand
Reply instructions:
You may reply publically to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EDA4914C4BAB5848BD29F696B5FE612D0445E7A8@CDSMSX102.ccr.corp.intel.com \
--to=junx.w.zhou@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=ting.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
patches for DPDK stable branches
Archives are clonable:
git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
stable@dpdk.org
public-inbox-index stable
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.stable
AGPL code for this site: git clone https://public-inbox.org/ public-inbox