[PATCH v8 1/3] app/testpmd: fix the testpmd field string sequence

[PATCH v8 1/3] app/testpmd: fix the testpmd field string sequence

[Rongwei Liu]

The field string should be in the same order as the rte_flow_field_id
enumration definitions

Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields")
Cc: michaelba@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 60ee9337cf..775ce20fc4 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -1002,10 +1002,10 @@ static const char *const flow_field_ids[] = {
 	"hash_result",
 	"geneve_opt_type", "geneve_opt_class", "geneve_opt_data", "mpls",
 	"tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len",
-	"random",
 	"ipv4_proto",
-	"esp_spi", "esp_seq_num", "esp_proto",
 	"ipv6_flow_label", "ipv6_traffic_class",
+	"esp_spi", "esp_seq_num", "esp_proto",
+	"random",
 	NULL
 };
 
-- 
2.27.0

RE: [PATCH v8 1/3] app/testpmd: fix the testpmd field string sequence

[Ori Kam]

> -----Original Message-----
> From: rongwei liu <rongweil@nvidia.com>
> Sent: Friday, June 7, 2024 5:02 PM
> 
> The field string should be in the same order as the rte_flow_field_id
> enumration definitions
> 
> Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields")
> Cc: michaelba@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> ---

Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori

Re: [PATCH v8 1/3] app/testpmd: fix the testpmd field string sequence

[Ferruh Yigit]

On 6/7/2024 3:02 PM, Rongwei Liu wrote:
> The field string should be in the same order as the rte_flow_field_id
> enumration definitions
> 
> Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields")
> Cc: michaelba@nvidia.com
> Cc: stable@dpdk.org
> 

 Fixes: d66aa38f431d ("ethdev: allow modifying IPsec fields")
 Fixes: b160da13b398 ("ethdev: allow modifying IPv4 next protocol field")

Above can be because of merge conflict, I didn't investigate in depth.

> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> ---
>  app/test-pmd/cmdline_flow.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 60ee9337cf..775ce20fc4 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -1002,10 +1002,10 @@ static const char *const flow_field_ids[] = {
>  	"hash_result",
>  	"geneve_opt_type", "geneve_opt_class", "geneve_opt_data", "mpls",
>  	"tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len",
> -	"random",
>  	"ipv4_proto",
> -	"esp_spi", "esp_seq_num", "esp_proto",
>  	"ipv6_flow_label", "ipv6_traffic_class",
> +	"esp_spi", "esp_seq_num", "esp_proto",
> +	"random",
>  	NULL
>  };
>