* Re: [dpdk-stable] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2
@ 2019-09-11 10:38 Jerin Jacob Kollanukkaran
2019-09-12 14:42 ` Honnappa Nagarahalli
0 siblings, 1 reply; 5+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-09-11 10:38 UTC (permalink / raw)
To: Gavin Hu, dev
Cc: nd, thomas, hemant.agrawal, Pavan Nikhilesh Bhagavatula,
Honnappa.Nagarahalli, stable
> -----Original Message-----
> From: Gavin Hu <gavin.hu@arm.com>
> Sent: Thursday, August 1, 2019 5:18 AM
> To: dev@dpdk.org
> Cc: nd@arm.com; thomas@monjalon.net; hemant.agrawal@nxp.com; Jerin
> Jacob Kollanukkaran <jerinj@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Honnappa.Nagarahalli@arm.com;
> stable@dpdk.org
> Subject: [EXT] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2
>
> With "-march=armv8.2-a" specified, a compiling error generated:
> app/test/test_rcu_qsbr.c:234:10: error: comparison of integer expressions of
> different signedness: ‘unsigned int’ and ‘int’
> [-Werror=sign-compare]
>
> Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Steve Capper <steve.capper@arm.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> ---
> app/test/test_rcu_qsbr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index
> 1d273e3..b008c9d 100644
> --- a/app/test/test_rcu_qsbr.c
> +++ b/app/test/test_rcu_qsbr.c
> @@ -231,7 +231,7 @@ test_rcu_qsbr_thread_unregister(void)
> /* Update quiescent state counter */
> for (i = 0; i < num_threads[j]; i++) {
> /* Skip one update */
> - if (i == (RTE_MAX_LCORE - 10))
> + if (i == (unsigned int)(RTE_MAX_LCORE - 10))
> continue;
> rte_rcu_qsbr_quiescent(t[0],
> (j == 2) ? (RTE_MAX_LCORE - 1) : i);
> --
> 2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2
2019-09-11 10:38 [dpdk-stable] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2 Jerin Jacob Kollanukkaran
@ 2019-09-12 14:42 ` Honnappa Nagarahalli
2019-09-13 15:28 ` Gavin Hu (Arm Technology China)
0 siblings, 1 reply; 5+ messages in thread
From: Honnappa Nagarahalli @ 2019-09-12 14:42 UTC (permalink / raw)
To: jerinj, Gavin Hu (Arm Technology China), dev
Cc: nd, thomas, hemant.agrawal, Pavan Nikhilesh Bhagavatula, stable,
Honnappa Nagarahalli, nd
<snip>
> > Subject: [EXT] [PATCH v2 1/3] test/rcu: fix the compiling error for
> > armv8.2
> >
> > With "-march=armv8.2-a" specified, a compiling error generated:
> > app/test/test_rcu_qsbr.c:234:10: error: comparison of integer
> > expressions of different signedness: ‘unsigned int’ and ‘int’
> > [-Werror=sign-compare]
> >
> > Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Steve Capper <steve.capper@arm.com>
>
>
> Reviewed-by: Jerin Jacob <jerinj@marvell.com>
This should be fixed already due to commit 104dbec2081.
Gavin, can you please verify? If yes, we can skip this patch.
>
>
> > ---
> > app/test/test_rcu_qsbr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index
> > 1d273e3..b008c9d 100644
> > --- a/app/test/test_rcu_qsbr.c
> > +++ b/app/test/test_rcu_qsbr.c
> > @@ -231,7 +231,7 @@ test_rcu_qsbr_thread_unregister(void)
> > /* Update quiescent state counter */
> > for (i = 0; i < num_threads[j]; i++) {
> > /* Skip one update */
> > - if (i == (RTE_MAX_LCORE - 10))
> > + if (i == (unsigned int)(RTE_MAX_LCORE - 10))
> > continue;
> > rte_rcu_qsbr_quiescent(t[0],
> > (j == 2) ? (RTE_MAX_LCORE - 1) : i);
> > --
> > 2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2
2019-09-12 14:42 ` Honnappa Nagarahalli
@ 2019-09-13 15:28 ` Gavin Hu (Arm Technology China)
2019-09-13 15:36 ` Honnappa Nagarahalli
0 siblings, 1 reply; 5+ messages in thread
From: Gavin Hu (Arm Technology China) @ 2019-09-13 15:28 UTC (permalink / raw)
To: Honnappa Nagarahalli, jerinj, dev
Cc: nd, thomas, hemant.agrawal, Pavan Nikhilesh Bhagavatula, stable, nd
Hi Honnappa,
> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: Thursday, September 12, 2019 10:43 PM
> To: jerinj@marvell.com; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>; dev@dpdk.org
> Cc: nd <nd@arm.com>; thomas@monjalon.net; hemant.agrawal@nxp.com;
> Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; stable@dpdk.org;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
> Subject: RE: [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2
>
> <snip>
>
> > > Subject: [EXT] [PATCH v2 1/3] test/rcu: fix the compiling error for
> > > armv8.2
> > >
> > > With "-march=armv8.2-a" specified, a compiling error generated:
> > > app/test/test_rcu_qsbr.c:234:10: error: comparison of integer
> > > expressions of different signedness: ‘unsigned int’ and ‘int’
> > > [-Werror=sign-compare]
> > >
> > > Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > > Reviewed-by: Steve Capper <steve.capper@arm.com>
> >
> >
> > Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> This should be fixed already due to commit 104dbec2081.
> Gavin, can you please verify? If yes, we can skip this patch.
No, just ran and the issue persisted with the above commit in place.
I see the above commit was to fix a limited range of data type issue, this commit is to fix a signedness issue.
~/dpdk/app/test/test_rcu_qsbr.c: In function ‘test_rcu_qsbr_thread_unregister’:
~/dpdk/app/test/test_rcu_qsbr.c:233:10: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Werror=sign-compare]
if (i == (RTE_MAX_LCORE - 10))
>
> >
> >
> > > ---
> > > app/test/test_rcu_qsbr.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index
> > > 1d273e3..b008c9d 100644
> > > --- a/app/test/test_rcu_qsbr.c
> > > +++ b/app/test/test_rcu_qsbr.c
> > > @@ -231,7 +231,7 @@ test_rcu_qsbr_thread_unregister(void)
> > > /* Update quiescent state counter */
> > > for (i = 0; i < num_threads[j]; i++) {
> > > /* Skip one update */
> > > -if (i == (RTE_MAX_LCORE - 10))
> > > +if (i == (unsigned int)(RTE_MAX_LCORE - 10))
> > > continue;
> > > rte_rcu_qsbr_quiescent(t[0],
> > > (j == 2) ? (RTE_MAX_LCORE - 1) : i);
> > > --
> > > 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2
2019-09-13 15:28 ` Gavin Hu (Arm Technology China)
@ 2019-09-13 15:36 ` Honnappa Nagarahalli
0 siblings, 0 replies; 5+ messages in thread
From: Honnappa Nagarahalli @ 2019-09-13 15:36 UTC (permalink / raw)
To: Gavin Hu (Arm Technology China), jerinj, dev
Cc: nd, thomas, hemant.agrawal, Pavan Nikhilesh Bhagavatula, stable, nd, nd
> > <snip>
> >
> > > > Subject: [EXT] [PATCH v2 1/3] test/rcu: fix the compiling error
> > > > for
> > > > armv8.2
> > > >
> > > > With "-march=armv8.2-a" specified, a compiling error generated:
> > > > app/test/test_rcu_qsbr.c:234:10: error: comparison of integer
> > > > expressions of different signedness: ‘unsigned int’ and ‘int’
> > > > [-Werror=sign-compare]
> > > >
> > > > Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > > > Reviewed-by: Steve Capper <steve.capper@arm.com>
> > >
> > >
> > > Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> > This should be fixed already due to commit 104dbec2081.
> > Gavin, can you please verify? If yes, we can skip this patch.
> No, just ran and the issue persisted with the above commit in place.
> I see the above commit was to fix a limited range of data type issue, this
> commit is to fix a signedness issue.
> ~/dpdk/app/test/test_rcu_qsbr.c: In function
> ‘test_rcu_qsbr_thread_unregister’:
> ~/dpdk/app/test/test_rcu_qsbr.c:233:10: error: comparison of integer
> expressions of different signedness: ‘unsigned int’ and ‘int’ [-Werror=sign-
> compare]
> if (i == (RTE_MAX_LCORE - 10))
Ok, it is the right side of the 'if' (not the left side).
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> >
> > >
> > >
> > > > ---
> > > > app/test/test_rcu_qsbr.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c
> > > > index 1d273e3..b008c9d 100644
> > > > --- a/app/test/test_rcu_qsbr.c
> > > > +++ b/app/test/test_rcu_qsbr.c
> > > > @@ -231,7 +231,7 @@ test_rcu_qsbr_thread_unregister(void)
> > > > /* Update quiescent state counter */ for (i = 0; i <
> > > > num_threads[j]; i++) {
> > > > /* Skip one update */
> > > > -if (i == (RTE_MAX_LCORE - 10))
> > > > +if (i == (unsigned int)(RTE_MAX_LCORE - 10))
> > > > continue;
> > > > rte_rcu_qsbr_quiescent(t[0],
> > > > (j == 2) ? (RTE_MAX_LCORE - 1) : i);
> > > > --
> > > > 2.7.4
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-stable] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2
2019-07-31 23:32 ` [dpdk-stable] [PATCH 1/2] " Gavin Hu
@ 2019-07-31 23:48 ` Gavin Hu
0 siblings, 0 replies; 5+ messages in thread
From: Gavin Hu @ 2019-07-31 23:48 UTC (permalink / raw)
To: dev
Cc: nd, thomas, hemant.agrawal, jerinj, pbhagavatula,
Honnappa.Nagarahalli, stable
With "-march=armv8.2-a" specified, a compiling error generated:
app/test/test_rcu_qsbr.c:234:10: error: comparison of integer
expressions of different signedness: ‘unsigned int’ and ‘int’
[-Werror=sign-compare]
Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
Cc: stable@dpdk.org
Signed-off-by: Gavin Hu <gavin.hu@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Steve Capper <steve.capper@arm.com>
---
app/test/test_rcu_qsbr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c
index 1d273e3..b008c9d 100644
--- a/app/test/test_rcu_qsbr.c
+++ b/app/test/test_rcu_qsbr.c
@@ -231,7 +231,7 @@ test_rcu_qsbr_thread_unregister(void)
/* Update quiescent state counter */
for (i = 0; i < num_threads[j]; i++) {
/* Skip one update */
- if (i == (RTE_MAX_LCORE - 10))
+ if (i == (unsigned int)(RTE_MAX_LCORE - 10))
continue;
rte_rcu_qsbr_quiescent(t[0],
(j == 2) ? (RTE_MAX_LCORE - 1) : i);
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-13 15:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 10:38 [dpdk-stable] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2 Jerin Jacob Kollanukkaran
2019-09-12 14:42 ` Honnappa Nagarahalli
2019-09-13 15:28 ` Gavin Hu (Arm Technology China)
2019-09-13 15:36 ` Honnappa Nagarahalli
[not found] <1564616902-13861-1-git-send-email-gavin.hu@arm.com>
2019-07-31 23:32 ` [dpdk-stable] [PATCH 1/2] " Gavin Hu
2019-07-31 23:48 ` [dpdk-stable] [PATCH v2 1/3] " Gavin Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).