From: Ferruh Yigit <ferruh.yigit@xilinx.com> To: "Min Hu (Connor)" <humin29@huawei.com>, <dev@dpdk.org> Cc: Huisong Li <lihuisong@huawei.com>, <stable@dpdk.org>, Chas Williams <chas3@att.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru> Subject: Re: [PATCH V2 2/4] net/bonding: fix non-terminable while loop Date: Tue, 26 Apr 2022 19:19:44 +0100 Message-ID: <c79ea0bc-7c3a-607b-5117-def93b9b1ddd@xilinx.com> (raw) In-Reply-To: <20220324030036.4761-3-humin29@huawei.com> On 3/24/2022 3:00 AM, Min Hu (Connor) wrote: > From: Huisong Li <lihuisong@huawei.com> > > All slaves will be stopped and removed when closing a bonded port. But the > while loop can not stop if both rte_eth_dev_stop and > rte_eth_bond_slave_remove fail to run. > Agree that this is a defect introduced in below commit. Thanks for the fix. > Fixes: fb0379bc5db3 ("net/bonding: check stop call status") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li <lihuisong@huawei.com> > Signed-off-by: Min Hu (Connor) <humin29@huawei.com> > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index 469dc71170..00d4deda44 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -2149,13 +2149,14 @@ bond_ethdev_close(struct rte_eth_dev *dev) > return 0; > > RTE_BOND_LOG(INFO, "Closing bonded device %s", dev->device->name); > - while (internals->slave_count != skipped) { > + while (skipped < internals->slave_count) { When below fixed with adding 'continue', no need to change the check, right? Although new one is also correct. > uint16_t port_id = internals->slaves[skipped].port_id; > > if (rte_eth_dev_stop(port_id) != 0) { > RTE_BOND_LOG(ERR, "Failed to stop device on port %u", > port_id); > skipped++; > + continue; Can't we remove the slave even if 'stop()' failed? If so I think better to just log the error and keep continue in that case, what do you think? > } > > if (rte_eth_bond_slave_remove(bond_port_id, port_id) != 0) {
next prev parent reply other threads:[~2022-04-26 18:19 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20211025063922.34066-1-humin29@huawei.com> [not found] ` <20220324030036.4761-1-humin29@huawei.com> 2022-03-24 3:00 ` [PATCH V2 1/4] net/bonding: fix non-active slaves aren't stopped Min Hu (Connor) 2022-04-26 18:19 ` Ferruh Yigit 2022-04-29 6:45 ` Min Hu (Connor) 2022-04-29 13:31 ` Ferruh Yigit 2022-05-03 6:54 ` Min Hu (Connor) 2022-05-03 19:04 ` Ferruh Yigit 2022-05-05 1:16 ` Min Hu (Connor) 2022-03-24 3:00 ` [PATCH V2 2/4] net/bonding: fix non-terminable while loop Min Hu (Connor) 2022-04-26 18:19 ` Ferruh Yigit [this message] 2022-04-29 6:52 ` Min Hu (Connor) 2022-04-29 13:35 ` Ferruh Yigit 2022-03-24 3:00 ` [PATCH V2 3/4] app/testpmd: fix port status of slave device Min Hu (Connor) 2022-03-24 3:00 ` [PATCH V2 4/4] app/testpmd: fix slave device isn't released Min Hu (Connor) 2022-05-30 6:01 ` Min Hu (Connor) 2022-05-30 10:21 ` Singh, Aman Deep [not found] ` <20220503100217.46203-1-humin29@huawei.com> 2022-05-03 10:02 ` [PATCH v3 1/5] net/bonding: fix non-active slaves aren't stopped Min Hu (Connor) 2022-05-03 10:02 ` [PATCH v3 2/5] net/bonding: fix non-terminable while loop Min Hu (Connor) 2022-05-03 10:02 ` [PATCH v3 3/5] app/testpmd: fix port status of slave device Min Hu (Connor) 2022-05-03 23:39 ` Konstantin Ananyev 2022-05-06 8:16 ` Min Hu (Connor) 2022-05-08 11:28 ` Konstantin Ananyev 2022-05-10 16:34 ` Ferruh Yigit 2022-05-10 21:48 ` Konstantin Ananyev 2022-05-11 2:16 ` Min Hu (Connor) 2022-05-11 10:05 ` Ferruh Yigit 2022-05-11 2:14 ` [PATCH v4] " Min Hu (Connor) 2022-05-11 22:08 ` Konstantin Ananyev 2022-05-19 7:15 ` Andrew Rybchenko 2022-05-03 10:02 ` [PATCH v3 4/5] app/testpmd: fix slave device isn't released Min Hu (Connor) 2022-06-01 17:54 ` Ferruh Yigit 2022-06-07 8:15 ` Dongdong Liu 2022-06-07 8:10 ` [PATCH v4] " Dongdong Liu 2022-06-07 14:31 ` Ferruh Yigit 2022-06-09 7:50 ` Dongdong Liu 2022-06-09 8:50 ` Ferruh Yigit 2022-06-09 11:20 ` Dongdong Liu 2022-06-09 11:49 ` [PATCH v5] " Dongdong Liu 2022-06-10 8:10 ` Ferruh Yigit 2022-05-03 10:02 ` [PATCH v3 5/5] ethdev: fix dev state when stop Min Hu (Connor) 2022-05-25 17:44 ` Ferruh Yigit 2022-05-26 10:21 ` Thomas Monjalon 2022-05-30 12:04 ` Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c79ea0bc-7c3a-607b-5117-def93b9b1ddd@xilinx.com \ --to=ferruh.yigit@xilinx.com \ --cc=arybchenko@solarflare.com \ --cc=chas3@att.com \ --cc=dev@dpdk.org \ --cc=humin29@huawei.com \ --cc=ivan.ilchenko@oktetlabs.ru \ --cc=lihuisong@huawei.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git