From: "Burakov, Anatoly" <anatoly.burakov@intel.com> To: David Hunt <david.hunt@intel.com>, dev@dpdk.org Cc: stable@dpdk.org Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 0/6] power: fix make build for power apps Date: Wed, 13 Jan 2021 11:18:09 +0000 Message-ID: <d38ef56d-8c09-ea9e-e071-13fe5d19d936@intel.com> (raw) In-Reply-To: <f99a5ee3-b6bd-ee22-7fd8-d9234dfb176c@intel.com> On 13-Jan-21 11:14 AM, David Hunt wrote: > Hi Anatoly, > > On 13/1/2021 11:08 AM, Burakov, Anatoly wrote: >> On 08-Jan-21 2:30 PM, David Hunt wrote: >>> The power example applications that uses the virtio-serial method of >>> communication cannot currently be built with make, and can only be built >>> using meson/ninja. >>> >>> The guest channel message definitions and functions in guest_channel.h >>> are needed by applications and need to be made public. >>> >>> This worked pre-20.11, but now with all the meson/ninja changes, making >>> these apps externally no longer works. To fix, we need to move the >>> header >>> file with the API definitions for the channel commands public, and >>> rename >>> the functions accordingly. >>> >>> The main change is to rename channel_commands.h to >>> rte_power_guest_channel.h so that it gets picked up by the installer and >>> copied to /usr/local/include. Other changes include renaming #defines to >>> have RTE_ at the beginning instead of CPU_. Finally we refactor the code >>> to work with those changes. >>> >>> --- >>> v2 changes >>> - re-worked from monolithic patch to a 6 patch patchset for easier >>> review >>> >>> [PATCH v2 1/6] power: create guest channel public header file >>> [PATCH v2 2/6] power: make channel msg functions public >>> [PATCH v2 3/6] power: rename public structs >>> [PATCH v2 4/6] power: rename defines >>> [PATCH v2 5/6] power: add new header file to export list >>> [PATCH v2 6/6] power: clean up includes >>> >> >> Just a general question: wouldn't it be better to move this stuff >> entirely into sample app and not bother with keeping it in the >> library? There is precedent - ethtool app has a "library" and an >> "application" part, i think you should be able to move it out of the >> library and into the sample app entirely without too much trouble, as >> code looks to be fairly self-contained. >> > > Agreed, that's a great idea. I could have a common lib under > examples/vm_power_manager, then two apps, vm_power_manager and > guest_cli. That would keep everything nicely local, and not expose the > channel API publicly. The only reason we were making it public was to > allow "make" to work, so that's not a good enought reason, tbh. I'll > throw a prototype together today. Yep, IIRC Make works perfectly fine with ethtool, so i don't see why it wouldn't work for your sample app as well. Thanks! > > Thanks, > Dave. > > > > -- Thanks, Anatoly
next prev parent reply other threads:[~2021-01-13 11:18 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-17 11:36 [dpdk-stable] [PATCH v1] " David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH 0/6] " David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH v2 1/6] power: create guest channel public header file David Hunt 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 0/6] power: fix make build for power apps David Hunt 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 1/6] power: create guest channel public header file David Hunt 2021-01-20 15:09 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-20 15:12 ` David Hunt 2021-01-21 17:21 ` [dpdk-stable] [PATCH v4 0/6] power: fix make build for power apps David Hunt 2021-01-21 17:21 ` [dpdk-stable] [PATCH v4 1/6] power: create guest channel public header file David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 0/6] power: fix make build for power apps David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 1/6] power: create guest channel public header file David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 2/6] power: make channel msg functions public David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 3/6] power: rename public structs David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 4/6] power: rename defines David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 5/6] power: add new header file to export list David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 6/6] power: clean up includes David Hunt 2021-01-29 10:30 ` [dpdk-stable] [dpdk-dev] [PATCH v5 0/6] power: fix make build for power apps Thomas Monjalon 2021-01-21 17:21 ` [dpdk-stable] [PATCH v4 2/6] power: make channel msg functions public David Hunt 2021-01-22 12:12 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-02-22 9:53 ` [dpdk-stable] " Ferruh Yigit 2021-01-21 17:21 ` [dpdk-stable] [PATCH v4 3/6] power: rename public structs David Hunt 2021-01-22 12:15 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-22 12:18 ` Burakov, Anatoly 2021-01-22 12:18 ` Burakov, Anatoly 2021-01-28 22:57 ` [dpdk-stable] " Thomas Monjalon 2021-02-22 9:56 ` Ferruh Yigit 2021-01-21 17:21 ` [dpdk-stable] [PATCH v4 4/6] power: rename defines David Hunt 2021-01-22 13:50 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-21 17:22 ` [dpdk-stable] [PATCH v4 5/6] power: add new header file to export list David Hunt 2021-01-22 13:51 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-21 17:22 ` [dpdk-stable] [PATCH v4 6/6] power: clean up includes David Hunt 2021-01-22 13:53 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-29 10:27 ` [dpdk-stable] [PATCH v4 0/6] power: fix make build for power apps Thomas Monjalon 2021-02-24 13:16 ` [dpdk-stable] [PATCH] power: remove duplicated symbols from map file Ferruh Yigit 2021-02-24 15:24 ` Aaron Conole 2021-02-24 14:54 ` Ferruh Yigit 2021-02-25 9:11 ` [dpdk-stable] [dpdk-dev] " David Marchand 2021-02-25 10:41 ` Ferruh Yigit 2021-02-25 10:44 ` David Marchand 2021-02-25 10:54 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit 2021-02-25 14:38 ` David Marchand 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 2/6] power: make channel msg functions public David Hunt 2021-01-20 14:26 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-20 15:08 ` David Hunt 2021-01-20 15:23 ` Burakov, Anatoly 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 3/6] power: rename public structs David Hunt 2021-01-20 14:27 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-20 15:03 ` David Hunt 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 4/6] power: rename defines David Hunt 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 5/6] power: add new header file to export list David Hunt 2021-01-20 14:28 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-20 15:01 ` David Hunt 2021-01-20 15:17 ` Burakov, Anatoly 2021-01-20 15:08 ` Bruce Richardson 2021-01-20 15:18 ` Burakov, Anatoly 2021-01-20 15:29 ` David Hunt 2021-01-20 15:43 ` Burakov, Anatoly 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 6/6] power: clean up includes David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH v2 2/6] power: make channel msg functions public David Hunt 2021-01-19 14:31 ` Thomas Monjalon 2021-01-19 14:51 ` David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH v2 3/6] power: rename public structs David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH v2 4/6] power: rename defines David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH v2 5/6] power: add new header file to export list David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH v2 6/6] power: clean up includes David Hunt 2021-01-13 11:08 ` [dpdk-stable] [dpdk-dev] [PATCH 0/6] power: fix make build for power apps Burakov, Anatoly 2021-01-13 11:14 ` David Hunt 2021-01-13 11:18 ` Burakov, Anatoly [this message] 2021-01-13 13:25 ` David Hunt 2021-01-13 17:30 ` Burakov, Anatoly
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d38ef56d-8c09-ea9e-e071-13fe5d19d936@intel.com \ --to=anatoly.burakov@intel.com \ --cc=david.hunt@intel.com \ --cc=dev@dpdk.org \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git