From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: chenmin.sun@intel.com
Subject: [dpdk-test-report] |WARNING| pw63851 [FDIO] dpdk: add devargs support
Date: Fri, 13 Dec 2019 15:37:25 +0100 (CET) [thread overview]
Message-ID: <20191213143725.2A5181BFBA@dpdk.org> (raw)
In-Reply-To: <20191213233554.90866-1-chenmin.sun@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/63851
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#74: FILE: src/plugins/dpdk/device/dpdk.h:339:
+ u8 *devargs;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#87: FILE: src/plugins/dpdk/device/format.c:567:
+ if (di.device->devargs && di.device->devargs->args)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (2, 4)
#87: FILE: src/plugins/dpdk/device/format.c:567:
+ if (di.device->devargs && di.device->devargs->args)
+ s = format (s, "%UDevargs: %s
",
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#88: FILE: src/plugins/dpdk/device/format.c:568:
+ s = format (s, "%UDevargs: %s
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#101: FILE: src/plugins/dpdk/device/init.c:1121:
+ else if (unformat (input, "devargs %s", &devconf->devargs))$
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#101: FILE: src/plugins/dpdk/device/init.c:1121:
+ else if (unformat (input, "devargs %s", &devconf->devargs))
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#114: FILE: src/plugins/dpdk/device/init.c:1437:
if (num_whitelisted > 0 && devconf->is_blacklisted == 0)
+ {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (4, 10)
#114: FILE: src/plugins/dpdk/device/init.c:1437:
if (num_whitelisted > 0 && devconf->is_blacklisted == 0)
+ {
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#121: FILE: src/plugins/dpdk/device/init.c:1438:
+ {$
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#123: FILE: src/plugins/dpdk/device/init.c:1440:
+ vec_add1 (conf->eal_init_args, tmp);
WARNING:TABSTOP: Statements should start on a tabstop
#124: FILE: src/plugins/dpdk/device/init.c:1441:
+ if (devconf->devargs)
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#124: FILE: src/plugins/dpdk/device/init.c:1441:
+ if (devconf->devargs)
+ {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (10, 12)
#124: FILE: src/plugins/dpdk/device/init.c:1441:
+ if (devconf->devargs)
+ {
WARNING:TABSTOP: Statements should start on a tabstop
#125: FILE: src/plugins/dpdk/device/init.c:1442:
+ {
WARNING:LONG_LINE: line over 90 characters
#126: FILE: src/plugins/dpdk/device/init.c:1443:
+ tmp = format (0, "%U,%s", format_vlib_pci_addr, &devconf->pci_addr, devconf->devargs, 0);
WARNING:TABSTOP: Statements should start on a tabstop
#127: FILE: src/plugins/dpdk/device/init.c:1444:
+ }
WARNING:TABSTOP: Statements should start on a tabstop
#128: FILE: src/plugins/dpdk/device/init.c:1445:
+ else
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#128: FILE: src/plugins/dpdk/device/init.c:1445:
+ else
+ {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (10, 12)
#128: FILE: src/plugins/dpdk/device/init.c:1445:
+ else
+ {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#128: FILE: src/plugins/dpdk/device/init.c:1445:
+ }
+ else
WARNING:TABSTOP: Statements should start on a tabstop
#129: FILE: src/plugins/dpdk/device/init.c:1446:
+ {
WARNING:TABSTOP: Statements should start on a tabstop
#131: FILE: src/plugins/dpdk/device/init.c:1448:
+ }
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#132: FILE: src/plugins/dpdk/device/init.c:1449:
+ vec_add1 (conf->eal_init_args, tmp);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#133: FILE: src/plugins/dpdk/device/init.c:1450:
+ }$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#134: FILE: src/plugins/dpdk/device/init.c:1451:
else if (num_whitelisted == 0 && devconf->is_blacklisted != 0)
+ {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (4, 10)
#134: FILE: src/plugins/dpdk/device/init.c:1451:
else if (num_whitelisted == 0 && devconf->is_blacklisted != 0)
+ {
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#141: FILE: src/plugins/dpdk/device/init.c:1452:
+ {$
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#143: FILE: src/plugins/dpdk/device/init.c:1454:
+ vec_add1 (conf->eal_init_args, tmp);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#145: FILE: src/plugins/dpdk/device/init.c:1456:
+ vec_add1 (conf->eal_init_args, tmp);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#146: FILE: src/plugins/dpdk/device/init.c:1457:
+ }$
total: 5 errors, 25 warnings, 79 lines checked
parent reply other threads:[~2019-12-13 14:37 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20191213233554.90866-1-chenmin.sun@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213143725.2A5181BFBA@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=chenmin.sun@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).