automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Pu Xu <583493798@qq.com>
Subject: [dpdk-test-report] |WARNING| pw69640 [PATCH] ip_frag: fix fragmenting ipv4 packet with header option
Date: Fri,  1 May 2020 15:51:12 +0200 (CEST)	[thread overview]
Message-ID: <20200501135112.A3DE71DA43@dpdk.org> (raw)
In-Reply-To: <20200501135018.130315-1-583493798@qq.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/69640

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#62: 
When fragmenting ipv4 packet, the data offset should be calculated through the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).

ERROR:CODE_INDENT: code indent should use tabs where possible
#84: FILE: lib/librte_ip_frag/rte_ipv4_fragmentation.c:27:
+        uint16_t len, uint16_t fofs, uint16_t dofs, uint32_t mf)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#84: FILE: lib/librte_ip_frag/rte_ipv4_fragmentation.c:27:
+        uint16_t len, uint16_t fofs, uint16_t dofs, uint32_t mf)$

WARNING:LONG_LINE: line over 90 characters
#105: FILE: lib/librte_ip_frag/rte_ipv4_fragmentation.c:90:
+	header_len = (in_hdr->version_ihl & RTE_IPV4_HDR_IHL_MASK) * RTE_IPV4_IHL_MULTIPLIER;

total: 1 errors, 3 warnings, 84 lines checked

       reply	other threads:[~2020-05-01 13:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200501135018.130315-1-583493798@qq.com>
2020-05-01 13:51 ` checkpatch [this message]
2020-05-01 20:13 ` [dpdk-test-report] || pw69640 " 0-day Robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200501135112.A3DE71DA43@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=583493798@qq.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).