* [dpdk-test-report] |WARNING| pw75532 [PATCH 12/22] uio: Fix 64 bit BARs mapping
[not found] <1597360905-74106-13-git-send-email-navasile@linux.microsoft.com>
@ 2020-08-13 23:25 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-08-13 23:25 UTC (permalink / raw)
To: test-report; +Cc: Narcisa Ana Maria Vasile
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/75532
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: kernel/windows/netuio/netuio_dev.c:31:
+ WDFDEVICE device = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#129: FILE: kernel/windows/netuio/netuio_dev.c:33:
+ WDF_OBJECT_ATTRIBUTES deviceAttributes;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#130: FILE: kernel/windows/netuio/netuio_dev.c:34:
+ WDF_PNPPOWER_EVENT_CALLBACKS pnpPowerCallbacks;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#131: FILE: kernel/windows/netuio/netuio_dev.c:35:
+ WDF_FILEOBJECT_CONFIG fileConfig;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#136: FILE: kernel/windows/netuio/netuio_dev.c:39:
+ // Register PnP power management callbacks$
ERROR:C99_COMMENTS: do not use C99 // comments
#136: FILE: kernel/windows/netuio/netuio_dev.c:39:
+ // Register PnP power management callbacks
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: kernel/windows/netuio/netuio_dev.c:40:
+ WDF_PNPPOWER_EVENT_CALLBACKS_INIT(&pnpPowerCallbacks);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#138: FILE: kernel/windows/netuio/netuio_dev.c:41:
+ pnpPowerCallbacks.EvtDevicePrepareHardware = netuio_evt_prepare_hw;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#139: FILE: kernel/windows/netuio/netuio_dev.c:42:
+ pnpPowerCallbacks.EvtDeviceReleaseHardware = netuio_evt_release_hw;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#140: FILE: kernel/windows/netuio/netuio_dev.c:43:
+ WdfDeviceInitSetPnpPowerEventCallbacks(DeviceInit, &pnpPowerCallbacks);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#142: FILE: kernel/windows/netuio/netuio_dev.c:45:
+ // Register callbacks for when a HANDLE is opened or closed.$
ERROR:C99_COMMENTS: do not use C99 // comments
#142: FILE: kernel/windows/netuio/netuio_dev.c:45:
+ // Register callbacks for when a HANDLE is opened or closed.
WARNING:LONG_LINE: line over 100 characters
#143: FILE: kernel/windows/netuio/netuio_dev.c:46:
+ WDF_FILEOBJECT_CONFIG_INIT(&fileConfig, WDF_NO_EVENT_CALLBACK, WDF_NO_EVENT_CALLBACK, netuio_evt_file_cleanup);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#143: FILE: kernel/windows/netuio/netuio_dev.c:46:
+ WDF_FILEOBJECT_CONFIG_INIT(&fileConfig, WDF_NO_EVENT_CALLBACK, WDF_NO_EVENT_CALLBACK, netuio_evt_file_cleanup);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#144: FILE: kernel/windows/netuio/netuio_dev.c:47:
+ WdfDeviceInitSetFileObjectConfig(DeviceInit, &fileConfig, WDF_NO_OBJECT_ATTRIBUTES);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#148: FILE: kernel/windows/netuio/netuio_dev.c:51:
+ WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, NETUIO_CONTEXT_DATA);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#157: FILE: kernel/windows/netuio/netuio_dev.c:103:
+ NTSTATUS status;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: kernel/windows/netuio/netuio_dev.c:108:
+ if (!netuio_contextdata) {$
WARNING:BRACES: braces {} are not necessary for single statement blocks
#163: FILE: kernel/windows/netuio/netuio_dev.c:108:
+ if (!netuio_contextdata) {
return STATUS_UNSUCCESSFUL;
+ }
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#165: FILE: kernel/windows/netuio/netuio_dev.c:110:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#169: FILE: kernel/windows/netuio/netuio_dev.c:112:
+ PCI_COMMON_HEADER pci_config = {0};$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#170: FILE: kernel/windows/netuio/netuio_dev.c:113:
+ ULONG bytes_returned;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#178: FILE: kernel/windows/netuio/netuio_dev.c:115:
+ // Read PCI configuration space$
ERROR:C99_COMMENTS: do not use C99 // comments
#178: FILE: kernel/windows/netuio/netuio_dev.c:115:
+ // Read PCI configuration space
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#179: FILE: kernel/windows/netuio/netuio_dev.c:116:
+ bytes_returned = netuio_contextdata->bus_interface.GetBusData($
ERROR:CODE_INDENT: code indent should use tabs where possible
#180: FILE: kernel/windows/netuio/netuio_dev.c:117:
+ netuio_contextdata->bus_interface.Context,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#180: FILE: kernel/windows/netuio/netuio_dev.c:117:
+ netuio_contextdata->bus_interface.Context,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#181: FILE: kernel/windows/netuio/netuio_dev.c:118:
+ PCI_WHICHSPACE_CONFIG,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#181: FILE: kernel/windows/netuio/netuio_dev.c:118:
+ PCI_WHICHSPACE_CONFIG,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#182: FILE: kernel/windows/netuio/netuio_dev.c:119:
+ &pci_config,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#182: FILE: kernel/windows/netuio/netuio_dev.c:119:
+ &pci_config,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#183: FILE: kernel/windows/netuio/netuio_dev.c:120:
+ 0,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#183: FILE: kernel/windows/netuio/netuio_dev.c:120:
+ 0,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#184: FILE: kernel/windows/netuio/netuio_dev.c:121:
+ sizeof(pci_config));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#184: FILE: kernel/windows/netuio/netuio_dev.c:121:
+ sizeof(pci_config));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: kernel/windows/netuio/netuio_dev.c:123:
+ if (bytes_returned != sizeof(pci_config)) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#187: FILE: kernel/windows/netuio/netuio_dev.c:124:
+ status = STATUS_NOT_SUPPORTED;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#187: FILE: kernel/windows/netuio/netuio_dev.c:124:
+ status = STATUS_NOT_SUPPORTED;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#188: FILE: kernel/windows/netuio/netuio_dev.c:125:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#188: FILE: kernel/windows/netuio/netuio_dev.c:125:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#189: FILE: kernel/windows/netuio/netuio_dev.c:126:
+ }$
WARNING:TYPO_SPELLING: 'implictly' may be misspelled - perhaps 'implicitly'?
#191: FILE: kernel/windows/netuio/netuio_dev.c:128:
+ // Device type is implictly enforced by .inf
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#191: FILE: kernel/windows/netuio/netuio_dev.c:128:
+ // Device type is implictly enforced by .inf$
ERROR:C99_COMMENTS: do not use C99 // comments
#191: FILE: kernel/windows/netuio/netuio_dev.c:128:
+ // Device type is implictly enforced by .inf
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#192: FILE: kernel/windows/netuio/netuio_dev.c:129:
+ ASSERT(PCI_CONFIGURATION_TYPE(&pci_config) == PCI_DEVICE_TYPE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#194: FILE: kernel/windows/netuio/netuio_dev.c:131:
+ PCM_PARTIAL_RESOURCE_DESCRIPTOR descriptor;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#195: FILE: kernel/windows/netuio/netuio_dev.c:132:
+ ULONG next_descriptor = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#196: FILE: kernel/windows/netuio/netuio_dev.c:133:
+ ULONGLONG bar_addr = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#197: FILE: kernel/windows/netuio/netuio_dev.c:134:
+ ULONG curr_bar = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: kernel/windows/netuio/netuio_dev.c:135:
+ ULONG prev_bar = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#200: FILE: kernel/windows/netuio/netuio_dev.c:137:
+ for (INT bar_index = 0; bar_index < PCI_MAX_BAR; bar_index++) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#201: FILE: kernel/windows/netuio/netuio_dev.c:138:
+ prev_bar = curr_bar;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: kernel/windows/netuio/netuio_dev.c:138:
+ prev_bar = curr_bar;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#202: FILE: kernel/windows/netuio/netuio_dev.c:139:
+ curr_bar = pci_config.u.type0.BaseAddresses[bar_index];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#202: FILE: kernel/windows/netuio/netuio_dev.c:139:
+ curr_bar = pci_config.u.type0.BaseAddresses[bar_index];$
ERROR:CODE_INDENT: code indent should use tabs where possible
#203: FILE: kernel/windows/netuio/netuio_dev.c:140:
+ if (curr_bar == 0 || (prev_bar & PCI_TYPE_64BIT)) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: kernel/windows/netuio/netuio_dev.c:140:
+ if (curr_bar == 0 || (prev_bar & PCI_TYPE_64BIT)) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#203: FILE: kernel/windows/netuio/netuio_dev.c:140:
+ if (curr_bar == 0 || (prev_bar & PCI_TYPE_64BIT)) {
+ // Skip this bar
ERROR:CODE_INDENT: code indent should use tabs where possible
#204: FILE: kernel/windows/netuio/netuio_dev.c:141:
+ // Skip this bar$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#204: FILE: kernel/windows/netuio/netuio_dev.c:141:
+ // Skip this bar$
ERROR:C99_COMMENTS: do not use C99 // comments
#204: FILE: kernel/windows/netuio/netuio_dev.c:141:
+ // Skip this bar
ERROR:CODE_INDENT: code indent should use tabs where possible
#205: FILE: kernel/windows/netuio/netuio_dev.c:142:
+ netuio_contextdata->bar[bar_index].base_addr.QuadPart = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#205: FILE: kernel/windows/netuio/netuio_dev.c:142:
+ netuio_contextdata->bar[bar_index].base_addr.QuadPart = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#206: FILE: kernel/windows/netuio/netuio_dev.c:143:
+ netuio_contextdata->bar[bar_index].size = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#206: FILE: kernel/windows/netuio/netuio_dev.c:143:
+ netuio_contextdata->bar[bar_index].size = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#207: FILE: kernel/windows/netuio/netuio_dev.c:144:
+ netuio_contextdata->bar[bar_index].virt_addr = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#207: FILE: kernel/windows/netuio/netuio_dev.c:144:
+ netuio_contextdata->bar[bar_index].virt_addr = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#209: FILE: kernel/windows/netuio/netuio_dev.c:146:
+ netuio_contextdata->dpdk_hw[bar_index].mdl = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#209: FILE: kernel/windows/netuio/netuio_dev.c:146:
+ netuio_contextdata->dpdk_hw[bar_index].mdl = NULL;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#210: FILE: kernel/windows/netuio/netuio_dev.c:147:
+ netuio_contextdata->dpdk_hw[bar_index].mem.size = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#210: FILE: kernel/windows/netuio/netuio_dev.c:147:
+ netuio_contextdata->dpdk_hw[bar_index].mem.size = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#212: FILE: kernel/windows/netuio/netuio_dev.c:149:
+ continue;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#212: FILE: kernel/windows/netuio/netuio_dev.c:149:
+ continue;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#222: FILE: kernel/windows/netuio/netuio_dev.c:152:
+ // Find next CmResourceTypeMemory$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#222: FILE: kernel/windows/netuio/netuio_dev.c:152:
+ // Find next CmResourceTypeMemory$
ERROR:C99_COMMENTS: do not use C99 // comments
#222: FILE: kernel/windows/netuio/netuio_dev.c:152:
+ // Find next CmResourceTypeMemory
ERROR:CODE_INDENT: code indent should use tabs where possible
#223: FILE: kernel/windows/netuio/netuio_dev.c:153:
+ do {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#223: FILE: kernel/windows/netuio/netuio_dev.c:153:
+ do {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#223: FILE: kernel/windows/netuio/netuio_dev.c:153:
+ do {
+ descriptor = WdfCmResourceListGetDescriptor(ResourcesTranslated, next_descriptor);
ERROR:CODE_INDENT: code indent should use tabs where possible
#224: FILE: kernel/windows/netuio/netuio_dev.c:154:
+ descriptor = WdfCmResourceListGetDescriptor(ResourcesTranslated, next_descriptor);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#224: FILE: kernel/windows/netuio/netuio_dev.c:154:
+ descriptor = WdfCmResourceListGetDescriptor(ResourcesTranslated, next_descriptor);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#225: FILE: kernel/windows/netuio/netuio_dev.c:155:
+ next_descriptor++;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#225: FILE: kernel/windows/netuio/netuio_dev.c:155:
+ next_descriptor++;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#229: FILE: kernel/windows/netuio/netuio_dev.c:157:
+ if (descriptor == NULL) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#229: FILE: kernel/windows/netuio/netuio_dev.c:157:
+ if (descriptor == NULL) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#230: FILE: kernel/windows/netuio/netuio_dev.c:158:
+ status = STATUS_DEVICE_CONFIGURATION_ERROR;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#230: FILE: kernel/windows/netuio/netuio_dev.c:158:
+ status = STATUS_DEVICE_CONFIGURATION_ERROR;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#233: FILE: kernel/windows/netuio/netuio_dev.c:161:
+ } while (descriptor->Type != CmResourceTypeMemory);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#233: FILE: kernel/windows/netuio/netuio_dev.c:161:
+ } while (descriptor->Type != CmResourceTypeMemory);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#237: FILE: kernel/windows/netuio/netuio_dev.c:163:
+ // Assert that we have the correct descriptor$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#237: FILE: kernel/windows/netuio/netuio_dev.c:163:
+ // Assert that we have the correct descriptor$
ERROR:C99_COMMENTS: do not use C99 // comments
#237: FILE: kernel/windows/netuio/netuio_dev.c:163:
+ // Assert that we have the correct descriptor
ERROR:CODE_INDENT: code indent should use tabs where possible
#238: FILE: kernel/windows/netuio/netuio_dev.c:164:
+ ASSERT((descriptor->Flags & CM_RESOURCE_MEMORY_BAR) != 0);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#238: FILE: kernel/windows/netuio/netuio_dev.c:164:
+ ASSERT((descriptor->Flags & CM_RESOURCE_MEMORY_BAR) != 0);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#245: FILE: kernel/windows/netuio/netuio_dev.c:166:
+ if (curr_bar & PCI_TYPE_64BIT) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#245: FILE: kernel/windows/netuio/netuio_dev.c:166:
+ if (curr_bar & PCI_TYPE_64BIT) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#245: FILE: kernel/windows/netuio/netuio_dev.c:166:
+ if (curr_bar & PCI_TYPE_64BIT) {
+ ASSERT(bar_index != PCI_TYPE0_ADDRESSES - 1);
ERROR:CODE_INDENT: code indent should use tabs where possible
#246: FILE: kernel/windows/netuio/netuio_dev.c:167:
+ ASSERT(bar_index != PCI_TYPE0_ADDRESSES - 1);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#246: FILE: kernel/windows/netuio/netuio_dev.c:167:
+ ASSERT(bar_index != PCI_TYPE0_ADDRESSES - 1);$
WARNING:LONG_LINE: line over 100 characters
#247: FILE: kernel/windows/netuio/netuio_dev.c:168:
+ bar_addr = ((ULONGLONG)pci_config.u.type0.BaseAddresses[bar_index + 1] << 32) | (curr_bar & PCI_ADDRESS_MEMORY_ADDRESS_MASK);
ERROR:CODE_INDENT: code indent should use tabs where possible
#247: FILE: kernel/windows/netuio/netuio_dev.c:168:
+ bar_addr = ((ULONGLONG)pci_config.u.type0.BaseAddresses[bar_index + 1] << 32) | (curr_bar & PCI_ADDRESS_MEMORY_ADDRESS_MASK);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#247: FILE: kernel/windows/netuio/netuio_dev.c:168:
+ bar_addr = ((ULONGLONG)pci_config.u.type0.BaseAddresses[bar_index + 1] << 32) | (curr_bar & PCI_ADDRESS_MEMORY_ADDRESS_MASK);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#248: FILE: kernel/windows/netuio/netuio_dev.c:169:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#248: FILE: kernel/windows/netuio/netuio_dev.c:169:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#249: FILE: kernel/windows/netuio/netuio_dev.c:170:
+ else$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#249: FILE: kernel/windows/netuio/netuio_dev.c:170:
+ else$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#249: FILE: kernel/windows/netuio/netuio_dev.c:170:
+ else
+ {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#249: FILE: kernel/windows/netuio/netuio_dev.c:170:
+ else
+ {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#249: FILE: kernel/windows/netuio/netuio_dev.c:170:
+ }
+ else
ERROR:CODE_INDENT: code indent should use tabs where possible
#250: FILE: kernel/windows/netuio/netuio_dev.c:171:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#250: FILE: kernel/windows/netuio/netuio_dev.c:171:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#251: FILE: kernel/windows/netuio/netuio_dev.c:172:
+ bar_addr = curr_bar & PCI_ADDRESS_MEMORY_ADDRESS_MASK;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#251: FILE: kernel/windows/netuio/netuio_dev.c:172:
+ bar_addr = curr_bar & PCI_ADDRESS_MEMORY_ADDRESS_MASK;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#265: FILE: kernel/windows/netuio/netuio_dev.c:175:
+ ASSERT((ULONGLONG)descriptor->u.Memory.Start.QuadPart == bar_addr);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#265: FILE: kernel/windows/netuio/netuio_dev.c:175:
+ ASSERT((ULONGLONG)descriptor->u.Memory.Start.QuadPart == bar_addr);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#267: FILE: kernel/windows/netuio/netuio_dev.c:177:
+ // Retrieve and map the BARs$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#267: FILE: kernel/windows/netuio/netuio_dev.c:177:
+ // Retrieve and map the BARs$
ERROR:C99_COMMENTS: do not use C99 // comments
#267: FILE: kernel/windows/netuio/netuio_dev.c:177:
+ // Retrieve and map the BARs
ERROR:CODE_INDENT: code indent should use tabs where possible
#268: FILE: kernel/windows/netuio/netuio_dev.c:178:
+ netuio_contextdata->bar[bar_index].base_addr.QuadPart = descriptor->u.Memory.Start.QuadPart;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#268: FILE: kernel/windows/netuio/netuio_dev.c:178:
+ netuio_contextdata->bar[bar_index].base_addr.QuadPart = descriptor->u.Memory.Start.QuadPart;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#269: FILE: kernel/windows/netuio/netuio_dev.c:179:
+ netuio_contextdata->bar[bar_index].size = descriptor->u.Memory.Length;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#269: FILE: kernel/windows/netuio/netuio_dev.c:179:
+ netuio_contextdata->bar[bar_index].size = descriptor->u.Memory.Length;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#270: FILE: kernel/windows/netuio/netuio_dev.c:180:
+ netuio_contextdata->bar[bar_index].virt_addr = MmMapIoSpace(descriptor->u.Memory.Start,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#270: FILE: kernel/windows/netuio/netuio_dev.c:180:
+ netuio_contextdata->bar[bar_index].virt_addr = MmMapIoSpace(descriptor->u.Memory.Start,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#271: FILE: kernel/windows/netuio/netuio_dev.c:181:
+ descriptor->u.Memory.Length,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#271: FILE: kernel/windows/netuio/netuio_dev.c:181:
+ descriptor->u.Memory.Length,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#272: FILE: kernel/windows/netuio/netuio_dev.c:182:
+ MmNonCached);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#272: FILE: kernel/windows/netuio/netuio_dev.c:182:
+ MmNonCached);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#273: FILE: kernel/windows/netuio/netuio_dev.c:183:
+ if (netuio_contextdata->bar[bar_index].virt_addr == NULL) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#273: FILE: kernel/windows/netuio/netuio_dev.c:183:
+ if (netuio_contextdata->bar[bar_index].virt_addr == NULL) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#273: FILE: kernel/windows/netuio/netuio_dev.c:183:
+ if (netuio_contextdata->bar[bar_index].virt_addr == NULL) {
+ status = STATUS_INSUFFICIENT_RESOURCES;
ERROR:CODE_INDENT: code indent should use tabs where possible
#274: FILE: kernel/windows/netuio/netuio_dev.c:184:
+ status = STATUS_INSUFFICIENT_RESOURCES;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#274: FILE: kernel/windows/netuio/netuio_dev.c:184:
+ status = STATUS_INSUFFICIENT_RESOURCES;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#275: FILE: kernel/windows/netuio/netuio_dev.c:185:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#275: FILE: kernel/windows/netuio/netuio_dev.c:185:
+ goto end;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#279: FILE: kernel/windows/netuio/netuio_dev.c:188:
+ // Allocate an MDL for the device BAR, so we can map it to the user's process context later.$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#279: FILE: kernel/windows/netuio/netuio_dev.c:188:
+ // Allocate an MDL for the device BAR, so we can map it to the user's process context later.$
ERROR:C99_COMMENTS: do not use C99 // comments
#279: FILE: kernel/windows/netuio/netuio_dev.c:188:
+ // Allocate an MDL for the device BAR, so we can map it to the user's process context later.
WARNING:LONG_LINE: line over 100 characters
#280: FILE: kernel/windows/netuio/netuio_dev.c:189:
+ netuio_contextdata->dpdk_hw[bar_index].mdl = IoAllocateMdl(netuio_contextdata->bar[bar_index].virt_addr,
ERROR:CODE_INDENT: code indent should use tabs where possible
#280: FILE: kernel/windows/netuio/netuio_dev.c:189:
+ netuio_contextdata->dpdk_hw[bar_index].mdl = IoAllocateMdl(netuio_contextdata->bar[bar_index].virt_addr,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#280: FILE: kernel/windows/netuio/netuio_dev.c:189:
+ netuio_contextdata->dpdk_hw[bar_index].mdl = IoAllocateMdl(netuio_contextdata->bar[bar_index].virt_addr,$
WARNING:LONG_LINE: line over 100 characters
#281: FILE: kernel/windows/netuio/netuio_dev.c:190:
+ (ULONG)netuio_contextdata->bar[bar_index].size,
ERROR:CODE_INDENT: code indent should use tabs where possible
#281: FILE: kernel/windows/netuio/netuio_dev.c:190:
+ (ULONG)netuio_contextdata->bar[bar_index].size,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#281: FILE: kernel/windows/netuio/netuio_dev.c:190:
+ (ULONG)netuio_contextdata->bar[bar_index].size,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#282: FILE: kernel/windows/netuio/netuio_dev.c:191:
+ FALSE,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#282: FILE: kernel/windows/netuio/netuio_dev.c:191:
+ FALSE,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#283: FILE: kernel/windows/netuio/netuio_dev.c:192:
+ FALSE,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#283: FILE: kernel/windows/netuio/netuio_dev.c:192:
+ FALSE,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#284: FILE: kernel/windows/netuio/netuio_dev.c:193:
+ NULL);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#284: FILE: kernel/windows/netuio/netuio_dev.c:193:
+ NULL);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#285: FILE: kernel/windows/netuio/netuio_dev.c:194:
+ if (!netuio_contextdata->dpdk_hw[bar_index].mdl) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#285: FILE: kernel/windows/netuio/netuio_dev.c:194:
+ if (!netuio_contextdata->dpdk_hw[bar_index].mdl) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#285: FILE: kernel/windows/netuio/netuio_dev.c:194:
+ if (!netuio_contextdata->dpdk_hw[bar_index].mdl) {
+ status = STATUS_INSUFFICIENT_RESOURCES;
ERROR:CODE_INDENT: code indent should use tabs where possible
#286: FILE: kernel/windows/netuio/netuio_dev.c:195:
+ status = STATUS_INSUFFICIENT_RESOURCES;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: kernel/windows/netuio/netuio_dev.c:195:
+ status = STATUS_INSUFFICIENT_RESOURCES;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#287: FILE: kernel/windows/netuio/netuio_dev.c:196:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#287: FILE: kernel/windows/netuio/netuio_dev.c:196:
+ goto end;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#288: FILE: kernel/windows/netuio/netuio_dev.c:197:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#288: FILE: kernel/windows/netuio/netuio_dev.c:197:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#290: FILE: kernel/windows/netuio/netuio_dev.c:199:
+ netuio_contextdata->dpdk_hw[bar_index].mem.size = netuio_contextdata->bar[bar_index].size;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#290: FILE: kernel/windows/netuio/netuio_dev.c:199:
+ netuio_contextdata->dpdk_hw[bar_index].mem.size = netuio_contextdata->bar[bar_index].size;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#291: FILE: kernel/windows/netuio/netuio_dev.c:200:
+ } // for bar_index$
ERROR:C99_COMMENTS: do not use C99 // comments
#291: FILE: kernel/windows/netuio/netuio_dev.c:200:
+ } // for bar_index
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#293: FILE: kernel/windows/netuio/netuio_dev.c:202:
+ status = STATUS_SUCCESS;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#296: FILE: kernel/windows/netuio/netuio_dev.c:205:
+ if (status != STATUS_SUCCESS) {$
WARNING:BRACES: braces {} are not necessary for single statement blocks
#296: FILE: kernel/windows/netuio/netuio_dev.c:205:
+ if (status != STATUS_SUCCESS) {
+ netuio_free_hw_resources(Device);
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#297: FILE: kernel/windows/netuio/netuio_dev.c:206:
+ netuio_free_hw_resources(Device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#297: FILE: kernel/windows/netuio/netuio_dev.c:206:
+ netuio_free_hw_resources(Device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#298: FILE: kernel/windows/netuio/netuio_dev.c:207:
+ }$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#312: FILE: kernel/windows/netuio/netuio_dev.c:219:
for (UINT8 bar_index = 0; bar_index < PCI_MAX_BAR; bar_index++) {
[...]
+ // Free the allocated MDLs
ERROR:CODE_INDENT: code indent should use tabs where possible
#315: FILE: kernel/windows/netuio/netuio_dev.c:221:
+ // Free the allocated MDLs$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#315: FILE: kernel/windows/netuio/netuio_dev.c:221:
+ // Free the allocated MDLs$
ERROR:C99_COMMENTS: do not use C99 // comments
#315: FILE: kernel/windows/netuio/netuio_dev.c:221:
+ // Free the allocated MDLs
ERROR:CODE_INDENT: code indent should use tabs where possible
#316: FILE: kernel/windows/netuio/netuio_dev.c:222:
+ if (netuio_contextdata->dpdk_hw[bar_index].mdl) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#316: FILE: kernel/windows/netuio/netuio_dev.c:222:
+ if (netuio_contextdata->dpdk_hw[bar_index].mdl) {$
WARNING:BRACES: braces {} are not necessary for single statement blocks
#316: FILE: kernel/windows/netuio/netuio_dev.c:222:
+ if (netuio_contextdata->dpdk_hw[bar_index].mdl) {
+ IoFreeMdl(netuio_contextdata->dpdk_hw[bar_index].mdl);
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#317: FILE: kernel/windows/netuio/netuio_dev.c:223:
+ IoFreeMdl(netuio_contextdata->dpdk_hw[bar_index].mdl);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#317: FILE: kernel/windows/netuio/netuio_dev.c:223:
+ IoFreeMdl(netuio_contextdata->dpdk_hw[bar_index].mdl);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#318: FILE: kernel/windows/netuio/netuio_dev.c:224:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#318: FILE: kernel/windows/netuio/netuio_dev.c:224:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#320: FILE: kernel/windows/netuio/netuio_dev.c:226:
+ // Unmap all the BAR regions previously mapped$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#320: FILE: kernel/windows/netuio/netuio_dev.c:226:
+ // Unmap all the BAR regions previously mapped$
ERROR:C99_COMMENTS: do not use C99 // comments
#320: FILE: kernel/windows/netuio/netuio_dev.c:226:
+ // Unmap all the BAR regions previously mapped
ERROR:CODE_INDENT: code indent should use tabs where possible
#321: FILE: kernel/windows/netuio/netuio_dev.c:227:
+ if (netuio_contextdata->bar[bar_index].virt_addr) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#321: FILE: kernel/windows/netuio/netuio_dev.c:227:
+ if (netuio_contextdata->bar[bar_index].virt_addr) {$
WARNING:BRACES: braces {} are not necessary for single statement blocks
#321: FILE: kernel/windows/netuio/netuio_dev.c:227:
+ if (netuio_contextdata->bar[bar_index].virt_addr) {
MmUnmapIoSpace(netuio_contextdata->bar[bar_index].virt_addr, netuio_contextdata->bar[bar_index].size);
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#323: FILE: kernel/windows/netuio/netuio_dev.c:229:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#323: FILE: kernel/windows/netuio/netuio_dev.c:229:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#326: FILE: kernel/windows/netuio/netuio_dev.c:232:
+ RtlZeroMemory(netuio_contextdata->dpdk_hw, sizeof(netuio_contextdata->dpdk_hw));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#326: FILE: kernel/windows/netuio/netuio_dev.c:232:
+ RtlZeroMemory(netuio_contextdata->dpdk_hw, sizeof(netuio_contextdata->dpdk_hw));$
ERROR:CODE_INDENT: code indent should use tabs where possible
#327: FILE: kernel/windows/netuio/netuio_dev.c:233:
+ RtlZeroMemory(netuio_contextdata->bar, sizeof(netuio_contextdata->bar));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#327: FILE: kernel/windows/netuio/netuio_dev.c:233:
+ RtlZeroMemory(netuio_contextdata->bar, sizeof(netuio_contextdata->bar));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#336: FILE: kernel/windows/netuio/netuio_dev.c:316:
+ NTSTATUS status;$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#341: FILE: kernel/windows/netuio/netuio_dev.c:321:
if (!netuio_contextdata)
+ {
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#343: FILE: kernel/windows/netuio/netuio_dev.c:322:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#344: FILE: kernel/windows/netuio/netuio_dev.c:323:
+ status = STATUS_INVALID_DEVICE_STATE;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#344: FILE: kernel/windows/netuio/netuio_dev.c:323:
+ status = STATUS_INVALID_DEVICE_STATE;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#345: FILE: kernel/windows/netuio/netuio_dev.c:324:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#345: FILE: kernel/windows/netuio/netuio_dev.c:324:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#346: FILE: kernel/windows/netuio/netuio_dev.c:325:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#354: FILE: kernel/windows/netuio/netuio_dev.c:360:
+ status = STATUS_SUCCESS;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#357: FILE: kernel/windows/netuio/netuio_dev.c:363:
+ if (status != STATUS_SUCCESS)$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#357: FILE: kernel/windows/netuio/netuio_dev.c:363:
+ if (status != STATUS_SUCCESS)
+ {
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#358: FILE: kernel/windows/netuio/netuio_dev.c:364:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#359: FILE: kernel/windows/netuio/netuio_dev.c:365:
+ free_usermemory_segment(device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#359: FILE: kernel/windows/netuio/netuio_dev.c:365:
+ free_usermemory_segment(device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#360: FILE: kernel/windows/netuio/netuio_dev.c:366:
+ }$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#368: FILE: kernel/windows/netuio/netuio_dev.c:378:
if (netuio_contextdata->dpdk_seg.mdl)
+ {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#368: FILE: kernel/windows/netuio/netuio_dev.c:378:
if (netuio_contextdata->dpdk_seg.mdl)
+ {
ERROR:CODE_INDENT: code indent should use tabs where possible
#369: FILE: kernel/windows/netuio/netuio_dev.c:379:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#369: FILE: kernel/windows/netuio/netuio_dev.c:379:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#371: FILE: kernel/windows/netuio/netuio_dev.c:381:
+ netuio_contextdata->dpdk_seg.mdl = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#371: FILE: kernel/windows/netuio/netuio_dev.c:381:
+ netuio_contextdata->dpdk_seg.mdl = NULL;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#372: FILE: kernel/windows/netuio/netuio_dev.c:382:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#372: FILE: kernel/windows/netuio/netuio_dev.c:382:
+ }$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#374: FILE: kernel/windows/netuio/netuio_dev.c:384:
if (netuio_contextdata->dpdk_seg.mem.virt_addr)
+ {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#374: FILE: kernel/windows/netuio/netuio_dev.c:384:
if (netuio_contextdata->dpdk_seg.mem.virt_addr)
+ {
ERROR:CODE_INDENT: code indent should use tabs where possible
#375: FILE: kernel/windows/netuio/netuio_dev.c:385:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#375: FILE: kernel/windows/netuio/netuio_dev.c:385:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#377: FILE: kernel/windows/netuio/netuio_dev.c:387:
+ netuio_contextdata->dpdk_seg.mem.virt_addr = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#377: FILE: kernel/windows/netuio/netuio_dev.c:387:
+ netuio_contextdata->dpdk_seg.mem.virt_addr = NULL;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#378: FILE: kernel/windows/netuio/netuio_dev.c:388:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#378: FILE: kernel/windows/netuio/netuio_dev.c:388:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#404: FILE: kernel/windows/netuio/netuio_dev.h:31:
+ WDFDEVICE wdf_device; // WDF device handle to the FDO$
ERROR:C99_COMMENTS: do not use C99 // comments
#404: FILE: kernel/windows/netuio/netuio_dev.h:31:
+ WDFDEVICE wdf_device; // WDF device handle to the FDO
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#405: FILE: kernel/windows/netuio/netuio_dev.h:32:
+ BUS_INTERFACE_STANDARD bus_interface; // Bus interface for config space access$
ERROR:C99_COMMENTS: do not use C99 // comments
#405: FILE: kernel/windows/netuio/netuio_dev.h:32:
+ BUS_INTERFACE_STANDARD bus_interface; // Bus interface for config space access
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#406: FILE: kernel/windows/netuio/netuio_dev.h:33:
+ struct pci_bar bar[PCI_MAX_BAR]; // device BARs$
ERROR:C99_COMMENTS: do not use C99 // comments
#406: FILE: kernel/windows/netuio/netuio_dev.h:33:
+ struct pci_bar bar[PCI_MAX_BAR]; // device BARs
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#407: FILE: kernel/windows/netuio/netuio_dev.h:34:
+ struct dev_addr addr; // B:D:F details of device$
ERROR:C99_COMMENTS: do not use C99 // comments
#407: FILE: kernel/windows/netuio/netuio_dev.h:34:
+ struct dev_addr addr; // B:D:F details of device
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#408: FILE: kernel/windows/netuio/netuio_dev.h:35:
+ USHORT dev_numa_node; // The NUMA node of the device$
ERROR:C99_COMMENTS: do not use C99 // comments
#408: FILE: kernel/windows/netuio/netuio_dev.h:35:
+ USHORT dev_numa_node; // The NUMA node of the device
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#409: FILE: kernel/windows/netuio/netuio_dev.h:36:
+ struct mem_map_region dpdk_hw[PCI_MAX_BAR]; // mapped region for the device's register space$
ERROR:C99_COMMENTS: do not use C99 // comments
#409: FILE: kernel/windows/netuio/netuio_dev.h:36:
+ struct mem_map_region dpdk_hw[PCI_MAX_BAR]; // mapped region for the device's register space
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#410: FILE: kernel/windows/netuio/netuio_dev.h:37:
+ struct mem_map_region dpdk_seg; // mapped region allocated for DPDK process use$
ERROR:C99_COMMENTS: do not use C99 // comments
#410: FILE: kernel/windows/netuio/netuio_dev.h:37:
+ struct mem_map_region dpdk_seg; // mapped region allocated for DPDK process use
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#441: FILE: kernel/windows/netuio/netuio_drv.c:66:
+ return netuio_create_device(DeviceInit);$
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#451: FILE: kernel/windows/netuio/netuio_drv.c:128:
+/*
+Routine Description :
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#458: FILE: kernel/windows/netuio/netuio_drv.c:135:
+-*/
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#462: FILE: kernel/windows/netuio/netuio_drv.c:139:
+ WDFDEVICE device;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#463: FILE: kernel/windows/netuio/netuio_drv.c:140:
+ PNETUIO_CONTEXT_DATA netuio_contextdata;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#465: FILE: kernel/windows/netuio/netuio_drv.c:142:
+ device = WdfFileObjectGetDevice(FileObject);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#466: FILE: kernel/windows/netuio/netuio_drv.c:143:
+ netuio_contextdata = netuio_get_context_data(device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#468: FILE: kernel/windows/netuio/netuio_drv.c:145:
+ if (netuio_contextdata)$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#468: FILE: kernel/windows/netuio/netuio_drv.c:145:
+ if (netuio_contextdata)
+ {
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#469: FILE: kernel/windows/netuio/netuio_drv.c:146:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#470: FILE: kernel/windows/netuio/netuio_drv.c:147:
+ netuio_unmap_address_from_user_process(netuio_contextdata);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#470: FILE: kernel/windows/netuio/netuio_drv.c:147:
+ netuio_unmap_address_from_user_process(netuio_contextdata);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#471: FILE: kernel/windows/netuio/netuio_drv.c:148:
+ }$
WARNING:LONG_LINE: line over 100 characters
#495: FILE: kernel/windows/netuio/netuio_interface.h:25:
+#define IOCTL_NETUIO_MAP_HW_INTO_USERMODE CTL_CODE(FILE_DEVICE_NETWORK, 51, METHOD_BUFFERED, FILE_READ_ACCESS | FILE_WRITE_ACCESS)
WARNING:LONG_LINE: line over 100 characters
#496: FILE: kernel/windows/netuio/netuio_interface.h:26:
+#define IOCTL_NETUIO_PCI_CONFIG_IO CTL_CODE(FILE_DEVICE_NETWORK, 52, METHOD_BUFFERED, FILE_READ_ACCESS | FILE_WRITE_ACCESS)
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#509: FILE: kernel/windows/netuio/netuio_interface.h:50:
+ struct mem_region hw[PCI_MAX_BAR];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#559: FILE: kernel/windows/netuio/netuio_queue.c:22:
+ ASSERT(outputBufSize == sizeof(struct dpdk_private_info));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#567: FILE: kernel/windows/netuio/netuio_queue.c:27:
+ for (ULONG idx = 0; idx < PCI_MAX_BAR; idx++) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#568: FILE: kernel/windows/netuio/netuio_queue.c:28:
+ dpdk_pvt_info->hw[idx].phys_addr.QuadPart = netuio_contextdata->bar[idx].base_addr.QuadPart;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#568: FILE: kernel/windows/netuio/netuio_queue.c:28:
+ dpdk_pvt_info->hw[idx].phys_addr.QuadPart = netuio_contextdata->bar[idx].base_addr.QuadPart;$
WARNING:LONG_LINE: line over 100 characters
#569: FILE: kernel/windows/netuio/netuio_queue.c:29:
+ dpdk_pvt_info->hw[idx].user_mapped_virt_addr = netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr;
ERROR:CODE_INDENT: code indent should use tabs where possible
#569: FILE: kernel/windows/netuio/netuio_queue.c:29:
+ dpdk_pvt_info->hw[idx].user_mapped_virt_addr = netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#569: FILE: kernel/windows/netuio/netuio_queue.c:29:
+ dpdk_pvt_info->hw[idx].user_mapped_virt_addr = netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#570: FILE: kernel/windows/netuio/netuio_queue.c:30:
+ dpdk_pvt_info->hw[idx].size = netuio_contextdata->bar[idx].size;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#570: FILE: kernel/windows/netuio/netuio_queue.c:30:
+ dpdk_pvt_info->hw[idx].size = netuio_contextdata->bar[idx].size;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#571: FILE: kernel/windows/netuio/netuio_queue.c:31:
+ }$
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#579: FILE: kernel/windows/netuio/netuio_queue.c:39:
+/*
+Routine Description:
WARNING:TYPO_SPELLING: 'process'' may be misspelled - perhaps 'process's'?
#580: FILE: kernel/windows/netuio/netuio_queue.c:40:
+ Maps address ranges into the usermode process's address space. The following
ERROR:CODE_INDENT: code indent should use tabs where possible
#583: FILE: kernel/windows/netuio/netuio_queue.c:43:
+ * Any PCI BARs that our device was assigned$
ERROR:CODE_INDENT: code indent should use tabs where possible
#584: FILE: kernel/windows/netuio/netuio_queue.c:44:
+ * The scratch buffer of contiguous pages$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#592: FILE: kernel/windows/netuio/netuio_queue.c:52:
+ NTSTATUS status = STATUS_SUCCESS;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#594: FILE: kernel/windows/netuio/netuio_queue.c:54:
+ // Map the scratch memory regions to the user's process context$
ERROR:C99_COMMENTS: do not use C99 // comments
#594: FILE: kernel/windows/netuio/netuio_queue.c:54:
+ // Map the scratch memory regions to the user's process context
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#595: FILE: kernel/windows/netuio/netuio_queue.c:55:
+ MmBuildMdlForNonPagedPool(netuio_contextdata->dpdk_seg.mdl);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#596: FILE: kernel/windows/netuio/netuio_queue.c:56:
+ netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr =$
ERROR:CODE_INDENT: code indent should use tabs where possible
#597: FILE: kernel/windows/netuio/netuio_queue.c:57:
+ MmMapLockedPagesSpecifyCache($
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#597: FILE: kernel/windows/netuio/netuio_queue.c:57:
+ MmMapLockedPagesSpecifyCache($
ERROR:CODE_INDENT: code indent should use tabs where possible
#598: FILE: kernel/windows/netuio/netuio_queue.c:58:
+ netuio_contextdata->dpdk_seg.mdl, UserMode, MmCached,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#598: FILE: kernel/windows/netuio/netuio_queue.c:58:
+ netuio_contextdata->dpdk_seg.mdl, UserMode, MmCached,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#599: FILE: kernel/windows/netuio/netuio_queue.c:59:
+ NULL, FALSE, (NormalPagePriority | MdlMappingNoExecute));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#599: FILE: kernel/windows/netuio/netuio_queue.c:59:
+ NULL, FALSE, (NormalPagePriority | MdlMappingNoExecute));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#601: FILE: kernel/windows/netuio/netuio_queue.c:61:
+ if (netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr == NULL) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#602: FILE: kernel/windows/netuio/netuio_queue.c:62:
+ status = STATUS_INSUFFICIENT_RESOURCES;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#602: FILE: kernel/windows/netuio/netuio_queue.c:62:
+ status = STATUS_INSUFFICIENT_RESOURCES;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#603: FILE: kernel/windows/netuio/netuio_queue.c:63:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#603: FILE: kernel/windows/netuio/netuio_queue.c:63:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#604: FILE: kernel/windows/netuio/netuio_queue.c:64:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#606: FILE: kernel/windows/netuio/netuio_queue.c:66:
+ // Map any device BAR(s) to the user's process context$
ERROR:C99_COMMENTS: do not use C99 // comments
#606: FILE: kernel/windows/netuio/netuio_queue.c:66:
+ // Map any device BAR(s) to the user's process context
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#607: FILE: kernel/windows/netuio/netuio_queue.c:67:
+ for (INT idx = 0; idx < PCI_MAX_BAR; idx++) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#608: FILE: kernel/windows/netuio/netuio_queue.c:68:
+ if (netuio_contextdata->dpdk_hw[idx].mdl == NULL) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#608: FILE: kernel/windows/netuio/netuio_queue.c:68:
+ if (netuio_contextdata->dpdk_hw[idx].mdl == NULL) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#608: FILE: kernel/windows/netuio/netuio_queue.c:68:
+ if (netuio_contextdata->dpdk_hw[idx].mdl == NULL) {
+ continue;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#608: FILE: kernel/windows/netuio/netuio_queue.c:68:
+ if (netuio_contextdata->dpdk_hw[idx].mdl == NULL) {
+ continue;
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#609: FILE: kernel/windows/netuio/netuio_queue.c:69:
+ continue;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#609: FILE: kernel/windows/netuio/netuio_queue.c:69:
+ continue;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#610: FILE: kernel/windows/netuio/netuio_queue.c:70:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#610: FILE: kernel/windows/netuio/netuio_queue.c:70:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#612: FILE: kernel/windows/netuio/netuio_queue.c:72:
+ MmBuildMdlForNonPagedPool(netuio_contextdata->dpdk_hw[idx].mdl);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#612: FILE: kernel/windows/netuio/netuio_queue.c:72:
+ MmBuildMdlForNonPagedPool(netuio_contextdata->dpdk_hw[idx].mdl);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#613: FILE: kernel/windows/netuio/netuio_queue.c:73:
+ netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr =$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#613: FILE: kernel/windows/netuio/netuio_queue.c:73:
+ netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr =$
ERROR:CODE_INDENT: code indent should use tabs where possible
#614: FILE: kernel/windows/netuio/netuio_queue.c:74:
+ MmMapLockedPagesSpecifyCache($
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#614: FILE: kernel/windows/netuio/netuio_queue.c:74:
+ MmMapLockedPagesSpecifyCache($
ERROR:CODE_INDENT: code indent should use tabs where possible
#615: FILE: kernel/windows/netuio/netuio_queue.c:75:
+ netuio_contextdata->dpdk_hw[idx].mdl, UserMode, MmCached,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#615: FILE: kernel/windows/netuio/netuio_queue.c:75:
+ netuio_contextdata->dpdk_hw[idx].mdl, UserMode, MmCached,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#616: FILE: kernel/windows/netuio/netuio_queue.c:76:
+ NULL, FALSE, (NormalPagePriority | MdlMappingNoExecute));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#616: FILE: kernel/windows/netuio/netuio_queue.c:76:
+ NULL, FALSE, (NormalPagePriority | MdlMappingNoExecute));$
ERROR:CODE_INDENT: code indent should use tabs where possible
#618: FILE: kernel/windows/netuio/netuio_queue.c:78:
+ if (netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr == NULL) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#618: FILE: kernel/windows/netuio/netuio_queue.c:78:
+ if (netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr == NULL) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#618: FILE: kernel/windows/netuio/netuio_queue.c:78:
+ if (netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr == NULL) {
+ status = STATUS_INSUFFICIENT_RESOURCES;
ERROR:CODE_INDENT: code indent should use tabs where possible
#619: FILE: kernel/windows/netuio/netuio_queue.c:79:
+ status = STATUS_INSUFFICIENT_RESOURCES;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#619: FILE: kernel/windows/netuio/netuio_queue.c:79:
+ status = STATUS_INSUFFICIENT_RESOURCES;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#620: FILE: kernel/windows/netuio/netuio_queue.c:80:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#620: FILE: kernel/windows/netuio/netuio_queue.c:80:
+ goto end;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#621: FILE: kernel/windows/netuio/netuio_queue.c:81:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#621: FILE: kernel/windows/netuio/netuio_queue.c:81:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#622: FILE: kernel/windows/netuio/netuio_queue.c:82:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#625: FILE: kernel/windows/netuio/netuio_queue.c:85:
+ if (status != STATUS_SUCCESS) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (4, 16)
#625: FILE: kernel/windows/netuio/netuio_queue.c:85:
+ if (status != STATUS_SUCCESS) {
+ netuio_unmap_address_from_user_process(netuio_contextdata);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#625: FILE: kernel/windows/netuio/netuio_queue.c:85:
+ if (status != STATUS_SUCCESS) {
+ netuio_unmap_address_from_user_process(netuio_contextdata);
+ }
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#627: FILE: kernel/windows/netuio/netuio_queue.c:87:
+ }$
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#633: FILE: kernel/windows/netuio/netuio_queue.c:93:
+/*
+Routine Description:
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#644: FILE: kernel/windows/netuio/netuio_queue.c:104:
+ if (netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr != NULL) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#645: FILE: kernel/windows/netuio/netuio_queue.c:105:
+ MmUnmapLockedPages($
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#645: FILE: kernel/windows/netuio/netuio_queue.c:105:
+ MmUnmapLockedPages($
ERROR:CODE_INDENT: code indent should use tabs where possible
#646: FILE: kernel/windows/netuio/netuio_queue.c:106:
+ netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#646: FILE: kernel/windows/netuio/netuio_queue.c:106:
+ netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#647: FILE: kernel/windows/netuio/netuio_queue.c:107:
+ netuio_contextdata->dpdk_seg.mdl);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#647: FILE: kernel/windows/netuio/netuio_queue.c:107:
+ netuio_contextdata->dpdk_seg.mdl);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#648: FILE: kernel/windows/netuio/netuio_queue.c:108:
+ netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#648: FILE: kernel/windows/netuio/netuio_queue.c:108:
+ netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#649: FILE: kernel/windows/netuio/netuio_queue.c:109:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#651: FILE: kernel/windows/netuio/netuio_queue.c:111:
+ for (INT idx = 0; idx < PCI_MAX_BAR; idx++) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#652: FILE: kernel/windows/netuio/netuio_queue.c:112:
+ if (netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr != NULL) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#652: FILE: kernel/windows/netuio/netuio_queue.c:112:
+ if (netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr != NULL) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#652: FILE: kernel/windows/netuio/netuio_queue.c:112:
+ if (netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr != NULL) {
+ MmUnmapLockedPages(
ERROR:CODE_INDENT: code indent should use tabs where possible
#653: FILE: kernel/windows/netuio/netuio_queue.c:113:
+ MmUnmapLockedPages($
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#653: FILE: kernel/windows/netuio/netuio_queue.c:113:
+ MmUnmapLockedPages($
ERROR:CODE_INDENT: code indent should use tabs where possible
#654: FILE: kernel/windows/netuio/netuio_queue.c:114:
+ netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#654: FILE: kernel/windows/netuio/netuio_queue.c:114:
+ netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#655: FILE: kernel/windows/netuio/netuio_queue.c:115:
+ netuio_contextdata->dpdk_hw[idx].mdl);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#655: FILE: kernel/windows/netuio/netuio_queue.c:115:
+ netuio_contextdata->dpdk_hw[idx].mdl);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#656: FILE: kernel/windows/netuio/netuio_queue.c:116:
+ netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#656: FILE: kernel/windows/netuio/netuio_queue.c:116:
+ netuio_contextdata->dpdk_hw[idx].mem.user_mapped_virt_addr = NULL;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#657: FILE: kernel/windows/netuio/netuio_queue.c:117:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#657: FILE: kernel/windows/netuio/netuio_queue.c:117:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#658: FILE: kernel/windows/netuio/netuio_queue.c:118:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#669: FILE: kernel/windows/netuio/netuio_queue.c:185:
+ case IOCTL_NETUIO_MAP_HW_INTO_USERMODE:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#690: FILE: kernel/windows/netuio/netuio_queue.c:202:
+ if (netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr != NULL) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#690: FILE: kernel/windows/netuio/netuio_queue.c:202:
+ if (netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr != NULL) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#690: FILE: kernel/windows/netuio/netuio_queue.c:202:
+ if (netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr != NULL) {
+ status = STATUS_ALREADY_COMMITTED;
ERROR:CODE_INDENT: code indent should use tabs where possible
#691: FILE: kernel/windows/netuio/netuio_queue.c:203:
+ status = STATUS_ALREADY_COMMITTED;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#691: FILE: kernel/windows/netuio/netuio_queue.c:203:
+ status = STATUS_ALREADY_COMMITTED;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#705: FILE: kernel/windows/netuio/netuio_queue.c:214:
+ // Zero out the physically contiguous block$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#705: FILE: kernel/windows/netuio/netuio_queue.c:214:
+ // Zero out the physically contiguous block$
ERROR:C99_COMMENTS: do not use C99 // comments
#705: FILE: kernel/windows/netuio/netuio_queue.c:214:
+ // Zero out the physically contiguous block
WARNING:LONG_LINE: line over 100 characters
#706: FILE: kernel/windows/netuio/netuio_queue.c:215:
+ RtlZeroMemory(netuio_contextdata->dpdk_seg.mem.virt_addr, netuio_contextdata->dpdk_seg.mem.size);
ERROR:CODE_INDENT: code indent should use tabs where possible
#706: FILE: kernel/windows/netuio/netuio_queue.c:215:
+ RtlZeroMemory(netuio_contextdata->dpdk_seg.mem.virt_addr, netuio_contextdata->dpdk_seg.mem.size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#706: FILE: kernel/windows/netuio/netuio_queue.c:215:
+ RtlZeroMemory(netuio_contextdata->dpdk_seg.mem.virt_addr, netuio_contextdata->dpdk_seg.mem.size);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#708: FILE: kernel/windows/netuio/netuio_queue.c:217:
+ status = netuio_map_address_into_user_process(netuio_contextdata);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#708: FILE: kernel/windows/netuio/netuio_queue.c:217:
+ status = netuio_map_address_into_user_process(netuio_contextdata);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#709: FILE: kernel/windows/netuio/netuio_queue.c:218:
+ if (status != STATUS_SUCCESS) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#709: FILE: kernel/windows/netuio/netuio_queue.c:218:
+ if (status != STATUS_SUCCESS) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#709: FILE: kernel/windows/netuio/netuio_queue.c:218:
+ if (status != STATUS_SUCCESS) {
+ break;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#709: FILE: kernel/windows/netuio/netuio_queue.c:218:
+ if (status != STATUS_SUCCESS) {
+ break;
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#710: FILE: kernel/windows/netuio/netuio_queue.c:219:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#710: FILE: kernel/windows/netuio/netuio_queue.c:219:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#711: FILE: kernel/windows/netuio/netuio_queue.c:220:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#711: FILE: kernel/windows/netuio/netuio_queue.c:220:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#717: FILE: kernel/windows/netuio/netuio_queue.c:223:
+ netuio_handle_get_hw_data_request(Request, netuio_contextdata, output_buf, output_buf_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#717: FILE: kernel/windows/netuio/netuio_queue.c:223:
+ netuio_handle_get_hw_data_request(Request, netuio_contextdata, output_buf, output_buf_size);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#718: FILE: kernel/windows/netuio/netuio_queue.c:224:
+ bytes_returned = output_buf_size;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#718: FILE: kernel/windows/netuio/netuio_queue.c:224:
+ bytes_returned = output_buf_size;$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#725: FILE: kernel/windows/netuio/netuio_queue.c:261:
if (dpdk_pci_io_input->op == PCI_IO_READ) {
+ *(UINT64 *)output_buf = 0;
ERROR:CODE_INDENT: code indent should use tabs where possible
#732: FILE: kernel/windows/netuio/netuio_queue.c:262:
+ *(UINT64 *)output_buf = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#732: FILE: kernel/windows/netuio/netuio_queue.c:262:
+ *(UINT64 *)output_buf = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#733: FILE: kernel/windows/netuio/netuio_queue.c:263:
+ bytes_returned = netuio_contextdata->bus_interface.GetBusData($
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#733: FILE: kernel/windows/netuio/netuio_queue.c:263:
+ bytes_returned = netuio_contextdata->bus_interface.GetBusData($
ERROR:CODE_INDENT: code indent should use tabs where possible
#734: FILE: kernel/windows/netuio/netuio_queue.c:264:
+ netuio_contextdata->bus_interface.Context,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#734: FILE: kernel/windows/netuio/netuio_queue.c:264:
+ netuio_contextdata->bus_interface.Context,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#735: FILE: kernel/windows/netuio/netuio_queue.c:265:
+ PCI_WHICHSPACE_CONFIG,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#735: FILE: kernel/windows/netuio/netuio_queue.c:265:
+ PCI_WHICHSPACE_CONFIG,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#736: FILE: kernel/windows/netuio/netuio_queue.c:266:
+ output_buf,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#736: FILE: kernel/windows/netuio/netuio_queue.c:266:
+ output_buf,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#737: FILE: kernel/windows/netuio/netuio_queue.c:267:
+ dpdk_pci_io_input->offset,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#737: FILE: kernel/windows/netuio/netuio_queue.c:267:
+ dpdk_pci_io_input->offset,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#738: FILE: kernel/windows/netuio/netuio_queue.c:268:
+ dpdk_pci_io_input->access_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#738: FILE: kernel/windows/netuio/netuio_queue.c:268:
+ dpdk_pci_io_input->access_size);$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#740: FILE: kernel/windows/netuio/netuio_queue.c:270:
else if (dpdk_pci_io_input->op == PCI_IO_WRITE) {
+ // returns bytes written
ERROR:CODE_INDENT: code indent should use tabs where possible
#746: FILE: kernel/windows/netuio/netuio_queue.c:271:
+ // returns bytes written$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#746: FILE: kernel/windows/netuio/netuio_queue.c:271:
+ // returns bytes written$
ERROR:C99_COMMENTS: do not use C99 // comments
#746: FILE: kernel/windows/netuio/netuio_queue.c:271:
+ // returns bytes written
ERROR:CODE_INDENT: code indent should use tabs where possible
#747: FILE: kernel/windows/netuio/netuio_queue.c:272:
+ bytes_returned = netuio_contextdata->bus_interface.SetBusData($
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#747: FILE: kernel/windows/netuio/netuio_queue.c:272:
+ bytes_returned = netuio_contextdata->bus_interface.SetBusData($
ERROR:CODE_INDENT: code indent should use tabs where possible
#748: FILE: kernel/windows/netuio/netuio_queue.c:273:
+ netuio_contextdata->bus_interface.Context,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#748: FILE: kernel/windows/netuio/netuio_queue.c:273:
+ netuio_contextdata->bus_interface.Context,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#749: FILE: kernel/windows/netuio/netuio_queue.c:274:
+ PCI_WHICHSPACE_CONFIG,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#749: FILE: kernel/windows/netuio/netuio_queue.c:274:
+ PCI_WHICHSPACE_CONFIG,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#750: FILE: kernel/windows/netuio/netuio_queue.c:275:
+ (PVOID)&dpdk_pci_io_input->data,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#750: FILE: kernel/windows/netuio/netuio_queue.c:275:
+ (PVOID)&dpdk_pci_io_input->data,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#751: FILE: kernel/windows/netuio/netuio_queue.c:276:
+ dpdk_pci_io_input->offset,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#751: FILE: kernel/windows/netuio/netuio_queue.c:276:
+ dpdk_pci_io_input->offset,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#752: FILE: kernel/windows/netuio/netuio_queue.c:277:
+ dpdk_pci_io_input->access_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#752: FILE: kernel/windows/netuio/netuio_queue.c:277:
+ dpdk_pci_io_input->access_size);$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 161 errors, 242 warnings, 648 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-13 23:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1597360905-74106-13-git-send-email-navasile@linux.microsoft.com>
2020-08-13 23:25 ` [dpdk-test-report] |WARNING| pw75532 [PATCH 12/22] uio: Fix 64 bit BARs mapping checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).