* [dpdk-test-report] |WARNING| pw76224 [PATCH v1 21/42] net/txgbe: add RX and TX queues setup
[not found] <20200901115113.1529675-21-jiawenwu@trustnetic.com>
@ 2020-09-08 23:27 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-09-08 23:27 UTC (permalink / raw)
To: test-report; +Cc: Jiawen Wu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76224
_coding style issues_
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#133: FILE: drivers/net/txgbe/txgbe_rxtx.c:116:
+ unsigned i;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc > TXGBE_RING_DESC_MAX'
#195: FILE: drivers/net/txgbe/txgbe_rxtx.c:207:
+ if (nb_desc % TXGBE_TXD_ALIGN != 0 ||
+ (nb_desc > TXGBE_RING_DESC_MAX) ||
+ (nb_desc < TXGBE_RING_DESC_MIN)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc < TXGBE_RING_DESC_MIN'
#195: FILE: drivers/net/txgbe/txgbe_rxtx.c:207:
+ if (nb_desc % TXGBE_TXD_ALIGN != 0 ||
+ (nb_desc > TXGBE_RING_DESC_MAX) ||
+ (nb_desc < TXGBE_RING_DESC_MIN)) {
CHECK:SPACING: No space is necessary after a cast
#279: FILE: drivers/net/txgbe/txgbe_rxtx.c:291:
+ txq->tx_ring = (struct txgbe_tx_desc *) TMZ_VADDR(tz);
CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#289: FILE: drivers/net/txgbe/txgbe_rxtx.c:301:
+ PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%"PRIx64,
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#289: FILE: drivers/net/txgbe/txgbe_rxtx.c:301:
+ PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%"PRIx64,
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc > TXGBE_RING_DESC_MAX'
#385: FILE: drivers/net/txgbe/txgbe_rxtx.c:501:
+ if (nb_desc % TXGBE_RXD_ALIGN != 0 ||
+ (nb_desc > TXGBE_RING_DESC_MAX) ||
+ (nb_desc < TXGBE_RING_DESC_MIN)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc < TXGBE_RING_DESC_MIN'
#385: FILE: drivers/net/txgbe/txgbe_rxtx.c:501:
+ if (nb_desc % TXGBE_RXD_ALIGN != 0 ||
+ (nb_desc > TXGBE_RING_DESC_MAX) ||
+ (nb_desc < TXGBE_RING_DESC_MIN)) {
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#506: FILE: drivers/net/txgbe/txgbe_rxtx.c:622:
+ "dma_addr=0x%"PRIx64,
total: 0 errors, 1 warnings, 8 checks, 518 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-08 23:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200901115113.1529675-21-jiawenwu@trustnetic.com>
2020-09-08 23:27 ` [dpdk-test-report] |WARNING| pw76224 [PATCH v1 21/42] net/txgbe: add RX and TX queues setup checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).