[dpdk-test-report] |WARNING| pw76242 [PATCH v1 39/42] net/txgbe: configure DCB HW resources

automatic DPDK test reports
 help / color / mirror / Atom feed

* [dpdk-test-report] |WARNING| pw76242 [PATCH v1 39/42] net/txgbe: configure DCB HW resources
       [not found] <20200901115113.1529675-39-jiawenwu@trustnetic.com>
@ 2020-09-08 23:29 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-09-08 23:29 UTC (permalink / raw)
  To: test-report; +Cc: Jiawen Wu

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76242

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#317: FILE: drivers/net/txgbe/base/txgbe_dcb.h:96:
+s32 txgbe_dcb_calculate_tc_credits_cee(struct txgbe_hw *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name
#317: FILE: drivers/net/txgbe/base/txgbe_dcb.h:96:
+s32 txgbe_dcb_calculate_tc_credits_cee(struct txgbe_hw *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#317: FILE: drivers/net/txgbe/base/txgbe_dcb.h:96:
+s32 txgbe_dcb_calculate_tc_credits_cee(struct txgbe_hw *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#317: FILE: drivers/net/txgbe/base/txgbe_dcb.h:96:
+s32 txgbe_dcb_calculate_tc_credits_cee(struct txgbe_hw *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#321: FILE: drivers/net/txgbe/base/txgbe_dcb.h:100:
+s32 txgbe_dcb_config_pfc(struct txgbe_hw *, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#321: FILE: drivers/net/txgbe/base/txgbe_dcb.h:100:
+s32 txgbe_dcb_config_pfc(struct txgbe_hw *, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#321: FILE: drivers/net/txgbe/base/txgbe_dcb.h:100:
+s32 txgbe_dcb_config_pfc(struct txgbe_hw *, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name
#324: FILE: drivers/net/txgbe/base/txgbe_dcb.h:103:
+void txgbe_dcb_unpack_pfc_cee(struct txgbe_dcb_config *, u8 *, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#324: FILE: drivers/net/txgbe/base/txgbe_dcb.h:103:
+void txgbe_dcb_unpack_pfc_cee(struct txgbe_dcb_config *, u8 *, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#324: FILE: drivers/net/txgbe/base/txgbe_dcb.h:103:
+void txgbe_dcb_unpack_pfc_cee(struct txgbe_dcb_config *, u8 *, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name
#325: FILE: drivers/net/txgbe/base/txgbe_dcb.h:104:
+void txgbe_dcb_unpack_refill_cee(struct txgbe_dcb_config *, int, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#325: FILE: drivers/net/txgbe/base/txgbe_dcb.h:104:
+void txgbe_dcb_unpack_refill_cee(struct txgbe_dcb_config *, int, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#325: FILE: drivers/net/txgbe/base/txgbe_dcb.h:104:
+void txgbe_dcb_unpack_refill_cee(struct txgbe_dcb_config *, int, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name
#326: FILE: drivers/net/txgbe/base/txgbe_dcb.h:105:
+void txgbe_dcb_unpack_max_cee(struct txgbe_dcb_config *, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#326: FILE: drivers/net/txgbe/base/txgbe_dcb.h:105:
+void txgbe_dcb_unpack_max_cee(struct txgbe_dcb_config *, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name
#327: FILE: drivers/net/txgbe/base/txgbe_dcb.h:106:
+void txgbe_dcb_unpack_bwgid_cee(struct txgbe_dcb_config *, int, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#327: FILE: drivers/net/txgbe/base/txgbe_dcb.h:106:
+void txgbe_dcb_unpack_bwgid_cee(struct txgbe_dcb_config *, int, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#327: FILE: drivers/net/txgbe/base/txgbe_dcb.h:106:
+void txgbe_dcb_unpack_bwgid_cee(struct txgbe_dcb_config *, int, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name
#328: FILE: drivers/net/txgbe/base/txgbe_dcb.h:107:
+void txgbe_dcb_unpack_tsa_cee(struct txgbe_dcb_config *, int, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#328: FILE: drivers/net/txgbe/base/txgbe_dcb.h:107:
+void txgbe_dcb_unpack_tsa_cee(struct txgbe_dcb_config *, int, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#328: FILE: drivers/net/txgbe/base/txgbe_dcb.h:107:
+void txgbe_dcb_unpack_tsa_cee(struct txgbe_dcb_config *, int, u8 *);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#430: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.c:90:
+	for (i = 0; i < 128; i++) {
+		wr32(hw, TXGBE_QARBTXCRED(i), 0);
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'map[j] == i'
#554: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.c:214:
+			if ((map[j] == i) && (pfc_en & (1 << j))) {

CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#618: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.c:278:
+	if (!((tc_count == 8 && vt_mode == false) || tc_count == 4))

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#638: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:9:
+s32 txgbe_dcb_config_pfc_raptor(struct txgbe_hw *, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#638: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:9:
+s32 txgbe_dcb_config_pfc_raptor(struct txgbe_hw *, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#638: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:9:
+s32 txgbe_dcb_config_pfc_raptor(struct txgbe_hw *, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#641: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:12:
+s32 txgbe_dcb_config_tc_stats_raptor(struct txgbe_hw *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name
#641: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:12:
+s32 txgbe_dcb_config_tc_stats_raptor(struct txgbe_hw *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#645: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:16:
+s32 txgbe_dcb_config_tx_desc_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#645: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:16:
+s32 txgbe_dcb_config_tx_desc_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#645: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:16:
+s32 txgbe_dcb_config_tx_desc_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#645: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:16:
+s32 txgbe_dcb_config_tx_desc_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#645: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:16:
+s32 txgbe_dcb_config_tx_desc_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#647: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:18:
+s32 txgbe_dcb_config_tx_data_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#647: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:18:
+s32 txgbe_dcb_config_tx_data_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#647: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:18:
+s32 txgbe_dcb_config_tx_data_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#647: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:18:
+s32 txgbe_dcb_config_tx_data_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#647: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:18:
+s32 txgbe_dcb_config_tx_data_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#647: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:18:
+s32 txgbe_dcb_config_tx_data_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#649: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:20:
+s32 txgbe_dcb_config_rx_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, u8 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#649: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:20:
+s32 txgbe_dcb_config_rx_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, u8 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#649: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:20:
+s32 txgbe_dcb_config_rx_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, u8 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#649: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:20:
+s32 txgbe_dcb_config_rx_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, u8 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#649: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:20:
+s32 txgbe_dcb_config_rx_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, u8 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#649: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:20:
+s32 txgbe_dcb_config_rx_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, u8 *,

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#774: FILE: drivers/net/txgbe/txgbe_rxtx.c:2789:
+	if (dcb_config->num_tcs.pg_tcs == 8) {
[...]
+	} else {
[...]

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#867: FILE: drivers/net/txgbe/txgbe_rxtx.c:2882:
+		if (dcb_config->vt_mode) {
[...]
+		} else {
[...]

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#876: FILE: drivers/net/txgbe/txgbe_rxtx.c:2891:
+		if (dcb_config->vt_mode)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#878: FILE: drivers/net/txgbe/txgbe_rxtx.c:2893:
+		else {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#891: FILE: drivers/net/txgbe/txgbe_rxtx.c:2906:
+	for (i = 0; i < NUM_VFTA_REGISTERS; i++) {
+		wr32(hw, TXGBE_VLANTBL(i), 0xFFFFFFFF);
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'j < ETH_DCB_NUM_USER_PRIORITIES'
#992: FILE: drivers/net/txgbe/txgbe_rxtx.c:3007:
+			if ((mask & 0x1) && (j < ETH_DCB_NUM_USER_PRIORITIES))

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1029: FILE: drivers/net/txgbe/txgbe_rxtx.c:3044:
+		for (i = 0; i < nb_tcs; i++) {
+			wr32(hw, TXGBE_PBRXSIZE(i), rxpbsize);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1033: FILE: drivers/net/txgbe/txgbe_rxtx.c:3048:
+		for (; i < ETH_DCB_NUM_USER_PRIORITIES; i++) {
+			wr32(hw, TXGBE_PBRXSIZE(i), 0);
+		}

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1089: FILE: drivers/net/txgbe/txgbe_rxtx.c:3104:
+			/*
+			* If the TC count is 8,and the default high_water is 48,

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around dev->data->dev_conf
#1121: FILE: drivers/net/txgbe/txgbe_rxtx.c:3180:
+	struct rte_eth_conf *dev_conf = &(dev->data->dev_conf);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev_conf->rxmode.mq_mode != ETH_MQ_RX_VMDQ_DCB'
#1126: FILE: drivers/net/txgbe/txgbe_rxtx.c:3185:
+	if ((dev_conf->rxmode.mq_mode != ETH_MQ_RX_VMDQ_DCB) &&
+	    (dev_conf->rxmode.mq_mode != ETH_MQ_RX_DCB) &&
+	    (dev_conf->rxmode.mq_mode != ETH_MQ_RX_DCB_RSS))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev_conf->rxmode.mq_mode != ETH_MQ_RX_DCB'
#1126: FILE: drivers/net/txgbe/txgbe_rxtx.c:3185:
+	if ((dev_conf->rxmode.mq_mode != ETH_MQ_RX_VMDQ_DCB) &&
+	    (dev_conf->rxmode.mq_mode != ETH_MQ_RX_DCB) &&
+	    (dev_conf->rxmode.mq_mode != ETH_MQ_RX_DCB_RSS))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev_conf->rxmode.mq_mode != ETH_MQ_RX_DCB_RSS'
#1126: FILE: drivers/net/txgbe/txgbe_rxtx.c:3185:
+	if ((dev_conf->rxmode.mq_mode != ETH_MQ_RX_VMDQ_DCB) &&
+	    (dev_conf->rxmode.mq_mode != ETH_MQ_RX_DCB) &&
+	    (dev_conf->rxmode.mq_mode != ETH_MQ_RX_DCB_RSS))

total: 0 errors, 51 warnings, 8 checks, 1010 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-09-08 23:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200901115113.1529675-39-jiawenwu@trustnetic.com>
2020-09-08 23:29 ` [dpdk-test-report] |WARNING| pw76242 [PATCH v1 39/42] net/txgbe: configure DCB HW resources checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).