From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Joyce Kong <joyce.kong@arm.com>
Subject: [dpdk-test-report] |WARNING| pw77384 [RFC 1/3] net/virtio: move AVX based Rx and Tx code to separate file
Date: Fri, 11 Sep 2020 14:10:30 +0200 (CEST) [thread overview]
Message-ID: <20200911121030.E7FCC1C0B9@dpdk.org> (raw)
In-Reply-To: <20200911120906.45995-2-joyce.kong@arm.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/77384
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <_Pragma>
#178: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#178: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#178: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#178: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+ for (iter = val; iter < size; iter++)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#183: FILE: drivers/net/virtio/virtio_rxtx_packed.h:57:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#183: FILE: drivers/net/virtio/virtio_rxtx_packed.h:57:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#183: FILE: drivers/net/virtio/virtio_rxtx_packed.h:57:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+ for (iter = val; iter < size; iter++)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#188: FILE: drivers/net/virtio/virtio_rxtx_packed.h:62:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#188: FILE: drivers/net/virtio/virtio_rxtx_packed.h:62:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#188: FILE: drivers/net/virtio/virtio_rxtx_packed.h:62:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#193: FILE: drivers/net/virtio/virtio_rxtx_packed.h:67:
+#define virtio_for_each_try_unroll(iter, val, num) \
+ for (iter = val; iter < num; iter++)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'num' may be better as '(num)' to avoid precedence issues
#193: FILE: drivers/net/virtio/virtio_rxtx_packed.h:67:
+#define virtio_for_each_try_unroll(iter, val, num) \
+ for (iter = val; iter < num; iter++)
WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Joyce Kong <joyce.kong@arm.com>'
total: 3 errors, 1 warnings, 9 checks, 618 lines checked
Warning in drivers/net/virtio/virtio_rxtx_packed.c:
Using rte_panic/rte_exit
parent reply other threads:[~2020-09-11 12:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200911120906.45995-2-joyce.kong@arm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911121030.E7FCC1C0B9@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=joyce.kong@arm.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).