From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw78362 [PATCH v2 33/60] common/sfc_efx/base: implement Tx control path for Riverhead
Date: Tue, 22 Sep 2020 11:42:40 +0200 (CEST) [thread overview]
Message-ID: <20200922094240.46D2A1DD15@dpdk.org> (raw)
In-Reply-To: <1600767288-12109-34-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78362
_coding style issues_
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#260: FILE: drivers/common/sfc_efx/base/rhead_impl.h:396:
+ __inout unsigned int *addedp);
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#292: FILE: drivers/common/sfc_efx/base/rhead_impl.h:428:
+ __inout unsigned int *addedp);
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#300: FILE: drivers/common/sfc_efx/base/rhead_impl.h:436:
+ __inout_ecount(TX_NQSTATS) efsys_stat_t *stat);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#364: FILE: drivers/common/sfc_efx/base/rhead_tx.c:51:
+ if ((rc = efx_mcdi_init_txq(enp, ndescs, eep->ee_index, label, index,
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#374: FILE: drivers/common/sfc_efx/base/rhead_tx.c:61:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#379: FILE: drivers/common/sfc_efx/base/rhead_tx.c:66:
+ return (rc);
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#396: FILE: drivers/common/sfc_efx/base/rhead_tx.c:83:
+ __inout unsigned int *addedp)
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#406: FILE: drivers/common/sfc_efx/base/rhead_tx.c:93:
+ return (ENOTSUP);
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#431: FILE: drivers/common/sfc_efx/base/rhead_tx.c:118:
+ return (ENOTSUP);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#441: FILE: drivers/common/sfc_efx/base/rhead_tx.c:128:
+ if ((rc = efx_mcdi_fini_txq(enp, etp->et_index)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#444: FILE: drivers/common/sfc_efx/base/rhead_tx.c:131:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#456: FILE: drivers/common/sfc_efx/base/rhead_tx.c:143:
+ return (rc);
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#473: FILE: drivers/common/sfc_efx/base/rhead_tx.c:160:
+ __inout unsigned int *addedp)
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#483: FILE: drivers/common/sfc_efx/base/rhead_tx.c:170:
+ return (ENOTSUP);
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#491: FILE: drivers/common/sfc_efx/base/rhead_tx.c:178:
+ __inout_ecount(TX_NQSTATS) efsys_stat_t *stat)
total: 6 errors, 9 warnings, 368 lines checked
parent reply other threads:[~2020-09-22 9:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1600767288-12109-34-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922094240.46D2A1DD15@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).