automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw92077 [21.08 PATCH v4 2/2] power: refactor pstate and acpi code
       [not found] <83b1e89d14834251d4d7e72fcc19d82dfb52686d.1619175790.git.anatoly.burakov@intel.com>
@ 2021-04-23 11:04 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-04-23 11:04 UTC (permalink / raw)
  To: test-report; +Cc: Anatoly Burakov

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/92077

_coding style issues_


WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#508: FILE: lib/power/power_common.h:14:
+#define POWER_DEBUG_TRACE(fmt, args...) do { \
+		RTE_LOG(ERR, POWER, "%s: " fmt, __func__, ## args); \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#515: FILE: lib/power/power_common.h:21:
+#define FOPEN_OR_ERR_RET(f, retval) do { \
+		if ((f) == NULL) { \
+			RTE_LOG(ERR, POWER, "File not opened
"); \
+			return retval; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#522: FILE: lib/power/power_common.h:28:
+#define FOPEN_OR_ERR_GOTO(f, label) do { \
+		if ((f) == NULL) { \
+			RTE_LOG(ERR, POWER, "File not opened
"); \
+			goto label; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#529: FILE: lib/power/power_common.h:35:
+#define FOPS_OR_NULL_GOTO(ret, label) do { \
+		if ((ret) == NULL) { \
+			RTE_LOG(ERR, POWER, "fgets returns nothing
"); \
+			goto label; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#536: FILE: lib/power/power_common.h:42:
+#define FOPS_OR_ERR_GOTO(ret, label) do { \
+		if ((ret) < 0) { \
+			RTE_LOG(ERR, POWER, "File operations failed
"); \
+			goto label; \
+		} \
+} while (0)

total: 0 errors, 5 warnings, 857 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-04-23 11:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <83b1e89d14834251d4d7e72fcc19d82dfb52686d.1619175790.git.anatoly.burakov@intel.com>
2021-04-23 11:04 ` [dpdk-test-report] |WARNING| pw92077 [21.08 PATCH v4 2/2] power: refactor pstate and acpi code checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).