From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: [dpdk-test-report] |WARNING| pw97171 [RFC 5/7] eth: make drivers to use new API to obtain descriptor status
Date: Fri, 20 Aug 2021 18:30:33 +0200 (CEST) [thread overview]
Message-ID: <20210820163033.DF1C21226B3@dpdk.org> (raw)
In-Reply-To: <20210820162834.12544-6-konstantin.ananyev@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97171
_coding style issues_
ERROR:CODE_INDENT: code indent should use tabs where possible
#263: FILE: lib/ethdev/ethdev_driver.h:1824:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#263: FILE: lib/ethdev/ethdev_driver.h:1824:
+ return 0;$
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#280: FILE: lib/ethdev/ethdev_driver.h:1841:
+#define _RTE_ETH_RX_DESC_DEF(fn) \
+_RTE_ETH_RX_DESC_PROTO(fn) \
+{ \
+ int rc; \
+ void *rxq; \
+ rc = _rte_eth_rx_desc_prolog(port_id, queue_id, &rxq); \
+ if (rc != 0) \
+ return rc; \
+ return fn(rxq, offset); \
+}
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#280: FILE: lib/ethdev/ethdev_driver.h:1841:
+#define _RTE_ETH_RX_DESC_DEF(fn) \
+_RTE_ETH_RX_DESC_PROTO(fn) \
+{ \
+ int rc; \
+ void *rxq; \
+ rc = _rte_eth_rx_desc_prolog(port_id, queue_id, &rxq); \
+ if (rc != 0) \
+ return rc; \
+ return fn(rxq, offset); \
+}
ERROR:CODE_INDENT: code indent should use tabs where possible
#329: FILE: lib/ethdev/ethdev_driver.h:1890:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#329: FILE: lib/ethdev/ethdev_driver.h:1890:
+ return 0;$
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#346: FILE: lib/ethdev/ethdev_driver.h:1907:
+#define _RTE_ETH_TX_DESC_DEF(fn) \
+_RTE_ETH_TX_DESC_PROTO(fn) \
+{ \
+ int rc; \
+ void *txq; \
+ rc = _rte_eth_tx_desc_prolog(port_id, queue_id, &txq); \
+ if (rc != 0) \
+ return rc; \
+ return fn(txq, offset); \
+}
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#346: FILE: lib/ethdev/ethdev_driver.h:1907:
+#define _RTE_ETH_TX_DESC_DEF(fn) \
+_RTE_ETH_TX_DESC_PROTO(fn) \
+{ \
+ int rc; \
+ void *txq; \
+ rc = _rte_eth_tx_desc_prolog(port_id, queue_id, &txq); \
+ if (rc != 0) \
+ return rc; \
+ return fn(txq, offset); \
+}
total: 4 errors, 4 warnings, 378 lines checked
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)
parent reply other threads:[~2021-08-20 16:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210820162834.12544-6-konstantin.ananyev@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820163033.DF1C21226B3@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).