|WARNING| pw104171 [PATCH] net/mlx5: remove redundant "set used"

|WARNING| pw104171 [PATCH] net/mlx5: remove redundant "set used"

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 2288 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/104171

_apply patch failure_

Submitter: Slava Ovsiienko <viacheslavo@nvidia.com>
Date: Thursday, November 11 2021 08:47:51 
Applied on: CommitID:19d024003dfce0018c9e52635b78efdc6e1c172a
Apply patch set 104171 failed:

Checking patch drivers/net/mlx5/mlx5_txpp.c...
error: while searching for:
{
	struct mlx5_priv *priv = dev->data->dev_private;
	struct mlx5_dev_ctx_shared *sh = priv->sh;
	int ret;

	if (!priv->txpp_en) {
		/* Packet pacing is already disabled for the device. */
		return;
	}
	priv->txpp_en = 0;
	ret = pthread_mutex_lock(&sh->txpp.mutex);
	MLX5_ASSERT(!ret);
	RTE_SET_USED(ret);
	MLX5_ASSERT(sh->txpp.refcnt);
	if (!sh->txpp.refcnt || --sh->txpp.refcnt) {
		ret = pthread_mutex_unlock(&sh->txpp.mutex);
		MLX5_ASSERT(!ret);
		RTE_SET_USED(ret);
		return;
	}
	/* No references any more, do actual destroy. */
	mlx5_txpp_destroy(sh);
	ret = pthread_mutex_unlock(&sh->txpp.mutex);
	MLX5_ASSERT(!ret);
	RTE_SET_USED(ret);
}

/*

error: patch failed: drivers/net/mlx5/mlx5_txpp.c:944
Applying patch drivers/net/mlx5/mlx5_txpp.c with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Rejected hunk #4.
diff a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c	(rejected hunks)
@@ -944,28 +941,21 @@ mlx5_txpp_stop(struct rte_eth_dev *dev)
 {
 	struct mlx5_priv *priv = dev->data->dev_private;
 	struct mlx5_dev_ctx_shared *sh = priv->sh;
-	int ret;
 
 	if (!priv->txpp_en) {
 		/* Packet pacing is already disabled for the device. */
 		return;
 	}
 	priv->txpp_en = 0;
-	ret = pthread_mutex_lock(&sh->txpp.mutex);
-	MLX5_ASSERT(!ret);
-	RTE_SET_USED(ret);
+	claim_zero(pthread_mutex_lock(&sh->txpp.mutex));
 	MLX5_ASSERT(sh->txpp.refcnt);
 	if (!sh->txpp.refcnt || --sh->txpp.refcnt) {
-		ret = pthread_mutex_unlock(&sh->txpp.mutex);
-		MLX5_ASSERT(!ret);
-		RTE_SET_USED(ret);
+		claim_zero(pthread_mutex_unlock(&sh->txpp.mutex));
 		return;
 	}
 	/* No references any more, do actual destroy. */
 	mlx5_txpp_destroy(sh);
-	ret = pthread_mutex_unlock(&sh->txpp.mutex);
-	MLX5_ASSERT(!ret);
-	RTE_SET_USED(ret);
+	claim_zero(pthread_mutex_unlock(&sh->txpp.mutex));
 }
 
 /*

https://lab.dpdk.org/results/dashboard/patchsets/20153/

UNH-IOL DPDK Community Lab