|WARNING| pw105319 [PATCH v2 8/8] net/bonding: add LACP short timeout tests

|WARNING| pw105319 [PATCH v2 8/8] net/bonding: add LACP short timeout tests

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105319

_coding style issues_


WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#81: 
- Remove call to rte_eth_dev_mac_addr_remove from add_slave,

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#221: FILE: app/test/test_link_bonding_mode4.c:741:
+	struct slave_conf *slave;

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#221: FILE: app/test/test_link_bonding_mode4.c:741:
+	struct slave_conf *slave;

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#224: FILE: app/test/test_link_bonding_mode4.c:744:
+	struct rte_eth_bond_8023ad_slave_info info;

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#228: FILE: app/test/test_link_bonding_mode4.c:748:
+	retval = initialize_bonded_device_with_slaves(TEST_LACP_SLAVE_COUT, 0);

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#228: FILE: app/test/test_link_bonding_mode4.c:748:
+	retval = initialize_bonded_device_with_slaves(TEST_LACP_SLAVE_COUT, 0);

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#243: FILE: app/test/test_link_bonding_mode4.c:763:
+		 * value to slaves (iterations 1 and 2).

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#250: FILE: app/test/test_link_bonding_mode4.c:770:
+		/* Verify that slaves' actor states have expected value.*/

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#251: FILE: app/test/test_link_bonding_mode4.c:771:
+		FOR_EACH_PORT(i, slave) {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#252: FILE: app/test/test_link_bonding_mode4.c:772:
+			retval = rte_eth_bond_8023ad_slave_info(port_id,

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#253: FILE: app/test/test_link_bonding_mode4.c:773:
+				slave->port_id, &info);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#255: FILE: app/test/test_link_bonding_mode4.c:775:
+				"Failed to get LACP slave info");

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#258: FILE: app/test/test_link_bonding_mode4.c:778:
+				" Wrong LACP slave info timeout flag");

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#269: FILE: app/test/test_link_bonding_mode4.c:789:
+	retval = remove_slaves_and_stop_bonded_device();

WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Robert Sanford <rsanford2@gmail.com>' != 'Signed-off-by: Robert Sanford <rsanford@akamai.com>'

total: 0 errors, 15 warnings, 195 lines checked

|FAILURE| pw105319 [PATCH v2 8/8] net/bonding: add LACP short timeout tests

[0-day Robot]

From: robot@bytheb.org

Test-Label: github-robot: build
Test-Status: FAILURE
http://patchwork.dpdk.org/patch/105319/

_github build: failed_
Build URL: https://github.com/ovsrobot/dpdk/actions/runs/1608520874
Build Logs:
-----------------------Summary of failed steps-----------------------
"ubuntu-18.04-gcc-shared-abi+doc+tests" failed at step Build and test
----------------------End summary of failed steps--------------------

-------------------------------BEGIN LOGS----------------------------
####################################################################################
#### [Begin job log] "ubuntu-18.04-gcc-shared-abi+doc+tests" at step Build and test
####################################################################################
Installing /home/runner/work/dpdk/dpdk/doc/guides/custom.css to /home/runner/work/dpdk/dpdk/install/usr/local/share/doc/dpdk/_static/css
Installing /home/runner/work/dpdk/dpdk/build/rte_build_config.h to /home/runner/work/dpdk/dpdk/install/usr/local/include
Installing /home/runner/work/dpdk/dpdk/build/meson-private/libdpdk-libs.pc to /home/runner/work/dpdk/dpdk/install/usr/local/lib/x86_64-linux-gnu/pkgconfig
Installing /home/runner/work/dpdk/dpdk/build/meson-private/libdpdk.pc to /home/runner/work/dpdk/dpdk/install/usr/local/lib/x86_64-linux-gnu/pkgconfig
Running custom install script '/bin/sh /home/runner/work/dpdk/dpdk/config/../buildtools/symlink-drivers-solibs.sh lib/x86_64-linux-gnu dpdk/pmds-22.1'
+ devtools/gen-abi.sh install
+ devtools/check-abi.sh reference install
Functions changes summary: 0 Removed, 1 Changed (1 filtered out), 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

1 function with some indirect sub-type change:

  [C] 'function int rte_eth_bond_8023ad_conf_get(uint16_t, rte_eth_bond_8023ad_conf*)' at rte_eth_bond_8023ad.c:1423:1 has some indirect sub-type changes:
    parameter 2 of type 'rte_eth_bond_8023ad_conf*' has sub-type changes:
      in pointed to type 'struct rte_eth_bond_8023ad_conf' at rte_eth_bond_8023ad.h:131:1:
Error: ABI issue reported for 'abidiff --suppr devtools/libabigail.abignore --no-added-syms --headers-dir1 reference/usr/local/include --headers-dir2 install/usr/local/include reference/dump/librte_net_bond.dump install/dump/librte_net_bond.dump'
ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue).
        type size hasn't changed
        2 data member insertions:
          'uint8_t rte_eth_bond_8023ad_conf::lacp_timeout_control', at offset 352 (in bits) at rte_eth_bond_8023ad.h:142:1
          'uint8_t rte_eth_bond_8023ad_conf::reserved_8s[3]', at offset 360 (in bits) at rte_eth_bond_8023ad.h:144:1



##[error]Process completed with exit code 1.
####################################################################################
#### [End job log] "ubuntu-18.04-gcc-shared-abi+doc+tests" at step Build and test
####################################################################################
--------------------------------END LOGS-----------------------------