From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: <abhimanyu.saini@xilinx.com>
Subject: |WARNING| pw105720 [PATCH] vdpa/sfc: make MCDI memzone name unique
Date: Tue, 11 Jan 2022 06:34:41 +0100 (CET) [thread overview]
Message-ID: <20220111053441.E9082121D83@dpdk.org> (raw)
In-Reply-To: <20220111053303.18162-1-asaini@xilinx.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105720
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#148: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:28:
+ char mz_name[RTE_MEMZONE_NAMESIZE];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#154: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:34:
+ ret = snprintf(mz_name, RTE_MEMZONE_NAMESIZE, "%s_%s",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:35:
+ sva->pdev->name, name);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#155: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:35:
+ sva->pdev->name, name);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#156: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:36:
+ if (ret < 0 || ret >= RTE_MEMZONE_NAMESIZE) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#156: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:36:
+ if (ret < 0 || ret >= RTE_MEMZONE_NAMESIZE) {
+ sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",
ERROR:CODE_INDENT: code indent should use tabs where possible
#157: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:37:
+ sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#157: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:37:
+ sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#158: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:38:
+ sva->pdev->name, name);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:38:
+ sva->pdev->name, name);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:39:
+ return -EINVAL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:39:
+ return -EINVAL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:40:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:42:
+ sfc_vdpa_log_init(sva, "name=%s, len=%zu", mz_name, len);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#166: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:44:
+ mz = rte_memzone_reserve_aligned(mz_name, mcdi_buff_size,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#173: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:50:
+ mz_name, (unsigned int)len,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#173: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:50:
+ mz_name, (unsigned int)len,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#174: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:51:
+ rte_strerror(rte_errno));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#174: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:51:
+ rte_strerror(rte_errno));$
total: 6 errors, 13 warnings, 33 lines checked
next parent reply other threads:[~2022-01-11 5:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220111053303.18162-1-asaini@xilinx.com>
2022-01-11 5:34 ` checkpatch [this message]
2022-01-11 5:48 dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111053441.E9082121D83@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=abhimanyu.saini@xilinx.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).