* |WARNING| pw105720 [PATCH] vdpa/sfc: make MCDI memzone name unique
[not found] <20220111053303.18162-1-asaini@xilinx.com>
@ 2022-01-11 5:34 ` checkpatch
0 siblings, 0 replies; 2+ messages in thread
From: checkpatch @ 2022-01-11 5:34 UTC (permalink / raw)
To: test-report; +Cc: abhimanyu.saini
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105720
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#148: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:28:
+ char mz_name[RTE_MEMZONE_NAMESIZE];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#154: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:34:
+ ret = snprintf(mz_name, RTE_MEMZONE_NAMESIZE, "%s_%s",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:35:
+ sva->pdev->name, name);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#155: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:35:
+ sva->pdev->name, name);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#156: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:36:
+ if (ret < 0 || ret >= RTE_MEMZONE_NAMESIZE) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#156: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:36:
+ if (ret < 0 || ret >= RTE_MEMZONE_NAMESIZE) {
+ sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",
ERROR:CODE_INDENT: code indent should use tabs where possible
#157: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:37:
+ sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#157: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:37:
+ sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#158: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:38:
+ sva->pdev->name, name);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:38:
+ sva->pdev->name, name);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:39:
+ return -EINVAL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:39:
+ return -EINVAL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:40:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:42:
+ sfc_vdpa_log_init(sva, "name=%s, len=%zu", mz_name, len);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#166: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:44:
+ mz = rte_memzone_reserve_aligned(mz_name, mcdi_buff_size,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#173: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:50:
+ mz_name, (unsigned int)len,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#173: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:50:
+ mz_name, (unsigned int)len,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#174: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:51:
+ rte_strerror(rte_errno));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#174: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:51:
+ rte_strerror(rte_errno));$
total: 6 errors, 13 warnings, 33 lines checked
^ permalink raw reply [flat|nested] 2+ messages in thread
* |WARNING| pw105720 [PATCH] vdpa/sfc: make MCDI memzone name unique
@ 2022-01-11 5:48 dpdklab
0 siblings, 0 replies; 2+ messages in thread
From: dpdklab @ 2022-01-11 5:48 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
[-- Attachment #1: Type: text/plain, Size: 2805 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/105720
_apply patch failure_
Submitter: <abhimanyu.saini@xilinx.com>
Date: Tuesday, January 11 2022 05:33:03
Applied on: CommitID:042f5a355a57b31a9f87824173a9d427b21abdb8
Apply patch set 105720 failed:
Checking patch drivers/vdpa/sfc/sfc_vdpa_hw.c...
error: while searching for:
{
uint64_t mcdi_iova;
size_t mcdi_buff_size;
const struct rte_memzone *mz = NULL;
int numa_node = sva->pdev->device.numa_node;
int ret;
mcdi_buff_size = RTE_ALIGN_CEIL(len, PAGE_SIZE);
sfc_vdpa_log_init(sva, "name=%s, len=%zu", name, len);
mz = rte_memzone_reserve_aligned(name, mcdi_buff_size,
numa_node,
RTE_MEMZONE_IOVA_CONTIG,
PAGE_SIZE);
if (mz == NULL) {
sfc_vdpa_err(sva, "cannot reserve memory for %s: len=%#x: %s",
name, (unsigned int)len, rte_strerror(rte_errno));
return -ENOMEM;
}
error: patch failed: drivers/vdpa/sfc/sfc_vdpa_hw.c:25
Applying patch drivers/vdpa/sfc/sfc_vdpa_hw.c with 1 reject...
Rejected hunk #1.
diff a/drivers/vdpa/sfc/sfc_vdpa_hw.c b/drivers/vdpa/sfc/sfc_vdpa_hw.c (rejected hunks)
@@ -25,21 +25,30 @@
{
uint64_t mcdi_iova;
size_t mcdi_buff_size;
+ char mz_name[RTE_MEMZONE_NAMESIZE];
const struct rte_memzone *mz = NULL;
int numa_node = sva->pdev->device.numa_node;
int ret;
mcdi_buff_size = RTE_ALIGN_CEIL(len, PAGE_SIZE);
+ ret = snprintf(mz_name, RTE_MEMZONE_NAMESIZE, "%s_%s",
+ sva->pdev->name, name);
+ if (ret < 0 || ret >= RTE_MEMZONE_NAMESIZE) {
+ sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",
+ sva->pdev->name, name);
+ return -EINVAL;
+ }
- sfc_vdpa_log_init(sva, "name=%s, len=%zu", name, len);
+ sfc_vdpa_log_init(sva, "name=%s, len=%zu", mz_name, len);
- mz = rte_memzone_reserve_aligned(name, mcdi_buff_size,
+ mz = rte_memzone_reserve_aligned(mz_name, mcdi_buff_size,
numa_node,
RTE_MEMZONE_IOVA_CONTIG,
PAGE_SIZE);
if (mz == NULL) {
sfc_vdpa_err(sva, "cannot reserve memory for %s: len=%#x: %s",
- name, (unsigned int)len, rte_strerror(rte_errno));
+ mz_name, (unsigned int)len,
+ rte_strerror(rte_errno));
return -ENOMEM;
}
https://lab.dpdk.org/results/dashboard/patchsets/20631/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-11 5:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220111053303.18162-1-asaini@xilinx.com>
2022-01-11 5:34 ` |WARNING| pw105720 [PATCH] vdpa/sfc: make MCDI memzone name unique checkpatch
2022-01-11 5:48 dpdklab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).