|WARNING| pw106833 [PATCH v4] eventdev/eth_rx: fix memory leak when token parsing finished

|WARNING| pw106833 [PATCH v4] eventdev/eth_rx: fix memory leak when token parsing finished

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106833

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#100: FILE: lib/eventdev/rte_event_eth_rx_adapter.c:296:
+#define RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_GOTO_ERR_RET(id, retval) do { \
+	if (!rxa_validate_id(id)) { \
+		RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d
", id); \
+		ret = retval; \
+		goto error; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#108: FILE: lib/eventdev/rte_event_eth_rx_adapter.c:304:
+#define RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, retval) do { \
+	if ((token) == NULL || strlen(token) == 0 || !isdigit(*token)) { \
+		RTE_EDEV_LOG_ERR("Invalid eth Rx adapter token
"); \
+		ret = retval; \
+		goto error; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#116: FILE: lib/eventdev/rte_event_eth_rx_adapter.c:312:
+#define RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET(port_id, retval) do { \
+	if (!rte_eth_dev_is_valid_port(port_id)) { \
+		RTE_ETHDEV_LOG(ERR, "Invalid port_id=%u
", port_id); \
+		ret = retval; \
+		goto error; \
+	} \
+} while (0)

total: 0 errors, 3 warnings, 210 lines checked

|SUCCESS| pw106833 [PATCH v4] eventdev/eth_rx: fix memory leak when token parsing finished

[0-day Robot]

From: robot@bytheb.org

Test-Label: github-robot: build
Test-Status: SUCCESS
http://patchwork.dpdk.org/patch/106833/

_github build: passed_
Build URL: https://github.com/ovsrobot/dpdk/actions/runs/1788517380

|WARNING| pw106833 [PATCH] [v4] eventdev/eth_rx: fix memory leak when token parsing finished

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 4156 bytes --]

Test-Label: iol-abi-testing
Test-Status: WARNING
http://dpdk.org/patch/106833

_Testing issues_

Submitter: Weiguo Li <liwg06@foxmail.com>
Date: Thursday, February 03 2022 08:49:52 
DPDK git baseline: Repo:dpdk
  Branch: master
  CommitID:ed579e50c66db90485593c6c79f5366a57145f2a

106833 --> testing fail

Test environment and result as below:

+-----------------------------+----------+
|         Environment         | abi_test |
+=============================+==========+
| Arch Linux                  | PASS     |
+-----------------------------+----------+
| Ubuntu 20.04 ARM GCC Native | PASS     |
+-----------------------------+----------+
| Ubuntu 20.04                | FAIL     |
+-----------------------------+----------+
| Fedora 31                   | FAIL     |
+-----------------------------+----------+
| Fedora 32                   | PASS     |
+-----------------------------+----------+
| RHEL8                       | PASS     |
+-----------------------------+----------+
| CentOS 8                    | FAIL     |
+-----------------------------+----------+
| RHEL 7                      | PASS     |
+-----------------------------+----------+
| Ubuntu 18.04                | PASS     |
+-----------------------------+----------+
| CentOS Stream 8             | PASS     |
+-----------------------------+----------+
| Fedora 34 clang             | PASS     |
+-----------------------------+----------+
| openSUSE Leap 15            | PASS     |
+-----------------------------+----------+
| Fedora 34                   | PASS     |
+-----------------------------+----------+
| Fedora 33                   | PASS     |
+-----------------------------+----------+

==== 20 line log output for CentOS 8 (abi_test): ====
[3411/3498] Linking target examples/dpdk-l2fwd-event.
[3412/3498] Linking target examples/dpdk-flow_classify.
[3413/3498] Linking target examples/dpdk-distributor.
[3414/3498] Linking target examples/dpdk-flow_filtering.
[3415/3498] Linking target examples/dpdk-ip_fragmentation.
[3416/3498] Linking target examples/dpdk-ethtool.
[3417/3498] Linking target examples/dpdk-fips_validation.
[3418/3498] Linking target examples/dpdk-helloworld.
[3419/3498] Linking target examples/dpdk-bond.
[3420/3498] Linking target examples/dpdk-dma.
[3421/3498] Linking target examples/dpdk-l2fwd-jobstats.
[3422/3498] Linking target examples/dpdk-ipv4_multicast.
[3423/3498] Linking target examples/dpdk-l2fwd.
[3424/3498] Linking target examples/dpdk-kni.
[3425/3498] Linking target examples/dpdk-mp_client.
ninja: build stopped: subcommand failed.
==== Creating reference DPDK ABI
Error: install directory 'build_install' does not exist.
==== Checking ABI
Error: directory to check 'build_install' does not exist.
==== End log output ====

Arch Linux
	Kernel: 5.4.0-73-generic
	Compiler: gcc 11.1.0

Ubuntu 20.04 ARM GCC Native
	Kernel: 5.4.0-53-generic
	Compiler: gcc 9.3

Ubuntu 20.04
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 9.3.0-17ubuntu1~20.04

Fedora 31
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 9.3.1

Fedora 32
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 10.2.1

RHEL8
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 8.3.1 20191121 (Red Hat 8.3.1-5)

CentOS 8
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 8.3.1 20191121 (Red Hat 8.3.1-5)

RHEL 7
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 4.8.5 20150623 (Red Hat 4.8.5-44)

Ubuntu 18.04
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 7.5.0-3ubuntu1~18.04

CentOS Stream 8
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 8.4.1 20200928

Fedora 34 clang
	Kernel: 5.4.0-72-generic
	Compiler: clang 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)

openSUSE Leap 15
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 7.5.0

Fedora 34
	Kernel: 5.4.0-72-generic
	Compiler: gcc 11.1.1 20210428 (Red Hat 11.1.1-1)

Fedora 33
	Kernel: 5.4.0-72-generic
	Compiler: gcc 10.3.1 20210422 (Red Hat 10.3.1-1)

To view detailed results, visit:
https://lab.dpdk.org/results/dashboard/patchsets/20897/

UNH-IOL DPDK Community Lab

To manage your email subscriptions, visit: 
https://lab.dpdk.org/results/dashboard/preferences/subscriptions/