|WARNING| pw111281 [RFC v3 02/11] net/idpf/base: add OS specific implementation

|WARNING| pw111281 [RFC v3 02/11] net/idpf/base: add OS specific implementation

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/111281

_coding style issues_


WARNING:TYPO_SPELLING: 'definations' may be misspelled - perhaps 'definitions'?
#68: 
Add some MACRO definations and small functions which are specific

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(arr)
#183: FILE: drivers/net/idpf/base/iecm_osdep.h:100:
+#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0]))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'h' - possible side-effects?
#191: FILE: drivers/net/idpf/base/iecm_osdep.h:108:
+#define iecm_debug(h, m, s, ...)					\
+	do {								\
+		if (((m) & (h)->debug_mask))				\
+			PMD_DRV_LOG_RAW(DEBUG, "iecm %02x.%x " s,       \
+					(h)->bus.device, (h)->bus.func,	\
+					##__VA_ARGS__);			\
+	} while (0)

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#209: FILE: drivers/net/idpf/base/iecm_osdep.h:126:
+				   "0x%04X  0x%016"PRIx64"
",		\

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#209: FILE: drivers/net/idpf/base/iecm_osdep.h:126:
+				   "0x%04X  0x%016"PRIx64"
",		\

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'c' - possible side-effects?
#275: FILE: drivers/net/idpf/base/iecm_osdep.h:192:
+#define iecm_memdup(a, b, c, d)	rte_memcpy(iecm_malloc(a, c), b, c)

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#332: FILE: drivers/net/idpf/base/iecm_osdep.h:249:
+	snprintf(z_name, sizeof(z_name), "iecm_dma_%"PRIu64, rte_rand());

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#332: FILE: drivers/net/idpf/base/iecm_osdep.h:249:
+	snprintf(z_name, sizeof(z_name), "iecm_dma_%"PRIu64, rte_rand());

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'd' - possible side-effects?
#385: FILE: drivers/net/idpf/base/iecm_osdep.h:302:
+#define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#398: FILE: drivers/net/idpf/base/iecm_osdep.h:315:
+#define DIVIDE_AND_ROUND_UP(a, b) (((a) + (b) - 1) / (b))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects?
#422: FILE: drivers/net/idpf/base/iecm_osdep.h:339:
+#define IS_ZERO_ETHER_ADDR(addr)				\
+	(((bool)((((u16 *)(addr))[0] == ((u16)0x0)))) &&	\
+	 ((bool)((((u16 *)(addr))[1] == ((u16)0x0)))) &&	\
+	 ((bool)((((u16 *)(addr))[2] == ((u16)0x0)))))

total: 0 errors, 2 warnings, 9 checks, 365 lines checked
Warning in drivers/net/idpf/base/iecm_osdep.h:
Using compiler attribute directly