|WARNING| pw114154 [PATCH] event/cnxk: fix stale data in workslots

|WARNING| pw114154 [PATCH] event/cnxk: fix stale data in workslots

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 4842 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/114154

_apply patch failure_

Submitter: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Date: Monday, July 25 2022 08:35:45 
Applied on: CommitID:72206323a5dd3182b13f61b25a64abdddfee595c
Apply patch set 114154 failed:

Checking patch drivers/event/cnxk/cn10k_eventdev.c...
error: while searching for:

	for (i = 0; i < dev->nb_event_ports; i++) {
		struct cn10k_sso_hws *ws = event_dev->data->ports[i];
		ws->lookup_mem = lookup_mem;
		ws->tstamp = dev->tstamp;
		if (meta_aura)
			ws->meta_aura = meta_aura;
	}

error: patch failed: drivers/event/cnxk/cn10k_eventdev.c:701
Hunk #2 succeeded at 892 (offset -5 lines).
Hunk #3 succeeded at 902 (offset -5 lines).
Hunk #4 succeeded at 919 (offset -5 lines).
Hunk #5 succeeded at 960 (offset -5 lines).
Checking patch drivers/event/cnxk/cn9k_eventdev.c...
error: while searching for:
}

static void
cn9k_sso_set_priv_mem(const struct rte_eventdev *event_dev, void *lookup_mem)
{
	struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev);
	int i;

error: patch failed: drivers/event/cnxk/cn9k_eventdev.c:942
error: while searching for:
		if (dev->dual_ws) {
			struct cn9k_sso_hws_dual *dws =
				event_dev->data->ports[i];
			dws->lookup_mem = lookup_mem;
			dws->tstamp = dev->tstamp;
		} else {
			struct cn9k_sso_hws *ws = event_dev->data->ports[i];
			ws->lookup_mem = lookup_mem;
			ws->tstamp = dev->tstamp;
		}
	}
}

error: patch failed: drivers/event/cnxk/cn9k_eventdev.c:951
error: while searching for:

	rxq = eth_dev->data->rx_queues[0];
	lookup_mem = rxq->lookup_mem;
	cn9k_sso_set_priv_mem(event_dev, lookup_mem);
	cn9k_sso_fp_fns_set((struct rte_eventdev *)(uintptr_t)event_dev);

	return 0;

error: patch failed: drivers/event/cnxk/cn9k_eventdev.c:982
Hunk #4 succeeded at 1123 (offset -5 lines).
Hunk #5 succeeded at 1133 (offset -5 lines).
Hunk #6 succeeded at 1150 (offset -5 lines).
Hunk #7 succeeded at 1189 (offset -5 lines).
Checking patch drivers/event/cnxk/cnxk_tim_evdev.c...
Hunk #2 succeeded at 354 (offset 88 lines).
Hunk #3 succeeded at 485 (offset 108 lines).
Hunk #4 succeeded at 500 (offset 108 lines).
Checking patch drivers/event/cnxk/cnxk_tim_evdev.h...
Hunk #2 succeeded at 293 (offset -27 lines).
Applying patch drivers/event/cnxk/cn10k_eventdev.c with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Hunk #4 applied cleanly.
Hunk #5 applied cleanly.
Applying patch drivers/event/cnxk/cn9k_eventdev.c with 3 rejects...
Rejected hunk #1.
Rejected hunk #2.
Rejected hunk #3.
Hunk #4 applied cleanly.
Hunk #5 applied cleanly.
Hunk #6 applied cleanly.
Hunk #7 applied cleanly.
Applied patch drivers/event/cnxk/cnxk_tim_evdev.c cleanly.
Applied patch drivers/event/cnxk/cnxk_tim_evdev.h cleanly.
diff a/drivers/event/cnxk/cn10k_eventdev.c b/drivers/event/cnxk/cn10k_eventdev.c	(rejected hunks)
@@ -701,8 +701,11 @@ cn10k_sso_set_priv_mem(const struct rte_eventdev *event_dev, void *lookup_mem, u

 	for (i = 0; i < dev->nb_event_ports; i++) {
 		struct cn10k_sso_hws *ws = event_dev->data->ports[i];
-		ws->lookup_mem = lookup_mem;
+		ws->xaq_lmt = dev->xaq_lmt;
+		ws->fc_mem = (uint64_t *)dev->fc_iova;
 		ws->tstamp = dev->tstamp;
+		if (lookup_mem)
+			ws->lookup_mem = lookup_mem;
 		if (meta_aura)
 			ws->meta_aura = meta_aura;
 	}
diff a/drivers/event/cnxk/cn9k_eventdev.c b/drivers/event/cnxk/cn9k_eventdev.c	(rejected hunks)
@@ -942,7 +942,8 @@ cn9k_sso_rx_adapter_caps_get(const struct rte_eventdev *event_dev,
 }

 static void
-cn9k_sso_set_priv_mem(const struct rte_eventdev *event_dev, void *lookup_mem)
+cn9k_sso_set_priv_mem(const struct rte_eventdev *event_dev, void *lookup_mem,
+		      uint64_t aura __rte_unused)
 {
 	struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev);
 	int i;
@@ -951,12 +952,18 @@ cn9k_sso_set_priv_mem(const struct rte_eventdev *event_dev, void *lookup_mem)
 		if (dev->dual_ws) {
 			struct cn9k_sso_hws_dual *dws =
 				event_dev->data->ports[i];
-			dws->lookup_mem = lookup_mem;
+			dws->xaq_lmt = dev->xaq_lmt;
+			dws->fc_mem = (uint64_t *)dev->fc_iova;
 			dws->tstamp = dev->tstamp;
+			if (lookup_mem)
+				dws->lookup_mem = lookup_mem;
 		} else {
 			struct cn9k_sso_hws *ws = event_dev->data->ports[i];
-			ws->lookup_mem = lookup_mem;
+			ws->xaq_lmt = dev->xaq_lmt;
+			ws->fc_mem = (uint64_t *)dev->fc_iova;
 			ws->tstamp = dev->tstamp;
+			if (lookup_mem)
+				ws->lookup_mem = lookup_mem;
 		}
 	}
 }
@@ -982,7 +989,7 @@ cn9k_sso_rx_adapter_queue_add(

 	rxq = eth_dev->data->rx_queues[0];
 	lookup_mem = rxq->lookup_mem;
-	cn9k_sso_set_priv_mem(event_dev, lookup_mem);
+	cn9k_sso_set_priv_mem(event_dev, lookup_mem, 0);
 	cn9k_sso_fp_fns_set((struct rte_eventdev *)(uintptr_t)event_dev);

 	return 0;

https://lab.dpdk.org/results/dashboard/patchsets/23059/

UNH-IOL DPDK Community Lab

|WARNING| pw114154 [PATCH] event/cnxk: fix stale data in workslots

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114154

_coding style issues_


WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#135: FILE: drivers/event/cnxk/cn10k_eventdev.c:928:
+cn10k_tim_caps_get(const struct rte_eventdev *evdev, uint64_t flags,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#138: FILE: drivers/event/cnxk/cn10k_eventdev.c:931:
+	return cnxk_tim_caps_get(evdev, flags, caps, ops,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#150: FILE: drivers/event/cnxk/cn10k_eventdev.c:968:
+	.timer_adapter_caps_get = cn10k_tim_caps_get,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#223: FILE: drivers/event/cnxk/cn9k_eventdev.c:1159:
+cn9k_tim_caps_get(const struct rte_eventdev *evdev, uint64_t flags,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#226: FILE: drivers/event/cnxk/cn9k_eventdev.c:1162:
+	return cnxk_tim_caps_get(evdev, flags, caps, ops,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#238: FILE: drivers/event/cnxk/cn9k_eventdev.c:1197:
+	.timer_adapter_caps_get = cn9k_tim_caps_get,

total: 0 errors, 6 warnings, 177 lines checked