From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw114462 [PATCH] segfault in ovs in setup with DPDK, qemu vhost-user
Date: Sat, 30 Jul 2022 12:30:28 -0400 (EDT) [thread overview]
Message-ID: <20220730163028.BFEFE456@noxus.dpdklab.iol.unh.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/114462
_apply patch failure_
Submitter: Claudio Fontana <cfontana@suse.de>
Date: Saturday, July 30 2022 16:17:36
Applied on: CommitID:72206323a5dd3182b13f61b25a64abdddfee595c
Apply patch set 114462 failed:
Checking patch lib/vhost/virtio_net.c...
error: while searching for:
*desc_chain_head = idx;
if (vq->desc[idx].flags & VRING_DESC_F_INDIRECT) {
dlen = vq->desc[idx].len;
nr_descs = dlen / sizeof(struct vring_desc);
error: patch failed: lib/vhost/virtio_net.c:722
error: while searching for:
idx = descs[idx].next;
}
*desc_chain_len = len;
*vec_idx = vec_id;
error: patch failed: lib/vhost/virtio_net.c:773
Applying patch lib/vhost/virtio_net.c with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
diff a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c (rejected hunks)
@@ -722,6 +722,13 @@ fill_vec_buf_split(struct virtio_net *dev, struct vhost_virtqueue *vq,
*desc_chain_head = idx;
+ /* XXX claudio: why zero? */
+ if (unlikely(vq->desc[idx].addr == 0 || vq->desc[idx].len == 0)) {
+ VHOST_LOG_DATA(dev->ifname, ERR, "claudio: skipping broken vq descriptor: addr=%llu, len=%u",
+ vq->desc[idx].addr, vq->desc[idx].len);
+ goto out;
+ }
+
if (vq->desc[idx].flags & VRING_DESC_F_INDIRECT) {
dlen = vq->desc[idx].len;
nr_descs = dlen / sizeof(struct vring_desc);
@@ -773,6 +780,7 @@ fill_vec_buf_split(struct virtio_net *dev, struct vhost_virtqueue *vq,
idx = descs[idx].next;
}
+out:
*desc_chain_len = len;
*vec_idx = vec_id;
https://lab.dpdk.org/results/dashboard/patchsets/23109/
UNH-IOL DPDK Community Lab
reply other threads:[~2022-07-30 16:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220730163028.BFEFE456@noxus.dpdklab.iol.unh.edu \
--to=dpdklab@iol.unh.edu \
--cc=dpdk-test-reports@iol.unh.edu \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).