|WARNING| pw114462 [PATCH] segfault in ovs in setup with DPDK, qemu vhost-user

|WARNING| pw114462 [PATCH] segfault in ovs in setup with DPDK, qemu vhost-user

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/114462

_apply patch failure_

Submitter: Claudio Fontana <cfontana@suse.de>
Date: Saturday, July 30 2022 16:17:36 
Applied on: CommitID:72206323a5dd3182b13f61b25a64abdddfee595c
Apply patch set 114462 failed:

Checking patch lib/vhost/virtio_net.c...
error: while searching for:

       *desc_chain_head = idx;

       if (vq->desc[idx].flags & VRING_DESC_F_INDIRECT) {
               dlen = vq->desc[idx].len;
               nr_descs = dlen / sizeof(struct vring_desc);

error: patch failed: lib/vhost/virtio_net.c:722
error: while searching for:
               idx = descs[idx].next;
       }

       *desc_chain_len = len;
       *vec_idx = vec_id;


error: patch failed: lib/vhost/virtio_net.c:773
Applying patch lib/vhost/virtio_net.c with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
diff a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c	(rejected hunks)
@@ -722,6 +722,13 @@ fill_vec_buf_split(struct virtio_net *dev, struct vhost_virtqueue *vq,
 
        *desc_chain_head = idx;
 
+        /* XXX claudio: why zero? */
+       if (unlikely(vq->desc[idx].addr == 0 || vq->desc[idx].len == 0)) {
+            VHOST_LOG_DATA(dev->ifname, ERR, "claudio: skipping broken vq descriptor: addr=%llu, len=%u",
+                           vq->desc[idx].addr, vq->desc[idx].len);
+            goto out;
+        }
+
        if (vq->desc[idx].flags & VRING_DESC_F_INDIRECT) {
                dlen = vq->desc[idx].len;
                nr_descs = dlen / sizeof(struct vring_desc);
@@ -773,6 +780,7 @@ fill_vec_buf_split(struct virtio_net *dev, struct vhost_virtqueue *vq,
                idx = descs[idx].next;
        }
 
+out:
        *desc_chain_len = len;
        *vec_idx = vec_id;
 

https://lab.dpdk.org/results/dashboard/patchsets/23109/

UNH-IOL DPDK Community Lab