From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Qi Zhang <qi.z.zhang@intel.com>
Subject: |WARNING| pw114977 [PATCH 20/70] net/ice/base: refactor DDP code
Date: Mon, 15 Aug 2022 01:06:58 +0200 (CEST) [thread overview]
Message-ID: <20220814230658.F0D11120775@dpdk.org> (raw)
In-Reply-To: <20220815071306.2910599-21-qi.z.zhang@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114977
_coding style issues_
WARNING:TYPO_SPELLING: 'Aslo' may be misspelled - perhaps 'Also'?
#68:
Aslo added support for DDP signature segments.
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#3172: FILE: drivers/net/ice/base/ice_defs.h:31:
+#define ROUND_UP(a, b) ((b) * DIVIDE_AND_ROUND_UP((a), (b)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_t' - possible side-effects?
#3174: FILE: drivers/net/ice/base/ice_defs.h:33:
+#define MIN_T(_t, _a, _b) min((_t)(_a), (_t)(_b))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible side-effects?
#3185: FILE: drivers/net/ice/base/ice_defs.h:44:
+#define ice_struct_size(ptr, field, num) \
+ (sizeof(*(ptr)) + sizeof(*(ptr)->field) * (num))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'field' may be better as '(field)' to avoid precedence issues
#3185: FILE: drivers/net/ice/base/ice_defs.h:44:
+#define ice_struct_size(ptr, field, num) \
+ (sizeof(*(ptr)) + sizeof(*(ptr)->field) * (num))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_mem' may be better as '(_mem)' to avoid precedence issues
#3188: FILE: drivers/net/ice/base/ice_defs.h:47:
+#define FLEX_ARRAY_SIZE(_ptr, _mem, cnt) ((cnt) * sizeof(_ptr->_mem[0]))
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#5156: FILE: drivers/net/ice/base/ice_flex_pipe.c:191:
+ * dont_care: b0 0 1 1 0 0
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#5163: FILE: drivers/net/ice/base/ice_flex_pipe.c:197:
+ice_gen_key_word(u8 val, u8 valid, u8 dont_care, u8 nvr_mtch, u8 *key,
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#5174: FILE: drivers/net/ice/base/ice_flex_pipe.c:203:
+ /* 'dont_care' and 'nvr_mtch' masks cannot overlap */
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#5175: FILE: drivers/net/ice/base/ice_flex_pipe.c:204:
+ if ((dont_care ^ nvr_mtch) != (dont_care | nvr_mtch))
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#5175: FILE: drivers/net/ice/base/ice_flex_pipe.c:204:
+ if ((dont_care ^ nvr_mtch) != (dont_care | nvr_mtch))
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#5197: FILE: drivers/net/ice/base/ice_flex_pipe.c:218:
+ } else if (dont_care & 0x1) { /* don't care bit */
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#5214: FILE: drivers/net/ice/base/ice_flex_pipe.c:232:
+ dont_care >>= 1;
total: 0 errors, 8 warnings, 5 checks, 5876 lines checked
parent reply other threads:[~2022-08-14 23:07 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220815071306.2910599-21-qi.z.zhang@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220814230658.F0D11120775@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).