|WARNING| pw116586-116588 [PATCH] [v2, 3/3] event/cnxk: update event vector Tx routine

|WARNING| pw116586-116588 [PATCH] [v2, 3/3] event/cnxk: update event vector Tx routine

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 3427 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/116586

_apply patch failure_

Submitter: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Date: Wednesday, September 21 2022 16:43:42 
Applied on: CommitID:1c9a7fba5c90e0422b517404499ed106f647bcff
Apply patch set 116586-116588 failed:

Checking patch drivers/event/cnxk/cn10k_worker.h...
Hunk #1 succeeded at 516 (offset -18 lines).
Hunk #2 succeeded at 538 (offset -18 lines).
Hunk #3 succeeded at 578 (offset -18 lines).
Hunk #4 succeeded at 656 (offset -18 lines).
error: while searching for:
						   (meta >> 48)] &
					  (BIT_ULL(48) - 1));

			cn10k_nix_xmit_pkts_vector(txq, (uint64_t *)ws, mbufs,
						   meta & 0xFFFF, cmd,
						   flags | NIX_TX_VWQE_F);
		} else {
			cn10k_sso_vwqe_split_tx(
				ws, mbufs, meta & 0xFFFF, cmd, lmt_id, lmt_addr,
				ev->sched_type, txq_data, flags);
		}
		rte_mempool_put(rte_mempool_from_obj(ev->vec), ev->vec);
		rte_prefetch0(ws);
		return 1;
	}

	m = ev->mbuf;
	txq = cn10k_sso_hws_xtract_meta(m, txq_data);
	if (((txq->nb_sqb_bufs_adj -
	      __atomic_load_n((int16_t *)txq->fc_mem, __ATOMIC_RELAXED))
	     << txq->sqes_per_sqb_log2) <= 0)
		return 0;
	cn10k_sso_tx_one(ws, m, cmd, lmt_id, lmt_addr, ev->sched_type, txq_data,
			 flags);

	return 1;
}

#define T(name, sz, flags)                                                     \

error: patch failed: drivers/event/cnxk/cn10k_worker.h:659
Applying patch drivers/event/cnxk/cn10k_worker.h with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Hunk #4 applied cleanly.
Rejected hunk #5.
diff a/drivers/event/cnxk/cn10k_worker.h b/drivers/event/cnxk/cn10k_worker.h	(rejected hunks)
@@ -659,29 +686,35 @@ cn10k_sso_hws_event_tx(struct cn10k_sso_hws *ws, struct rte_event *ev,
 						   (meta >> 48)] &
 					  (BIT_ULL(48) - 1));
 
-			cn10k_nix_xmit_pkts_vector(txq, (uint64_t *)ws, mbufs,
-						   meta & 0xFFFF, cmd,
+			/* Transmit based on queue depth */
+			space = cn10k_sso_sq_depth(txq);
+			if (space <= 0)
+				return 0;
+			nb_pkts = nb_pkts < space ? nb_pkts : (uint16_t)space;
+			cn10k_nix_xmit_pkts_vector(txq, (uint64_t *)ws,
+						   mbufs + offset, nb_pkts, cmd,
 						   flags | NIX_TX_VWQE_F);
 		} else {
-			cn10k_sso_vwqe_split_tx(
-				ws, mbufs, meta & 0xFFFF, cmd, lmt_id, lmt_addr,
-				ev->sched_type, txq_data, flags);
+			nb_pkts = cn10k_sso_vwqe_split_tx(ws, mbufs + offset,
+							  nb_pkts, cmd,
+							  txq_data, flags);
+		}
+		left = (meta & 0xFFFF) - nb_pkts;
+
+		if (!left) {
+			rte_mempool_put(rte_mempool_from_obj(ev->vec), ev->vec);
+		} else {
+			*(uint64_t *)ev->vec =
+				(meta & ~0xFFFFFFFUL) |
+				(((uint32_t)nb_pkts + offset) << 16) | left;
 		}
-		rte_mempool_put(rte_mempool_from_obj(ev->vec), ev->vec);
 		rte_prefetch0(ws);
-		return 1;
+		return !left;
 	}
 
 	m = ev->mbuf;
-	txq = cn10k_sso_hws_xtract_meta(m, txq_data);
-	if (((txq->nb_sqb_bufs_adj -
-	      __atomic_load_n((int16_t *)txq->fc_mem, __ATOMIC_RELAXED))
-	     << txq->sqes_per_sqb_log2) <= 0)
-		return 0;
-	cn10k_sso_tx_one(ws, m, cmd, lmt_id, lmt_addr, ev->sched_type, txq_data,
-			 flags);
-
-	return 1;
+	return cn10k_sso_tx_one(ws, m, cmd, lmt_id, lmt_addr, ev->sched_type,
+				txq_data, flags);
 }
 
 #define T(name, sz, flags)                                                     \

https://lab.dpdk.org/results/dashboard/patchsets/23578/

UNH-IOL DPDK Community Lab