|WARNING| pw119505 [PATCH V5] app/testpmd: update bond port configurations when add slave

|WARNING| pw119505 [PATCH V5] app/testpmd: update bond port configurations when add slave

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/119505

_coding style issues_


WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#62: 
device in dev_info is zero when no slave is added. And its capability will

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#63: 
be updated when add a new slave device.

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#74: 
intersection of the capability of all slave devices. If use original port

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#75: 
configurations, the removed capabilities because of adding a new slave may

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#105: FILE: app/test-pmd/testpmd.c:2806:
+ * device in dev_info is zero when no slave is added. And its capability

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#106: FILE: app/test-pmd/testpmd.c:2807:
+ * will be updated when add a new slave device. So adding a slave device need

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#106: FILE: app/test-pmd/testpmd.c:2807:
+ * will be updated when add a new slave device. So adding a slave device need

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#175: FILE: drivers/net/bonding/bonding_testpmd.c:628:
+	ports[master_port_id].update_conf = 1;

total: 0 errors, 8 warnings, 0 checks, 75 lines checked

|WARNING| pw119505 [PATCH] [V5] app/testpmd: update bond port configurations when add slave

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 1921 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/119505

_apply patch failure_

Submitter: Huisong Li <lihuisong@huawei.com>
Date: Monday, November 07 2022 02:18:34 
Applied on: CommitID:a39f5e14560df310e7af3c135a11bb6f51eb92e6
Apply patch set 119505 failed:

Checking patch app/test-pmd/testpmd.c...
Checking patch app/test-pmd/testpmd.h...
error: while searching for:
	uint32_t                queue_sz; /**< size of a queue for flow rules */
	uint8_t                 slave_flag : 1, /**< bonding slave port */
				bond_flag : 1, /**< port is bond device */
				fwd_mac_swap : 1; /**< swap packet MAC before forward */
	struct port_template    *pattern_templ_list; /**< Pattern templates. */
	struct port_template    *actions_templ_list; /**< Actions templates. */
	struct port_table       *table_list; /**< Flow tables. */

error: patch failed: app/test-pmd/testpmd.h:317
Checking patch drivers/net/bonding/bonding_testpmd.c...
Applied patch app/test-pmd/testpmd.c cleanly.
Applying patch app/test-pmd/testpmd.h with 1 reject...
Rejected hunk #1.
Applied patch drivers/net/bonding/bonding_testpmd.c cleanly.
diff a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h	(rejected hunks)
@@ -317,7 +317,8 @@ struct rte_port {
 	uint32_t                queue_sz; /**< size of a queue for flow rules */
 	uint8_t                 slave_flag : 1, /**< bonding slave port */
 				bond_flag : 1, /**< port is bond device */
-				fwd_mac_swap : 1; /**< swap packet MAC before forward */
+				fwd_mac_swap : 1, /**< swap packet MAC before forward */
+				update_conf : 1; /**< need to update bonding device configuration */
 	struct port_template    *pattern_templ_list; /**< Pattern templates. */
 	struct port_template    *actions_templ_list; /**< Actions templates. */
 	struct port_table       *table_list; /**< Flow tables. */

https://lab.dpdk.org/results/dashboard/patchsets/24337/

UNH-IOL DPDK Community Lab