|WARNING| pw121241 [RFC PATCH] bus/platform: add platform bus

|WARNING| pw121241 [RFC PATCH] bus/platform: add platform bus

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121241

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#300: FILE: drivers/bus/platform/platform.c:154:
+	if (!(dp = opendir(PLATFORM_BUS_DEVICES_PATH))) {

ERROR:SPACING: space required after that ',' (ctx:VxB)
#659: FILE: drivers/bus/platform/private.h:37:
+		RTE_FMT("platform bus: " RTE_FMT_HEAD(__VA_ARGS__,) , \
 		                                                 ^

ERROR:SPACING: space prohibited before that ',' (ctx:WxE)
#659: FILE: drivers/bus/platform/private.h:37:
+		RTE_FMT("platform bus: " RTE_FMT_HEAD(__VA_ARGS__,) , \
 		                                                    ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#660: FILE: drivers/bus/platform/private.h:38:
+			RTE_FMT_TAIL(__VA_ARGS__,)))
 			                        ^

total: 4 errors, 0 warnings, 710 lines checked

|FAILURE| pw121241 [RFC PATCH] bus/platform: add platform bus

[qemudev]

Test-Label: loongarch-compilation
Test-Status: FAILURE
http://dpdk.org/patch/121241

_ninja build failure_

Submitter: Tomasz Duszynski <tduszynski@marvell.com>
Date: Thu, 22 Dec 2022 01:01:06 +0100
DPDK git baseline: Repo:dpdk
  Branch: main
  CommitID: 373f4c7de8ff350548cacc3d56e788461677f2c7

121241 --> ninja build failed

Test environment and result as below:

+---------------------+----------------+
|     Environment     | compilation    |
+---------------------+----------------+
| Loongnix-Server 8.3 | FAIL           |
+---------------------+----------------+

Loongnix-Server 8.3
    Kernel: 4.19.190+
    Compiler: gcc 8.3


Ninja build logs:
-------------------------------BEGIN LOGS----------------------------
FAILED: drivers/libtmp_rte_bus_platform.a.p/bus_platform_platform_params.c.o
cc -Idrivers/libtmp_rte_bus_platform.a.p -Idrivers -I../drivers -Idrivers/bus/platform -I../drivers/bus/platform -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/loongarch/include -I../lib/eal/loongarch/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=loongarch64 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DRTE_LOG_DEFAULT_LOGTYPE=bus.platform -MD -MQ
  drivers/libtmp_rte_bus_platform.a.p/bus_platform_platform_params.c.o -MF drivers/libtmp_rte_bus_platform.a.p/bus_platform_platform_params.c.o.d -o drivers/libtmp_rte_bus_platform.a.p/bus_platform_platform_params.c.o -c ../drivers/bus/platform/platform_params.c
In file included from ../drivers/bus/platform/private.h:14,
from ../drivers/bus/platform/platform_params.c:13:
./drivers/bus/platform/rte_bus_platform.h:91:20: error: field ‘device’ has incomplete type
struct rte_device device; /**< Core device app/ build/ buildtools/ config/ devtools/ doc/ drivers/ dts/ examples/ kernel/ lib/ license/ usertools/
^~~~~~
./drivers/bus/platform/rte_bus_platform.h:102:20: error: field ‘driver’ has incomplete type
struct rte_driver driver; /**< Core driver app/ build/ buildtools/ config/ devtools/ doc/ drivers/ dts/ examples/ kernel/ lib/ license/ usertools/
^~~~~~
In file included from ../drivers/bus/platform/platform_params.c:13:
./drivers/bus/platform/private.h:30:17: error: field ‘bus’ has incomplete type
struct rte_bus bus; /bin /boot /corefiles /dev /etc /home /lib /lib64 /lost+found /media /mnt /opt /proc /root /run /sbin /srv /sys /tmp /usr /var Core bus app/ build/ buildtools/ config/ devtools/ doc/ drivers/ dts/ examples/ kernel/ lib/ license/ usertools/
^~~
./drivers/bus/platform/platform_params.c: In function ‘platform_dev_match’:
./drivers/bus/platform/platform_params.c:38:30: error: dereferencing pointer to incomplete type ‘const struct rte_device’
if (name && strcmp(name, dev->name))
^~
./drivers/bus/platform/platform_params.c: In function ‘platform_bus_dev_iterate’:
./drivers/bus/platform/platform_params.c:48:2: error: unknown type name ‘rte_bus_find_device_t’
rte_bus_find_device_t find_device;
^~~~~~~~~~~~~~~~~~~~~
./drivers/bus/platform/platform_params.c:56:16: error: ‘EINVAL’ undeclared (first use in this function)
rte_errno = EINVAL;
^~~~~~
./drivers/bus/platform/platform_params.c:56:16: note: each undeclared identifier is reported only once for each function it appears in
[447/2818] Compiling C object drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_portal_dpaa2_hw_dpci.c.o
[448/2818] Compiling C object drivers/libtmp_rte_bus_pci.a.p/bus_pci_pci_common_uio.c.o
[449/2818] Generating rte_bus_ifpga.pmd.c with a custom command
[450/2818] Compiling C object drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_fslmc_vfio.c.o
[451/2818] Compiling C object drivers/libtmp_rte_bus_platform.a.p/bus_platform_platform.c.o
FAILED: drivers/libtmp_rte_bus_platform.a.p/bus_platform_platform.c.o
cc -Idrivers/libtmp_rte_bus_platform.a.p -Idrivers -I../drivers -Idrivers/bus/platform -I../drivers/bus/platform -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/loongarch/include -I../lib/eal/loongarch/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=loongarch64 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DRTE_LOG_DEFAULT_LOGTYPE=bus.platform -MD -MQ
  drivers/libtmp_rte_bus_platform.a.p/bus_platform_platform.c.o -MF drivers/libtmp_rte_bus_platform.a.p/bus_platform_platform.c.o.d -o drivers/libtmp_rte_bus_platform.a.p/bus_platform_platform.c.o -c ../drivers/bus/platform/platform.c
In file included from ../drivers/bus/platform/platform.c:12:
./drivers/bus/platform/rte_bus_platform.h:91:20: error: field ‘device’ has incomplete type
struct rte_device device; /**< Core device app/ build/ buildtools/ config/ devtools/ doc/ drivers/ dts/ examples/ kernel/ lib/ license/ usertools/
^~~~~~
./drivers/bus/platform/rte_bus_platform.h:102:20: error: field ‘driver’ has incomplete type
struct rte_driver driver; /**< Core driver app/ build/ buildtools/ config/ devtools/ doc/ drivers/ dts/ examples/ kernel/ lib/ license/ usertools/
^~~~~~
In file included from ../drivers/bus/platform/platform.c:20:
./drivers/bus/platform/private.h:30:17: error: field ‘bus’ has incomplete type
struct rte_bus bus; /bin /boot /corefiles /dev /etc /home /lib /lib64 /lost+found /media /mnt /opt /proc /root /run /sbin /srv /sys /tmp /usr /var Core bus app/ build/ buildtools/ config/ devtools/ doc/ drivers/ dts/ examples/ kernel/ lib/ license/ usertools/
^~~
./drivers/bus/platform/platform.c: In function ‘device_allowed’:
./drivers/bus/platform/platform.c:68:7: error: ‘RTE_BUS_SCAN_UNDEFINED’ undeclared (first use in this function); did you mean ‘RTE_BUS_AUXILIARY’?
case RTE_BUS_SCAN_UNDEFINED:
^~~~~~~~~~~~~~~~~~~~~~
RTE_BUS_AUXILIARY
./drivers/bus/platform/platform.c:68:7: note: each undeclared identifier is reported only once for each function it appears in
./drivers/bus/platform/platform.c:69:7: error: ‘RTE_BUS_SCAN_ALLOWLIST’ undeclared (first use in this function)
case RTE_BUS_SCAN_ALLOWLIST:
^~~~~~~~~~~~~~~~~~~~~~
./drivers/bus/platform/platform.c:73:7: error: ‘RTE_BUS_SCAN_BLOCKLIST’ undeclared (first use in this function)
case RTE_BUS_SCAN_BLOCKLIST:
^~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/bus/platform/platform.c:8:
./drivers/bus/platform/platform.c: In function ‘platform_bus_find_device’:
./lib/eal/include/rte_common.h:812:46: warning: initialization of ‘const int *’ from incompatible pointer type ‘const struct rte_device *’ [-Wincompatible-pointer-types]
const typeof(((type *)0)->member) *_ptr = (ptr); ^
./drivers/bus/platform/platform.c:264:17: note: in expansion of macro ‘RTE_TAILQ_NEXT’
pdev = start ? RTE_TAILQ_NEXT(RTE_DEV_TO_PLATFORM_DEV_CONST(start), next) :
^~~~~~~~~~~~~~
./drivers/bus/platform/rte_bus_platform.h:120:2: note: in expansion of macro ‘container_of’
container_of(ptr, const struct rte_platform_device, device)
^~~~~~~~~~~~
./drivers/bus/platform/platform.c:264:32: note: in expansion of macro ‘RTE_DEV_TO_PLATFORM_DEV_CONST’
pdev = start ? RTE_TAILQ_NEXT(RTE_DEV_TO_PLATFORM_DEV_CONST(start), next) :
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./drivers/bus/platform/platform.c: In function ‘platform_bus_plug’:
./drivers/bus/platform/platform.c:289:24: error: dereferencing pointer to incomplete type ‘struct rte_device’
if (!device_exists(dev->name))
^~
In file included from ../drivers/bus/platform/rte_bus_platform.h:21,
from ../drivers/bus/platform/platform.c:12:
./lib/eal/include/rte_common.h:812:46: warning: initialization of ‘const int *’ from incompatible pointer type ‘struct rte_device *’ [-Wincompatible-pointer-types]
const typeof(((type *)0)->member) *_ptr = (ptr); ^
./drivers/bus/platform/rte_bus_platform.h:117:2: note: in expansion of macro ‘container_of’
container_of(ptr, struct rte_platform_device, device)
^~~~~~~~~~~~
./drivers/bus/platform/platform.c:298:24: note: in expansion of macro ‘RTE_DEV_TO_PLATFORM_DEV’
return platform_probe(RTE_DEV_TO_PLATFORM_DEV(dev));
^~~~~~~~~~~~~~~~~~~~~~~
./drivers/bus/platform/platform.c: In function ‘platform_bus_unplug’:
./lib/eal/include/rte_common.h:812:46: warning: initialization of ‘const int *’ from incompatible pointer type ‘struct rte_device *’ [-Wincompatible-pointer-types]
const typeof(((type *)0)->member) *_ptr = (ptr); ^
./drivers/bus/platform/rte_bus_platform.h:117:2: note: in expansion of macro ‘container_of’
container_of(ptr, struct rte_platform_device, device)
^~~~~~~~~~~~
./drivers/bus/platform/platform.c:304:37: note: in expansion of macro ‘RTE_DEV_TO_PLATFORM_DEV’
struct rte_platform_device *pdev = RTE_DEV_TO_PLATFORM_DEV(dev);
^~~~~~~~~~~~~~~~~~~~~~~
./lib/eal/include/rte_common.h:812:46: note: (near initialization for ‘pdev’)
const typeof(((type *)0)->member) *_ptr = (ptr); ^
./drivers/bus/platform/rte_bus_platform.h:117:2: note: in expansion of macro ‘container_of’
container_of(ptr, struct rte_platform_device, device)
^~~~~~~~~~~~
./drivers/bus/platform/platform.c:304:37: note: in expansion of macro ‘RTE_DEV_TO_PLATFORM_DEV’
struct rte_platform_device *pdev = RTE_DEV_TO_PLATFORM_DEV(dev);
^~~~~~~~~~~~~~~~~~~~~~~
./drivers/bus/platform/platform.c: In function ‘platform_bus_dma_map’:
./lib/eal/include/rte_common.h:812:46: warning: initialization of ‘const int *’ from incompatible pointer type ‘struct rte_device *’ [-Wincompatible-pointer-types]
const typeof(((type *)0)->member) *_ptr = (ptr); ^
./drivers/bus/platform/rte_bus_platform.h:117:2: note: in expansion of macro ‘container_of’
container_of(ptr, struct rte_platform_device, device)
^~~~~~~~~~~~
./drivers/bus/platform/platform.c:325:37: note: in expansion of macro ‘RTE_DEV_TO_PLATFORM_DEV’
struct rte_platform_device *pdev = RTE_DEV_TO_PLATFORM_DEV(dev);
^~~~~~~~~~~~~~~~~~~~~~~
./lib/eal/include/rte_common.h:812:46: note: (near initialization for ‘pdev’)
const typeof(((type *)0)->member) *_ptr = (ptr); ^
./drivers/bus/platform/rte_bus_platform.h:117:2: note: in expansion of macro ‘container_of’
container_of(ptr, struct rte_platform_device, device)
^~~~~~~~~~~~
./drivers/bus/platform/platform.c:325:37: note: in expansion of macro ‘RTE_DEV_TO_PLATFORM_DEV’
struct rte_platform_device *pdev = RTE_DEV_TO_PLATFORM_DEV(dev);
^~~~~~~~~~~~~~~~~~~~~~~
./drivers/bus/platform/platform.c: In function ‘platform_bus_dma_unmap’:
./lib/eal/include/rte_common.h:812:46: warning: initialization of ‘const int *’ from incompatible pointer type ‘struct rte_device *’ [-Wincompatible-pointer-types]
const typeof(((type *)0)->member) *_ptr = (ptr); ^
./drivers/bus/platform/rte_bus_platform.h:117:2: note: in expansion of macro ‘container_of’
container_of(ptr, struct rte_platform_device, device)
^~~~~~~~~~~~
./drivers/bus/platform/platform.c:346:37: note: in expansion of macro ‘RTE_DEV_TO_PLATFORM_DEV’
struct rte_platform_device *pdev = RTE_DEV_TO_PLATFORM_DEV(dev);
^~~~~~~~~~~~~~~~~~~~~~~
./lib/eal/include/rte_common.h:812:46: note: (near initialization for ‘pdev’)
const typeof(((type *)0)->member) *_ptr = (ptr); ^
./drivers/bus/platform/rte_bus_platform.h:117:2: note: in expansion of macro ‘container_of’
container_of(ptr, struct rte_platform_device, device)
^~~~~~~~~~~~
./drivers/bus/platform/platform.c:346:37: note: in expansion of macro ‘RTE_DEV_TO_PLATFORM_DEV’
struct rte_platform_device *pdev = RTE_DEV_TO_PLATFORM_DEV(dev);
^~~~~~~~~~~~~~~~~~~~~~~
./drivers/bus/platform/platform.c: At top level:
./drivers/bus/platform/platform.c:378:3: error: field name not in record or union initializer
.scan = platform_bus_scan,
^
./drivers/bus/platform/platform.c:378:3: note: (near initialization for ‘platform_bus.bus’)
./drivers/bus/platform/platform.c:379:3: error: field name not in record or union initializer
.probe = platform_bus_probe,
^
./drivers/bus/platform/platform.c:379:3: note: (near initialization for ‘platform_bus.bus’)
./drivers/bus/platform/platform.c:380:3: error: field name not in record or union initializer
.find_device = platform_bus_find_device,
^
./drivers/bus/platform/platform.c:380:3: note: (near initialization for ‘platform_bus.bus’)
./drivers/bus/platform/platform.c:381:3: error: field name not in record or union initializer
.plug = platform_bus_plug,
^
./drivers/bus/platform/platform.c:381:3: note: (near initialization for ‘platform_bus.bus’)
./drivers/bus/platform/platform.c:382:3: error: field name not in record or union initializer
.unplug = platform_bus_unplug,
^
./drivers/bus/platform/platform.c:382:3: note: (near initialization for ‘platform_bus.bus’)
./drivers/bus/platform/platform.c:383:3: error: field name not in record or union initializer
.parse = platform_bus_parse,
^
./drivers/bus/platform/platform.c:383:3: note: (near initialization for ‘platform_bus.bus’)
./drivers/bus/platform/platform.c:384:3: error: field name not in record or union initializer
.dma_map = platform_bus_dma_map,
^
./drivers/bus/platform/platform.c:384:3: note: (near initialization for ‘platform_bus.bus’)
./drivers/bus/platform/platform.c:385:3: error: field name not in record or union initializer
.dma_unmap = platform_bus_dma_unmap,
^
./drivers/bus/platform/platform.c:385:3: note: (near initialization for ‘platform_bus.bus’)
./drivers/bus/platform/platform.c:386:3: error: field name not in record or union initializer
.get_iommu_class = platform_bus_get_iommu_class,
^
./drivers/bus/platform/platform.c:386:3: note: (near initialization for ‘platform_bus.bus’)
./drivers/bus/platform/platform.c:387:3: error: field name not in record or union initializer
.dev_iterate = platform_bus_dev_iterate,
^
./drivers/bus/platform/platform.c:387:3: note: (near initialization for ‘platform_bus.bus’)
./drivers/bus/platform/platform.c:393:44: error: expected ‘)’ before ‘.’ token
RTE_REGISTER_BUS(platform_bus, platform_bus.bus);
^
)
[452/2818] Compiling C object drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_portal_dpaa2_hw_dpio.c.o
[453/2818] Generating rte_common_cpt.sym_chk with a custom command (wrapped by meson to capture output)
[454/2818] Compiling C object lib/librte_pipeline.a.p/pipeline_rte_swx_pipeline_spec.c.o
[455/2818] Compiling C object drivers/libtmp_rte_bus_pci.a.p/bus_pci_pci_common.c.o
[456/2818] Compiling C object drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_qbman_qbman_debug.c.o
[457/2818] Compiling C object drivers/libtmp_rte_bus_pci.a.p/bus_pci_linux_pci_uio.c.o
[458/2818] Compiling C object drivers/libtmp_rte_bus_pci.a.p/bus_pci_linux_pci.c.o
[459/2818] Generating sched.sym_chk with a custom command (wrapped by meson to capture output)
[460/2818] Generating rte_common_octeontx.sym_chk with a custom command (wrapped by meson to capture output)
[461/2818] Compiling C object drivers/libtmp_rte_bus_pci.a.p/bus_pci_linux_pci_vfio.c.o
[462/2818] Generating rte_common_iavf.sym_chk with a custom command (wrapped by meson to capture output)
[463/2818] Generating port.sym_chk with a custom command (wrapped by meson to capture output)
[464/2818] Generating rte_bus_auxiliary.sym_chk with a custom command (wrapped by meson to capture output)
[465/2818] Generating rte_common_idpf.sym_chk with a custom command (wrapped by meson to capture output)
[466/2818] Generating table.sym_chk with a custom command (wrapped by meson to capture output)
[467/2818] Generating rte_common_dpaax.sym_chk with a custom command (wrapped by meson to capture output)
[468/2818] Generating graph.sym_chk with a custom command (wrapped by meson to capture output)
[469/2818] Compiling C object lib/librte_pipeline.a.p/pipeline_rte_table_action.c.o
[470/2818] Generating cryptodev.sym_chk with a custom command (wrapped by meson to capture output)
[471/2818] Generating eventdev.sym_chk with a custom command (wrapped by meson to capture output)
[472/2818] Compiling C object drivers/libtmp_rte_event_sw.a.p/event_sw_sw_evdev_scheduler.c.o
[473/2818] Compiling C object drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_qbman_qbman_portal.c.o
[474/2818] Compiling C object lib/librte_vhost.a.p/vhost_vhost_crypto.c.o
[475/2818] Compiling C object drivers/libtmp_rte_bus_dpaa.a.p/bus_dpaa_base_qbman_qman.c.o
[476/2818] Generating ethdev.sym_chk with a custom command (wrapped by meson to capture output)
[477/2818] Compiling C object lib/librte_vhost.a.p/vhost_virtio_net.c.o
[478/2818] Compiling C object lib/librte_pipeline.a.p/pipeline_rte_swx_pipeline.c.o
[479/2818] Generating eal.sym_chk with a custom command (wrapped by meson to capture output)
ninja: build stopped: subcommand failed.
-------------------------------END LOGS------------------------------