* |WARNING| pw125315-125316 [PATCH] [v2, 2/2] ci: test compilation with debug in GHA
@ 2023-03-20 13:46 dpdklab
0 siblings, 0 replies; only message in thread
From: dpdklab @ 2023-03-20 13:46 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/125315
_apply patch failure_
Submitter: David Marchand <david.marchand@redhat.com>
Date: Monday, March 20 2023 12:18:33
Applied on: CommitID:56de01c119381f82baef819184a8dba36ea9c333
Apply patch set 125315-125316 failed:
Checking patch app/test-mldev/test_inference_common.c...
error: while searching for:
*/
#include <errno.h>
#include <unistd.h>
#include <rte_common.h>
error: patch failed: app/test-mldev/test_inference_common.c:3
error: while searching for:
struct test_inference *t = ml_test_priv((struct ml_test *)opaque);
struct ml_request *req = (struct ml_request *)obj;
struct ml_model *model = &t->model[req->fid];
char str[PATH_MAX];
bool error = false;
RTE_SET_USED(mp);
error: patch failed: app/test-mldev/test_inference_common.c:901
error: while searching for:
dump_output_pass:
if (obj_idx == 0) {
/* write quantized output */
snprintf(str, PATH_MAX, "%s.q", t->cmn.opt->filelist[req->fid].output);
ML_OPEN_WRITE_GET_ERR(str, req->output, model->out_qsize, error);
if (error)
return;
/* write dequantized output */
snprintf(str, PATH_MAX, "%s", t->cmn.opt->filelist[req->fid].output);
ML_OPEN_WRITE_GET_ERR(str, model->output, model->out_dsize, error);
if (error)
return;
}
error: patch failed: app/test-mldev/test_inference_common.c:926
error: while searching for:
dump_output_fail:
if (t->cmn.opt->debug) {
/* dump quantized output buffer */
snprintf(str, PATH_MAX, "%s.q.%d", t->cmn.opt->filelist[req->fid].output, obj_idx);
ML_OPEN_WRITE_GET_ERR(str, req->output, model->out_qsize, error);
if (error)
return;
/* dump dequantized output buffer */
snprintf(str, PATH_MAX, "%s.%d", t->cmn.opt->filelist[req->fid].output, obj_idx);
ML_OPEN_WRITE_GET_ERR(str, model->output, model->out_dsize, error);
if (error)
return;
}
error: patch failed: app/test-mldev/test_inference_common.c:943
Applying patch app/test-mldev/test_inference_common.c with 4 rejects...
Rejected hunk #1.
Rejected hunk #2.
Rejected hunk #3.
Rejected hunk #4.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/app/test-mldev/test_inference_common.c b/app/test-mldev/test_inference_common.c (rejected hunks)
@@ -3,6 +3,7 @@
*/
#include <errno.h>
+#include <stdio.h>
#include <unistd.h>
#include <rte_common.h>
@@ -901,8 +902,8 @@ ml_request_finish(struct rte_mempool *mp, void *opaque, void *obj, unsigned int
struct test_inference *t = ml_test_priv((struct ml_test *)opaque);
struct ml_request *req = (struct ml_request *)obj;
struct ml_model *model = &t->model[req->fid];
- char str[PATH_MAX];
bool error = false;
+ char *dump_path;
RTE_SET_USED(mp);
@@ -926,14 +927,18 @@ ml_request_finish(struct rte_mempool *mp, void *opaque, void *obj, unsigned int
dump_output_pass:
if (obj_idx == 0) {
/* write quantized output */
- snprintf(str, PATH_MAX, "%s.q", t->cmn.opt->filelist[req->fid].output);
- ML_OPEN_WRITE_GET_ERR(str, req->output, model->out_qsize, error);
+ if (asprintf(&dump_path, "%s.q", t->cmn.opt->filelist[req->fid].output) == -1)
+ return;
+ ML_OPEN_WRITE_GET_ERR(dump_path, req->output, model->out_qsize, error);
+ free(dump_path);
if (error)
return;
/* write dequantized output */
- snprintf(str, PATH_MAX, "%s", t->cmn.opt->filelist[req->fid].output);
- ML_OPEN_WRITE_GET_ERR(str, model->output, model->out_dsize, error);
+ if (asprintf(&dump_path, "%s", t->cmn.opt->filelist[req->fid].output) == -1)
+ return;
+ ML_OPEN_WRITE_GET_ERR(dump_path, model->output, model->out_dsize, error);
+ free(dump_path);
if (error)
return;
}
@@ -943,14 +948,20 @@ ml_request_finish(struct rte_mempool *mp, void *opaque, void *obj, unsigned int
dump_output_fail:
if (t->cmn.opt->debug) {
/* dump quantized output buffer */
- snprintf(str, PATH_MAX, "%s.q.%d", t->cmn.opt->filelist[req->fid].output, obj_idx);
- ML_OPEN_WRITE_GET_ERR(str, req->output, model->out_qsize, error);
+ if (asprintf(&dump_path, "%s.q.%u", t->cmn.opt->filelist[req->fid].output,
+ obj_idx) == -1)
+ return;
+ ML_OPEN_WRITE_GET_ERR(dump_path, req->output, model->out_qsize, error);
+ free(dump_path);
if (error)
return;
/* dump dequantized output buffer */
- snprintf(str, PATH_MAX, "%s.%d", t->cmn.opt->filelist[req->fid].output, obj_idx);
- ML_OPEN_WRITE_GET_ERR(str, model->output, model->out_dsize, error);
+ if (asprintf(&dump_path, "%s.%u", t->cmn.opt->filelist[req->fid].output,
+ obj_idx) == -1)
+ return;
+ ML_OPEN_WRITE_GET_ERR(dump_path, model->output, model->out_dsize, error);
+ free(dump_path);
if (error)
return;
}
Checking patch .ci/linux-build.sh...
error: while searching for:
cross_file=config/riscv/riscv64_linux_gcc
fi
if [ "$BUILD_DOCS" = "true" ]; then
OPTS="$OPTS -Denable_docs=true"
fi
error: patch failed: .ci/linux-build.sh:65
error: while searching for:
OPTS="$OPTS -Dplatform=generic"
OPTS="$OPTS -Ddefault_library=$DEF_LIB"
OPTS="$OPTS -Dbuildtype=debugoptimized"
OPTS="$OPTS -Dcheck_includes=true"
if [ "$MINI" = "true" ]; then
OPTS="$OPTS -Denable_drivers=net/null"
error: patch failed: .ci/linux-build.sh:85
Checking patch .github/workflows/build.yml...
error: while searching for:
ABI_CHECKS: ${{ contains(matrix.config.checks, 'abi') }}
ASAN: ${{ contains(matrix.config.checks, 'asan') }}
BUILD_32BIT: ${{ matrix.config.cross == 'i386' }}
BUILD_DOCS: ${{ contains(matrix.config.checks, 'doc') }}
CC: ccache ${{ matrix.config.compiler }}
DEF_LIB: ${{ matrix.config.library }}
error: patch failed: .github/workflows/build.yml:18
error: while searching for:
mini: mini
- os: ubuntu-20.04
compiler: gcc
checks: abi+doc+tests
- os: ubuntu-20.04
compiler: clang
checks: asan+doc+tests
error: patch failed: .github/workflows/build.yml:39
Applying patch .ci/linux-build.sh with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
Applying patch .github/workflows/build.yml with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/.ci/linux-build.sh b/.ci/linux-build.sh (rejected hunks)
@@ -65,6 +65,12 @@ if [ "$RISCV64" = "true" ]; then
cross_file=config/riscv/riscv64_linux_gcc
fi
+buildtype=debugoptimized
+
+if [ "$BUILD_DEBUG" = "true" ]; then
+ buildtype=debug
+fi
+
if [ "$BUILD_DOCS" = "true" ]; then
OPTS="$OPTS -Denable_docs=true"
fi
@@ -85,7 +91,7 @@ fi
OPTS="$OPTS -Dplatform=generic"
OPTS="$OPTS -Ddefault_library=$DEF_LIB"
-OPTS="$OPTS -Dbuildtype=debugoptimized"
+OPTS="$OPTS -Dbuildtype=$buildtype"
OPTS="$OPTS -Dcheck_includes=true"
if [ "$MINI" = "true" ]; then
OPTS="$OPTS -Denable_drivers=net/null"
diff a/.github/workflows/build.yml b/.github/workflows/build.yml (rejected hunks)
@@ -18,6 +18,7 @@ jobs:
ABI_CHECKS: ${{ contains(matrix.config.checks, 'abi') }}
ASAN: ${{ contains(matrix.config.checks, 'asan') }}
BUILD_32BIT: ${{ matrix.config.cross == 'i386' }}
+ BUILD_DEBUG: ${{ contains(matrix.config.checks, 'debug') }}
BUILD_DOCS: ${{ contains(matrix.config.checks, 'doc') }}
CC: ccache ${{ matrix.config.compiler }}
DEF_LIB: ${{ matrix.config.library }}
@@ -39,7 +40,7 @@ jobs:
mini: mini
- os: ubuntu-20.04
compiler: gcc
- checks: abi+doc+tests
+ checks: abi+debug+doc+tests
- os: ubuntu-20.04
compiler: clang
checks: asan+doc+tests
https://lab.dpdk.org/results/dashboard/patchsets/25801/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-20 13:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-20 13:46 |WARNING| pw125315-125316 [PATCH] [v2, 2/2] ci: test compilation with debug in GHA dpdklab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).