[E810 Offload VLAN Stripping]

[E810 Offload VLAN Stripping]

[Carlos de Souza Moraes Neto]

[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]


Hello,
I'm currently working on enabling the RTE_ETH_RX_OFFLOAD_VLAN_STRIP offload feature to strip VLAN tags and store the VLAN information in the vlan_tci field while using an Intel E810-XXVDA2 NIC. However, the VLAN tags are not being stripped. I've already tried to update DPDK (23.11), E810 firmware (4.40), ICE and DDP (1.3.35.0) but nothing. My console output is:

EAL: Detected CPU lcores: 8
EAL: Detected NUMA nodes: 1
EAL: Detected shared linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: VFIO support initialized
EAL: Using IOMMU type 1 (Type 1)
EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:01:00.0 (socket -1)
ice_load_pkg_type(): Active package is: 1.3.35.0, ICE OS Default Package (single VLAN mode)
EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:01:00.1 (socket -1)
ice_load_pkg_type(): Active package is: 1.3.35.0, ICE OS Default Package (single VLAN mode)
EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.0 (socket -1)
EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.1 (socket -1)
EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.2 (socket -1)
EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.3 (socket -1)
TELEMETRY: No legacy callbacks, legacy socket not created
ice_set_rx_function(): Using AVX2 OFFLOAD Vector Rx (port 0).
ice_set_tx_function(): Using AVX2 OFFLOAD Vector Tx (port 0).
ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not support qinq
ice_set_rx_function(): Using AVX2 OFFLOAD Vector Rx (port 1).
ice_set_tx_function(): Using AVX2 OFFLOAD Vector Tx (port 1).
ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not support qinq


Sincerely,
Carlos Moraes


[-- Attachment #2: Type: text/html, Size: 5597 bytes --]

Re: [E810 Offload VLAN Stripping]

[David Marchand]

Hello Carlos,

On Mon, Mar 11, 2024 at 10:29 AM Carlos de Souza Moraes Neto
<carlosmn@weg.net> wrote:
> Hello,
>

Adding some Intel folks.

> I'm currently working on enabling the RTE_ETH_RX_OFFLOAD_VLAN_STRIP offload feature to strip VLAN tags and store the VLAN information in the vlan_tci field while using an Intel E810-XXVDA2 NIC. However, the VLAN tags are not being stripped. I’ve already tried to update DPDK (23.11), E810 firmware (4.40), ICE and DDP (1.3.35.0) but nothing. My console output is:
>
> EAL: Detected CPU lcores: 8
> EAL: Detected NUMA nodes: 1
> EAL: Detected shared linkage of DPDK
> EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
> EAL: Selected IOVA mode 'VA'
> EAL: VFIO support initialized
> EAL: Using IOMMU type 1 (Type 1)
> EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:01:00.0 (socket -1)
> ice_load_pkg_type(): Active package is: 1.3.35.0, ICE OS Default Package (single VLAN mode)
> EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:01:00.1 (socket -1)
> ice_load_pkg_type(): Active package is: 1.3.35.0, ICE OS Default Package (single VLAN mode)
> EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.0 (socket -1)
> EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.1 (socket -1)
> EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.2 (socket -1)
> EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.3 (socket -1)
> TELEMETRY: No legacy callbacks, legacy socket not created
> ice_set_rx_function(): Using AVX2 OFFLOAD Vector Rx (port 0).
> ice_set_tx_function(): Using AVX2 OFFLOAD Vector Tx (port 0).
> ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not support qinq
> ice_set_rx_function(): Using AVX2 OFFLOAD Vector Rx (port 1).
> ice_set_tx_function(): Using AVX2 OFFLOAD Vector Tx (port 1).
> ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not support qinq

I think I reproduce your issue (though I see messages claiming support
for double VLAN in my setup).

I tested with testpmd in v23.11 and a E810 nic:
04:00.0 Ethernet controller: Intel Corporation Ethernet Controller
E810-XXV for SFP (rev 02)

# ./build/app/dpdk-testpmd -a 0000:04:00.0 -- --enable-hw-vlan-strip -i
...
ice_load_pkg_type(): Active package is: 1.3.30.0, ICE OS Default
Package (double VLAN mode)
...
testpmd> set verbose 1
Change verbose level from 0 to 1
testpmd> start
...
port 0/queue 0: received 1 packets
  src=00:00:00:00:00:00 - dst=FF:FF:FF:FF:FF:FF - pool=mb_pool_0 -
type=0x8100 - length=60 - nb_segs=1 - hw ptype: L2_ETHER
L3_IPV4_EXT_UNKNOWN L4_NONFRAG  - sw ptype: L2_ETHER_VLAN L3_IPV4  -
l2_len=18 - l3_len=20 - Receive queue=0x0
  ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD
RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD


I did a bisect, v22.11 worked for me and I ended up on: de5da9d16430
("net/ice: support double VLAN") as the first bad commit.

Reverting it restores vlan stripping for me on RHEL9.

port 0/queue 0: received 1 packets
  src=00:00:00:00:00:00 - dst=FF:FF:FF:FF:FF:FF - pool=mb_pool_0 -
type=0x0800 - length=60 - nb_segs=1 - VLAN tci=0x2a - hw ptype:
L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG  - sw ptype: L2_ETHER L3_IPV4
- l2_len=14 - l3_len=20 - Receive queue=0x0
  ol_flags: RTE_MBUF_F_RX_VLAN RTE_MBUF_F_RX_L4_CKSUM_GOOD
RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_VLAN_STRIPPED
RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD

Carlos, do you see the same?

Bruce, Vladimir, could you have a look and confirm on your side?


Thanks!

-- 
David Marchand

RES: [E810 Offload VLAN Stripping]

[Carlos de Souza Moraes Neto]

Hi David,

It worked in 22.11 but when I tried 23.11 and revert de5da9d16430 it didn’t work.

Sincerely,
Carlos Moraes


-----Mensagem original-----
De: David Marchand <david.marchand@redhat.com> 
Enviada em: segunda-feira, 11 de março de 2024 12:11
Para: Carlos de Souza Moraes Neto <carlosmn@weg.net>; Bruce Richardson <bruce.richardson@intel.com>; Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: users@dpdk.org
Assunto: Re: [E810 Offload VLAN Stripping]

ATENÇÃO:  Esta mensagem é de REMETENTE EXTERNO - Tenha cuidado ao abrir links e anexos.
*** NOVO *** NÃO digite sua SENHA WEG quando solicitada por E-MAIL EXTERNO


Hello Carlos,

On Mon, Mar 11, 2024 at 10:29 AM Carlos de Souza Moraes Neto <carlosmn@weg.net> wrote:
> Hello,
>

Adding some Intel folks.

> I'm currently working on enabling the RTE_ETH_RX_OFFLOAD_VLAN_STRIP offload feature to strip VLAN tags and store the VLAN information in the vlan_tci field while using an Intel E810-XXVDA2 NIC. However, the VLAN tags are not being stripped. I’ve already tried to update DPDK (23.11), E810 firmware (4.40), ICE and DDP (1.3.35.0) but nothing. My console output is:
>
> EAL: Detected CPU lcores: 8
> EAL: Detected NUMA nodes: 1
> EAL: Detected shared linkage of DPDK
> EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
> EAL: Selected IOVA mode 'VA'
> EAL: VFIO support initialized
> EAL: Using IOMMU type 1 (Type 1)
> EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:01:00.0 
> (socket -1)
> ice_load_pkg_type(): Active package is: 1.3.35.0, ICE OS Default 
> Package (single VLAN mode)
> EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:01:00.1 
> (socket -1)
> ice_load_pkg_type(): Active package is: 1.3.35.0, ICE OS Default 
> Package (single VLAN mode)
> EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.0 
> (socket -1)
> EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.1 
> (socket -1)
> EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.2 
> (socket -1)
> EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.3 
> (socket -1)
> TELEMETRY: No legacy callbacks, legacy socket not created
> ice_set_rx_function(): Using AVX2 OFFLOAD Vector Rx (port 0).
> ice_set_tx_function(): Using AVX2 OFFLOAD Vector Tx (port 0).
> ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not 
> support qinq
> ice_set_rx_function(): Using AVX2 OFFLOAD Vector Rx (port 1).
> ice_set_tx_function(): Using AVX2 OFFLOAD Vector Tx (port 1).
> ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not 
> support qinq

I think I reproduce your issue (though I see messages claiming support for double VLAN in my setup).

I tested with testpmd in v23.11 and a E810 nic:
04:00.0 Ethernet controller: Intel Corporation Ethernet Controller E810-XXV for SFP (rev 02)

# ./build/app/dpdk-testpmd -a 0000:04:00.0 -- --enable-hw-vlan-strip -i ...
ice_load_pkg_type(): Active package is: 1.3.30.0, ICE OS Default Package (double VLAN mode) ...
testpmd> set verbose 1
Change verbose level from 0 to 1
testpmd> start
...
port 0/queue 0: received 1 packets
  src=00:00:00:00:00:00 - dst=FF:FF:FF:FF:FF:FF - pool=mb_pool_0 -
type=0x8100 - length=60 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG  - sw ptype: L2_ETHER_VLAN L3_IPV4  -
l2_len=18 - l3_len=20 - Receive queue=0x0
  ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD


I did a bisect, v22.11 worked for me and I ended up on: de5da9d16430
("net/ice: support double VLAN") as the first bad commit.

Reverting it restores vlan stripping for me on RHEL9.

port 0/queue 0: received 1 packets
  src=00:00:00:00:00:00 - dst=FF:FF:FF:FF:FF:FF - pool=mb_pool_0 -
type=0x0800 - length=60 - nb_segs=1 - VLAN tci=0x2a - hw ptype:
L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG  - sw ptype: L2_ETHER L3_IPV4
- l2_len=14 - l3_len=20 - Receive queue=0x0
  ol_flags: RTE_MBUF_F_RX_VLAN RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_VLAN_STRIPPED RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD

Carlos, do you see the same?

Bruce, Vladimir, could you have a look and confirm on your side?


Thanks!

--
David Marchand

Re: [E810 Offload VLAN Stripping]

[David Marchand]

Hello Carlos,

On Mon, Mar 11, 2024 at 7:07 PM Carlos de Souza Moraes Neto
<carlosmn@weg.net> wrote:
> It worked in 22.11 but when I tried 23.11 and revert de5da9d16430 it didn’t work.

Are you testing with testpmd?
If not, please double check first with testpmd.

And describe the traffic you are testing with.

With this, I hope Intel can reproduce your issue.


-- 
David Marchand

RES: [E810 Offload VLAN Stripping]

[Carlos de Souza Moraes Neto]

Hi David!

I think i messed up in some part and know it is working. I'm using testpmd to read tagged packets (IEC Sampled Values) that come to that port.




I'm using testpmd to read packets that arrive to the port.
This is the part to confirm I changed to 23.11 and revert de5da9d16430
root@SAL7:~/downloads/dpdk# git checkout v23.11
Previous HEAD position was f262f16087 version: 22.11.0
HEAD is now at eeb0605f11 version: 23.11.0
root@SAL7:~/downloads/dpdk# cat VERSION
23.11.0
root@SAL7:~/downloads/dpdk# git revert de5da9d16430
Auto-merging drivers/net/ice/ice_ethdev.c
Auto-merging drivers/net/ice/ice_ethdev.h
[detached HEAD 1b41a38e69] Revert "net/ice: support double VLAN"
 2 files changed, 15 insertions(+), 408 deletions(-)

After compiling and installing it I start testpmd with 

root@SAL7:~/downloads/dpdk/build# dpdk-testpmd -a 0000:01:00.0 -- --enable-hw-vlan-strip -i
EAL: Detected CPU lcores: 8
EAL: Detected NUMA nodes: 1
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: VFIO support initialized
EAL: Using IOMMU type 1 (Type 1)
EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:01:00.0 (socket -1)
ice_load_pkg_type(): Active package is: 1.3.35.0, ICE OS Default Package (single VLAN mode)
TELEMETRY: No legacy callbacks, legacy socket not created
Interactive-mode selected
Warning: NUMA should be configured manually by using --port-numa-config and --ring-numa-config parameters along with --numa.
testpmd: create a new mbuf pool <mb_pool_0>: n=203456, size=2176, socket=0
testpmd: preferred mempool ops selected: ring_mp_mc

Warning! port-topology=paired and odd forward ports number, the last port will pair with itself.

Configuring Port 0 (socket 0)
ice_set_rx_function(): Using AVX2 OFFLOAD Vector Rx (port 0).

Port 0: link state change event
Port 0: B4:96:91:EB:84:94
Checking link statuses...
Done
testpmd> set promisc all on
testpmd> set verbose 1
Change verbose level from 0 to 1
testpmd>
testpmd> start

io packet forwarding - ports=1 - cores=1 - streams=1 - NUMA support enabled, MP allocation mode: native
Logical Core 1 (socket 0) forwards packets on 1 streams:
  RX P=0/Q=0 (socket 0) -> TX P=0/Q=0 (socket 0) peer=02:00:00:00:00:00
  src=B4:B1:5A:18:04:3B - dst=01:0C:CD:04:00:01 - pool=mb_pool_0 - type=0x88ba - length=231 - nb_segs=1 - VLAN tci=0xe003 - hw ptype: L2_ETHER  - sw ptype: L2_ETHER  - l2_len=14 - Receive queue=0x0
  ol_flags: RTE_MBUF_F_RX_VLAN RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_VLAN_STRIPPED RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD
port 0/queue 0: received 1 packets
  src=B4:B1:5A:18:04:3B - dst=01:0C:CD:04:00:00 - pool=mb_pool_0 - type=0x88ba - length=863 - nb_segs=1 - VLAN tci=0x6004 - hw ptype: L2_ETHER  - sw ptype: L2_ETHER  - l2_len=14 - Receive queue=0x0
  ol_flags: RTE_MBUF_F_RX_VLAN RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_VLAN_STRIPPED RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD
port 0/queue 0: received 1 packets
  src=B4:B1:5A:18:04:3B - dst=01:0C:CD:04:00:01 - pool=mb_pool_0 - type=0x88ba - length=231 - nb_segs=1 - VLAN tci=0xe003 - hw ptype: L2_ETHER  - sw ptype: L2_ETHER  - l2_len=14 - Receive queue=0x0
  ol_flags: RTE_MBUF_F_RX_VLAN RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_VLAN_STRIPPED RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD
port 0/queue 0: received 1 packets
  src=B4:B1:5A:18:04:3B - dst=01:0C:CD:04:00:00 - pool=mb_pool_0 - type=0x88ba - length=863 - nb_segs=1 - VLAN tci=0x6004 - hw ptype: L2_ETHER  - sw ptype: L2_ETHER  - l2_len=14 - Receive queue=0x0
  ol_flags: RTE_MBUF_F_RX_VLAN RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_VLAN_STRIPPED RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD
port 0/queue 0: received 1 packets
  src=B4:B1:5A:18:04:3B - dst=01:0C:CD:04:00:01 - pool=mb_pool_0 - type=0x88ba - length=231 - nb_segs=1 - VLAN tci=0xe003 - hw ptype: L2_ETHER  - sw ptype: L2_ETHER  - l2_len=14 - Receive queue=0x0
  ol_flags: RTE_MBUF_F_RX_VLAN RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_VLAN_STRIPPED RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD




Atenciosamente, 

Carlos de Souza Moraes Neto
Depto. Centro de Negócios de Subestações
Fone: +55 (47) 3276-5786 Celular: +55 (47) 99927-9354 skype: carlossmneto
WEG Equipamentos Elétricos S/A. - Transmissão & Distribuição
www.weg.net




-----Mensagem original-----
De: David Marchand <david.marchand@redhat.com> 
Enviada em: terça-feira, 12 de março de 2024 08:52
Para: Carlos de Souza Moraes Neto <carlosmn@weg.net>
Cc: Bruce Richardson <bruce.richardson@intel.com>; Vladimir Medvedkin <vladimir.medvedkin@intel.com>; users@dpdk.org; Rafael Bonet Scheffer <rafaelbonet@weg.net>
Assunto: Re: [E810 Offload VLAN Stripping]

ATENÇÃO:  Esta mensagem é de REMETENTE EXTERNO - Tenha cuidado ao abrir links e anexos.
*** NOVO *** NÃO digite sua SENHA WEG quando solicitada por E-MAIL EXTERNO


Hello Carlos,

On Mon, Mar 11, 2024 at 7:07 PM Carlos de Souza Moraes Neto <carlosmn@weg.net> wrote:
> It worked in 22.11 but when I tried 23.11 and revert de5da9d16430 it didn’t work.

Are you testing with testpmd?
If not, please double check first with testpmd.

And describe the traffic you are testing with.

With this, I hope Intel can reproduce your issue.


--
David Marchand

Re: [E810 Offload VLAN Stripping]

[David Marchand]

Hello Carlos, John,

On Tue, Mar 12, 2024 at 9:10 PM Carlos de Souza Moraes Neto
<carlosmn@weg.net> wrote:
>
> I think i messed up in some part and know it is working. I'm using testpmd to read tagged packets (IEC Sampled Values) that come to that port.

Carlos,

Thanks for the confirmation that reverting de5da9d16430 works for you.
I opened a bz: https://bugs.dpdk.org/show_bug.cgi?id=1402


John,

We mentionned this (E810 vlan stripping) issue during the maintainers
call this morning.
Please can you find someone at Intel to look into it?


Thanks.
-- 
David Marchand