From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Zhang, Qi" <qi.zhang@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used
Date: Wed, 12 Apr 2017 11:43:27 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115308B12A@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1491922880-18702-1-git-send-email-bernard.iremonger@intel.com>
Hi Bernard:
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger
> Sent: Tuesday, April 11, 2017 11:01 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Zhang, Qi <qi.zhang@intel.com>; Iremonger,
> Bernard <bernard.iremonger@intel.com>
> Subject: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used
>
> In rx vector mode, the QinQ VLAN tag is not stripped.
> When hw_vlan_extend is set for QinQ ensure that rx vector mode is not
> selected.
>
> Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector
> driver")
Why fixes? I didn't see above commit change rx callback function if hw_vlan_extend == 1
>
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
> drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h
> b/drivers/net/i40e/i40e_rxtx_vec_common.h
> index 952fd4b63..692096684 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_common.h
> +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
> @@ -234,6 +234,10 @@
> i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev)
> if (rxmode->header_split == 1)
> return -1;
>
> + /* no QinQ support */
> + if (rxmode->hw_vlan_extend == 1)
> + return -1;
> +
> return 0;
> #else
> RTE_SET_USED(dev);
> --
> 2.11.0
next prev parent reply other threads:[~2017-04-12 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 15:01 Bernard Iremonger
2017-04-12 11:43 ` Zhang, Qi Z [this message]
2017-04-12 12:30 ` Iremonger, Bernard
2017-04-12 12:42 ` Zhang, Qi Z
2017-04-12 13:54 ` Iremonger, Bernard
2017-04-12 14:07 ` Ferruh Yigit
2017-04-12 14:16 ` Zhang, Qi Z
2017-04-12 15:05 ` Iremonger, Bernard
2017-04-12 14:37 ` Iremonger, Bernard
2017-04-12 15:28 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2017-04-13 9:53 ` [dpdk-dev] [PATCH v3] " Bernard Iremonger
2017-04-18 9:58 ` Ananyev, Konstantin
2017-04-18 10:04 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2017-04-19 13:10 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E706115308B12A@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=qi.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).