From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Zhang, Qi" <qi.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used
Date: Wed, 12 Apr 2017 15:05:41 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C224D530BA@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E706115308B269@SHSMSX103.ccr.corp.intel.com>
Hi Qi,
<snip>
> >
> > >>>> -----Original Message-----
> > >>>> From: Zhang, Qi Z
> > >>>> Sent: Wednesday, April 12, 2017 12:43 PM
> > >>>> To: Iremonger, Bernard <bernard.iremonger@intel.com>;
> > >>>> dev@dpdk.org
> > >>>> Cc: Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo
> > >>>> <wenzhuo.lu@intel.com>; Zhang, Qi <qi.zhang@intel.com>;
> > >>>> Iremonger, Bernard <bernard.iremonger@intel.com>
> > >>>> Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector
> > >>>> mode is not used
> > >>>>
> > >>>> Hi Bernard:
> > >>>>
> > >>>>> -----Original Message-----
> > >>>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard
> > >>>> Iremonger
> > >>>>> Sent: Tuesday, April 11, 2017 11:01 PM
> > >>>>> To: dev@dpdk.org
> > >>>>> Cc: Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo
> > >>>>> <wenzhuo.lu@intel.com>; Zhang, Qi <qi.zhang@intel.com>;
> > >> Iremonger,
> > >>>>> Bernard <bernard.iremonger@intel.com>
> > >>>>> Subject: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode
> > >>>>> is not used
> > >>>>>
> > >>>>> In rx vector mode, the QinQ VLAN tag is not stripped.
> > >>>>> When hw_vlan_extend is set for QinQ ensure that rx vector mode
> > >>>>> is not selected.
> > >>>>>
> > >>>>> Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code
> > >>>>> from vector
> > >>>>> driver")
> > >>>>
> > >>>> Why fixes? I didn't see above commit change rx callback function
> > >>>> if hw_vlan_extend == 1
> > >>>
> > >>> Some of the QinQ functionality was introduced in 17.02, this
> > >>> functionality also has the same issue.
> > >>> So I added a fixes line.
> > >>
> > >> If you think this patch is a fix, you need to find the commit that
> > >> introduce this issue The commit ca74903b75cf is not the root cause
> > >> of the issue, it just move the code from I40e_rxtx_vec.c to
> > >> i40e_rxtx_vec_common.h
> > >>
> > >> Regards
> > >> Qi
> > >>
> > > This is a fix to the i40e_rx_vec_dev_conf_condition_check_default()
> > function.
> > > The issue is caused because there is no check on the hw_vlan_extend
> flag
> > at present.
> > > This is the correct fixline for that function.
> > > ca74903b75 (Jianbo Liu 2016-10-14 09:30:00 +0530 221)
> > i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev
> *dev)
> > >
> > > I will send a v2 as I should have added the "Cc: stable@dpdk.org" line.
>
> I think it should be
> Fixes: 8e109464c02292 ("i40e: allow vector Rx and Tx usage") This is the first
> commit after which that QinQ is allowed with vPMD.
Or should it be the following commit, when it is used for QinQ?
Fixes: 5b2d37858d32 ("net/i40e: fix single VLAN tag to be outer VLAN tag")
> >
> > Hi Bernard,
> >
> > I agree with Qi, the commit you are using is just moves function to a
> > common header, you are not fixing that.
> >
> > Perhaps fixline can be the commit that adds QinQ support, because it
> > forgets adding hw_vlan_extend check?
> >
> > byw, since this common function used by other vector drivers, neon and
> > altivec, will this something effect them, is there any case
> > "hw_vlan_extend == 1" but other vector drivers can be used?
>
> As I see, neon and altivec follow x86's implementation, they do not support
> QinQ neither.
>
> >
> > Thanks,
> > ferruh
> >
> > >
> > > Regards,
> > >
> > > Bernard.
> > >
> > >
Regards,
Bernard.
next prev parent reply other threads:[~2017-04-12 15:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 15:01 Bernard Iremonger
2017-04-12 11:43 ` Zhang, Qi Z
2017-04-12 12:30 ` Iremonger, Bernard
2017-04-12 12:42 ` Zhang, Qi Z
2017-04-12 13:54 ` Iremonger, Bernard
2017-04-12 14:07 ` Ferruh Yigit
2017-04-12 14:16 ` Zhang, Qi Z
2017-04-12 15:05 ` Iremonger, Bernard [this message]
2017-04-12 14:37 ` Iremonger, Bernard
2017-04-12 15:28 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2017-04-13 9:53 ` [dpdk-dev] [PATCH v3] " Bernard Iremonger
2017-04-18 9:58 ` Ananyev, Konstantin
2017-04-18 10:04 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2017-04-19 13:10 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C224D530BA@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qi.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).