From: Olivier Matz <olivier.matz@6wind.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Tomasz Duszynski <tdu@semihalf.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Ivan Malov <Ivan.Malov@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address
Date: Tue, 3 Apr 2018 18:26:16 +0200 [thread overview]
Message-ID: <20180403162616.2xyosoulzcw7s24p@platinum> (raw)
In-Reply-To: <20180403145724.GD4957@6wind.com>
On Tue, Apr 03, 2018 at 04:57:24PM +0200, Adrien Mazarguil wrote:
> On Tue, Apr 03, 2018 at 02:41:03PM +0200, Olivier Matz wrote:
> > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a
> > return code is added to notify the caller (librte_ether) if an error
> > occurred in the PMD.
> >
> > The new default MAC address is now copied in dev->data->mac_addrs[0]
> > only if the operation is successful.
> >
> > The patch also updates all the PMDs accordingly.
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> > ---
> >
> > v2:
> > * add same change for net/cxgbe
> > * mrvl was renamed as mvpp2
> > * mvpp2: return success if no ppio as suggested by Tomasz
> > * mlx5: update comment as suggested by Adrien
> > * sfc: replace by Ivan's patch
>
> Just one remaining nit regarding mlx5, please see below. Otherwise for both
> mlx4 and mlx5:
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
> <snip>
> > diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c
> > index 01c7ba17a..3bf76e38c 100644
> > --- a/drivers/net/mlx5/mlx5_mac.c
> > +++ b/drivers/net/mlx5/mlx5_mac.c
> > @@ -124,8 +124,11 @@ mlx5_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac,
> > * Pointer to Ethernet device structure.
> > * @param mac_addr
> > * MAC address to register.
> > + *
> > + * @return
> > + * 0 on success, a negative errno value otherwise and rte_errno is set.
> > */
> > -void
> > +int
> > mlx5_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)
> > {
> > int ret;
> > @@ -137,4 +140,6 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)
> > if (ret)
> > DRV_LOG(ERR, "port %u cannot set mac address: %s",
> > dev->data->port_id, strerror(rte_errno));
> > +
>
> This empty line is unnecessary (this follows the work done to remove
> non-mandatory empty lines sprinkled everywhere in these PMDs for coding
> style consistency).
Will fix in next version, thanks.
Olivier
next prev parent reply other threads:[~2018-04-03 16:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 15:11 [dpdk-dev] [PATCH] " Olivier Matz
2018-03-05 10:29 ` Adrien Mazarguil
2018-03-06 9:37 ` Tomasz Duszynski
2018-03-16 15:41 ` Andrew Rybchenko
2018-03-26 18:39 ` Ferruh Yigit
2018-03-28 8:24 ` Olivier Matz
2018-04-03 12:41 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2018-04-03 13:02 ` Andrew Rybchenko
2018-04-03 14:57 ` Adrien Mazarguil
2018-04-03 16:26 ` Olivier Matz [this message]
2018-04-03 16:19 ` Ferruh Yigit
2018-04-03 16:25 ` Olivier Matz
2018-04-04 8:19 ` Shreyansh Jain
2018-04-06 15:21 ` [dpdk-dev] [PATCH] " Olivier Matz
2018-04-06 15:34 ` Olivier Matz
2018-04-09 8:57 ` Nélio Laranjeiro
2018-04-06 15:34 ` [dpdk-dev] [PATCH v3] " Olivier Matz
2018-04-06 16:03 ` Ferruh Yigit
2018-04-10 13:19 ` Thomas Monjalon
2018-04-11 16:32 ` [dpdk-dev] [PATCH v4] " Olivier Matz
2018-04-11 19:30 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403162616.2xyosoulzcw7s24p@platinum \
--to=olivier.matz@6wind.com \
--cc=Ivan.Malov@oktetlabs.ru \
--cc=adrien.mazarguil@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=tdu@semihalf.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).