From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Olivier Matz <olivier.matz@6wind.com>, <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Tomasz Duszynski <tdu@semihalf.com>,
Ivan Malov <Ivan.Malov@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address
Date: Tue, 3 Apr 2018 16:02:11 +0300 [thread overview]
Message-ID: <6cd951f4-fba1-7fc5-93fa-aee0e6480f08@solarflare.com> (raw)
In-Reply-To: <20180403124103.13124-1-olivier.matz@6wind.com>
On 04/03/2018 03:41 PM, Olivier Matz wrote:
> Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a
> return code is added to notify the caller (librte_ether) if an error
> occurred in the PMD.
>
> The new default MAC address is now copied in dev->data->mac_addrs[0]
> only if the operation is successful.
>
> The patch also updates all the PMDs accordingly.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> ---
>
> v2:
> * add same change for net/cxgbe
> * mrvl was renamed as mvpp2
> * mvpp2: return success if no ppio as suggested by Tomasz
> * mlx5: update comment as suggested by Adrien
> * sfc: replace by Ivan's patch
>
> doc/guides/rel_notes/deprecation.rst | 8 --------
> drivers/net/ark/ark_ethdev.c | 9 ++++++---
> drivers/net/avf/avf_ethdev.c | 12 +++++++----
> drivers/net/bnxt/bnxt_ethdev.c | 10 ++++++----
> drivers/net/bonding/rte_eth_bond_pmd.c | 8 ++++++--
> drivers/net/cxgbe/cxgbe_ethdev.c | 5 +++--
> drivers/net/cxgbe/cxgbe_pfvf.h | 2 +-
> drivers/net/dpaa/dpaa_ethdev.c | 4 +++-
> drivers/net/dpaa2/dpaa2_ethdev.c | 6 ++++--
> drivers/net/e1000/igb_ethdev.c | 12 ++++++-----
> drivers/net/failsafe/failsafe_ops.c | 17 +++++++++++++---
> drivers/net/i40e/i40e_ethdev.c | 24 +++++++++++++---------
> drivers/net/i40e/i40e_ethdev_vf.c | 12 ++++++-----
> drivers/net/ixgbe/ixgbe_ethdev.c | 13 +++++++-----
> drivers/net/mlx4/mlx4.h | 2 +-
> drivers/net/mlx4/mlx4_ethdev.c | 7 +++++--
> drivers/net/mlx5/mlx5.h | 2 +-
> drivers/net/mlx5/mlx5_mac.c | 7 ++++++-
> drivers/net/mvpp2/mrvl_ethdev.c | 15 ++++++++++----
> drivers/net/null/rte_eth_null.c | 3 ++-
> drivers/net/octeontx/octeontx_ethdev.c | 4 +++-
> drivers/net/qede/qede_ethdev.c | 7 +++----
> drivers/net/sfc/sfc_ethdev.c | 35 ++++++++++++++++++++++-----------
> drivers/net/szedata2/rte_eth_szedata2.c | 3 ++-
> drivers/net/tap/rte_eth_tap.c | 34 +++++++++++++++++++++-----------
> drivers/net/virtio/virtio_ethdev.c | 15 +++++++++-----
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 +++--
> lib/librte_ether/rte_ethdev.c | 7 +++++--
> lib/librte_ether/rte_ethdev_core.h | 2 +-
> test/test/virtual_pmd.c | 3 ++-
> 30 files changed, 188 insertions(+), 105 deletions(-)
sfc part
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2018-04-03 13:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 15:11 [dpdk-dev] [PATCH] " Olivier Matz
2018-03-05 10:29 ` Adrien Mazarguil
2018-03-06 9:37 ` Tomasz Duszynski
2018-03-16 15:41 ` Andrew Rybchenko
2018-03-26 18:39 ` Ferruh Yigit
2018-03-28 8:24 ` Olivier Matz
2018-04-03 12:41 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2018-04-03 13:02 ` Andrew Rybchenko [this message]
2018-04-03 14:57 ` Adrien Mazarguil
2018-04-03 16:26 ` Olivier Matz
2018-04-03 16:19 ` Ferruh Yigit
2018-04-03 16:25 ` Olivier Matz
2018-04-04 8:19 ` Shreyansh Jain
2018-04-06 15:21 ` [dpdk-dev] [PATCH] " Olivier Matz
2018-04-06 15:34 ` Olivier Matz
2018-04-09 8:57 ` Nélio Laranjeiro
2018-04-06 15:34 ` [dpdk-dev] [PATCH v3] " Olivier Matz
2018-04-06 16:03 ` Ferruh Yigit
2018-04-10 13:19 ` Thomas Monjalon
2018-04-11 16:32 ` [dpdk-dev] [PATCH v4] " Olivier Matz
2018-04-11 19:30 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cd951f4-fba1-7fc5-93fa-aee0e6480f08@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=Ivan.Malov@oktetlabs.ru \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=tdu@semihalf.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).