From: Shahaf Shuler <shahafs@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 3/4] net/mlx5: rework PMD global data init
Date: Tue, 19 Mar 2019 06:54:13 +0000 [thread overview]
Message-ID: <AM0PR0502MB3795D8E49B1B1F27E19EC427C3400@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
Message-ID: <20190319065413.sWQm0pQlDxdY6vxbyRaIZ9LIXVsEjXvNOSGjnQ7oSRM@z> (raw)
In-Reply-To: <20190318212107.GA37866@yongseok-MBP.local>
Monday, March 18, 2019 11:21 PM, Yongseok Koh:
> Subject: Re: [PATCH 3/4] net/mlx5: rework PMD global data init
>
> On Thu, Mar 14, 2019 at 05:36:28AM -0700, Shahaf Shuler wrote:
> > Hi Koh,
> >
> > Thursday, March 7, 2019 9:33 AM, Yongseok Koh:
> > > Subject: [PATCH 3/4] net/mlx5: rework PMD global data init
> > >
> > > There's more need to have PMD global data structure. It should be
> > > initialized once per a process regardless of how many PMD instances are
> probed.
> > > mlx5_init_once() is called during probing and make sure all the init
> > > functions are called once per a process. The existing shared memory
> > > gets more extensively used for this purpose. As there could be
> > > multiple secondary processes, a static storage (local to process) is also
> added.
> >
> > It is hard to understand from the commit log what was missing on the old
> design.
>
> Okay, will add more comments.
>
> > > As the reserved virtual address for UAR remap is a PMD global
> > > resource, this doesn't need to be stored in the device priv
> > > structure, but in the PMD global data.
> >
> > I thought we agreed to drop those and have different VA for each process.
> > If so, is the extra work on the UAR here is needed?
>
> My plan was to do that in a separate patch for performance regression.
> Let me know if you want it to be done in this patchset.
I prefer to see how the UAR will look in the final design. If you can include such patch it wil be great.
Otherwise lets keep it as is.
>
> > > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> > > ---
> > > drivers/net/mlx5/mlx5.c | 250
> ++++++++++++++++++++++++++++++++--
> > > ----------
> > > drivers/net/mlx5/mlx5.h | 19 +++-
> > > drivers/net/mlx5/mlx5_mp.c | 19 +++-
> > > drivers/net/mlx5/mlx5_txq.c | 7 +-
> > > 4 files changed, 217 insertions(+), 78 deletions(-)
> > >
> > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index
> > > 6ed2418106..ea8fd55ee6 100644
> > > --- a/drivers/net/mlx5/mlx5.c
> > > +++ b/drivers/net/mlx5/mlx5.c
> > > @@ -128,16 +128,26 @@ struct mlx5_shared_data *mlx5_shared_data;
> > > /* Spinlock for mlx5_shared_data allocation. */ static
> > > rte_spinlock_t mlx5_shared_data_lock = RTE_SPINLOCK_INITIALIZER;
> > >
> > > +/* Process local data for secondary processes. */ static struct
> > > +mlx5_local_data mlx5_local_data;
> >
> > Why not storing this context as part of ethdev-> process_private instead of
> declaring it static?
>
> Because it is not per-device data but per-PMD data.
>
> Will also have to rebase my patchsets when I send out v2.
>
>
> Thanks,
> Yongseok
next prev parent reply other threads:[~2019-03-19 6:54 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 7:33 [dpdk-dev] [PATCH 0/4] net/mlx5: rework IPC socket and " Yongseok Koh
2019-03-07 7:33 ` [dpdk-dev] [PATCH 1/4] net/mlx5: fix memory event on secondary process Yongseok Koh
2019-03-07 7:33 ` [dpdk-dev] [PATCH 2/4] net/mlx5: replace IPC socket with EAL API Yongseok Koh
2019-03-14 12:36 ` Shahaf Shuler
2019-03-14 12:36 ` Shahaf Shuler
2019-03-18 21:29 ` Yongseok Koh
2019-03-18 21:29 ` Yongseok Koh
2019-03-07 7:33 ` [dpdk-dev] [PATCH 3/4] net/mlx5: rework PMD global data init Yongseok Koh
2019-03-14 12:36 ` Shahaf Shuler
2019-03-14 12:36 ` Shahaf Shuler
2019-03-18 21:21 ` Yongseok Koh
2019-03-18 21:21 ` Yongseok Koh
2019-03-19 6:54 ` Shahaf Shuler [this message]
2019-03-19 6:54 ` Shahaf Shuler
2019-03-07 7:33 ` [dpdk-dev] [PATCH 4/4] net/mlx5: sync stop/start of datapath with secondary process Yongseok Koh
2019-03-25 19:15 ` [dpdk-dev] [PATCH v2 0/4] net/mlx5: rework IPC socket and PMD global data init Yongseok Koh
2019-03-25 19:15 ` Yongseok Koh
2019-03-25 19:15 ` [dpdk-dev] [PATCH v2 1/4] net/mlx5: fix memory event on secondary process Yongseok Koh
2019-03-25 19:15 ` Yongseok Koh
2019-03-26 12:28 ` Shahaf Shuler
2019-03-26 12:28 ` Shahaf Shuler
2019-03-25 19:15 ` [dpdk-dev] [PATCH v2 2/4] net/mlx5: replace IPC socket with EAL API Yongseok Koh
2019-03-25 19:15 ` Yongseok Koh
2019-03-26 12:31 ` Shahaf Shuler
2019-03-26 12:31 ` Shahaf Shuler
2019-03-25 19:15 ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: rework PMD global data init Yongseok Koh
2019-03-25 19:15 ` Yongseok Koh
2019-03-26 12:38 ` Shahaf Shuler
2019-03-26 12:38 ` Shahaf Shuler
2019-03-25 19:15 ` [dpdk-dev] [PATCH v2 4/4] net/mlx5: sync stop/start of datapath with secondary process Yongseok Koh
2019-03-25 19:15 ` Yongseok Koh
2019-03-26 12:49 ` Shahaf Shuler
2019-03-26 12:49 ` Shahaf Shuler
2019-04-01 21:12 ` [dpdk-dev] [PATCH v3 0/4] net/mlx5: rework IPC socket and PMD global data init Yongseok Koh
2019-04-01 21:12 ` Yongseok Koh
2019-04-01 21:12 ` [dpdk-dev] [PATCH v3 1/4] net/mlx5: fix memory event on secondary process Yongseok Koh
2019-04-01 21:12 ` Yongseok Koh
2019-04-01 21:12 ` [dpdk-dev] [PATCH v3 2/4] net/mlx5: replace IPC socket with EAL API Yongseok Koh
2019-04-01 21:12 ` Yongseok Koh
2019-04-01 21:12 ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: rework PMD global data init Yongseok Koh
2019-04-01 21:12 ` Yongseok Koh
2019-04-01 21:12 ` [dpdk-dev] [PATCH v3 4/4] net/mlx5: sync stop/start of datapath with secondary process Yongseok Koh
2019-04-01 21:12 ` Yongseok Koh
2019-04-02 7:11 ` [dpdk-dev] [PATCH v3 0/4] net/mlx5: rework IPC socket and PMD global data init Shahaf Shuler
2019-04-02 7:11 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB3795D8E49B1B1F27E19EC427C3400@AM0PR0502MB3795.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).