DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Wei Zhao <wei.zhao1@intel.com>, dev@dpdk.org
Cc: yuan.peng@intel.com, stable@dpdk.org, qi.z.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key
Date: Wed, 20 Mar 2019 12:20:58 +0000	[thread overview]
Message-ID: <26b0ab4f-3bae-7ce4-89d0-4c1e49500440@redhat.com> (raw)
Message-ID: <20190320122058.9mUKXp9gSP_tOZa1pOFisBOdUyeGPrq1SqqIxxl1Vfo@z> (raw)
In-Reply-To: <1553052676-7961-1-git-send-email-wei.zhao1@intel.com>

On 20/03/2019 03:31, Wei Zhao wrote:
> There need a warning info when no perfect RSS key is config,

It is mixing info and warning levels in the description and log. Better
to be consistent and use one (I think info).

> so i40e will use default key.
> 
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index dca61f0..9235b08 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
>  		rss_conf.rss_key = (uint8_t *)rss_key_default;
>  		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
>  							sizeof(uint32_t);
> +		PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so use default configuration\n");

It's an info log, so remove "Warning!" and the message can be a little
clearer so user doesn't interpret as an instruction. Suggest "No RSS key
config for i40e provided, using default"

>  	}
>  
>  	i40e_hw_rss_hash_set(pf, &rss_conf);
> 


  parent reply	other threads:[~2019-03-20 12:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20  3:31 Wei Zhao
2019-03-20  3:31 ` Wei Zhao
2019-03-20  9:21 ` Peng, Yuan
2019-03-20  9:21   ` Peng, Yuan
2019-03-20  9:23   ` Zhao1, Wei
2019-03-20  9:23     ` Zhao1, Wei
2019-03-20 12:20 ` Kevin Traynor [this message]
2019-03-20 12:20   ` Kevin Traynor
2019-03-22  1:27   ` Zhao1, Wei
2019-03-22  1:27     ` Zhao1, Wei
2019-03-22  2:16 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-03-22  2:16   ` Wei Zhao
2019-03-22  3:06 ` Wei Zhao
2019-03-22  3:06   ` Wei Zhao
2019-03-22 13:30   ` Zhang, Qi Z
2019-03-22 13:30     ` Zhang, Qi Z
2019-03-26  8:35   ` [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid Wei Zhao
2019-03-26  8:35     ` Wei Zhao
2019-03-26 12:41     ` Zhang, Qi Z
2019-03-26 12:41       ` Zhang, Qi Z
2019-03-26 14:51       ` Ferruh Yigit
2019-03-26 14:51         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26b0ab4f-3bae-7ce4-89d0-4c1e49500440@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wei.zhao1@intel.com \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).