From: Bruce Richardson <bruce.richardson@intel.com>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/power: fix governor storage to trim newlines
Date: Fri, 29 Mar 2019 16:24:18 +0000 [thread overview]
Message-ID: <20190329162417.GA1432@bricha3-MOBL.ger.corp.intel.com> (raw)
Message-ID: <20190329162418.R_HEHnboyRGFs_UYbIoGel7Z91u068NSQFBfPZtK4jY@z> (raw)
In-Reply-To: <20190329161142.39787-1-david.hunt@intel.com>
On Fri, Mar 29, 2019 at 04:11:42PM +0000, David Hunt wrote:
> Currently the Power Libray stores the governor name with an embedded
> newline read from the scaling_governor sysfs file. This patch strips
> it out.
>
> Fixes: 445c6528b55f ("power: common interface for guest and host")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
> lib/librte_power/power_acpi_cpufreq.c | 4 ++++
> lib/librte_power/power_pstate_cpufreq.c | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c
> index 45412f0b9..c2febdf06 100644
> --- a/lib/librte_power/power_acpi_cpufreq.c
> +++ b/lib/librte_power/power_acpi_cpufreq.c
> @@ -147,6 +147,10 @@ power_set_governor_userspace(struct rte_power_info *pi)
>
> s = fgets(buf, sizeof(buf), f);
> FOPS_OR_NULL_GOTO(s, out);
> + buf[BUFSIZ-1] = '\0';
Should not be needed as fgets null-terminates.
" fgets() reads in at most one less than size characters from stream and
stores them into the buffer pointed to by s. Reading stops after an EOF or
a newline. If a newline is read, it is stored into the buffer. A
terminating null byte ('\0') is stored after the last character in the
buffer."
/Bruce
next prev parent reply other threads:[~2019-03-29 16:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 16:11 David Hunt
2019-03-29 16:11 ` David Hunt
2019-03-29 16:24 ` Bruce Richardson [this message]
2019-03-29 16:24 ` Bruce Richardson
2019-03-29 16:25 ` Burakov, Anatoly
2019-03-29 16:25 ` Burakov, Anatoly
2019-03-29 16:35 ` Hunt, David
2019-03-29 16:35 ` Hunt, David
2019-03-29 16:39 ` [dpdk-dev] [PATCH v2] " David Hunt
2019-03-29 16:39 ` David Hunt
2019-03-29 17:56 ` Burakov, Anatoly
2019-03-29 17:56 ` Burakov, Anatoly
2019-04-01 20:24 ` Thomas Monjalon
2019-04-01 20:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329162417.GA1432@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).