DPDK patches and discussions
 help / color / mirror / Atom feed

From: "Hunt, David" <david.hunt@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/power: fix governor storage to trim newlines
Date: Fri, 29 Mar 2019 16:35:12 +0000	[thread overview]
Message-ID: <eaad6404-6f09-55bb-7d45-5430f15e687e@intel.com> (raw)
Message-ID: <20190329163512.1Q3PeQA9j82NHwlqYA-wCifzNTrUyrjit_urrP9dC4g@z> (raw)
In-Reply-To: <abf8228d-9c7d-d4b6-753e-44fe8077c20e@intel.com>

Hi Anatoly,

On 29/3/2019 4:25 PM, Burakov, Anatoly wrote:
> On 29-Mar-19 4:11 PM, David Hunt wrote:
>> Currently the Power Libray stores the governor name with an embedded
>> newline read from the scaling_governor sysfs file. This patch strips
>> it out.
>>
>> Fixes: 445c6528b55f ("power: common interface for guest and host")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> ---
>>   lib/librte_power/power_acpi_cpufreq.c   | 4 ++++
>>   lib/librte_power/power_pstate_cpufreq.c | 4 ++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/lib/librte_power/power_acpi_cpufreq.c 
>> b/lib/librte_power/power_acpi_cpufreq.c
>> index 45412f0b9..c2febdf06 100644
>> --- a/lib/librte_power/power_acpi_cpufreq.c
>> +++ b/lib/librte_power/power_acpi_cpufreq.c
>> @@ -147,6 +147,10 @@ power_set_governor_userspace(struct 
>> rte_power_info *pi)
>>         s = fgets(buf, sizeof(buf), f);
>>       FOPS_OR_NULL_GOTO(s, out);
>> +    buf[BUFSIZ-1] = '\0';
>> +    if (strlen(buf))
>> +        /* Strip off terminating '\n' */
>> +        strtok(buf, "\n");
>
> I have a feeling that either strlen or strtok here is unnecessary.
>
> If it's always terminating - you can just use strlen return value and 
> overwrite the '\n' without going over the string the second time - you 
> know where the string ends!
>
> You have already written null-terminator to the end of the buffer, so 
> it can't overflow on strtok, so you don't really need strlen either, 
> because the string will either:
>
> 1) be empty (in which case strtok does nothing)
> 2) contain text + newline (in which case you cut off the newline and 
> leave the text - no need for strlen), or
> 3) contain just a newline (which would make it empty after strtok)
>
> Did you mean to only cut off the newline off the strings that have 
> stuff other than newline? That would be the only case where using 
> strlen would make sense - in which case, not only the check is wrong, 
> but you could also replace it with a simple 'if (buf[0] != '\n')' 
> check instead of strlen.
>

So just the strtok() then, without anything else (apart from the 
comment) . Sure! :)

Thanks,
Dave.

next prev parent reply	other threads:[~2019-03-29 16:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29 16:11 David Hunt
2019-03-29 16:11 ` David Hunt
2019-03-29 16:24 ` Bruce Richardson
2019-03-29 16:24   ` Bruce Richardson
2019-03-29 16:25 ` Burakov, Anatoly
2019-03-29 16:25   ` Burakov, Anatoly
2019-03-29 16:35   ` Hunt, David [this message]
2019-03-29 16:35     ` Hunt, David
2019-03-29 16:39 ` [dpdk-dev] [PATCH v2] " David Hunt
2019-03-29 16:39   ` David Hunt
2019-03-29 17:56   ` Burakov, Anatoly
2019-03-29 17:56     ` Burakov, Anatoly
2019-04-01 20:24     ` Thomas Monjalon
2019-04-01 20:24       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eaad6404-6f09-55bb-7d45-5430f15e687e@intel.com \
    --to=david.hunt@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).