From: Bruce Richardson <bruce.richardson@intel.com>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] build: use cat if found
Date: Mon, 1 Apr 2019 16:48:30 +0100 [thread overview]
Message-ID: <20190401154830.GA1452@bricha3-MOBL.ger.corp.intel.com> (raw)
Message-ID: <20190401154830.duAJYs8ZslsAZrip7gbxaVf4m1MDKeIE4f0tH5Eeqv0@z> (raw)
In-Reply-To: <20190401153836.30807-1-alialnu@mellanox.com>
On Mon, Apr 01, 2019 at 03:38:59PM +0000, Ali Alnubani wrote:
> This is to fix a build error with meson in GNU/Linux that is caused
> by using the 'more' command to read the VERSION file. The error:
>
> config/meson.build:10:10: ERROR: String
> '::::::::::::::\n<RTE_SDK_PATH>VERSION\n::::::::::::::\n19' cannot be
> converted to int
>
> The command 'more' prints the file name before the actual
> contents of the file when it's being run without a controlling terminal.
> This could happen in CI environments.
>
> Please refer to:
> https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/text-utils/more.c
>
> Fixes: c04172b5f031 ("build: add single source of DPDK version number")
> Fixes: d320fe56bd51 ("build: use version number from config file")
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> Changes in v2:
> - Use find_program to fallback to 'more'.
> - Update patch title.
>
> meson.build | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Thanks for the V2, code change looks good now. For the title, I think this
is really a bug-fix so I'd suggest something like:
build: fix meson build in CI environments
as more helpful. [Thomas, can you correct on apply, or do you want a v3?]
/Bruce
next prev parent reply other threads:[~2019-04-01 15:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 10:36 [dpdk-dev] [PATCH] build: use cat instead of more Ali Alnubani
2019-04-01 10:36 ` Ali Alnubani
2019-04-01 11:24 ` Thomas Monjalon
2019-04-01 11:24 ` Thomas Monjalon
2019-04-01 14:47 ` Bruce Richardson
2019-04-01 14:47 ` Bruce Richardson
2019-04-01 15:38 ` [dpdk-dev] [PATCH v2] build: use cat if found Ali Alnubani
2019-04-01 15:38 ` Ali Alnubani
2019-04-01 15:48 ` Bruce Richardson [this message]
2019-04-01 15:48 ` Bruce Richardson
2019-04-01 16:59 ` Thomas Monjalon
2019-04-01 16:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401154830.GA1452@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).