From: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
To: Keith Wiles <keith.wiles@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com,
Herakliusz Lipiec <herakliusz.lipiec@intel.com>,
rasland@mellanox.com, stable@dpdk.org
Subject: [dpdk-stable] [PATCH v4 2/2] ipc: fix tap pmd memleak
Date: Thu, 25 Apr 2019 13:48:17 +0100 [thread overview]
Message-ID: <20190425124817.28409-3-herakliusz.lipiec@intel.com> (raw)
In-Reply-To: <20190425124817.28409-1-herakliusz.lipiec@intel.com>
When sending synchronous IPC requests, the caller must free the response
buffer if the request was successful and reply is no longer needed.
Fix the code to correctly
use the IPC API.
Bugzilla ID: 228
Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
Cc: rasland@mellanox.com
Cc: stable@dpdk.org
Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
---
drivers/net/tap/rte_eth_tap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 7f74b5dc9..f8a4169c5 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -2118,7 +2118,7 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)
process_private->rxq_fds[queue] = reply->fds[fd_iterator++];
for (queue = 0; queue < reply_param->txq_count; queue++)
process_private->txq_fds[queue] = reply->fds[fd_iterator++];
-
+ free(reply);
return 0;
}
--
2.17.2
next prev parent reply other threads:[~2019-04-25 12:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 14:38 [dpdk-stable] [PATCH 1/8] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-23 8:11 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2019-04-23 8:13 ` Burakov, Anatoly
[not found] ` <20190423174334.19612-1-herakliusz.lipiec@intel.com>
2019-04-23 17:43 ` [dpdk-stable] [PATCH v2 " Herakliusz Lipiec
2019-04-24 9:28 ` [dpdk-stable] [dpdk-dev] " Stojaczyk, Dariusz
2019-04-25 9:37 ` Burakov, Anatoly
2019-04-23 17:43 ` [dpdk-stable] [PATCH v2 2/8] ipc: fix hotplug memleak Herakliusz Lipiec
2019-04-25 6:00 ` [dpdk-stable] [dpdk-dev] " Stojaczyk, Dariusz
2019-04-23 17:43 ` [dpdk-stable] [PATCH v2 3/8] ipc: fix vdev memleak Herakliusz Lipiec
2019-04-25 6:08 ` [dpdk-stable] [dpdk-dev] " Stojaczyk, Dariusz
2019-04-23 17:43 ` [dpdk-stable] [PATCH v2 4/8] ipc: fix vfio memleak Herakliusz Lipiec
2019-04-25 6:06 ` [dpdk-stable] [dpdk-dev] " Stojaczyk, Dariusz
2019-04-23 17:43 ` [dpdk-stable] [PATCH v2 5/8] ipc: fix pdump memleak Herakliusz Lipiec
2019-04-23 17:43 ` [dpdk-stable] [PATCH v2 6/8] ipc: fix tap pmd memleak Herakliusz Lipiec
[not found] ` <20190425114324.611-1-herakliusz.lipiec@intel.com>
2019-04-25 11:43 ` [dpdk-stable] [PATCH v3 1/2] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-25 12:47 ` Burakov, Anatoly
2019-04-25 11:43 ` [dpdk-stable] [PATCH v3 2/2] ipc: fix tap pmd memleak Herakliusz Lipiec
[not found] ` <20190425124817.28409-1-herakliusz.lipiec@intel.com>
2019-04-25 12:48 ` [dpdk-stable] [PATCH v4 1/2] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-25 12:48 ` Burakov, Anatoly
2019-04-25 12:48 ` Herakliusz Lipiec [this message]
2019-04-25 18:14 ` [dpdk-stable] [PATCH v4 2/2] ipc: fix tap pmd memleak Wiles, Keith
[not found] ` <20190503102857.15812-1-herakliusz.lipiec@intel.com>
2019-05-03 10:28 ` [dpdk-stable] [PATCH v5 1/2] ipc: fix memory leak in sync request Herakliusz Lipiec
2019-05-03 10:28 ` [dpdk-stable] [PATCH v5 2/2] net/tap: fix ipc related memory leak Herakliusz Lipiec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425124817.28409-3-herakliusz.lipiec@intel.com \
--to=herakliusz.lipiec@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).