From: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>
To: "Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>,
"jianfeng.tan@intel.com" <jianfeng.tan@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak
Date: Wed, 24 Apr 2019 09:28:41 +0000 [thread overview]
Message-ID: <FBE7E039FA50BF47A673AD0BD3CD56A8463232C7@HASMSX105.ger.corp.intel.com> (raw)
In-Reply-To: <20190423174334.19612-2-herakliusz.lipiec@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Herakliusz Lipiec
> Sent: Tuesday, April 23, 2019 7:43 PM
> Cc: dev@dpdk.org; Lipiec, Herakliusz <herakliusz.lipiec@intel.com>;
> jianfeng.tan@intel.com; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak
>
> When sending multiple requests, rte_mp_request_sync
> can succeed sending a few of those requests, but then
> fail on a later one and in the end return with rc=-1.
> The upper layers - e.g. device hotplug - currently
> handles this case as if no messages were sent and no
> memory for response buffers was allocated, which is
> not true. Fixed by always initializing message buffer
> to NULL.
> Bugzilla ID: 228
> Fixes: 783b6e54971d ("eal: add synchronous multi-process communication")
> Cc: jianfeng.tan@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
Acked-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Thanks!
next prev parent reply other threads:[~2019-04-24 9:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 14:38 [dpdk-stable] [PATCH " Herakliusz Lipiec
2019-04-23 8:11 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2019-04-23 8:13 ` Burakov, Anatoly
[not found] ` <20190423174334.19612-1-herakliusz.lipiec@intel.com>
2019-04-23 17:43 ` [dpdk-stable] [PATCH v2 " Herakliusz Lipiec
2019-04-24 9:28 ` Stojaczyk, Dariusz [this message]
2019-04-25 9:37 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2019-04-23 17:43 ` [dpdk-stable] [PATCH v2 2/8] ipc: fix hotplug memleak Herakliusz Lipiec
2019-04-25 6:00 ` [dpdk-stable] [dpdk-dev] " Stojaczyk, Dariusz
2019-04-23 17:43 ` [dpdk-stable] [PATCH v2 3/8] ipc: fix vdev memleak Herakliusz Lipiec
2019-04-25 6:08 ` [dpdk-stable] [dpdk-dev] " Stojaczyk, Dariusz
2019-04-23 17:43 ` [dpdk-stable] [PATCH v2 4/8] ipc: fix vfio memleak Herakliusz Lipiec
2019-04-25 6:06 ` [dpdk-stable] [dpdk-dev] " Stojaczyk, Dariusz
2019-04-23 17:43 ` [dpdk-stable] [PATCH v2 5/8] ipc: fix pdump memleak Herakliusz Lipiec
2019-04-23 17:43 ` [dpdk-stable] [PATCH v2 6/8] ipc: fix tap pmd memleak Herakliusz Lipiec
[not found] ` <20190425114324.611-1-herakliusz.lipiec@intel.com>
2019-04-25 11:43 ` [dpdk-stable] [PATCH v3 1/2] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-25 12:47 ` Burakov, Anatoly
2019-04-25 11:43 ` [dpdk-stable] [PATCH v3 2/2] ipc: fix tap pmd memleak Herakliusz Lipiec
[not found] ` <20190425124817.28409-1-herakliusz.lipiec@intel.com>
2019-04-25 12:48 ` [dpdk-stable] [PATCH v4 1/2] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-25 12:48 ` Burakov, Anatoly
2019-04-25 12:48 ` [dpdk-stable] [PATCH v4 2/2] ipc: fix tap pmd memleak Herakliusz Lipiec
2019-04-25 18:14 ` Wiles, Keith
[not found] ` <20190503102857.15812-1-herakliusz.lipiec@intel.com>
2019-05-03 10:28 ` [dpdk-stable] [PATCH v5 1/2] ipc: fix memory leak in sync request Herakliusz Lipiec
2019-05-03 10:28 ` [dpdk-stable] [PATCH v5 2/2] net/tap: fix ipc related memory leak Herakliusz Lipiec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FBE7E039FA50BF47A673AD0BD3CD56A8463232C7@HASMSX105.ger.corp.intel.com \
--to=dariusz.stojaczyk@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=herakliusz.lipiec@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).