DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30
Date: Thu, 2 May 2019 14:46:32 +0100	[thread overview]
Message-ID: <20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com> (raw)
Message-ID: <20190502134632.MMQvi68iWh-q0tGqRo8eos2KzVaL8OaVoak27jXh_Pg@z> (raw)
In-Reply-To: <CAJFAV8yn8qjNJ+Gy+1dNhr-AUvY2wyp9F6A4tURGoiA1+ZVxOg@mail.gmail.com>

On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote:
>    On Thu, May 2, 2019 at 3:24 PM Bruce Richardson
>    <[1]bruce.richardson@intel.com> wrote:
> 
>      On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote:
>      >    On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon
>      <[1][2]thomas@monjalon.net>
>      >    wrote:
>      >
>      >      01/05/2019 21:50, Bruce Richardson:
>      >      > This set of changes fixes warnings seen when compiling DPDK
>      on
>      >      Fedora 30.
>      >      > In most cases these warnings appear to be false positives,
>      which
>      >      means we
>      >      > have the option to just disable the warning. Because the
>      changes
>      >      required
>      >      > to the code to silence the warnings are fairly small I've
>      chosen
>      >      in all cases
>      >      > to change the code rather than disable the warnings, but
>      I'm open
>      >      to doing
>      >      > the opposite if it's felt it's a better solution. [One
>      thing I
>      >      didn't like
>      >      > about disabling the warnings is that the disabling flags
>      are not
>      >      supported
>      >      > by clang, so adding them involves compiler checks :-(]
>      >      >
>      >      > NOTE: this set does not cover all warnings with GCC9, but
>      it does
>      >      cover
>      >      > those seen when building with meson. There is still one
>      warning
>      >      disable
>      >      > flag needed when building with make, which will need a
>      follow-on
>      >      set to
>      >      > fix.
>      >      >
>      >      > Bruce Richardson (4):
>      >      >   net/ixgbe: fix warning with GCC 9 on Fedora 30
>      >      >   bus/fslmc: fix printf of null pointer
>      >      >   raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30
>      >      >   raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30
>      >      Cc: [2][3]stable@dpdk.org
>      >      Applied, thanks
>      >
>      >    I had a comment on patch 2, and the bigger problem is
>      >    -Waddress-of-packed-member.
>      >    The quicker solution for now is to downgrade it to warning only
>      so that
>      >    we can fix the parts later rather than globally disable it.
>      >    --
>      Well, it is already a warning, it's just that with make we build by
>      default
>      with -Werror when building from git.
> 
>    Err, why don't we have -Werror for meson ?
> 

Because it's generally not a good idea to use -Werror by default. However,
the test-meson-build script (which we should all be using for test
compilation before upstreaming) sets it for all builds.

/Bruce

  parent reply	other threads:[~2019-05-02 13:46 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01 19:50 [dpdk-dev] " Bruce Richardson
2019-05-01 19:50 ` Bruce Richardson
2019-05-01 19:50 ` [dpdk-dev] [PATCH 1/4] net/ixgbe: fix warning with GCC " Bruce Richardson
2019-05-01 19:50   ` Bruce Richardson
2019-05-02 12:20   ` David Marchand
2019-05-02 12:20     ` David Marchand
2019-05-01 19:50 ` [dpdk-dev] [PATCH 2/4] bus/fslmc: fix printf of null pointer Bruce Richardson
2019-05-01 19:50   ` Bruce Richardson
2019-05-02 12:20   ` David Marchand
2019-05-02 12:20     ` David Marchand
2019-05-01 19:50 ` [dpdk-dev] [PATCH 3/4] raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 Bruce Richardson
2019-05-01 19:50   ` Bruce Richardson
2019-05-02 12:22   ` David Marchand
2019-05-02 12:22     ` David Marchand
2019-05-01 19:50 ` [dpdk-dev] [PATCH 4/4] raw/dpaa2_cmdif: " Bruce Richardson
2019-05-01 19:50   ` Bruce Richardson
2019-05-02 12:24   ` David Marchand
2019-05-02 12:24     ` David Marchand
2019-05-02 12:18 ` [dpdk-dev] [PATCH 0/4] fix warnings with gcc " Thomas Monjalon
2019-05-02 12:18   ` Thomas Monjalon
2019-05-02 12:32   ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-05-02 12:32     ` David Marchand
2019-05-02 13:24     ` Bruce Richardson
2019-05-02 13:24       ` Bruce Richardson
2019-05-02 13:32       ` David Marchand
2019-05-02 13:32         ` David Marchand
2019-05-02 13:46         ` Bruce Richardson [this message]
2019-05-02 13:46           ` Bruce Richardson
2019-05-02 13:53           ` David Marchand
2019-05-02 13:53             ` David Marchand
2019-05-02 14:04             ` Bruce Richardson
2019-05-02 14:04               ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).