From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Chengwen Feng" <fengchengwen@huawei.com>,
"Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
"Kevin Laatz" <kevin.laatz@intel.com>
Subject: Re: [PATCH] build: exclude rather than include libs in MSVC build
Date: Tue, 2 Apr 2024 10:19:07 -0700 [thread overview]
Message-ID: <20240402171907.GA28745@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20240402101550.6e2966ad@hermes.local>
On Tue, Apr 02, 2024 at 10:15:50AM -0700, Stephen Hemminger wrote:
> On Tue, 2 Apr 2024 09:55:48 -0700
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
>
> > Some libraries that could be built with MSVC were not being built.
> >
> > Switch from explicit include to exclude of libs to get immediate CI
> > coverage of libraries that already work with MSVC Windows builds.
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
> For mbuf, since it requires mempool, you might not need to explicitly
> exclude it. But the change looks good.
interesting, i wonder if the dependency isn't properly working. the way
i chose to exclude libs was to just enable them all and then selectively
disable those that were attempted build but failed. mbuf did not
complain of missing mempool and there was an attempt to build it.
with your changes mempool will build though, just need to wait for it to
merge.
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2024-04-02 17:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 16:55 Tyler Retzlaff
2024-04-02 16:55 ` Tyler Retzlaff
2024-04-02 17:15 ` Stephen Hemminger
2024-04-02 17:19 ` Tyler Retzlaff [this message]
2024-04-05 20:33 ` Patrick Robb
2024-04-03 18:23 ` [PATCH v2] " Tyler Retzlaff
2024-04-03 18:23 ` Tyler Retzlaff
2024-04-03 18:50 ` Morten Brørup
2024-04-11 5:01 ` Patrick Robb
2024-04-03 21:51 ` Stephen Hemminger
2024-04-05 14:29 ` Patrick Robb
2024-04-06 0:38 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402171907.GA28745@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=kevin.laatz@intel.com \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).