DPDK patches and discussions
 help / color / mirror / Atom feed
From: Patrick Robb <probb@iol.unh.edu>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Tyler Retzlaff" <roretzla@linux.microsoft.com>,
	dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>,
	"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
	"Bruce Richardson" <bruce.richardson@intel.com>,
	"Chengwen Feng" <fengchengwen@huawei.com>,
	"Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
	"Kevin Laatz" <kevin.laatz@intel.com>,
	"Srikanth Yalavarthi" <syalavarthi@marvell.com>,
	"Vladimir Medvedkin" <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH v2] build: exclude rather than include libs in MSVC build
Date: Fri, 5 Apr 2024 10:29:58 -0400	[thread overview]
Message-ID: <CAJvnSUCwYbaLqT62-=VmQB2rfzNsOmPTgEFcdBb5CE7EFariqQ@mail.gmail.com> (raw)
In-Reply-To: <20240403145136.449ef6e0@hermes.local>

Recheck-request: iol-intel-Functional

checking for lab infra failure

On Wed, Apr 3, 2024 at 5:51 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Wed,  3 Apr 2024 11:23:19 -0700
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
>
> > Some libraries that could be built with MSVC were not being built.
> >
> > Switch from explicit include to exclude of libs to get immediate CI
> > coverage of libraries that already work with MSVC Windows builds.
> >
> > With this change we now get immediate CI build coverage for the libs
> > meter, timer, pci, cfgfile
> >
> > v2:
> >  * add a few more explicit exclusions for now as they are known to require
> >    more than trivial work and avoid needing to disable them later as the
> >    dependent libraries are enabled.
>
> If you need to do another revision, it might be good idea to add comment
> to the meson.build file when doing exclusions as to what is missing.

  reply	other threads:[~2024-04-05 14:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 16:55 [PATCH] " Tyler Retzlaff
2024-04-02 16:55 ` Tyler Retzlaff
2024-04-02 17:15   ` Stephen Hemminger
2024-04-02 17:19     ` Tyler Retzlaff
2024-04-05 20:33   ` Patrick Robb
2024-04-03 18:23 ` [PATCH v2] " Tyler Retzlaff
2024-04-03 18:23   ` Tyler Retzlaff
2024-04-03 18:50     ` Morten Brørup
2024-05-29 14:46       ` Thomas Monjalon
2024-04-11  5:01     ` Patrick Robb
2024-04-03 21:51   ` Stephen Hemminger
2024-04-05 14:29     ` Patrick Robb [this message]
2024-04-06  0:38   ` Patrick Robb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJvnSUCwYbaLqT62-=VmQB2rfzNsOmPTgEFcdBb5CE7EFariqQ@mail.gmail.com' \
    --to=probb@iol.unh.edu \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=kevin.laatz@intel.com \
    --cc=mb@smartsharesystems.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=stephen@networkplumber.org \
    --cc=syalavarthi@marvell.com \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).